)]}'
{"id":"LineageOS%2Fandroid_vendor_qcom_opensource_fm-commonsys~310083","triplet_id":"LineageOS%2Fandroid_vendor_qcom_opensource_fm-commonsys~lineage-18.1~I387886b78a2d036a0beb42d6218f8d56c015bbd6","project":"LineageOS/android_vendor_qcom_opensource_fm-commonsys","branch":"lineage-18.1","hashtags":[],"change_id":"I387886b78a2d036a0beb42d6218f8d56c015bbd6","subject":"[DNM] fm-commonsys with re-established legacy support","status":"ABANDONED","created":"2021-05-15 16:19:47.000000000","updated":"2021-07-16 02:08:52.000000000","total_comment_count":3,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"2be9e8623a19012a8981e5c971fdd177de2a5103","_number":310083,"virtual_id_number":310083,"owner":{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":0,"date":"2021-06-13 17:00:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8752,"name":"Hamsi2k","email":"Hamsi2k@freenet.de","username":"Quallenauge","avatars":[{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17793,"name":"Erfan Abdi","email":"erfangplus@gmail.com","username":"khode_erfan","avatars":[{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":1,"date":"2021-06-08 18:48:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22856,"name":"JarlPenguin","display_name":"Jarl-Penguin","email":"jarlpenguin@outlook.com","username":"JarlPenguin","avatars":[{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"date":"2021-06-10 00:41:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"rejected":{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":0,"date":"2021-06-13 17:00:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8752,"name":"Hamsi2k","email":"Hamsi2k@freenet.de","username":"Quallenauge","avatars":[{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17793,"name":"Erfan Abdi","email":"erfangplus@gmail.com","username":"khode_erfan","avatars":[{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":1,"date":"2021-06-08 18:48:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22856,"name":"JarlPenguin","display_name":"Jarl-Penguin","email":"jarlpenguin@outlook.com","username":"JarlPenguin","avatars":[{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":-2,"date":"2021-07-16 02:08:52.000000000","permitted_voting_range":{"min":-2,"max":1},"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"blocking":true},"CI":{"all":[{"_account_id":8752,"name":"Hamsi2k","email":"Hamsi2k@freenet.de","username":"Quallenauge","avatars":[{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":17793,"name":"Erfan Abdi","email":"erfangplus@gmail.com","username":"khode_erfan","avatars":[{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":22856,"name":"JarlPenguin","display_name":"Jarl-Penguin","email":"jarlpenguin@outlook.com","username":"JarlPenguin","avatars":[{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"REVIEWER":[{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":8752,"name":"Hamsi2k","email":"Hamsi2k@freenet.de","username":"Quallenauge","avatars":[{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":17793,"name":"Erfan Abdi","email":"erfangplus@gmail.com","username":"khode_erfan","avatars":[{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":22856,"name":"JarlPenguin","display_name":"Jarl-Penguin","email":"jarlpenguin@outlook.com","username":"JarlPenguin","avatars":[{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-16 00:15:10.000000000","updated_by":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-05-16 17:39:11.000000000","updated_by":{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-05-18 19:27:51.000000000","updated_by":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-06-04 21:14:31.000000000","updated_by":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"CC"},{"updated":"2021-06-08 18:49:30.000000000","updated_by":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":17793,"name":"Erfan Abdi","email":"erfangplus@gmail.com","username":"khode_erfan","avatars":[{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0e4b44c91a6881d9ae8b1296be171cd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-06-10 04:45:33.000000000","updated_by":{"_account_id":8752,"name":"Hamsi2k","email":"Hamsi2k@freenet.de","username":"Quallenauge","avatars":[{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":8752,"name":"Hamsi2k","email":"Hamsi2k@freenet.de","username":"Quallenauge","avatars":[{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-06-13 21:16:11.000000000","updated_by":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"CC"},{"updated":"2021-06-14 07:39:12.000000000","updated_by":{"_account_id":22856,"name":"JarlPenguin","display_name":"Jarl-Penguin","email":"jarlpenguin@outlook.com","username":"JarlPenguin","avatars":[{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":22856,"name":"JarlPenguin","display_name":"Jarl-Penguin","email":"jarlpenguin@outlook.com","username":"JarlPenguin","avatars":[{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/690dcb2061738b1e42d20638620d5aba.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-06-24 02:16:14.000000000","updated_by":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REMOVED"},{"updated":"2021-07-03 15:19:52.000000000","updated_by":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"CC"}],"messages":[{"id":"24836bd377aed76853a0767134b8dd333a55d931","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-05-15 16:19:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ef6e2d9c9e470cc1fec0e839a42d26f112033be0","author":{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-05-15 16:20:08.000000000","message":"Patch Set 1: Code-Review-2","accounts_in_message":[],"_revision_number":1},{"id":"c52f15c24ce097355dcd0240bd0bd1a74b2da44c","author":{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-05-15 16:24:33.000000000","message":"Patch Set 1:\n\nArco\u0027s tree works on FP2 (msm8974) but I cannot test it on non-legacy FM radio device (as I have none).","accounts_in_message":[],"_revision_number":1},{"id":"f166045654f2e89915c06017ae0572dea96af34f","author":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-05-16 00:15:10.000000000","message":"Patch Set 1: Verified+1 Code-Review+1\n\nWorks on my non-legacy (river, lake, PL2)","accounts_in_message":[],"_revision_number":1},{"id":"88d71523581129990d56c5a8602e37465b68eca4","author":{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-05-16 17:38:35.000000000","message":"Patch Set 1:\n\nArian tested Xiaomi Mi Note 10 Lite (sm6150, 11 blobs and vendor built).\n\nWorked for him in permissive only as new denials popup like:\n\"05-15 23:17:07.126   536   536 E SELinux : avc:  denied  { find } for interface\u003dvendor.qti.hardware.fm::IFmHci sid\u003du￼system_app:s0 pid\u003d5489 scontext\u003du￼system_app:s0 tcontext\u003du:object_r:vendor_hal_fm_hwservice:s0 tclass\u003dhwservice_manager permissive\u003d0\"","accounts_in_message":[],"_revision_number":1},{"id":"d8eb862884a506463147bb6734e842d40d14cbfa","author":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-05-18 19:27:51.000000000","message":"Patch Set 1: Verified-1 Code-Review-1\n\n\u003e Patch Set 1:\n\u003e \n\u003e \"05-15 23:17:07.126   536   536 E SELinux : avc:  denied  { find } for interface\u003dvendor.qti.hardware.fm::IFmHci sid\u003du￼system_app:s0 pid\u003d5489 scontext\u003du￼system_app:s0 tcontext\u003du:object_r:vendor_hal_fm_hwservice:s0 tclass\u003dhwservice_manager permissive\u003d0\"\n\nFM on payton is broken with this patch and selinux enforced, without this patch FM worked fine. The same denial occurs here, is there a selinux rule I could test?","accounts_in_message":[],"_revision_number":1},{"id":"18103de587cba61d5df3817c448f5765c92a9be0","author":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-05-19 01:08:58.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Verified-1 Code-Review-1\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e \"05-15 23:17:07.126   536   536 E SELinux : avc:  denied  { find } for interface\u003dvendor.qti.hardware.fm::IFmHci sid\u003du￼system_app:s0 pid\u003d5489 scontext\u003du￼system_app:s0 tcontext\u003du:object_r:vendor_hal_fm_hwservice:s0 tclass\u003dhwservice_manager permissive\u003d0\"\n\u003e \n\u003e FM on payton is broken with this patch and selinux enforced, without this patch FM worked fine. The same denial occurs here, is there a selinux rule I could test?\n\nhow about `allow system_app vendor_hal_fm_hwservice:hwservice_manager find`","accounts_in_message":[],"_revision_number":1},{"id":"a667a03c009d290aaaa587cbd277bcfa829efb20","author":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-05-19 04:36:30.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e how about `allow system_app vendor_hal_fm_hwservice:hwservice_manager find`\n\nDoes not work:\n\ndevice/motorola/sdm660-common/sepolicy/vendor/system_app.te:6:ERROR \u0027unknown type vendor_hal_fm_hwservice\u0027 at token \u0027;\u0027 on line 107129:","accounts_in_message":[],"_revision_number":1},{"id":"2c0136c78a7a1eda5e0e20c1d122db4dc9216a8b","author":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-05-19 04:46:35.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e how about `allow system_app vendor_hal_fm_hwservice:hwservice_manager find`\n\u003e \n\u003e Does not work:\n\u003e \n\u003e device/motorola/sdm660-common/sepolicy/vendor/system_app.te:6:ERROR \u0027unknown type vendor_hal_fm_hwservice\u0027 at token \u0027;\u0027 on line 107129:\n\nChanging to\n\nallow system_app hal_fm_hwservice:hwservice_manager find;\n\nstill does not work:\n\nlibsepol.report_failure: neverallow on line 30 of device/qcom/sepolicy-legacy-um/legacy/vendor/common/hal_fm.te (or line 73527 of policy.conf) violated by allow system_app hal_fm_hwservice:hwservice_manager { find };\n\npayton uses device/qcom/sepolicy-legacy-um:\nhttps://github.com/LineageOS/android_device_motorola_sdm660-common/blob/lineage-18.1/BoardConfigCommon.mk#L172\n\nwhich apparently lacks\nhttps://github.com/LineageOS/android_device_qcom_sepolicy_vndr/commit/865b2f7060791ad6a6f730f05267f49122c1053c#diff-87a58835705c90e82f7581c2dc63ca20501c73b5dd993e62d242c2b202219e73","accounts_in_message":[],"_revision_number":1},{"id":"3f4f99d4baa092b2d70e733e6079366ce561269a","author":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-02 21:28:03.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 1:\n\u003e \u003e \u003e \n\u003e \u003e \u003e how about `allow system_app vendor_hal_fm_hwservice:hwservice_manager find`\n\u003e \u003e \n\u003e \u003e Does not work:\n\u003e \u003e \n\u003e \u003e device/motorola/sdm660-common/sepolicy/vendor/system_app.te:6:ERROR \u0027unknown type vendor_hal_fm_hwservice\u0027 at token \u0027;\u0027 on line 107129:\n\u003e \n\u003e Changing to\n\u003e \n\u003e allow system_app hal_fm_hwservice:hwservice_manager find;\n\u003e \n\u003e still does not work:\n\u003e \n\u003e libsepol.report_failure: neverallow on line 30 of device/qcom/sepolicy-legacy-um/legacy/vendor/common/hal_fm.te (or line 73527 of policy.conf) violated by allow system_app hal_fm_hwservice:hwservice_manager { find };\n\u003e \n\u003e payton uses device/qcom/sepolicy-legacy-um:\n\u003e https://github.com/LineageOS/android_device_motorola_sdm660-common/blob/lineage-18.1/BoardConfigCommon.mk#L172\n\u003e \n\u003e which apparently lacks\n\u003e https://github.com/LineageOS/android_device_qcom_sepolicy_vndr/commit/865b2f7060791ad6a6f730f05267f49122c1053c#diff-87a58835705c90e82f7581c2dc63ca20501c73b5dd993e62d242c2b202219e73\n\nSo, I suppose the only way forward here is to split this into a `-legacy` repo then :/","accounts_in_message":[],"_revision_number":1},{"id":"57b2ad933b5aab64ca4d3aefa952ddb067036520","author":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-04 19:51:41.000000000","message":"Patch Set 1:\n\n\u003e So, I suppose the only way forward here is to split this into a `-legacy` repo then :/\n\nHmm, that\u0027s a shame.","accounts_in_message":[],"_revision_number":1},{"id":"a8b16f356e298c8949ad48dfb55ba39fa5fb0a77","author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-04 21:14:31.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e So, I suppose the only way forward here is to split this into a `-legacy` repo then :/\n\u003e \n\u003e Hmm, that\u0027s a shame.\n\nDid you try yourself, tho? It looks to me that the problem here is that seapp contexts for FM app is wrong. It should be:\n\n\u003e  user\u003d_app seinfo\u003dplatform name\u003dcom.caf.fmradio domain\u003dvendor_fm_app type\u003dapp_data_file levelFrom\u003dall","accounts_in_message":[],"_revision_number":1},{"id":"6d89e909b40cf5cb2b62de087e4f4580988857ac","author":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-04 23:01:46.000000000","message":"Patch Set 1:\n\n\u003e Did you try yourself, tho? It looks to me that the problem here is that seapp contexts for FM app is wrong. It should be:\n\u003e \n\u003e \u003e  user\u003d_app seinfo\u003dplatform name\u003dcom.caf.fmradio domain\u003dvendor_fm_app type\u003dapp_data_file levelFrom\u003dall\n\nWhat should I try? I don\u0027t have any new devices to test on. My serrano using legacy sepolicy works fine though.","accounts_in_message":[],"_revision_number":1},{"id":"374129b894ab730db5b69f9cbf179e6989ba93c6","author":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-05 06:59:24.000000000","message":"Patch Set 1:\n\n@Seven Rock,\n\nCan you try reverting this change here: https://github.com/arco/android_vendor_qcom_opensource_fm-commonsys/commit/2f5599f258e64cfc28a9927061e90c01b74af038","accounts_in_message":[],"_revision_number":1},{"id":"cd5918ffcfa5c4d80c7e8c17792376effc4e0370","author":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-05 08:59:13.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e @Seven Rock,\n\u003e \n\u003e Can you try reverting this change here: https://github.com/arco/android_vendor_qcom_opensource_fm-commonsys/commit/2f5599f258e64cfc28a9927061e90c01b74af038\n\nThis commit was already reverted:\nhttps://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys/commit/e175d1102f3004bc9e637029351fa7e584611a7a\n\nthen re-reverted\nhttps://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys/commit/0458ae485140e831828e02769211dc5f2d2d53ec\n\nand finally reverted again:\nhttps://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys/commit/bfb3da65ba9cd3f860eb7969282d306f2c77e024\n\ncom.caf.fmradio is not configured with android:sharedUserId\u003d\"android.uid.system\":\nhttps://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys/blob/lineage-18.1/fmapp2/AndroidManifest.xml#L31","accounts_in_message":[],"_revision_number":1},{"id":"5d359f424a77023ca49710de01be4efcbd92d5c8","author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-05 09:05:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"09009c31b80dff18e09c2d0f50cac8006b79a7e6","author":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-05 10:38:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"04bdf70bdf5a63a3028b4e8780ff1c481481e1bc","author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-05 10:43:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"203260192b2067a9cbd283a87a38e56713d44360","author":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-05 12:49:38.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e @Seven Rock,\n\u003e \n\u003e Can you try reverting this change here: https://github.com/arco/android_vendor_qcom_opensource_fm-commonsys/commit/2f5599f258e64cfc28a9927061e90c01b74af038\n\nA new denial occurs:\n\n06-05 14:06:20.536 13637 13637 D FMService: ++requestFocus\n06-05 14:06:20.536 13637 13637 E libc    : Access denied finding property \"vendor.bluetooth.soc\"\n06-05 14:06:20.536 13637 13637 D FMService: --requestFocus\n\n06-05 14:06:20.533 13637 13637 I auditd  : type\u003d1400 audit(0.0:914): avc: denied { read } for comm\u003d\"com.caf.fmradio\" uid\u003d10168 name\u003d\"u:object_r:bluetooth_prop:s0\" dev\u003d\"tmpfs\" ino\u003d12860 scontext\u003du:r:vendor_fm_app:s0:c1\n68,c256,c512,c768 tcontext\u003du:object_r:bluetooth_prop:s0 tclass\u003dfile permissive\u003d0 app\u003dcom.caf.fmradio","accounts_in_message":[],"_revision_number":1},{"id":"afa80626a3e4d45b9b44fec9c1e311dfb6aac909","author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-05 12:53:48.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e @Seven Rock,\n\u003e \u003e \n\u003e \u003e Can you try reverting this change here: https://github.com/arco/android_vendor_qcom_opensource_fm-commonsys/commit/2f5599f258e64cfc28a9927061e90c01b74af038\n\u003e \n\u003e A new denial occurs:\n\u003e \n\u003e 06-05 14:06:20.536 13637 13637 D FMService: ++requestFocus\n\u003e 06-05 14:06:20.536 13637 13637 E libc    : Access denied finding property \"vendor.bluetooth.soc\"\n\u003e 06-05 14:06:20.536 13637 13637 D FMService: --requestFocus\n\u003e \n\u003e 06-05 14:06:20.533 13637 13637 I auditd  : type\u003d1400 audit(0.0:914): avc: denied { read } for comm\u003d\"com.caf.fmradio\" uid\u003d10168 name\u003d\"u:object_r:bluetooth_prop:s0\" dev\u003d\"tmpfs\" ino\u003d12860 scontext\u003du:r:vendor_fm_app:s0:c1\n\u003e 68,c256,c512,c768 tcontext\u003du:object_r:bluetooth_prop:s0 tclass\u003dfile permissive\u003d0 app\u003dcom.caf.fmradio\n\nget_prop(vendor_fm_app, bluetooth_prop)","accounts_in_message":[],"_revision_number":1},{"id":"1cf58caa743ee3187f5927122c542850a5dde07e","author":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-05 13:20:01.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e get_prop(vendor_fm_app, bluetooth_prop)\n\nlibsepol.report_failure: neverallow on line 567 of system/sepolicy/public/app.te (or line 11100 of policy.conf) violated by allow vendor_fm_app bluetooth_prop:file { read getattr map open };\n\nTrying to fix it failed:\n\nsystem/sepolicy/public/app.te:568:ERROR \u0027unknown type vendor_fm_app\u0027 at token \u0027;\u0027 on line 9927:\n  -vendor_fm_app","accounts_in_message":[],"_revision_number":1},{"id":"4ccf519c9ad361a41406e0fc3fa3b056d1da17ca","author":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-05 19:58:54.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e get_prop(vendor_fm_app, bluetooth_prop)\n\u003e \n\u003e libsepol.report_failure: neverallow on line 567 of system/sepolicy/public/app.te (or line 11100 of policy.conf) violated by allow vendor_fm_app bluetooth_prop:file { read getattr map open };\n\u003e \n\u003e Trying to fix it failed:\n\u003e \n\u003e system/sepolicy/public/app.te:568:ERROR \u0027unknown type vendor_fm_app\u0027 at token \u0027;\u0027 on line 9927:\n\u003e   -vendor_fm_app\n\nAdd the rule in fm_app.te\n\nThere might be other property denials, since this squashed patch brings back legacy property handling in the FM app, and they likely removed the rules for it in the UM sepolicy.\n\nI found out the issue with me having to run the app as system uid, and it\u0027s because else it couldn\u0027t read the /dev/radio0 node. Changing permissions to 644 fixes that. However, since it no longer runs as system uid, legacy sepolicy needs to be updated for it. I\u0027ll take care of that.","accounts_in_message":[],"_revision_number":1},{"id":"7f51a64a28f06d3d968b5c5be6a7637d6d82ddcb","author":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-05 20:36:17.000000000","message":"Patch Set 1:\n\nIt\u0027s probably better to label vendor.bluetooth.soc as vendor_bluetooth_prop, since there\u0027s already a rule in fm_app.te for it.","accounts_in_message":[],"_revision_number":1},{"id":"ee3a907a64e0824a625d0db99e8826620b752df8","author":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-06 05:59:34.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e It\u0027s probably better to label vendor.bluetooth.soc as vendor_bluetooth_prop, since there\u0027s already a rule in fm_app.te for it.\n\nWhat about using \"vendor.qcom.bluetooth.soc\" instead of \"vendor.bluetooth.soc\" in com.caf.fmradio?\n\nMotorola sdm660-common sets both props: https://github.com/LineageOS/android_device_motorola_sdm660-common/blob/lineage-18.1/properties.mk#L88\n\nand \"vendor.qcom.bluetooth.\" is already configured as \"vendor_bluetooth_prop\":\nhttps://github.com/LineageOS/android_device_qcom_sepolicy/blob/lineage-18.1-legacy-um/legacy/vendor/common/property_contexts#L33","accounts_in_message":[],"_revision_number":1},{"id":"b9ebe74c657aad621512389805b28749818783a3","author":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-06 20:17:27.000000000","message":"Patch Set 1:\n\nOf course they are using two different props for basically the same thing... It\u0027s not qcom without being qcom.... /s\n\nSo the current situation after this patch:\nBluetooth is using vendor.qcom.bluetooth.soc\nFM is using vendor.bluetooth.soc\n\nSome devices are setting one of the props, and some are setting both.\nProp usage is still in use for bluetooth.\nProp usage is dead for FM (But we brought it back here for legacy reasons).\n\nLogically we should change to using vendor.qcom.bluetooth.soc in FM app, and add label\nfor it in legacy sepolicies.\n\nThoughts?","accounts_in_message":[],"_revision_number":1},{"id":"2ca30cfe20690458053c4fd8ded23cf2307a3721","author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-06 21:03:56.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Logically we should change to using vendor.qcom.bluetooth.soc in FM app, and add label\n\u003e for it in legacy sepolicies.\n\u003e \n\u003e Thoughts?\n\nGo for it.","accounts_in_message":[],"_revision_number":1},{"id":"07c33daa3ef3e51e9b7634251f8bc737508a6790","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-07 07:17:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cecc9b3163e6fb87dfb0c0749a1b3104d82cbce8","author":{"_account_id":20370,"name":"Seven Rock","email":"sevenrock@hotmail.de","username":"seven_rock","avatars":[{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2640b2dc7fa896bb876265997f4bc8e6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-08 18:48:39.000000000","message":"Patch Set 2: Verified+1 Code-Review+1\n\nFine on payton, no additional patches needed, thanks!\nScanning FM band \u0026 playback via headphone and speaker works.\n\nMinor nit, a new selinux denial, no functional limitations visible:\n\n06-08 20:36:16.892   611   611 I auditd  : avc:  denied  { find } for pid\u003d6560 uid\u003d10168 name\u003dmedia.metrics scontext\u003du:r:vendor_fm_app:s0:c168,c256,c512,c768 tcontext\u003du:object_r:mediametrics_service:s0 tclass\u003dservice_manager permissive\u003d0","accounts_in_message":[],"_revision_number":2},{"id":"793d4704d8bcb0bdd8acffd9e67d2b27c37fed3d","author":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-10 00:41:14.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Verified+1 Code-Review+1\n\u003e \n\u003e Fine on payton, no additional patches needed, thanks!\n\u003e Scanning FM band \u0026 playback via headphone and speaker works.\n\u003e \n\u003e Minor nit, a new selinux denial, no functional limitations visible:\n\u003e \n\u003e 06-08 20:36:16.892   611   611 I auditd  : avc:  denied  { find } for pid\u003d6560 uid\u003d10168 name\u003dmedia.metrics scontext\u003du:r:vendor_fm_app:s0:c168,c256,c512,c768 tcontext\u003du:object_r:mediametrics_service:s0 tclass\u003dservice_manager permissive\u003d0\n\nI can attest that just this, no sepolicy-legacy-um changes, and it still works on lake/river/PL2.","accounts_in_message":[],"_revision_number":2},{"id":"3c2fe039cd1b7c015bd329d42f21df3c0f4b094b","author":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-10 00:41:22.000000000","message":"Patch Set 2: Verified+1","accounts_in_message":[],"_revision_number":2},{"id":"c307d3543511d94d5e49485f084f12252dfd6459","author":{"_account_id":8752,"name":"Hamsi2k","email":"Hamsi2k@freenet.de","username":"Quallenauge","avatars":[{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-10 04:45:33.000000000","message":"Patch Set 2: Verified+1 Code-Review+1\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2: Verified+1 Code-Review+1\n\u003e \u003e \n\u003e \u003e Fine on payton, no additional patches needed, thanks!\n\u003e \u003e Scanning FM band \u0026 playback via headphone and speaker works.\n\u003e \u003e \n\u003e \u003e Minor nit, a new selinux denial, no functional limitations visible:\n\u003e \u003e \n\u003e \u003e 06-08 20:36:16.892   611   611 I auditd  : avc:  denied  { find } for pid\u003d6560 uid\u003d10168 name\u003dmedia.metrics scontext\u003du:r:vendor_fm_app:s0:c168,c256,c512,c768 tcontext\u003du:object_r:mediametrics_service:s0 tclass\u003dservice_manager permissive\u003d0\n\u003e \n\u003e I can attest that just this, no sepolicy-legacy-um changes, and it still works on lake/river/PL2.\n\nThat\u0027s interesting. Because for my device it was needed to change the sepolicy-legacy-um by moving permissions from \"system_app\" -\u003e \"vendor_fm_app\" (\nhttps://review.lineageos.org/c/LineageOS/android_device_qcom_sepolicy/+/312087 ) to fix sepolicy denials. Also I had to change permissions for the /dev/radio0 to 0644, as arco mentioned).\n\nBut beside of that, I can confirm it works.","accounts_in_message":[],"_revision_number":2},{"id":"b0e0e88bce04cd50467084429167040b1429c3c3","author":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-10 20:56:05.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Verified+1 Code-Review+1\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 2: Verified+1 Code-Review+1\n\u003e \u003e \u003e \n\u003e \u003e \u003e Fine on payton, no additional patches needed, thanks!\n\u003e \u003e \u003e Scanning FM band \u0026 playback via headphone and speaker works.\n\u003e \u003e \u003e \n\u003e \u003e \u003e Minor nit, a new selinux denial, no functional limitations visible:\n\u003e \u003e \u003e \n\u003e \u003e \u003e 06-08 20:36:16.892   611   611 I auditd  : avc:  denied  { find } for pid\u003d6560 uid\u003d10168 name\u003dmedia.metrics scontext\u003du:r:vendor_fm_app:s0:c168,c256,c512,c768 tcontext\u003du:object_r:mediametrics_service:s0 tclass\u003dservice_manager permissive\u003d0\n\u003e \u003e \n\u003e \u003e I can attest that just this, no sepolicy-legacy-um changes, and it still works on lake/river/PL2.\n\u003e \n\u003e That\u0027s interesting. Because for my device it was needed to change the sepolicy-legacy-um by moving permissions from \"system_app\" -\u003e \"vendor_fm_app\" (\n\u003e https://review.lineageos.org/c/LineageOS/android_device_qcom_sepolicy/+/312087 ) to fix sepolicy denials. Also I had to change permissions for the /dev/radio0 to 0644, as arco mentioned).\n\u003e \n\u003e But beside of that, I can confirm it works.\n\nradio permissions already match that here.","accounts_in_message":[],"_revision_number":2},{"id":"677829319553957ab9495b5edf3f66b131faa4da","author":{"_account_id":8752,"name":"Hamsi2k","email":"Hamsi2k@freenet.de","username":"Quallenauge","avatars":[{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d39213ca7cccdb2601981feba132202f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-13 17:00:51.000000000","message":"Patch Set 2: -Verified -Code-Review\n\nBTW: After applying android-11.0.0_r38 I\u0027m not able to switch off the fm radio without an error.\n```\n06-13 18:55:45.492  1868  1868 D FMService: FM application close button pressed or antenna removed\n06-13 18:55:45.494  1629  5205 D MediaSessionService: Global priority session is updated, active\u003dfalse\n06-13 18:55:45.496  1868  1868 D FMService: FM off from Application\n06-13 18:55:45.496  1868  1868 D FMService: stopNotification\n06-13 18:55:45.497  1933  1933 V AvrcpMediaPlayerList: onActiveSessionsChanged: number of controllers: 0\n06-13 18:55:45.498  1629  5205 W NotificationService: Package u0/com.caf.fmradio may not delete notification channel \u0027fmradio_notification_channel\u0027 with fg service\n06-13 18:55:45.500  1868  1868 D AndroidRuntime: Shutting down VM\n06-13 18:55:45.501  1868  1868 E AndroidRuntime: FATAL EXCEPTION: main\n06-13 18:55:45.501  1868  1868 E AndroidRuntime: Process: com.caf.fmradio, PID: 1868\n06-13 18:55:45.501  1868  1868 E AndroidRuntime: java.lang.SecurityException: Not allowed to delete channel fmradio_notification_channel with a foreground service\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.os.Parcel.createExceptionOrNull(Parcel.java:2373)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.os.Parcel.createException(Parcel.java:2357)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.os.Parcel.readException(Parcel.java:2340)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.os.Parcel.readException(Parcel.java:2282)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.app.INotificationManager$Stub$Proxy.deleteNotificationChannel(INotificationManager.java:4087)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.app.NotificationManager.deleteNotificationChannel(NotificationManager.java:906)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at com.caf.fmradio.FMRadioService.stopNotification(FMRadioService.java:2009)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at com.caf.fmradio.FMRadioService.fmOff(FMRadioService.java:2803)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at com.caf.fmradio.FMRadioService.access$2400(FMRadioService.java:116)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at com.caf.fmradio.FMRadioService$ServiceStub.fmOff(FMRadioService.java:2070)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at com.caf.fmradio.FMRadio.disableRadio(FMRadio.java:1651)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at com.caf.fmradio.FMRadio.access$4800(FMRadio.java:106)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at com.caf.fmradio.FMRadio$28.run(FMRadio.java:1544)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:938)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:99)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:223)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:7664)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime: Caused by: android.os.RemoteException: Remote stack trace:\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at com.android.server.notification.NotificationManagerService$11.enforceDeletingChannelHasNoFgService(NotificationManagerService.java:3458)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at com.android.server.notification.NotificationManagerService$11.deleteNotificationChannel(NotificationManagerService.java:3471)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.app.INotificationManager$Stub.onTransact(INotificationManager.java:1760)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.os.Binder.execTransactInternal(Binder.java:1154)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime:        at android.os.Binder.execTransact(Binder.java:1123)\n06-13 18:55:45.501  1868  1868 E AndroidRuntime: \n06-13 18:55:45.506  1629  5060 W ActivityTaskManager:   Force finishing activity com.caf.fmradio/.FMRadio\n```","accounts_in_message":[],"_revision_number":2},{"id":"9929171d320866976df7006c20c3bef3a0e3c144","author":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-13 18:16:29.000000000","message":"Patch Set 2:\n\nGoogle derped notification channels?","accounts_in_message":[],"_revision_number":2},{"id":"282ee6e32a3fcb7f597efb1216943ce4c40187d3","author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-13 21:16:11.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e Google derped notification channels?\n\nNo, they fixed a security issue which means fm app is doing things wrong","accounts_in_message":[],"_revision_number":2},{"id":"e0f1171107b1caf796a3b006c13cd6675cf90bbb","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-24 02:16:14.000000000","message":"Removed reviewer Nolen Johnson with the following votes:\n\n* Verified+1 by Nolen Johnson \u003cjohnsonnolen@gmail.com\u003e\n","accounts_in_message":[],"_revision_number":2},{"id":"da1a0c37a0502cc7d47a2fd28933cea20578da3a","author":{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-27 08:33:25.000000000","message":"Patch Set 2:\n\nWas that fixed in recent CAF update through \nhttps://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys/commit/26ca58940f9dbed3cb9f272d6bb0b088c3003026\n?","accounts_in_message":[],"_revision_number":2},{"id":"21c2efc16c65897d715a970fd3bcabdf8cf232ce","author":{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-27 12:48:32.000000000","message":"Patch Set 2:\n\nIt actually does not get fixed with caf update. Simple order change of shutdown sequence seems to fix it:\n\ndiff --git a/fmapp2/src/com/caf/fmradio/FMRadioService.java b/fmapp2/src/com/caf/fmradio/FMRadioService.java\nindex 113ea63..aece513 100644\n--- a/fmapp2/src/com/caf/fmradio/FMRadioService.java\n+++ b/fmapp2/src/com/caf/fmradio/FMRadioService.java\n@@ -2799,10 +2799,12 @@ public class FMRadioService extends Service\n            isfmOffFromApplication \u003d true;\n        }\n \n+       boolean ret \u003d fmOff();\n+\n        //stop Notification\n        stopNotification();\n \n-       return fmOff();\n+       return ret;\n    }\n   /*\n    * Turn OFF FM: Disable the FM Host when hardware resets asynchronously            .","accounts_in_message":[],"_revision_number":2},{"id":"5977f83071893fbf781a57e1c296b461212fa113","author":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-06-29 17:29:01.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e It actually does not get fixed with caf update. Simple order change of shutdown sequence seems to fix it:\n\nThere\u0027s also this: https://review.lineageos.org/c/LineageOS/android_vendor_qcom_opensource_fm-commonsys/+/312701\nOr the solution mentioned in the comments there..","accounts_in_message":[],"_revision_number":2},{"id":"66ed11bf0b8f0e8beb1ba6a8047075c63d2a8720","author":{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-07-03 12:04:09.000000000","message":"Patch Set 2:\n\nCan we conclude on this and request force push? \nJust keeping -2 here because of DNM squash.","accounts_in_message":[],"_revision_number":2},{"id":"ea8aa70354256c6dbc691cab969ee674b34e4854","author":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-07-03 15:19:52.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n \u003e \n \u003e Can we conclude on this and request force push? \n \u003e Just keeping -2 here because of DNM squash.\n\ngo for it!","accounts_in_message":[],"_revision_number":2},{"id":"e2a761d81a8f3479c2afc389ef0fad6baa2f2bbb","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-07-16 02:08:52.000000000","message":"Abandoned\n\npushed","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"965365aea1ad3a7066df5a602039c1c9b4eeafdf","revisions":{"ab77b23902becac28ab147081ba7c59e7b355e59":{"kind":"REWORK","_number":1,"created":"2021-05-15 16:19:47.000000000","uploader":{"_account_id":3917,"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","username":"chrmhoffmann","avatars":[{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4d04add7cca6b716cbda8136ff4f501a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/83/310083/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys","ref":"refs/changes/83/310083/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/1 \u0026\u0026 git checkout -b change-310083 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/1","Reset To":"git fetch https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3709d0a573a7c3d3fd1bb30f2fcdeda455e15661","subject":"Merge tag \u0027LA.QSSI.11.0.r1-11400-qssi.0\u0027 of https://source.codeaurora.org/quic/la/platform/vendor/qcom-opensource/fm-commonsys into lineage-18.1","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys/commit/3709d0a573a7c3d3fd1bb30f2fcdeda455e15661"}]}],"author":{"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","date":"2021-05-15 16:18:01.000000000","tz":120},"committer":{"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","date":"2021-05-15 16:18:01.000000000","tz":120},"subject":"[DNM] fm-commonsys with re-established legacy support","message":"[DNM] fm-commonsys with re-established legacy support\n\n* Source https://github.com/arco/android_vendor_qcom_opensource_fm-commonsys/commits/lineage-18.1\n* Apply on top of current https://github.com/arco/android_vendor_qcom_opensource_fm-commonsys/commits/lineage-18.1\n\nChange-Id: I387886b78a2d036a0beb42d6218f8d56c015bbd6\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys/commit/ab77b23902becac28ab147081ba7c59e7b355e59"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys/commit/ab77b23902becac28ab147081ba7c59e7b355e59"}]},"branch":"refs/heads/lineage-18.1"},"965365aea1ad3a7066df5a602039c1c9b4eeafdf":{"kind":"REWORK","_number":2,"created":"2021-06-07 07:17:25.000000000","uploader":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/83/310083/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys","ref":"refs/changes/83/310083/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/2 \u0026\u0026 git checkout -b change-310083 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/2","Reset To":"git fetch https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys refs/changes/83/310083/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f9711b42a5c71f50d49f5c0e66d8820a3ebcefbf","subject":"Automatic translation import","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys/commit/f9711b42a5c71f50d49f5c0e66d8820a3ebcefbf"}]}],"author":{"name":"Christian Hoffmann","email":"chrmhoffmann@gmail.com","date":"2021-05-15 16:18:01.000000000","tz":120},"committer":{"name":"Arne Coucheron","email":"arco68@gmail.com","date":"2021-06-07 05:59:06.000000000","tz":120},"subject":"[DNM] fm-commonsys with re-established legacy support","message":"[DNM] fm-commonsys with re-established legacy support\n\n* Source https://github.com/arco/android_vendor_qcom_opensource_fm-commonsys/commits/lineage-18.1\n* Apply on top of current https://github.com/arco/android_vendor_qcom_opensource_fm-commonsys/commits/lineage-18.1\n\nChange-Id: I387886b78a2d036a0beb42d6218f8d56c015bbd6\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys/commit/965365aea1ad3a7066df5a602039c1c9b4eeafdf"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_qcom_opensource_fm-commonsys/commit/965365aea1ad3a7066df5a602039c1c9b4eeafdf"}]},"branch":"refs/heads/lineage-18.1"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
