)]}'
{"release/release_config_map.mk":[{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"900af8c8ef616c75665a35f2953b48153725b3cf","unresolved":true,"context_lines":[{"line_number":17,"context_line":"local_dir :\u003d $(dir $(lastword $(MAKEFILE_LIST)))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Attach the flag value definitions to the various release configurations."},{"line_number":20,"context_line":"$(call declare-release-config, ap1a, $(local_dir)build_config/ap1a.scl)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"local_dir :\u003d"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"10d62ab9_fe09d634","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":71},"updated":"2024-04-08 16:06:04.000000000","message":"we should do something like\n`$(declare-release-config lineage_ap1a, ap1a, $(local_dir)build_config/lineage_ap1a.scl)`\notherwise we\u0027ll lose the other ap1a configs won\u0027t we?\n(lineage_ap1a: ap1a with lineage_ap1a overrides)\n\nRELEASE_ACONFIG_VALUE_SETS is marked as append so we\u0027ll automatically pull in the aconfig_value_set-ap1a","commit_id":"8dae23e11fa592b9a368deb5449369473768c0aa"},{"author":{"_account_id":22465,"name":"Daniel Moral","email":"daniel@danielml.es","username":"danielml3","avatars":[{"url":"https://www.gravatar.com/avatar/d61d1f72cbbea457a59a0374b6b13454.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d61d1f72cbbea457a59a0374b6b13454.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d61d1f72cbbea457a59a0374b6b13454.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d61d1f72cbbea457a59a0374b6b13454.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5e0973eafdcd79a8cbad82e75cd04ee324fc0adb","unresolved":true,"context_lines":[{"line_number":17,"context_line":"local_dir :\u003d $(dir $(lastword $(MAKEFILE_LIST)))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Attach the flag value definitions to the various release configurations."},{"line_number":20,"context_line":"$(call declare-release-config, ap1a, $(local_dir)build_config/ap1a.scl)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"local_dir :\u003d"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"80366e0f_05952f6c","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":71},"in_reply_to":"10d62ab9_fe09d634","updated":"2024-04-08 16:16:20.000000000","message":"On my tests with the current code, all the values from the original ap1a config get pulled, and RELEASE_ACONFIG_VALUE_SETS gets extended, leaving both the original config set and our custom one too.\n\nThere are some examples from AOSP: https://cs.android.com/android/platform/superproject/main/+/main:build/make/core/release_config.mk;l\u003d82?q\u003ddeclare-release-config\n\nIf I understand that correctly, adding a third argument will just make the $(1) release to use the configs from the $(3) release and the directly declared on $(2).\n\nI believe we should be fine without the $(3) override argument, due to this last 2 lines of the declare-release-config function:\n$(eval _all_release_configs.$(strip $(1)).DECLARED_IN :\u003d $(_included) $(_all_release_configs.$(strip $(1)).DECLARED_IN))\n    $(eval _all_release_configs.$(strip $(1)).FILES :\u003d $(_all_release_configs.$(strip $(1)).FILES) $(strip $(2)))\n\nDeclaring the same one just appends the new config files to the existing ones.","commit_id":"8dae23e11fa592b9a368deb5449369473768c0aa"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ebf37131ceb37e79d768adfc10538e0c97d98628","unresolved":false,"context_lines":[{"line_number":17,"context_line":"local_dir :\u003d $(dir $(lastword $(MAKEFILE_LIST)))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Attach the flag value definitions to the various release configurations."},{"line_number":20,"context_line":"$(call declare-release-config, ap1a, $(local_dir)build_config/ap1a.scl)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"local_dir :\u003d"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"a82eddaa_f8323672","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":71},"in_reply_to":"80366e0f_05952f6c","updated":"2024-04-08 16:19:33.000000000","message":"Acknowledged\nJust thinking if we should have a custom target since we\u0027re expanding it\nLuk/Michael, any preference?","commit_id":"8dae23e11fa592b9a368deb5449369473768c0aa"}]}