)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7ca48d8f89ad22b15dac066aeae43411f1fbf1b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"348a285d_00b484aa","updated":"2023-09-09 15:36:29.000000000","message":"This nicely handles my usecase: sm8550 device, with the modules defined by Google for 5.15 kernels - https://android.googlesource.com/kernel/common/+/refs/heads/android13-5.15-lts/android/gki_system_dlkm_modules.","commit_id":"b991ba8da2e1ae42d435bbacd6297923b9cd6622"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a007309b177c6ea313398363337ea4a3b4983041","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5d11584_24d94dac","updated":"2023-09-09 15:41:08.000000000","message":"that\u0027s correct, you could easily make those modules inline tho, they all are from mainline","commit_id":"b991ba8da2e1ae42d435bbacd6297923b9cd6622"},{"author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"305c0be8cfd39f95d4572f76093981cee72664d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dc110b49_001428dc","updated":"2023-09-10 15:13:57.000000000","message":"Final thoughts?","commit_id":"e35ad91e96917bcbad27acaab71e03f44d509ddc"}],"build/tasks/kernel.mk":[{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a007309b177c6ea313398363337ea4a3b4983041","unresolved":false,"context_lines":[{"line_number":452,"context_line":"\t\t\t$(foreach s, $(TARGET_MODULE_ALIASES),\\"},{"line_number":453,"context_line":"\t\t\t\t$(eval p :\u003d $(subst :,$(space),$(s))) \\"},{"line_number":454,"context_line":"\t\t\t\t; mv $$(find $$kernel_modules_dir -name $(word 1,$(p))) $$kernel_modules_dir/$(word 2,$(p))); \\"},{"line_number":455,"context_line":"\t\t\tmodules\u003d$$(find $$kernel_modules_dir -type f \\(-name \u0027*.ko\u0027 ! -name $(BOARD_SYSTEM_KERNEL_MODULES)\\)); \\"},{"line_number":456,"context_line":"\t\t\t($(call build-image-kernel-modules-lineage,$$modules,$(KERNEL_MODULES_OUT),$(KERNEL_MODULE_MOUNTPOINT)/,$(KERNEL_DEPMOD_STAGING_DIR),$(BOARD_VENDOR_KERNEL_MODULES_LOAD))); \\"},{"line_number":457,"context_line":"\t\t\t$(if $(BOOT_KERNEL_MODULES),\\"},{"line_number":458,"context_line":"\t\t\t\tvendor_boot_modules\u003d$$(for m in $(BOOT_KERNEL_MODULES); do \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"0d2bd565_af432cda","line":455,"updated":"2023-09-09 15:41:08.000000000","message":"this should be fine minus when you have lots of \"system\" modules and they exceed the max line of bash, but I\u0027m not exactly sure how you\u0027d solve it","commit_id":"b991ba8da2e1ae42d435bbacd6297923b9cd6622"},{"author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c00b326e712be2055cee6d21372a7d17a3700da9","unresolved":true,"context_lines":[{"line_number":452,"context_line":"\t\t\t$(foreach s, $(TARGET_MODULE_ALIASES),\\"},{"line_number":453,"context_line":"\t\t\t\t$(eval p :\u003d $(subst :,$(space),$(s))) \\"},{"line_number":454,"context_line":"\t\t\t\t; mv $$(find $$kernel_modules_dir -name $(word 1,$(p))) $$kernel_modules_dir/$(word 2,$(p))); \\"},{"line_number":455,"context_line":"\t\t\tmodules\u003d$$(find $$kernel_modules_dir -type f \\(-name \u0027*.ko\u0027 ! -name $(BOARD_SYSTEM_KERNEL_MODULES)\\)); \\"},{"line_number":456,"context_line":"\t\t\t($(call build-image-kernel-modules-lineage,$$modules,$(KERNEL_MODULES_OUT),$(KERNEL_MODULE_MOUNTPOINT)/,$(KERNEL_DEPMOD_STAGING_DIR),$(BOARD_VENDOR_KERNEL_MODULES_LOAD))); \\"},{"line_number":457,"context_line":"\t\t\t$(if $(BOOT_KERNEL_MODULES),\\"},{"line_number":458,"context_line":"\t\t\t\tvendor_boot_modules\u003d$$(for m in $(BOOT_KERNEL_MODULES); do \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"e145c741_4cf4b5a7","line":455,"in_reply_to":"0d2bd565_af432cda","updated":"2023-09-09 16:38:42.000000000","message":"I\u0027ll address that as well as the issue when BOARD_SYSTEM_KERNEL_MODULES is not set.","commit_id":"b991ba8da2e1ae42d435bbacd6297923b9cd6622"},{"author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4f8d8eb722a79b5a7c77e96d31200d133b712ba1","unresolved":false,"context_lines":[{"line_number":452,"context_line":"\t\t\t$(foreach s, $(TARGET_MODULE_ALIASES),\\"},{"line_number":453,"context_line":"\t\t\t\t$(eval p :\u003d $(subst :,$(space),$(s))) \\"},{"line_number":454,"context_line":"\t\t\t\t; mv $$(find $$kernel_modules_dir -name $(word 1,$(p))) $$kernel_modules_dir/$(word 2,$(p))); \\"},{"line_number":455,"context_line":"\t\t\tmodules\u003d$$(find $$kernel_modules_dir -type f \\(-name \u0027*.ko\u0027 ! -name $(BOARD_SYSTEM_KERNEL_MODULES)\\)); \\"},{"line_number":456,"context_line":"\t\t\t($(call build-image-kernel-modules-lineage,$$modules,$(KERNEL_MODULES_OUT),$(KERNEL_MODULE_MOUNTPOINT)/,$(KERNEL_DEPMOD_STAGING_DIR),$(BOARD_VENDOR_KERNEL_MODULES_LOAD))); \\"},{"line_number":457,"context_line":"\t\t\t$(if $(BOOT_KERNEL_MODULES),\\"},{"line_number":458,"context_line":"\t\t\t\tvendor_boot_modules\u003d$$(for m in $(BOOT_KERNEL_MODULES); do \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"116fc1f7_57b2497f","line":455,"in_reply_to":"e145c741_4cf4b5a7","updated":"2023-09-10 11:50:29.000000000","message":"Done","commit_id":"b991ba8da2e1ae42d435bbacd6297923b9cd6622"},{"author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"305c0be8cfd39f95d4572f76093981cee72664d2","unresolved":true,"context_lines":[{"line_number":465,"context_line":"\t\t\t\t\tif [ -n \"$$p\" ]; then echo $$p; else echo \"ERROR: $$m from BOARD_SYSTEM_KERNEL_MODULES was not found\" 1\u003e\u00262 \u0026\u0026 exit 1; fi; \\"},{"line_number":466,"context_line":"\t\t\t\tdone); \\"},{"line_number":467,"context_line":"\t\t\t\t[ $$? -ne 0 ] \u0026\u0026 exit 1; \\"},{"line_number":468,"context_line":"\t\t\t\t($(call build-image-kernel-modules-lineage,$$gki_modules,$(SYSTEM_KERNEL_MODULES_OUT),$(SYSTEM_KERNEL_MODULE_MOUNTPOINT)/,$(SYSTEM_KERNEL_DEPMOD_STAGING_DIR),$(BOARD_SYSTEM_KERNEL_MODULES),/$(GKI_SUFFIX))); \\"},{"line_number":469,"context_line":"\t\t\t\tfiltered_modules\u003d$$(for n in $$all_modules; do \\"},{"line_number":470,"context_line":"\t\t\t\t\tmodule_name\u003d$$(basename $$n); \\"},{"line_number":471,"context_line":"\t\t\t\t\tif [[ ! \"$(BOARD_SYSTEM_KERNEL_MODULES)\" \u003d~ \"$$module_name\" ]]; then echo $$n; fi; \\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"25c26265_098422bb","line":468,"range":{"start_line":468,"start_character":164,"end_line":468,"end_character":191},"updated":"2023-09-10 15:13:57.000000000","message":"Should I consider BOARD_SYSTEM_KERNEL_MODULES_LOAD here instead, for the case where only some of the GKI modules are loaded (rest are deps)?","commit_id":"e35ad91e96917bcbad27acaab71e03f44d509ddc"},{"author":{"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"55262c0e0ee8b4bc72d6f20317d13dddd27e6ab6","unresolved":true,"context_lines":[{"line_number":465,"context_line":"\t\t\t\t\tif [ -n \"$$p\" ]; then echo $$p; else echo \"ERROR: $$m from BOARD_SYSTEM_KERNEL_MODULES was not found\" 1\u003e\u00262 \u0026\u0026 exit 1; fi; \\"},{"line_number":466,"context_line":"\t\t\t\tdone); \\"},{"line_number":467,"context_line":"\t\t\t\t[ $$? -ne 0 ] \u0026\u0026 exit 1; \\"},{"line_number":468,"context_line":"\t\t\t\t($(call build-image-kernel-modules-lineage,$$gki_modules,$(SYSTEM_KERNEL_MODULES_OUT),$(SYSTEM_KERNEL_MODULE_MOUNTPOINT)/,$(SYSTEM_KERNEL_DEPMOD_STAGING_DIR),$(BOARD_SYSTEM_KERNEL_MODULES),/$(GKI_SUFFIX))); \\"},{"line_number":469,"context_line":"\t\t\t\tfiltered_modules\u003d$$(for n in $$all_modules; do \\"},{"line_number":470,"context_line":"\t\t\t\t\tmodule_name\u003d$$(basename $$n); \\"},{"line_number":471,"context_line":"\t\t\t\t\tif [[ ! \"$(BOARD_SYSTEM_KERNEL_MODULES)\" \u003d~ \"$$module_name\" ]]; then echo $$n; fi; \\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"f7bae69c_eaea58e7","line":468,"range":{"start_line":468,"start_character":164,"end_line":468,"end_character":191},"in_reply_to":"25c26265_098422bb","updated":"2023-09-10 16:11:30.000000000","message":"Having a separate list for copy and load would be nice. I\u0027ve blocked a change that used the vendor modules load var to copy stuff to the vendor modules folder, because my tegra targets only list the top level modules in load, not the deps.","commit_id":"e35ad91e96917bcbad27acaab71e03f44d509ddc"},{"author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0dd97e9fb0760a9556ef0e745094e4bef81e5263","unresolved":false,"context_lines":[{"line_number":465,"context_line":"\t\t\t\t\tif [ -n \"$$p\" ]; then echo $$p; else echo \"ERROR: $$m from BOARD_SYSTEM_KERNEL_MODULES was not found\" 1\u003e\u00262 \u0026\u0026 exit 1; fi; \\"},{"line_number":466,"context_line":"\t\t\t\tdone); \\"},{"line_number":467,"context_line":"\t\t\t\t[ $$? -ne 0 ] \u0026\u0026 exit 1; \\"},{"line_number":468,"context_line":"\t\t\t\t($(call build-image-kernel-modules-lineage,$$gki_modules,$(SYSTEM_KERNEL_MODULES_OUT),$(SYSTEM_KERNEL_MODULE_MOUNTPOINT)/,$(SYSTEM_KERNEL_DEPMOD_STAGING_DIR),$(BOARD_SYSTEM_KERNEL_MODULES),/$(GKI_SUFFIX))); \\"},{"line_number":469,"context_line":"\t\t\t\tfiltered_modules\u003d$$(for n in $$all_modules; do \\"},{"line_number":470,"context_line":"\t\t\t\t\tmodule_name\u003d$$(basename $$n); \\"},{"line_number":471,"context_line":"\t\t\t\t\tif [[ ! \"$(BOARD_SYSTEM_KERNEL_MODULES)\" \u003d~ \"$$module_name\" ]]; then echo $$n; fi; \\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"056f8128_bf7b6233","line":468,"range":{"start_line":468,"start_character":164,"end_line":468,"end_character":191},"in_reply_to":"f7bae69c_eaea58e7","updated":"2023-09-10 17:44:16.000000000","message":"Yea, makes sense. In the case of android13-5.15 only zram.ko can be loaded (zsmalloc.ko is its dep).","commit_id":"e35ad91e96917bcbad27acaab71e03f44d509ddc"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0513b64650a632909ef453d173b161408ed739f0","unresolved":true,"context_lines":[{"line_number":94,"context_line":"KERNEL_RELEASE :\u003d $(KERNEL_OUT)/include/config/kernel.release"},{"line_number":95,"context_line":"RECOVERY_KERNEL_CONFIG :\u003d $(RECOVERY_KERNEL_OUT)/.config"},{"line_number":96,"context_line":"RECOVERY_KERNEL_RELEASE :\u003d $(RECOVERY_KERNEL_OUT)/include/config/kernel.release"},{"line_number":97,"context_line":"GKI_SUFFIX :\u003d $(shell echo android$(PLATFORM_VERSION)-$(TARGET_KERNEL_VERSION))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"ifeq ($(KERNEL_ARCH),x86_64)"},{"line_number":100,"context_line":"KERNEL_DEFCONFIG_ARCH :\u003d x86"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"a8ea5577_b482416c","line":97,"updated":"2023-09-10 21:17:42.000000000","message":"this is kind of weird\ncan\u0027t you inline this variable within the rule definition?","commit_id":"a9e541b8969aa7220da5b047c5897440a3c63797"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d1c54d2d68b2cd2e041ba6bfc85cdae17a56bfec","unresolved":false,"context_lines":[{"line_number":94,"context_line":"KERNEL_RELEASE :\u003d $(KERNEL_OUT)/include/config/kernel.release"},{"line_number":95,"context_line":"RECOVERY_KERNEL_CONFIG :\u003d $(RECOVERY_KERNEL_OUT)/.config"},{"line_number":96,"context_line":"RECOVERY_KERNEL_RELEASE :\u003d $(RECOVERY_KERNEL_OUT)/include/config/kernel.release"},{"line_number":97,"context_line":"GKI_SUFFIX :\u003d $(shell echo android$(PLATFORM_VERSION)-$(TARGET_KERNEL_VERSION))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"ifeq ($(KERNEL_ARCH),x86_64)"},{"line_number":100,"context_line":"KERNEL_DEFCONFIG_ARCH :\u003d x86"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3c747e42_0ade78f5","line":97,"in_reply_to":"43167816_cf719702","updated":"2023-09-11 12:43:02.000000000","message":"Acknowledged","commit_id":"a9e541b8969aa7220da5b047c5897440a3c63797"},{"author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0356dd2eddb77b73bc3d4ab234924477f8a5d85a","unresolved":true,"context_lines":[{"line_number":94,"context_line":"KERNEL_RELEASE :\u003d $(KERNEL_OUT)/include/config/kernel.release"},{"line_number":95,"context_line":"RECOVERY_KERNEL_CONFIG :\u003d $(RECOVERY_KERNEL_OUT)/.config"},{"line_number":96,"context_line":"RECOVERY_KERNEL_RELEASE :\u003d $(RECOVERY_KERNEL_OUT)/include/config/kernel.release"},{"line_number":97,"context_line":"GKI_SUFFIX :\u003d $(shell echo android$(PLATFORM_VERSION)-$(TARGET_KERNEL_VERSION))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"ifeq ($(KERNEL_ARCH),x86_64)"},{"line_number":100,"context_line":"KERNEL_DEFCONFIG_ARCH :\u003d x86"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"b4712f63_42926654","line":97,"in_reply_to":"a8ea5577_b482416c","updated":"2023-09-11 08:20:37.000000000","message":"What do you mean with within the rule definition?","commit_id":"a9e541b8969aa7220da5b047c5897440a3c63797"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4f2046e5b2d06842d7e75596d75ae848df3e7be5","unresolved":true,"context_lines":[{"line_number":94,"context_line":"KERNEL_RELEASE :\u003d $(KERNEL_OUT)/include/config/kernel.release"},{"line_number":95,"context_line":"RECOVERY_KERNEL_CONFIG :\u003d $(RECOVERY_KERNEL_OUT)/.config"},{"line_number":96,"context_line":"RECOVERY_KERNEL_RELEASE :\u003d $(RECOVERY_KERNEL_OUT)/include/config/kernel.release"},{"line_number":97,"context_line":"GKI_SUFFIX :\u003d $(shell echo android$(PLATFORM_VERSION)-$(TARGET_KERNEL_VERSION))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"ifeq ($(KERNEL_ARCH),x86_64)"},{"line_number":100,"context_line":"KERNEL_DEFCONFIG_ARCH :\u003d x86"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"43167816_cf719702","line":97,"in_reply_to":"b4712f63_42926654","updated":"2023-09-11 08:25:57.000000000","message":"see inline reply","commit_id":"a9e541b8969aa7220da5b047c5897440a3c63797"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4f2046e5b2d06842d7e75596d75ae848df3e7be5","unresolved":true,"context_lines":[{"line_number":463,"context_line":"\t\t\t\t\tif [ -n \"$$p\" ]; then echo $$p; else echo \"ERROR: $$m from BOARD_SYSTEM_KERNEL_MODULES was not found\" 1\u003e\u00262 \u0026\u0026 exit 1; fi; \\"},{"line_number":464,"context_line":"\t\t\t\tdone); \\"},{"line_number":465,"context_line":"\t\t\t\t[ $$? -ne 0 ] \u0026\u0026 exit 1; \\"},{"line_number":466,"context_line":"\t\t\t\t($(call build-image-kernel-modules-lineage,$$gki_modules,$(SYSTEM_KERNEL_MODULES_OUT),$(SYSTEM_KERNEL_MODULE_MOUNTPOINT)/,$(SYSTEM_KERNEL_DEPMOD_STAGING_DIR),$(BOARD_SYSTEM_KERNEL_MODULES_LOAD),/$(GKI_SUFFIX))); \\"},{"line_number":467,"context_line":"\t\t\t\tfiltered_modules\u003d$$(for n in $$all_modules; do \\"},{"line_number":468,"context_line":"\t\t\t\t\tmodule_name\u003d$$(basename $$n); \\"},{"line_number":469,"context_line":"\t\t\t\t\tif [[ ! \"$(BOARD_SYSTEM_KERNEL_MODULES)\" \u003d~ \"$$module_name\" ]]; then echo $$n; fi; \\"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"53756d11_4b6ec60f","line":466,"range":{"start_line":466,"start_character":201,"end_line":466,"end_character":211},"updated":"2023-09-11 08:25:57.000000000","message":"it seems to be only used here\nyou can likely do after `$(if $(BOARD_SYSTEM_KERNEL_MODULES)`\ngki_suffic\u003dandroid$(PLATFORM_VERSION)-$(TARGET_KERNEL_VERSION)","commit_id":"a9e541b8969aa7220da5b047c5897440a3c63797"},{"author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fea0dc03657d12870f9dd6e5372df703e4823d55","unresolved":true,"context_lines":[{"line_number":463,"context_line":"\t\t\t\t\tif [ -n \"$$p\" ]; then echo $$p; else echo \"ERROR: $$m from BOARD_SYSTEM_KERNEL_MODULES was not found\" 1\u003e\u00262 \u0026\u0026 exit 1; fi; \\"},{"line_number":464,"context_line":"\t\t\t\tdone); \\"},{"line_number":465,"context_line":"\t\t\t\t[ $$? -ne 0 ] \u0026\u0026 exit 1; \\"},{"line_number":466,"context_line":"\t\t\t\t($(call build-image-kernel-modules-lineage,$$gki_modules,$(SYSTEM_KERNEL_MODULES_OUT),$(SYSTEM_KERNEL_MODULE_MOUNTPOINT)/,$(SYSTEM_KERNEL_DEPMOD_STAGING_DIR),$(BOARD_SYSTEM_KERNEL_MODULES_LOAD),/$(GKI_SUFFIX))); \\"},{"line_number":467,"context_line":"\t\t\t\tfiltered_modules\u003d$$(for n in $$all_modules; do \\"},{"line_number":468,"context_line":"\t\t\t\t\tmodule_name\u003d$$(basename $$n); \\"},{"line_number":469,"context_line":"\t\t\t\t\tif [[ ! \"$(BOARD_SYSTEM_KERNEL_MODULES)\" \u003d~ \"$$module_name\" ]]; then echo $$n; fi; \\"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"8248e04a_9dcf70db","line":466,"range":{"start_line":466,"start_character":201,"end_line":466,"end_character":211},"in_reply_to":"53756d11_4b6ec60f","updated":"2023-09-11 12:06:42.000000000","message":"Okay, I tried that before, but I get this:\n\n\u003e  error: kati doesn\u0027t support passing results of $(shell) to other make constructs: echo 5\".\"15","commit_id":"a9e541b8969aa7220da5b047c5897440a3c63797"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d1c54d2d68b2cd2e041ba6bfc85cdae17a56bfec","unresolved":false,"context_lines":[{"line_number":463,"context_line":"\t\t\t\t\tif [ -n \"$$p\" ]; then echo $$p; else echo \"ERROR: $$m from BOARD_SYSTEM_KERNEL_MODULES was not found\" 1\u003e\u00262 \u0026\u0026 exit 1; fi; \\"},{"line_number":464,"context_line":"\t\t\t\tdone); \\"},{"line_number":465,"context_line":"\t\t\t\t[ $$? -ne 0 ] \u0026\u0026 exit 1; \\"},{"line_number":466,"context_line":"\t\t\t\t($(call build-image-kernel-modules-lineage,$$gki_modules,$(SYSTEM_KERNEL_MODULES_OUT),$(SYSTEM_KERNEL_MODULE_MOUNTPOINT)/,$(SYSTEM_KERNEL_DEPMOD_STAGING_DIR),$(BOARD_SYSTEM_KERNEL_MODULES_LOAD),/$(GKI_SUFFIX))); \\"},{"line_number":467,"context_line":"\t\t\t\tfiltered_modules\u003d$$(for n in $$all_modules; do \\"},{"line_number":468,"context_line":"\t\t\t\t\tmodule_name\u003d$$(basename $$n); \\"},{"line_number":469,"context_line":"\t\t\t\t\tif [[ ! \"$(BOARD_SYSTEM_KERNEL_MODULES)\" \u003d~ \"$$module_name\" ]]; then echo $$n; fi; \\"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"6a5cf86d_08f28b37","line":466,"range":{"start_line":466,"start_character":201,"end_line":466,"end_character":211},"in_reply_to":"8248e04a_9dcf70db","updated":"2023-09-11 12:43:02.000000000","message":"Acknowledged\ndidn\u0027t notice TARGET_KERNEL_VERSION is using $(shell) already","commit_id":"a9e541b8969aa7220da5b047c5897440a3c63797"}]}