)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"da8e4867f2a4c3997adfe901506a67c5b3e415c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c72ef59_325b699a","updated":"2022-05-14 15:10:28.000000000","message":"https://gitlab.com/LineageOS/issues/android/-/issues/4674","commit_id":"d64017e232aa8fabb380d7b4b95b8f12b96db38e"},{"author":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"addd89cecfd5ac748e4954b48caa7d04960bdc5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bef9e7a8_6a89b03d","updated":"2022-05-14 15:38:14.000000000","message":"https://review.lineageos.org/c/LineageOS/android_device_google_raviole/+/327547 ","commit_id":"bb391f0fc89b303b6b14ea6933789ea609622390"},{"author":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f4abaf333e97a0f9a0b376d806ed48b5f68809eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b2d29832_8983c4fb","updated":"2022-05-14 15:39:39.000000000","message":"should we also set this global\nhttps://review.lineageos.org/c/LineageOS/android_device_google_raviole/+/327547","commit_id":"bb391f0fc89b303b6b14ea6933789ea609622390"},{"author":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8a9ed8cb27f6663e3f90c72aa1e8beae8b27d021","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"40c2e29b_93154507","updated":"2022-05-15 12:32:25.000000000","message":"\u003e Patch Set 5:\n\u003e \n\u003e Before adding such a workaround, I\u0027d suggest what exactly is causing those location requests in the first place. Is it something we have control over (IOW, build from source), or is it some QCOM blob running under the telephony service UID?\n\nI think its related to this, not sure though. it was merged in May SP .\nhttps://github.com/LineageOS/android_frameworks_base/commit/abb41637225c95d5530bff275531a446be66a18c","commit_id":"90902d9bcca8dfaa6c5822875995f2efc6de6836"},{"author":{"_account_id":29415,"name":"Alexander Koskovich","email":"akoskovich@pm.me","username":"nexus","avatars":[{"url":"https://www.gravatar.com/avatar/954e49384495941ef8384926fa1e319e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/954e49384495941ef8384926fa1e319e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/954e49384495941ef8384926fa1e319e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/954e49384495941ef8384926fa1e319e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cd20744c1f6e72ae7734f6d2e268888faf019bf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c15aede6_805fbf19","updated":"2022-05-17 14:30:49.000000000","message":"\u003e Patch Set 5:\n\u003e \n\u003e I somewhat doubt it\u0027s related to that. That patch just removes location info from the service state broadcast for receivers not holding the location permission, it doesn\u0027t change anything regarding location requests.\n\nAfter reverting the commit in question, I have gotten zero location requests from Phone Services.","commit_id":"90902d9bcca8dfaa6c5822875995f2efc6de6836"},{"author":{"_account_id":1063,"name":"Danny Baumann","email":"dannybaumann@web.de","username":"maniac103","avatars":[{"url":"https://www.gravatar.com/avatar/00c5b296596581f448d95945c1ad9c5f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00c5b296596581f448d95945c1ad9c5f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00c5b296596581f448d95945c1ad9c5f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00c5b296596581f448d95945c1ad9c5f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1afa787fb4242e072bf365505745caaa3ea13f54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d15b87a1_933a83a1","updated":"2022-05-17 15:08:02.000000000","message":"Interesting. On a first glance, that broadcast should only cause the location app op to be \u0027noted\u0027, not \u0027started\u0027 (the latter being the state recorded by the location indicator). I\u0027ll investigate this.","commit_id":"90902d9bcca8dfaa6c5822875995f2efc6de6836"},{"author":{"_account_id":1063,"name":"Danny Baumann","email":"dannybaumann@web.de","username":"maniac103","avatars":[{"url":"https://www.gravatar.com/avatar/00c5b296596581f448d95945c1ad9c5f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00c5b296596581f448d95945c1ad9c5f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00c5b296596581f448d95945c1ad9c5f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00c5b296596581f448d95945c1ad9c5f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b86470f245e3ff07b7e8b648b0e80819c079e673","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fc8445bd_3f6dbdb7","updated":"2022-05-18 07:53:26.000000000","message":"Looks I was right about the broadcast only causes the location access to be \u0027noted\u0027, but it also looks like that\u0027s sufficient to show the location indicator (-\u003e https://github.com/LineageOS/android_frameworks_base/blob/lineage-19.1/packages/SystemUI/src/com/android/systemui/appops/AppOpsControllerImpl.java#L417).\n\nIt still feels somewhat weird to me that passive reception of a broadcast causes the same visual outcome in SystemUI as an active access (e.g. registering a location listener), but I guess that\u0027s the way it\u0027s intended to work, so this patch seems correct.","commit_id":"90902d9bcca8dfaa6c5822875995f2efc6de6836"},{"author":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d8030536f39610ba1e3c5f48b3568b2d1305f716","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4e4cab6d_9da08996","updated":"2022-05-14 17:54:16.000000000","message":"Tested on alioth, no more phone service location indicator","commit_id":"90902d9bcca8dfaa6c5822875995f2efc6de6836"}],"overlay/common/frameworks/base/core/res/res/values/config.xml":[{"author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b96de5ac9656ac1b4d24dddb42e1e8e40ef83de4","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    \u003cstring-array name\u003d\"config_locationExtraPackageNames\" translatable\u003d\"false\"\u003e"},{"line_number":46,"context_line":"        \u003c!-- Dialer --\u003e"},{"line_number":47,"context_line":"        \u003citem\u003ecom.android.phone\u003c/item\u003e"},{"line_number":48,"context_line":"    \u003c/string-array\u003e"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    \u003cbool name\u003d\"config_cellBroadcastAppLinks\"\u003etrue\u003c/bool\u003e"}],"source_content_type":"application/xml","patch_set":2,"id":"0906269a_5fa68b33","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":38},"updated":"2022-05-14 15:34:12.000000000","message":"that\u0027s not dialer but TeleService in packages/services/Telephony","commit_id":"a61ec22a5d5dacd6bb1c9e01265b1e187ee8847c"},{"author":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"addd89cecfd5ac748e4954b48caa7d04960bdc5d","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    \u003cstring-array name\u003d\"config_locationExtraPackageNames\" translatable\u003d\"false\"\u003e"},{"line_number":46,"context_line":"        \u003c!-- Dialer --\u003e"},{"line_number":47,"context_line":"        \u003citem\u003ecom.android.phone\u003c/item\u003e"},{"line_number":48,"context_line":"    \u003c/string-array\u003e"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    \u003cbool name\u003d\"config_cellBroadcastAppLinks\"\u003etrue\u003c/bool\u003e"}],"source_content_type":"application/xml","patch_set":2,"id":"1fff4658_8b4d0a9d","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":38},"in_reply_to":"0906269a_5fa68b33","updated":"2022-05-14 15:38:14.000000000","message":"done","commit_id":"a61ec22a5d5dacd6bb1c9e01265b1e187ee8847c"}]}