)]}'
{"id":"LineageOS%2Fandroid_vendor_lineage~204837","triplet_id":"LineageOS%2Fandroid_vendor_lineage~staging%2Flineage-15.1~I120b8dc85dfbbe0b4d9e0a620c58d7556feca9c5","project":"LineageOS/android_vendor_lineage","branch":"staging/lineage-15.1","hashtags":[],"change_id":"I120b8dc85dfbbe0b4d9e0a620c58d7556feca9c5","subject":"overlay: Allow to use UnifiedNlp location provider","status":"ABANDONED","created":"2018-01-31 08:14:39.000000000","updated":"2020-12-03 06:14:47.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"555383c7670f32b25f464f70b50875699af6cc40","_number":204837,"virtual_id_number":204837,"owner":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"date":"2018-02-01 04:57:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"disliked":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":-1,"date":"2018-02-01 11:24:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0},"CI":{"all":[{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"CC":[{"_account_id":27552,"name":"greenflash1986","email":"green.flash@gmx.net","username":"Greenflash1986","avatars":[{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-02-01 11:24:56.000000000","updated_by":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-12-03 02:13:15.000000000","updated_by":{"_account_id":27552,"name":"greenflash1986","email":"green.flash@gmx.net","username":"Greenflash1986","avatars":[{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":27552,"name":"greenflash1986","email":"green.flash@gmx.net","username":"Greenflash1986","avatars":[{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"CC"}],"messages":[{"id":"b49ec07bc4f7c8b96072af254def1afce15102ad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-01-31 08:14:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7e68ec30191cb0103dc01050281d87e9a0c16ae4","author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-01-31 16:54:40.000000000","message":"Patch Set 1:\n\nI\u0027m fairly certain this is a no-op, because it loads them in order afaik, and com.android.location.fused is always present, so that is chosen before unifiednlp","accounts_in_message":[],"_revision_number":1},{"id":"bf2d4b6ae758ff2d4cd95f80eb9827b4f2c2c2f7","author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-01-31 17:01:33.000000000","message":"Patch Set 1:\n\nAlso, I don\u0027t think they can patch in signature spoofing in a flashable addon.","accounts_in_message":[],"_revision_number":1},{"id":"3b88883086d01b1c4526a5b462f30c8b0700adf9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-02-01 04:56:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9dfd6a7818f4d07b1844d7eb0130543f48c59392","author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-02-01 04:57:37.000000000","message":"Patch Set 2:\n\nYou don\u0027t need signature spoofing for this. It works with GAPPS installed. You don\u0027t need anything else from MicroG.","accounts_in_message":[],"_revision_number":2},{"id":"38003b934c2768c5f19b6759e9bdd27b9a906781","author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-02-01 11:24:56.000000000","message":"Patch Set 2: Code-Review-1\n\nI don\u0027t like prioritizing microG\u0027s UnifiedNlp over Google\u0027s location provider if the user installed both.","accounts_in_message":[],"_revision_number":2},{"id":"5250c96005f9a5f0621e48686d89e110a028cfd7","author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-02-01 11:27:00.000000000","message":"Patch Set 2:\n\n(that\u0027s my personal opinion, you may want to get more eyes on this)","accounts_in_message":[],"_revision_number":2},{"id":"4689f1f8c4bf27f2aa0aa21dee48c77461621a15","tag":"autogenerated:gerrit:abandon","author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-02-12 06:42:17.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2},{"id":"9ecc61fe611f195b13f5770e33904afccb01c2fa","author":{"_account_id":27552,"name":"greenflash1986","email":"green.flash@gmx.net","username":"Greenflash1986","avatars":[{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6431c06c589a1989d597378177f4c6da.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-12-03 02:13:15.000000000","message":"Patch Set 2:\n\nFirst time working with LineageOS Gerrit... Sorry for any mistakes.\n\nI was looking into this stuff the last days. I want to / have to use Gapps on my phone but I don\u0027t like to use the location provider. Therefore I did some science to use UnifiedNLP beside GAPPS.\n\nI\u0027ll post some proof if this PR can be reopened. If not I\u0027ll create a new one.\n\nMy findings for Android 9 / Pie are:\n- no loading of the location providers in order\n- no signature spoofing required -\u003e if the user were able to install the app in priv-app it\u0027s working.\n\nThe need for this PR is: the system uses this list to look up the Signatures of the packages in this list which are installed in sytem. This list contains the \"allowed signatures\".\n- after looking up the signatures the system looks for packages which provide different service: fused, network, Geocode...\n- the system checks the allowed signatures against the packages\n- the system looks for the \"serviceVersion\" in metadata of the package\n- the \"bestService\" is choosen to provide the implementation of the service\n- example:\n  - this PR applied, the system starts up, Gapps and MicroG and fused package are in the config_locationProviderPackageNames AND are installed in system\n  - the system collects the signature of all 3\n  - the system tries to load the location provider \"network\"\n  - it looks up the packages which provide \"location provider network\" and finds Gapps network location server and MicroG Unified\n  - the system questioned both of the for the \"serviceVersion\" of the \"location provider network\"-service\n  - the \"best one\" is choosen\n\ni tested this workflow with an Android 10 and self compiled Unified (https://forum.xda-developers.com/t/rom-unofficial-9-0-signed-ota-lineage-os-16-0-for-xperia-z1-compact.3886233/post-84022365)\n\nLet me know if this PR could be reopened or if I have to create a new one.\n\nBest regards","accounts_in_message":[],"_revision_number":2},{"id":"555383c7670f32b25f464f70b50875699af6cc40","author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-12-03 06:14:47.000000000","message":"Patch Set 2:\n\nHi - you definitely need to open a PR on the current branch, this one will not be reopened. It is on the 15.1 branch, where only security fixes are merged.\n\nIf Google is chosen before UnifiedNlp, I think I\u0027m actually OK with this...but I wish the logic here was more clear and that there was some way that we could know that Google\u0027s would be picked first given the order of the overlay or something, instead of relying on some kind of API version check that will assuredly violate assumptions later on.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fa1e5f66174a82db80101fac7953f8cebd418a1e","revisions":{"e1cb370973700c7a954ada878985639356fd04c1":{"kind":"REWORK","_number":1,"created":"2018-01-31 08:14:39.000000000","uploader":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/37/204837/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_vendor_lineage","ref":"refs/changes/37/204837/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/1 \u0026\u0026 git checkout -b change-204837 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/1","Reset To":"git fetch https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4e75f576f9589fcbd1d26b6406aa6dab13378d76","subject":"extract_utils: Fix regressions from 3f9b94cb67a88999f7747af8335c5e576939360b","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_lineage/commit/4e75f576f9589fcbd1d26b6406aa6dab13378d76"}]}],"author":{"name":"Andreas Schneider","email":"asn@cryptomilk.org","date":"2018-01-31 08:55:36.000000000","tz":60},"committer":{"name":"Andreas Schneider","email":"asn@cryptomilk.org","date":"2018-01-31 09:13:56.000000000","tz":60},"subject":"overlay: Allow to use UnifiedNlp location provider","message":"overlay: Allow to use UnifiedNlp location provider\n\nThis doesn\u0027t have security implications as in order to use the location\nprovider in needs to be installed as a system app. However this would\nallow it to be flashed to system like gapps.\n\nChange-Id: I120b8dc85dfbbe0b4d9e0a620c58d7556feca9c5\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_lineage/commit/e1cb370973700c7a954ada878985639356fd04c1"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_lineage/commit/e1cb370973700c7a954ada878985639356fd04c1"}]},"branch":"refs/heads/staging/lineage-15.1"},"fa1e5f66174a82db80101fac7953f8cebd418a1e":{"kind":"REWORK","_number":2,"created":"2018-02-01 04:56:43.000000000","uploader":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/37/204837/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_vendor_lineage","ref":"refs/changes/37/204837/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/2 \u0026\u0026 git checkout -b change-204837 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/2","Reset To":"git fetch https://github.com/LineageOS/android_vendor_lineage refs/changes/37/204837/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4e75f576f9589fcbd1d26b6406aa6dab13378d76","subject":"extract_utils: Fix regressions from 3f9b94cb67a88999f7747af8335c5e576939360b","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_lineage/commit/4e75f576f9589fcbd1d26b6406aa6dab13378d76"}]}],"author":{"name":"Andreas Schneider","email":"asn@cryptomilk.org","date":"2018-01-31 08:55:36.000000000","tz":60},"committer":{"name":"Andreas Schneider","email":"asn@cryptomilk.org","date":"2018-02-01 05:56:15.000000000","tz":60},"subject":"overlay: Allow to use UnifiedNlp location provider","message":"overlay: Allow to use UnifiedNlp location provider\n\nThis doesn\u0027t have security implications as in order to use the location\nprovider in needs to be installed as a system app. However this would\nallow it to be flashed to system like gapps.\n\nChange-Id: I120b8dc85dfbbe0b4d9e0a620c58d7556feca9c5\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_lineage/commit/fa1e5f66174a82db80101fac7953f8cebd418a1e"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_vendor_lineage/commit/fa1e5f66174a82db80101fac7953f8cebd418a1e"}]},"branch":"refs/heads/staging/lineage-15.1"}},"requirements":[],"submit_records":[],"submit_requirements":[]}