)]}'
{"device/src/controller.cc":[{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a1919f9c5c96b1db916d70128f80b741694497f1","unresolved":false,"context_lines":[{"line_number":369,"context_line":"#if (BTM_SCO_ENHANCED_SYNC_DISABLED \u003d\u003d TRUE)"},{"line_number":370,"context_line":"  return false;"},{"line_number":371,"context_line":"#else"},{"line_number":372,"context_line":"  return HCI_ENH_SETUP_SYNCH_CONN_SUPPORTED(supported_commands);"},{"line_number":373,"context_line":"#endif"},{"line_number":374,"context_line":"}"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-c","patch_set":1,"id":"d160cfe5_b6be56d0","line":372,"range":{"start_line":372,"start_character":44,"end_line":372,"end_character":62},"updated":"2018-02-24 18:41:31.000000000","message":"Previous comment was to modify the bitmask to remove the flag checked by HCI_ENH_SETUP_SYNCH_CONN_SUPPORTED from being set in the first place.","commit_id":"1da987b29410f6dc728f52d2a72bf7ba293c0348"},{"author":{"_account_id":18836,"name":"Nich","email":"nctrenco@gmail.com","username":"nichcream","avatars":[{"url":"https://www.gravatar.com/avatar/653fa2164851fbf35a7892a378010776.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/653fa2164851fbf35a7892a378010776.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/653fa2164851fbf35a7892a378010776.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/653fa2164851fbf35a7892a378010776.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"69819f70449a5a8c66512fac01cc3b9f47724c80","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  response \u003d"},{"line_number":115,"context_line":"      AWAIT_COMMAND(packet_factory-\u003emake_read_local_supported_commands());"},{"line_number":116,"context_line":"  packet_parser-\u003eparse_read_local_supported_commands_response("},{"line_number":117,"context_line":"      response, supported_commands, HCI_SUPPORTED_COMMANDS_ARRAY_SIZE);"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  // Read page 0 of the controller features next"},{"line_number":120,"context_line":"  uint8_t page_number \u003d 0;"}],"source_content_type":"text/x-c","patch_set":2,"id":"d3b9db67_ab0eec42","side":"PARENT","line":117,"updated":"2018-03-17 03:22:43.000000000","message":"Here.","commit_id":"f76bc749bf923fe687e1ba9eebb1522afd72e87e"},{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"50c72916caa8198463725a0d05aef8619c963dba","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  response \u003d"},{"line_number":115,"context_line":"      AWAIT_COMMAND(packet_factory-\u003emake_read_local_supported_commands());"},{"line_number":116,"context_line":"  packet_parser-\u003eparse_read_local_supported_commands_response("},{"line_number":117,"context_line":"      response, supported_commands, HCI_SUPPORTED_COMMANDS_ARRAY_SIZE);"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  // Read page 0 of the controller features next"},{"line_number":120,"context_line":"  uint8_t page_number \u003d 0;"}],"source_content_type":"text/x-c","patch_set":2,"id":"b226eb20_87de403f","side":"PARENT","line":117,"in_reply_to":"d3b9db67_ab0eec42","updated":"2018-03-17 05:56:41.000000000","message":"I think it makes more sense to unset that bit in the bitset based on the flag, rather than noop-ing the macro, in case the macro isn\u0027t the only thing checking the value.","commit_id":"f76bc749bf923fe687e1ba9eebb1522afd72e87e"}],"stack/include/hcidefs.h":[{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3b0b4cef34822ac3fe0821da7f8b83b596b58d66","unresolved":false,"context_lines":[{"line_number":1592,"context_line":"#define HCI_WRITE_BE_FLUSH_TOUT_SUPPORTED(x) ((x)[24] \u0026 0x08)"},{"line_number":1593,"context_line":"#define HCI_SHORT_RANGE_MODE_SUPPORTED(x) ((x)[24] \u0026 0x10)"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"#define HCI_ENH_SETUP_SYNCH_CONN_SUPPORTED(x) ((x)[29] \u0026 0x08)"},{"line_number":1596,"context_line":"#define HCI_ENH_ACCEPT_SYNCH_CONN_SUPPORTED(x) ((x)[29] \u0026 0x10)"},{"line_number":1597,"context_line":"#define HCI_READ_LOCAL_CODECS_SUPPORTED(x) ((x)[29] \u0026 0x20)"},{"line_number":1598,"context_line":"#define HCI_SET_MWS_CHANNEL_PARAMETERS_SUPPORTED(x) ((x)[29] \u0026 0x40)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e1122e27_7b0b9b02","side":"PARENT","line":1595,"range":{"start_line":1595,"start_character":8,"end_line":1595,"end_character":42},"updated":"2018-03-17 02:36:51.000000000","message":"What normally sets this bit? Instead of no-oping the check, why not check what sets the value to begin with?","commit_id":"f76bc749bf923fe687e1ba9eebb1522afd72e87e"}]}