)]}'
{"id":"LineageOS%2Fandroid_packages_services_Telephony~216256","triplet_id":"LineageOS%2Fandroid_packages_services_Telephony~cm-14.1~I446df94907dd5aff355216723e606cb52c92d123","project":"LineageOS/android_packages_services_Telephony","branch":"cm-14.1","hashtags":[],"change_id":"I446df94907dd5aff355216723e606cb52c92d123","subject":"Telephony: Don\u0027t rely on a possibly invalid phoneId","status":"MERGED","created":"2018-05-27 17:32:26.000000000","updated":"2018-05-28 18:19:25.000000000","submitted":"2018-05-28 18:19:25.000000000","submitter":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"216256-1527531565424-34f733cf","meta_rev_id":"1c4ea2163b5f6a6a8035ab8c752baed7f0f268b5","_number":216256,"virtual_id_number":216256,"owner":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":1,"date":"2018-05-28 18:16:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":2,"date":"2018-05-28 18:16:36.000000000","_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"342ea611dbbc5726c5f6f20268f570bfed812736","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-05-27 17:32:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"639c0edb3df59e3161498b260423d62cc97942fa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-05-27 18:12:14.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"0a2c4e6b3790dcd673f8f1839014a734714c4e81","author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-05-28 18:16:36.000000000","message":"Patch Set 2: Verified+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1c4ea2163b5f6a6a8035ab8c752baed7f0f268b5","tag":"autogenerated:gerrit:merged","author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-05-28 18:19:25.000000000","message":"Change has been successfully merged by Michael W","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1e0490f79a6b9509ecc2be6a4d98f54895409266","revisions":{"0f90aa852354809df70646948011140cdb90aef1":{"kind":"REWORK","_number":1,"created":"2018-05-27 17:32:26.000000000","uploader":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/56/216256/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_services_Telephony","ref":"refs/changes/56/216256/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/1 \u0026\u0026 git checkout -b change-216256 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ff2d39e6ef4e91108d0d31f746aeaaa0f0cd1f0d","subject":"Enhanced permission checks for TelephonyManager#endCall() API.","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telephony/commit/ff2d39e6ef4e91108d0d31f746aeaaa0f0cd1f0d"}]}],"author":{"name":"Michael W","email":"baddaemon87@gmail.com","date":"2018-05-27 17:30:25.000000000","tz":120},"committer":{"name":"Michael W","email":"baddaemon87@gmail.com","date":"2018-05-27 17:31:50.000000000","tz":120},"subject":"Telephony: Don\u0027t rely on a possibly invalid phoneId","message":"Telephony: Don\u0027t rely on a possibly invalid phoneId\n\n* getPhoneIdForECall returns \"0\" in case of missing Telephony extensions\n* this is always the first slot, so a sim in slot 2 wouldnt be used for\n  that call\n* return an invalid phoneId in that case and let the rest of the\n  logic choose a valid phoneId instead\n\nTest:\nChange-Id: I446df94907dd5aff355216723e606cb52c92d123\nBefore: Sim in slot2 only: emergency call aborted\nAfter: ECall actually goes through\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telephony/commit/0f90aa852354809df70646948011140cdb90aef1"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telephony/commit/0f90aa852354809df70646948011140cdb90aef1"}]},"branch":"refs/heads/cm-14.1"},"1e0490f79a6b9509ecc2be6a4d98f54895409266":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2018-05-27 18:12:14.000000000","uploader":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/56/216256/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_services_Telephony","ref":"refs/changes/56/216256/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/2 \u0026\u0026 git checkout -b change-216256 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_services_Telephony refs/changes/56/216256/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ff2d39e6ef4e91108d0d31f746aeaaa0f0cd1f0d","subject":"Enhanced permission checks for TelephonyManager#endCall() API.","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telephony/commit/ff2d39e6ef4e91108d0d31f746aeaaa0f0cd1f0d"}]}],"author":{"name":"Michael W","email":"baddaemon87@gmail.com","date":"2018-05-27 18:12:11.000000000","tz":120},"committer":{"name":"Michael W","email":"baddaemon87@gmail.com","date":"2018-05-27 18:12:11.000000000","tz":120},"subject":"Telephony: Don\u0027t rely on a possibly invalid phoneId","message":"Telephony: Don\u0027t rely on a possibly invalid phoneId\n\n* getPhoneIdForECall returns \"0\" in case of missing Telephony extensions\n* this is always the first slot, so a sim in slot 2 wouldnt be used for\n  that call\n* return an invalid phoneId in that case and let the rest of the\n  logic choose a valid phoneId instead\n\nTest:\nBefore: Sim in slot2 only: emergency call aborted\nAfter: ECall actually goes through\n\nChange-Id: I446df94907dd5aff355216723e606cb52c92d123\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telephony/commit/1e0490f79a6b9509ecc2be6a4d98f54895409266"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telephony/commit/1e0490f79a6b9509ecc2be6a4d98f54895409266"}]},"branch":"refs/heads/cm-14.1"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}