)]}'
{"id":"LineageOS%2Fandroid_packages_services_Telecomm~417929","triplet_id":"LineageOS%2Fandroid_packages_services_Telecomm~lineage-20.0~If46cfa26278f09854c10266af6eaa73382f20296","project":"LineageOS/android_packages_services_Telecomm","branch":"lineage-20.0","topic":"T_asb_2025-02","hashtags":[],"change_id":"If46cfa26278f09854c10266af6eaa73382f20296","subject":"Unbind CS if connection is not created within 15 seconds.","status":"MERGED","created":"2025-02-07 20:21:17.000000000","updated":"2025-02-15 15:51:37.000000000","submitted":"2025-02-15 15:51:37.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"417929-T_asb_2025-02","meta_rev_id":"99c0c6a5b4ce73c8fccb1a0f6a98007e1b3722f6","_number":417929,"virtual_id_number":417929,"owner":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"85e7c2b582f228a01fbcd4f97246124aa3498163","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-02-07 20:21:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"99c0c6a5b4ce73c8fccb1a0f6a98007e1b3722f6","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-02-15 15:51:37.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5fac45e2a0678a766840dce38b353c76ee6daa31","revisions":{"29350e833aac4ec142058212a53435e39dc97271":{"kind":"REWORK","_number":1,"created":"2025-02-07 20:21:17.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/29/417929/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_services_Telecomm","ref":"refs/changes/29/417929/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/1 \u0026\u0026 git checkout -b change-417929 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"041840af131e725c4204f1a75405c6d74261e8be","subject":"Merge tag \u0027android-security-13.0.0_r23\u0027 into staging/lineage-20.0_android-security-13.0.0_r23","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telecomm/commit/041840af131e725c4204f1a75405c6d74261e8be"}]}],"author":{"name":"Grant Menke","email":"grantmenke@google.com","date":"2024-10-28 23:42:25.000000000","tz":-420},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2025-02-07 17:35:33.000000000","tz":-420},"subject":"Unbind CS if connection is not created within 15 seconds.","message":"Unbind CS if connection is not created within 15 seconds.\n\nThis CL adds a check to ensure that connection creation occurs within 15 seconds after binding to that ConnectionService. If the connection/conference is not created in that timespan, this CL adds logic to manually unbind the ConnectionService at that point in time. This prevents malicious apps from keeping a declared permission in forever even in the background. This updated CL includes a null check to avoid a NPE that occurred in the first iteration of this change.\n\nBug: 293458004\nTest: manually using the provided apk + atest CallsManagerTest\nFlag: EXEMPT Security High/Critical Severity CVE\n(cherry picked from commit 48d6b0df91fb1c8c0b11891f878084c6d8f9fa8a)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:87d3edd1743efae8cfb5ff60b862e6430987bc5a)\nMerged-In: If46cfa26278f09854c10266af6eaa73382f20296\nChange-Id: If46cfa26278f09854c10266af6eaa73382f20296\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telecomm/commit/29350e833aac4ec142058212a53435e39dc97271"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telecomm/commit/29350e833aac4ec142058212a53435e39dc97271"}]},"branch":"refs/heads/lineage-20.0"},"5fac45e2a0678a766840dce38b353c76ee6daa31":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-02-15 15:51:37.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/29/417929/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_services_Telecomm","ref":"refs/changes/29/417929/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/2 \u0026\u0026 git checkout -b change-417929 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_services_Telecomm refs/changes/29/417929/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6917ee29580725092281e4b5e6bb9eab09621732","subject":"Merge cherrypicks of [\u0027googleplex-android-review.googlesource.com/28727862\u0027] into security-aosp-tm-release.","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telecomm/commit/6917ee29580725092281e4b5e6bb9eab09621732"}]}],"author":{"name":"Grant Menke","email":"grantmenke@google.com","date":"2024-10-28 23:42:25.000000000","tz":-420},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2024-12-12 01:42:48.000000000","tz":-480},"subject":"Unbind CS if connection is not created within 15 seconds.","message":"Unbind CS if connection is not created within 15 seconds.\n\nThis CL adds a check to ensure that connection creation occurs within 15 seconds after binding to that ConnectionService. If the connection/conference is not created in that timespan, this CL adds logic to manually unbind the ConnectionService at that point in time. This prevents malicious apps from keeping a declared permission in forever even in the background. This updated CL includes a null check to avoid a NPE that occurred in the first iteration of this change.\n\nBug: 293458004\nTest: manually using the provided apk + atest CallsManagerTest\nFlag: EXEMPT Security High/Critical Severity CVE\n(cherry picked from commit 48d6b0df91fb1c8c0b11891f878084c6d8f9fa8a)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:87d3edd1743efae8cfb5ff60b862e6430987bc5a)\nMerged-In: If46cfa26278f09854c10266af6eaa73382f20296\nChange-Id: If46cfa26278f09854c10266af6eaa73382f20296\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telecomm/commit/5fac45e2a0678a766840dce38b353c76ee6daa31"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_services_Telecomm/commit/5fac45e2a0678a766840dce38b353c76ee6daa31"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}