)]}'
{"id":"LineageOS%2Fandroid_packages_providers_MediaProvider~318529","triplet_id":"LineageOS%2Fandroid_packages_providers_MediaProvider~lineage-18.1~I1e62c4b31083ec07e72df066b1bd985289f01783","project":"LineageOS/android_packages_providers_MediaProvider","branch":"lineage-18.1","hashtags":[],"change_id":"I1e62c4b31083ec07e72df066b1bd985289f01783","subject":"Fix read range computation for some corner cases in redaction ranges","status":"MERGED","created":"2021-11-02 20:46:12.000000000","updated":"2021-11-06 20:30:37.000000000","submitted":"2021-11-06 20:30:37.000000000","submitter":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"318529","meta_rev_id":"7f5bb2c04de1b1a0e268917d3609f6e3a61d48dc","_number":318529,"virtual_id_number":318529,"owner":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":29353,"name":"Thomas Zell","email":"thomas.zell@gmail.com","username":"birefringence","avatars":[{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":0,"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":1,"date":"2021-11-06 20:27:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29353,"name":"Thomas Zell","email":"thomas.zell@gmail.com","username":"birefringence","avatars":[{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":2,"date":"2021-11-02 21:35:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":29353,"name":"Thomas Zell","email":"thomas.zell@gmail.com","username":"birefringence","avatars":[{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":1,"date":"2021-11-02 20:51:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":29353,"name":"Thomas Zell","email":"thomas.zell@gmail.com","username":"birefringence","avatars":[{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":29353,"name":"Thomas Zell","email":"thomas.zell@gmail.com","username":"birefringence","avatars":[{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-02 21:35:13.000000000","updated_by":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-11-06 20:27:53.000000000","updated_by":{"_account_id":29353,"name":"Thomas Zell","email":"thomas.zell@gmail.com","username":"birefringence","avatars":[{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":29353,"name":"Thomas Zell","email":"thomas.zell@gmail.com","username":"birefringence","avatars":[{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"feb074f5c7907cded6bc5069393903f43c76177a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-11-02 20:46:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9f2a88f5f737d3cffb6b87a6d98113353af93fbc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-11-02 20:50:17.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"bf8d79120a5c46f1ebed283f8a12178392ab506e","author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-11-02 20:51:32.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"79f0ac6d7f19c1ad465f2678047f14b02bd76db3","author":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-11-02 21:35:13.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1020303aa6856bb2d7baf521b93ed5c96956e91b","author":{"_account_id":29353,"name":"Thomas Zell","email":"thomas.zell@gmail.com","username":"birefringence","avatars":[{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-11-06 20:27:53.000000000","message":"Patch Set 2: Verified+1\n\nI don\u0027t really know how to trigger these edge conditions that are fixed here, but I can confirm that the code still build, runs, and the redacted sharing of JPEGs still works as expected.","accounts_in_message":[],"_revision_number":2},{"id":"7f5bb2c04de1b1a0e268917d3609f6e3a61d48dc","tag":"autogenerated:gerrit:merged","author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-11-06 20:30:37.000000000","message":"Change has been successfully merged by Luca Stefani","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c50c5facf24cd16145cc86003a68dd185311efe9","revisions":{"29fabfcd96e1c4a66a9fc7e5cd1e4f5f293b79cd":{"kind":"REWORK","_number":1,"created":"2021-11-02 20:46:12.000000000","uploader":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/29/318529/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_providers_MediaProvider","ref":"refs/changes/29/318529/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/1 \u0026\u0026 git checkout -b change-318529 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9ec0d2bf82b110d3417fa98cebb70537fda640a2","subject":"Fix issue in getOverlappingRedactionRanges.","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_providers_MediaProvider/commit/9ec0d2bf82b110d3417fa98cebb70537fda640a2"}]}],"author":{"name":"Sahana Rao","email":"sahanas@google.com","date":"2020-10-24 23:00:11.000000000","tz":60},"committer":{"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","date":"2021-11-02 20:46:07.000000000","tz":60},"subject":"Fix read range computation for some corner cases in redaction ranges","message":"Fix read range computation for some corner cases in redaction ranges\n\n1. Fixed read range computation for redaction range of zero size. For\nexample, a redaction range of [10, 10). There is nothing to redact here.\nSome images can have a redaction range like this.\n\nPreviously, computing read ranges for a redaction range like this would\nend up in an infinite while loop with getReadRanges() adding a read\nrange of [10, 0] to the vector in every iteration of while loop. Hence\nleading to high memory consumption, which results in MediaProvider\ncrashing because of lowmemorykiller.\n\nThis CL removes these redaction ranges of zero size from\nredaction_ranges_ vector.\n\n2. Fixed read range computation for redaction ranges where read offset\nor read_end overlaps with start or end of the redaction range.\n\nThese kind of reads will be very rare where app would read with offset\nthat matches exactly with redaction range start/end. But, when it\nhappens, we might end up in an infinite loop or read ranges with\nnegative values.\n\nChanged getReadRanges to compute read ranges by collecting sorted\nredaction ranges within the read range and finiding the right\nindex for read_start and read_end.\n\nAdded new tests to verify these corner cases in redaction ranges.\n\nBug: 170779687\nBug: 170357171\nTest: atest RedactionInfoTest\nChange-Id: I1e62c4b31083ec07e72df066b1bd985289f01783\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_providers_MediaProvider/commit/29fabfcd96e1c4a66a9fc7e5cd1e4f5f293b79cd"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_providers_MediaProvider/commit/29fabfcd96e1c4a66a9fc7e5cd1e4f5f293b79cd"}]},"branch":"refs/heads/lineage-18.1"},"c50c5facf24cd16145cc86003a68dd185311efe9":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-11-02 20:50:17.000000000","uploader":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/29/318529/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_providers_MediaProvider","ref":"refs/changes/29/318529/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/2 \u0026\u0026 git checkout -b change-318529 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_providers_MediaProvider refs/changes/29/318529/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f987004b905aee65b301ffeeb0d5dd71bd08bd07","subject":"Fix issue in getOverlappingRedactionRanges.","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_providers_MediaProvider/commit/f987004b905aee65b301ffeeb0d5dd71bd08bd07"}]}],"author":{"name":"Sahana Rao","email":"sahanas@google.com","date":"2020-10-24 23:00:11.000000000","tz":60},"committer":{"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","date":"2021-11-02 20:50:15.000000000","tz":60},"subject":"Fix read range computation for some corner cases in redaction ranges","message":"Fix read range computation for some corner cases in redaction ranges\n\n1. Fixed read range computation for redaction range of zero size. For\nexample, a redaction range of [10, 10). There is nothing to redact here.\nSome images can have a redaction range like this.\n\nPreviously, computing read ranges for a redaction range like this would\nend up in an infinite while loop with getReadRanges() adding a read\nrange of [10, 0] to the vector in every iteration of while loop. Hence\nleading to high memory consumption, which results in MediaProvider\ncrashing because of lowmemorykiller.\n\nThis CL removes these redaction ranges of zero size from\nredaction_ranges_ vector.\n\n2. Fixed read range computation for redaction ranges where read offset\nor read_end overlaps with start or end of the redaction range.\n\nThese kind of reads will be very rare where app would read with offset\nthat matches exactly with redaction range start/end. But, when it\nhappens, we might end up in an infinite loop or read ranges with\nnegative values.\n\nChanged getReadRanges to compute read ranges by collecting sorted\nredaction ranges within the read range and finiding the right\nindex for read_start and read_end.\n\nAdded new tests to verify these corner cases in redaction ranges.\n\nBug: 170779687\nBug: 170357171\nTest: atest RedactionInfoTest\nChange-Id: I1e62c4b31083ec07e72df066b1bd985289f01783\n(cherry picked from commit 8a1db67dac2e6169256be32234386d3319d8513a)\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_providers_MediaProvider/commit/c50c5facf24cd16145cc86003a68dd185311efe9"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_providers_MediaProvider/commit/c50c5facf24cd16145cc86003a68dd185311efe9"}]},"branch":"refs/heads/lineage-18.1"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":29353,"name":"Thomas Zell","email":"thomas.zell@gmail.com","username":"birefringence","avatars":[{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fa1927b81bd7c7c994f2ea4bae2f096e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}