)]}'
{"id":"LineageOS%2Fandroid_packages_modules_Permission~427562","triplet_id":"LineageOS%2Fandroid_packages_modules_Permission~lineage-20.0~I4146abff462ef4ed0e67efd04b4182bcf2c04d98","project":"LineageOS/android_packages_modules_Permission","branch":"lineage-20.0","topic":"T_asb_2025-04","hashtags":[],"change_id":"I4146abff462ef4ed0e67efd04b4182bcf2c04d98","subject":"Role re-evaluation should respect ask every time choice by user","status":"MERGED","created":"2025-04-16 21:49:11.000000000","updated":"2025-05-10 13:37:30.000000000","submitted":"2025-05-10 13:37:30.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"427562-T_asb_2025-04","meta_rev_id":"1ab986dd356a1a0009ad816a96d029f8c2f0e22f","_number":427562,"virtual_id_number":427562,"owner":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"aa5fff32eae1edb22c2671b243d19a89af1e493c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-04-16 21:49:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b926e10198ea52f8d21ed9edd84268a853171424","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-04-16 21:49:24.000000000","message":"Topic set to T_asb_2025-04","accounts_in_message":[],"_revision_number":1},{"id":"89c1f8ac26b951a6b1f6ece24bbb16d8d15e7251","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-04-18 17:42:09.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"1ab986dd356a1a0009ad816a96d029f8c2f0e22f","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-05-10 13:37:30.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"54fd3924b8333f2583f0e05115c21fdef5b2d7ae","revisions":{"bb5f7112d43754aeb331c7a912542c7e1ef852bc":{"kind":"REWORK","_number":1,"created":"2025-04-16 21:49:11.000000000","uploader":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/62/427562/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_modules_Permission","ref":"refs/changes/62/427562/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/1 \u0026\u0026 git checkout -b change-427562 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f861ce16689dcd1daa6aeae7ebc9afa1b5e86b71","subject":"Merge tag \u0027android-security-13.0.0_r24\u0027 into staging/lineage-20.0_android-security-13.0.0_r24","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Permission/commit/f861ce16689dcd1daa6aeae7ebc9afa1b5e86b71"}]}],"author":{"name":"Manjeet Rulhania","email":"mrulhania@google.com","date":"2024-10-30 20:18:46.000000000","tz":0},"committer":{"name":"mse1969","email":"mse1969@posteo.de","date":"2025-04-16 18:22:09.000000000","tz":120},"subject":"Role re-evaluation should respect ask every time choice by user","message":"Role re-evaluation should respect ask every time choice by user\n\nRole evalation respect USER_SET flag when the role is not\nsupposed to override user choices. Role granting logic\nis missing ONE_TIME check, ONE_TIME flag should be considered\na user choice.\n\nBug: 355411348\nTest: RolePermissionOverrideTest\nRelnote: security bug fix\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:71e09e5ad12d02b3129c7a5ce16f6de734fdd0da)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6687e8ebe51d3d180dd926e418ec0681a4a79b9b)\nMerged-In: I4146abff462ef4ed0e67efd04b4182bcf2c04d98\nChange-Id: I4146abff462ef4ed0e67efd04b4182bcf2c04d98\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Permission/commit/bb5f7112d43754aeb331c7a912542c7e1ef852bc"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Permission/commit/bb5f7112d43754aeb331c7a912542c7e1ef852bc"}]},"branch":"refs/heads/lineage-20.0"},"4e567ba1d545937bb8ef6438b791af6a5665ce08":{"kind":"NO_CHANGE","_number":2,"created":"2025-04-18 17:42:09.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/62/427562/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_modules_Permission","ref":"refs/changes/62/427562/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/2 \u0026\u0026 git checkout -b change-427562 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f861ce16689dcd1daa6aeae7ebc9afa1b5e86b71","subject":"Merge tag \u0027android-security-13.0.0_r24\u0027 into staging/lineage-20.0_android-security-13.0.0_r24","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Permission/commit/f861ce16689dcd1daa6aeae7ebc9afa1b5e86b71"}]}],"author":{"name":"Manjeet Rulhania","email":"mrulhania@google.com","date":"2024-10-30 20:18:46.000000000","tz":0},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2025-04-18 14:09:35.000000000","tz":-360},"subject":"Role re-evaluation should respect ask every time choice by user","message":"Role re-evaluation should respect ask every time choice by user\n\nRole evalation respect USER_SET flag when the role is not\nsupposed to override user choices. Role granting logic\nis missing ONE_TIME check, ONE_TIME flag should be considered\na user choice.\n\nBug: 355411348\nTest: RolePermissionOverrideTest\nRelnote: security bug fix\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:71e09e5ad12d02b3129c7a5ce16f6de734fdd0da)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6687e8ebe51d3d180dd926e418ec0681a4a79b9b)\nMerged-In: I4146abff462ef4ed0e67efd04b4182bcf2c04d98\nChange-Id: I4146abff462ef4ed0e67efd04b4182bcf2c04d98\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Permission/commit/4e567ba1d545937bb8ef6438b791af6a5665ce08"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Permission/commit/4e567ba1d545937bb8ef6438b791af6a5665ce08"}]},"branch":"refs/heads/lineage-20.0"},"54fd3924b8333f2583f0e05115c21fdef5b2d7ae":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-05-10 13:37:30.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/62/427562/3","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_modules_Permission","ref":"refs/changes/62/427562/3","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/3 \u0026\u0026 git checkout -b change-427562 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/3","Reset To":"git fetch https://github.com/LineageOS/android_packages_modules_Permission refs/changes/62/427562/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f42496fe04050fc84f36e729fd67658c37ea96e","subject":"Merge cherrypicks of [\u0027googleplex-android-review.googlesource.com/28791905\u0027] into security-aosp-tm-release.","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Permission/commit/7f42496fe04050fc84f36e729fd67658c37ea96e"}]}],"author":{"name":"Manjeet Rulhania","email":"mrulhania@google.com","date":"2024-10-30 20:18:46.000000000","tz":0},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2025-02-06 05:23:00.000000000","tz":-480},"subject":"Role re-evaluation should respect ask every time choice by user","message":"Role re-evaluation should respect ask every time choice by user\n\nRole evalation respect USER_SET flag when the role is not\nsupposed to override user choices. Role granting logic\nis missing ONE_TIME check, ONE_TIME flag should be considered\na user choice.\n\nBug: 355411348\nTest: RolePermissionOverrideTest\nRelnote: security bug fix\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:71e09e5ad12d02b3129c7a5ce16f6de734fdd0da)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6687e8ebe51d3d180dd926e418ec0681a4a79b9b)\nMerged-In: I4146abff462ef4ed0e67efd04b4182bcf2c04d98\nChange-Id: I4146abff462ef4ed0e67efd04b4182bcf2c04d98\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Permission/commit/54fd3924b8333f2583f0e05115c21fdef5b2d7ae"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Permission/commit/54fd3924b8333f2583f0e05115c21fdef5b2d7ae"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}