)]}'
{"id":"LineageOS%2Fandroid_packages_modules_Connectivity~432698","triplet_id":"LineageOS%2Fandroid_packages_modules_Connectivity~lineage-20.0~If71ce012f927a34c647d36b5eaf3723de2c01879","project":"LineageOS/android_packages_modules_Connectivity","branch":"lineage-20.0","topic":"T_asb_2025-06","hashtags":[],"change_id":"If71ce012f927a34c647d36b5eaf3723de2c01879","subject":"Add missing permission check to offerNetwork","status":"MERGED","created":"2025-06-08 12:47:03.000000000","updated":"2025-06-11 12:08:34.000000000","submitted":"2025-06-11 12:08:34.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"432698-T_asb_2025-06","meta_rev_id":"c717fb2da2b2e346983cb84eccd71700445a3c12","_number":432698,"virtual_id_number":432698,"owner":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"d1b9dc116e86cfc12b0b0913ebf970985307e34a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-06-08 12:47:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c717fb2da2b2e346983cb84eccd71700445a3c12","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-06-11 12:08:34.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b5c655f0f676381b1cf8d1e23eb75cacd964afd8","revisions":{"fdb75a3463e8b3f1889daa876992e6597d650125":{"kind":"REWORK","_number":1,"created":"2025-06-08 12:47:03.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/98/432698/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_modules_Connectivity","ref":"refs/changes/98/432698/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/1 \u0026\u0026 git checkout -b change-432698 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1fa42c03891ba203a321b597fb5709e3a9131f0e","subject":"Expose new isUidCurrentlyDisallowedByPolicy","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Connectivity/commit/1fa42c03891ba203a321b597fb5709e3a9131f0e"}]}],"author":{"name":"Patrick Rohr","email":"prohr@google.com","date":"2024-12-20 17:52:33.000000000","tz":-480},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2025-06-08 11:57:14.000000000","tz":-360},"subject":"Add missing permission check to offerNetwork","message":"Add missing permission check to offerNetwork\n\nThe missing permission check means that an unauthorized app could\nhave registered a network offer to intercept all NetworkRequests (by\ntrivially guessing an existing provider ID) which would have leaked\ninformation about other apps on the system.\n\nThis adds a NETWORK_FACTORY or MAINLINE_NETWORK_STACK permission check\nto offerNetwork per the API annotations in ConnectivityManager.\nTest networks can be offered when holding the MANAGE_TEST_NETWORKS\npermission which is consistent with similar APIs in this class.\n\nThere can be no legitimate use of this API a) offerNetwork is @hide\nand only exposed via NetworkProvider, and b) it requires getting a\nprovider ID by calling registerNetworkProvider which correctly enforces\npermissions.\n\nunofferNetwork does not currently require any permissions. Again, this\nis consistent with the API annotations in ConnectivityManager.\n\nTest: TH\n(cherry picked from https://android-review.googlesource.com/q/commit:ff65257bd07c791a5bfef2f54bf96ae224c03273)\nBug: 388828859\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1917a04ae0ebf221232f9f3bf80fe329a01c6ed2)\nMerged-In: If71ce012f927a34c647d36b5eaf3723de2c01879\nChange-Id: If71ce012f927a34c647d36b5eaf3723de2c01879\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Connectivity/commit/fdb75a3463e8b3f1889daa876992e6597d650125"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Connectivity/commit/fdb75a3463e8b3f1889daa876992e6597d650125"}]},"branch":"refs/heads/lineage-20.0"},"b5c655f0f676381b1cf8d1e23eb75cacd964afd8":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-06-11 12:08:34.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/98/432698/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_modules_Connectivity","ref":"refs/changes/98/432698/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/2 \u0026\u0026 git checkout -b change-432698 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_modules_Connectivity refs/changes/98/432698/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2193ab0467322ad22725e13ef375269f0921e3aa","subject":"Merge cherrypicks of [\u0027ag/19706348\u0027] into security-aosp-tm-release.","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Connectivity/commit/2193ab0467322ad22725e13ef375269f0921e3aa"}]}],"author":{"name":"Patrick Rohr","email":"prohr@google.com","date":"2024-12-20 17:52:33.000000000","tz":-480},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2025-04-09 22:18:39.000000000","tz":-420},"subject":"Add missing permission check to offerNetwork","message":"Add missing permission check to offerNetwork\n\nThe missing permission check means that an unauthorized app could\nhave registered a network offer to intercept all NetworkRequests (by\ntrivially guessing an existing provider ID) which would have leaked\ninformation about other apps on the system.\n\nThis adds a NETWORK_FACTORY or MAINLINE_NETWORK_STACK permission check\nto offerNetwork per the API annotations in ConnectivityManager.\nTest networks can be offered when holding the MANAGE_TEST_NETWORKS\npermission which is consistent with similar APIs in this class.\n\nThere can be no legitimate use of this API a) offerNetwork is @hide\nand only exposed via NetworkProvider, and b) it requires getting a\nprovider ID by calling registerNetworkProvider which correctly enforces\npermissions.\n\nunofferNetwork does not currently require any permissions. Again, this\nis consistent with the API annotations in ConnectivityManager.\n\nTest: TH\n(cherry picked from https://android-review.googlesource.com/q/commit:ff65257bd07c791a5bfef2f54bf96ae224c03273)\nBug: 388828859\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1917a04ae0ebf221232f9f3bf80fe329a01c6ed2)\nMerged-In: If71ce012f927a34c647d36b5eaf3723de2c01879\nChange-Id: If71ce012f927a34c647d36b5eaf3723de2c01879\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Connectivity/commit/b5c655f0f676381b1cf8d1e23eb75cacd964afd8"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_Connectivity/commit/b5c655f0f676381b1cf8d1e23eb75cacd964afd8"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}