)]}'
{"id":"LineageOS%2Fandroid_packages_modules_CaptivePortalLogin~289412","triplet_id":"LineageOS%2Fandroid_packages_modules_CaptivePortalLogin~lineage-18.1~I9f2e520227446ff0fc54a9caec7c3a54f6ba5a9d","project":"LineageOS/android_packages_modules_CaptivePortalLogin","branch":"lineage-18.1","hashtags":[],"change_id":"I9f2e520227446ff0fc54a9caec7c3a54f6ba5a9d","subject":"Fix captive portal downloads on private DNS","status":"MERGED","created":"2020-10-10 23:32:42.000000000","updated":"2021-11-04 17:20:38.000000000","submitted":"2021-11-04 17:20:38.000000000","submitter":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"289414","meta_rev_id":"f50e2cf10b36ac497d4dec881568bc9799aa68a8","_number":289412,"virtual_id_number":289412,"owner":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-04 17:20:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-04 17:20:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-04 17:20:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-19 18:02:43.000000000","updated_by":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"39bed8e3878c86aa760d3a9885ea8e8381e55520","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-10 23:32:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2a84e478c6cd537263684a4f7ede41e6d6d441b3","tag":"autogenerated:gerrit:move","author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-12-15 23:06:28.000000000","message":"Change destination moved from lineage-18.0 to lineage-18.1","accounts_in_message":[],"_revision_number":1},{"id":"425acd91c84b7309e41d461b08f1d762d9575203","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-12-15 23:06:49.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"823382bd02e2dc805cb7ee6e6ed4a8aef4135f19","author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-18 12:10:26.000000000","message":"Patch Set 2: Verified+1 Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"43d39a281042bdd038719fdf6b7d70e680edf2c9","author":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-19 18:02:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"f50e2cf10b36ac497d4dec881568bc9799aa68a8","tag":"autogenerated:gerrit:merged","author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-11-04 17:20:38.000000000","message":"Change has been successfully rebased and submitted as c5ee9d169290dda74bbb069ae748aac4fe2d20f6 by Michael Bestas","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c5ee9d169290dda74bbb069ae748aac4fe2d20f6","revisions":{"0cac586b76228726d15864d273db2a0cb11562cc":{"kind":"REWORK","_number":1,"created":"2020-10-10 23:32:42.000000000","uploader":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/12/289412/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin","ref":"refs/changes/12/289412/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/1 \u0026\u0026 git checkout -b change-289412 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc8c7b2c9f3d013d40434416f7f3c178e2a6deec","subject":"Move min/target_sdk_version to java_defaults","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin/commit/bc8c7b2c9f3d013d40434416f7f3c178e2a6deec"}]}],"author":{"name":"Remi NGUYEN VAN","email":"reminv@google.com","date":"2020-07-28 06:45:04.000000000","tz":540},"committer":{"name":"Michael Bestas","email":"mkbestas@lineageos.org","date":"2020-10-08 21:16:26.000000000","tz":180},"subject":"Fix captive portal downloads on private DNS","message":"Fix captive portal downloads on private DNS\n\nWhen private DNS is in strict mode, captive portal downloads would fail\nbecause DownloadService did not use a copy of Network that bypasses\nprivate DNS.\nThe network obtained by DownloadService is a copy of the private DNS\nbypassing network sent by CaptivePortalLoginActivity, but because the\nprivateDnsBypass attribute is not kept during parceling, default DNS\nsettings would be used.\n\nHave DownloadService call getPrivateDnsBypassingCopy to avoid the failed\ndownloads.\n\nBug: 161875845\nTest: atest DownloadServiceTest; manual: download a file with private\n          DNS set to strict from the portal app.\nChange-Id: I9f2e520227446ff0fc54a9caec7c3a54f6ba5a9d\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin/commit/0cac586b76228726d15864d273db2a0cb11562cc"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin/commit/0cac586b76228726d15864d273db2a0cb11562cc"}]},"branch":"refs/heads/lineage-18.1"},"09ccf33175227630cc8e416eed6eede3d0155e4a":{"kind":"NO_CHANGE","_number":2,"created":"2020-12-15 23:06:49.000000000","uploader":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/12/289412/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin","ref":"refs/changes/12/289412/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/2 \u0026\u0026 git checkout -b change-289412 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"47f332196196f3a3490ab79c3435a41156605870","subject":"Move min/target_sdk_version to java_defaults","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin/commit/47f332196196f3a3490ab79c3435a41156605870"}]}],"author":{"name":"Remi NGUYEN VAN","email":"reminv@google.com","date":"2020-07-28 06:45:04.000000000","tz":540},"committer":{"name":"Michael Bestas","email":"mkbestas@lineageos.org","date":"2020-12-15 23:06:49.000000000","tz":60},"subject":"Fix captive portal downloads on private DNS","message":"Fix captive portal downloads on private DNS\n\nWhen private DNS is in strict mode, captive portal downloads would fail\nbecause DownloadService did not use a copy of Network that bypasses\nprivate DNS.\nThe network obtained by DownloadService is a copy of the private DNS\nbypassing network sent by CaptivePortalLoginActivity, but because the\nprivateDnsBypass attribute is not kept during parceling, default DNS\nsettings would be used.\n\nHave DownloadService call getPrivateDnsBypassingCopy to avoid the failed\ndownloads.\n\nBug: 161875845\nTest: atest DownloadServiceTest; manual: download a file with private\n          DNS set to strict from the portal app.\nChange-Id: I9f2e520227446ff0fc54a9caec7c3a54f6ba5a9d\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin/commit/09ccf33175227630cc8e416eed6eede3d0155e4a"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin/commit/09ccf33175227630cc8e416eed6eede3d0155e4a"}]},"branch":"refs/heads/lineage-18.1","description":"Rebase"},"c5ee9d169290dda74bbb069ae748aac4fe2d20f6":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-11-04 17:20:38.000000000","uploader":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/12/289412/3","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin","ref":"refs/changes/12/289412/3","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/3 \u0026\u0026 git checkout -b change-289412 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/3","Reset To":"git fetch https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin refs/changes/12/289412/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2044e609a3f34effa30508077e3d70263c3315b3","subject":"Move min/target_sdk_version to java_defaults","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin/commit/2044e609a3f34effa30508077e3d70263c3315b3"}]}],"author":{"name":"Remi NGUYEN VAN","email":"reminv@google.com","date":"2020-07-28 06:45:04.000000000","tz":540},"committer":{"name":"Michael Bestas","email":"mkbestas@lineageos.org","date":"2021-11-04 17:20:38.000000000","tz":60},"subject":"Fix captive portal downloads on private DNS","message":"Fix captive portal downloads on private DNS\n\nWhen private DNS is in strict mode, captive portal downloads would fail\nbecause DownloadService did not use a copy of Network that bypasses\nprivate DNS.\nThe network obtained by DownloadService is a copy of the private DNS\nbypassing network sent by CaptivePortalLoginActivity, but because the\nprivateDnsBypass attribute is not kept during parceling, default DNS\nsettings would be used.\n\nHave DownloadService call getPrivateDnsBypassingCopy to avoid the failed\ndownloads.\n\nBug: 161875845\nTest: atest DownloadServiceTest; manual: download a file with private\n          DNS set to strict from the portal app.\nChange-Id: I9f2e520227446ff0fc54a9caec7c3a54f6ba5a9d\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin/commit/c5ee9d169290dda74bbb069ae748aac4fe2d20f6"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_modules_CaptivePortalLogin/commit/c5ee9d169290dda74bbb069ae748aac4fe2d20f6"}]},"branch":"refs/heads/lineage-18.1","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}