)]}'
{"id":"LineageOS%2Fandroid_packages_apps_Trebuchet~366321","triplet_id":"LineageOS%2Fandroid_packages_apps_Trebuchet~lineage-20.0~If35344c08975e35085c7c2b9b814a3c457a144b0","project":"LineageOS/android_packages_apps_Trebuchet","branch":"lineage-20.0","topic":"T_asb_2023-09","hashtags":[],"change_id":"If35344c08975e35085c7c2b9b814a3c457a144b0","subject":"Fix permission issue in legacy shortcut","status":"MERGED","created":"2023-09-16 16:53:24.000000000","updated":"2023-09-18 13:51:16.000000000","submitted":"2023-09-18 13:51:16.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"366321-T_asb_2023-09","meta_rev_id":"21cd4424a6ea50c6e995c4792e6480ac47c37b25","_number":366321,"virtual_id_number":366321,"owner":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"a81e0c515e9313efaa93fcd2bea047fae8bccc86","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-16 16:53:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"21cd4424a6ea50c6e995c4792e6480ac47c37b25","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-18 13:51:16.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"09f8b0e52e45a0b39bab457534ba2e5ae91ffad0","revisions":{"6dc89916d76b04d8a23a6c35fbe797f380f64811":{"kind":"REWORK","_number":1,"created":"2023-09-16 16:53:24.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/21/366321/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_Trebuchet","ref":"refs/changes/21/366321/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/1 \u0026\u0026 git checkout -b change-366321 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f71ed2a4546cff1642cd12135b1f2ef15b3fbb46","subject":"Merge tag \u0027android-13.0.0_r71\u0027 of https://android.googlesource.com/platform/packages/apps/Launcher3 into staging/lineage-20.0_merge-android-13.0.0_r67","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Trebuchet/commit/f71ed2a4546cff1642cd12135b1f2ef15b3fbb46"}]}],"author":{"name":"Pinyao Ting","email":"pinyaoting@google.com","date":"2023-06-02 01:12:44.000000000","tz":-420},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2023-09-16 14:36:42.000000000","tz":-360},"subject":"Fix permission issue in legacy shortcut","message":"Fix permission issue in legacy shortcut\n\nWhen building legacy shortcut, Launcher calls\nPackageManager#resolveActivity to retrieve necessary permission to\nlaunch the intent.\n\nHowever, when the source app wraps an arbitrary intent within\nIntent#createChooser, the existing logic will fail because launching\nChooser doesn\u0027t require additional permission.\n\nThis CL fixes the security vulnerability by performing the permission\ncheck against the intent that is wrapped within.\n\nBug: 270152142\nTest: manual\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c53818a16b4322a823497726ac7e7a44501b4442)\nMerged-In: If35344c08975e35085c7c2b9b814a3c457a144b0\nChange-Id: If35344c08975e35085c7c2b9b814a3c457a144b0\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Trebuchet/commit/6dc89916d76b04d8a23a6c35fbe797f380f64811"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Trebuchet/commit/6dc89916d76b04d8a23a6c35fbe797f380f64811"}]},"branch":"refs/heads/lineage-20.0"},"09f8b0e52e45a0b39bab457534ba2e5ae91ffad0":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-09-18 13:51:16.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/21/366321/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_Trebuchet","ref":"refs/changes/21/366321/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/2 \u0026\u0026 git checkout -b change-366321 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_Trebuchet refs/changes/21/366321/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4d098abb45aa38004cc5057b6dc382a148b56f01","subject":"Merge cherrypicks of [\u0027googleplex-android-review.googlesource.com/21050546\u0027] into security-aosp-tm-release.","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Trebuchet/commit/4d098abb45aa38004cc5057b6dc382a148b56f01"}]}],"author":{"name":"Pinyao Ting","email":"pinyaoting@google.com","date":"2023-06-02 01:12:44.000000000","tz":-420},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2023-07-14 17:31:09.000000000","tz":0},"subject":"Fix permission issue in legacy shortcut","message":"Fix permission issue in legacy shortcut\n\nWhen building legacy shortcut, Launcher calls\nPackageManager#resolveActivity to retrieve necessary permission to\nlaunch the intent.\n\nHowever, when the source app wraps an arbitrary intent within\nIntent#createChooser, the existing logic will fail because launching\nChooser doesn\u0027t require additional permission.\n\nThis CL fixes the security vulnerability by performing the permission\ncheck against the intent that is wrapped within.\n\nBug: 270152142\nTest: manual\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c53818a16b4322a823497726ac7e7a44501b4442)\nMerged-In: If35344c08975e35085c7c2b9b814a3c457a144b0\nChange-Id: If35344c08975e35085c7c2b9b814a3c457a144b0\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Trebuchet/commit/09f8b0e52e45a0b39bab457534ba2e5ae91ffad0"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Trebuchet/commit/09f8b0e52e45a0b39bab457534ba2e5ae91ffad0"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}