)]}'
{"id":"LineageOS%2Fandroid_packages_apps_Settings~427559","triplet_id":"LineageOS%2Fandroid_packages_apps_Settings~lineage-20.0~I539fca77a1d136bdd0e4892993020884430b8a4e","project":"LineageOS/android_packages_apps_Settings","branch":"lineage-20.0","topic":"T_asb_2025-04","hashtags":[],"change_id":"I539fca77a1d136bdd0e4892993020884430b8a4e","subject":"Remove incorrect call to Window.addFlags with a system flag","status":"MERGED","created":"2025-04-16 21:45:54.000000000","updated":"2025-05-10 13:36:27.000000000","submitted":"2025-05-10 13:36:27.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"427556-T_asb_2025-04","meta_rev_id":"49458468c325a80662364bbbec46343ee4f886e6","_number":427559,"virtual_id_number":427559,"owner":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"482ce49009437f0d59a2022ad839594079a25de4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-04-16 21:45:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"63e534d6751c8b8246e8ae2ea0f250b4e2fe6a99","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-04-16 21:46:45.000000000","message":"Topic set to T_asb_2025-04","accounts_in_message":[],"_revision_number":1},{"id":"990e5cc0744a403b8274f9cb4aca42ce4ff84cdb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-04-18 17:40:45.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"49458468c325a80662364bbbec46343ee4f886e6","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-05-10 13:36:27.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"3d7c35753eb328f1423bac43f0c7fe59fd3766d9","revisions":{"9d72df730497889d623ddf75ce165751258807d9":{"kind":"REWORK","_number":1,"created":"2025-04-16 21:45:54.000000000","uploader":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/59/427559/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_Settings","ref":"refs/changes/59/427559/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/1 \u0026\u0026 git checkout -b change-427559 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"af15dbbd7c082aef28d7f1a1eac310f8ed6765e9","subject":"Check the permission of the callingUid instead of the calling package","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/af15dbbd7c082aef28d7f1a1eac310f8ed6765e9"}]}],"author":{"name":"Matías Hernández","email":"matiashe@google.com","date":"2025-01-03 12:38:10.000000000","tz":60},"committer":{"name":"mse1969","email":"mse1969@posteo.de","date":"2025-04-16 18:16:28.000000000","tz":120},"subject":"Remove incorrect call to Window.addFlags with a system flag","message":"Remove incorrect call to Window.addFlags with a system flag\n\nThe same flag is being (correctly) added in onCreate, so on top of being wrong this was also completely unnecessary.\n\nBug: 368579654\nTest: manual\nFlag: EXEMPT bugfix\n\n(cherry picked from commit e0510a62eba04140e459cdd8232f35087aa3073b)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4f4d00f42271df5a2727cac373412dd0114076cf)\nMerged-In: I539fca77a1d136bdd0e4892993020884430b8a4e\nChange-Id: I539fca77a1d136bdd0e4892993020884430b8a4e\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/9d72df730497889d623ddf75ce165751258807d9"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/9d72df730497889d623ddf75ce165751258807d9"}]},"branch":"refs/heads/lineage-20.0"},"1d097c11509e4a13d5c581e07bd4be2e4a7e8936":{"kind":"NO_CHANGE","_number":2,"created":"2025-04-18 17:40:45.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/59/427559/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_Settings","ref":"refs/changes/59/427559/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/2 \u0026\u0026 git checkout -b change-427559 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a8697c1bec73c8ca8ecb188adae2055ee5c21bec","subject":"Check the permission of the callingUid instead of the calling package","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/a8697c1bec73c8ca8ecb188adae2055ee5c21bec"}]}],"author":{"name":"Matías Hernández","email":"matiashe@google.com","date":"2025-01-03 12:38:10.000000000","tz":60},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2025-04-18 14:07:45.000000000","tz":-360},"subject":"Remove incorrect call to Window.addFlags with a system flag","message":"Remove incorrect call to Window.addFlags with a system flag\n\nThe same flag is being (correctly) added in onCreate, so on top of being wrong this was also completely unnecessary.\n\nBug: 368579654\nTest: manual\nFlag: EXEMPT bugfix\n\n(cherry picked from commit e0510a62eba04140e459cdd8232f35087aa3073b)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4f4d00f42271df5a2727cac373412dd0114076cf)\nMerged-In: I539fca77a1d136bdd0e4892993020884430b8a4e\nChange-Id: I539fca77a1d136bdd0e4892993020884430b8a4e\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/1d097c11509e4a13d5c581e07bd4be2e4a7e8936"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/1d097c11509e4a13d5c581e07bd4be2e4a7e8936"}]},"branch":"refs/heads/lineage-20.0"},"3d7c35753eb328f1423bac43f0c7fe59fd3766d9":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-05-10 13:36:27.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/59/427559/3","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_Settings","ref":"refs/changes/59/427559/3","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/3 \u0026\u0026 git checkout -b change-427559 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/3","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/59/427559/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"07de5a14c05e8d5a28bbcd705aeee2296b46e030","subject":"Check the permission of the callingUid instead of the calling package","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/07de5a14c05e8d5a28bbcd705aeee2296b46e030"}]}],"author":{"name":"Matías Hernández","email":"matiashe@google.com","date":"2025-01-03 12:38:10.000000000","tz":60},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2025-02-06 05:22:25.000000000","tz":-480},"subject":"Remove incorrect call to Window.addFlags with a system flag","message":"Remove incorrect call to Window.addFlags with a system flag\n\nThe same flag is being (correctly) added in onCreate, so on top of being wrong this was also completely unnecessary.\n\nBug: 368579654\nTest: manual\nFlag: EXEMPT bugfix\n\n(cherry picked from commit e0510a62eba04140e459cdd8232f35087aa3073b)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4f4d00f42271df5a2727cac373412dd0114076cf)\nMerged-In: I539fca77a1d136bdd0e4892993020884430b8a4e\nChange-Id: I539fca77a1d136bdd0e4892993020884430b8a4e\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/3d7c35753eb328f1423bac43f0c7fe59fd3766d9"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/3d7c35753eb328f1423bac43f0c7fe59fd3766d9"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}