)]}'
{"id":"LineageOS%2Fandroid_packages_apps_Settings~366320","triplet_id":"LineageOS%2Fandroid_packages_apps_Settings~lineage-20.0~I6470d1684d707f4b1e86f8b456be0b4e0af5f188","project":"LineageOS/android_packages_apps_Settings","branch":"lineage-20.0","topic":"T_asb_2023-09","hashtags":[],"change_id":"I6470d1684d707f4b1e86f8b456be0b4e0af5f188","subject":"DO NOT MERGE: Prevent non-system IME from becoming device admin","status":"MERGED","created":"2023-09-16 16:53:00.000000000","updated":"2023-09-18 13:50:55.000000000","submitted":"2023-09-18 13:50:55.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"366318-T_asb_2023-09","meta_rev_id":"9146925ee5e9e3ebfb1d6f447de80549833526c8","_number":366320,"virtual_id_number":366320,"owner":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"24b3e3503a070ec0fcc3b4b711bed3d24e11e83a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-16 16:53:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9146925ee5e9e3ebfb1d6f447de80549833526c8","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-18 13:50:55.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"846180c19f68f6fb1b0653356401d3235fef846e","revisions":{"dcb5a821c48a957fcb6cc1eb0d053097807fa59a":{"kind":"REWORK","_number":1,"created":"2023-09-16 16:53:00.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/20/366320/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_Settings","ref":"refs/changes/20/366320/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/1 \u0026\u0026 git checkout -b change-366320 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3544f354f209b1cb9e19bffafb763556684f14e6","subject":"Settings: don\u0027t try to allow NLSes with too-long component names","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/3544f354f209b1cb9e19bffafb763556684f14e6"}]}],"author":{"name":"Taran Singh","email":"tarandeep@google.com","date":"2023-05-19 23:17:47.000000000","tz":0},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2023-09-16 14:39:33.000000000","tz":-360},"subject":"DO NOT MERGE: Prevent non-system IME from becoming device admin","message":"DO NOT MERGE: Prevent non-system IME from becoming device admin\n\nCurrently selected IME can inject KeyEvent on DeviceAdminAdd screen to\nactivate itself as device admin and cause various DoS attacks.\n\nThis CL ensures KeyEvent on \"Activate\" button can only come from system\napps.\n\nBug: 280793427\nTest: atest DeviceAdminActivationTest\n(cherry picked from commit 70a501d02e0a6aefd874767a15378ba998759373)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0976cd789d3bfb593e73237b5b0adc39933a1c1c)\nMerged-In: I6470d1684d707f4b1e86f8b456be0b4e0af5f188\nChange-Id: I6470d1684d707f4b1e86f8b456be0b4e0af5f188\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/dcb5a821c48a957fcb6cc1eb0d053097807fa59a"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/dcb5a821c48a957fcb6cc1eb0d053097807fa59a"}]},"branch":"refs/heads/lineage-20.0"},"846180c19f68f6fb1b0653356401d3235fef846e":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-09-18 13:50:55.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/20/366320/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_Settings","ref":"refs/changes/20/366320/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/2 \u0026\u0026 git checkout -b change-366320 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/20/366320/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f56b3ca6c6edb8815c2d2859db1a43cd7dfa819","subject":"Settings: don\u0027t try to allow NLSes with too-long component names","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/7f56b3ca6c6edb8815c2d2859db1a43cd7dfa819"}]}],"author":{"name":"Taran Singh","email":"tarandeep@google.com","date":"2023-05-19 23:17:47.000000000","tz":0},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2023-07-14 17:31:38.000000000","tz":0},"subject":"DO NOT MERGE: Prevent non-system IME from becoming device admin","message":"DO NOT MERGE: Prevent non-system IME from becoming device admin\n\nCurrently selected IME can inject KeyEvent on DeviceAdminAdd screen to\nactivate itself as device admin and cause various DoS attacks.\n\nThis CL ensures KeyEvent on \"Activate\" button can only come from system\napps.\n\nBug: 280793427\nTest: atest DeviceAdminActivationTest\n(cherry picked from commit 70a501d02e0a6aefd874767a15378ba998759373)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0976cd789d3bfb593e73237b5b0adc39933a1c1c)\nMerged-In: I6470d1684d707f4b1e86f8b456be0b4e0af5f188\nChange-Id: I6470d1684d707f4b1e86f8b456be0b4e0af5f188\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/846180c19f68f6fb1b0653356401d3235fef846e"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/846180c19f68f6fb1b0653356401d3235fef846e"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}