)]}'
{"id":"LineageOS%2Fandroid_packages_apps_Settings~366319","triplet_id":"LineageOS%2Fandroid_packages_apps_Settings~lineage-20.0~Ifc048311746c027e3683cdcf65f1079d04cf7c56","project":"LineageOS/android_packages_apps_Settings","branch":"lineage-20.0","topic":"T_asb_2023-09","hashtags":[],"change_id":"Ifc048311746c027e3683cdcf65f1079d04cf7c56","subject":"Settings: don\u0027t try to allow NLSes with too-long component names","status":"MERGED","created":"2023-09-16 16:53:00.000000000","updated":"2023-09-18 13:50:55.000000000","submitted":"2023-09-18 13:50:55.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"366318-T_asb_2023-09","meta_rev_id":"80ba5584547ed6f5b4dd1ce768d37b10f40ddb68","_number":366319,"virtual_id_number":366319,"owner":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"62ed1774d62202b25fd285bc8beb51a272466ebb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-16 16:53:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"80ba5584547ed6f5b4dd1ce768d37b10f40ddb68","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-18 13:50:55.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7f56b3ca6c6edb8815c2d2859db1a43cd7dfa819","revisions":{"3544f354f209b1cb9e19bffafb763556684f14e6":{"kind":"REWORK","_number":1,"created":"2023-09-16 16:53:00.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/19/366319/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_Settings","ref":"refs/changes/19/366319/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/1 \u0026\u0026 git checkout -b change-366319 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2edb2857baf2d746acd50d8b9a1a1f2840f92fe4","subject":"Don\u0027t hide approved NLSes in Settings","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/2edb2857baf2d746acd50d8b9a1a1f2840f92fe4"}]}],"author":{"name":"Matías Hernández","email":"matiashe@google.com","date":"2023-06-15 16:37:52.000000000","tz":120},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2023-09-16 14:39:32.000000000","tz":-360},"subject":"Settings: don\u0027t try to allow NLSes with too-long component names","message":"Settings: don\u0027t try to allow NLSes with too-long component names\n\n* NotificationAccessConfirmationActivity (triggered through CompanionDeviceManager) -\u003e Don\u0027t show the dialog, bail out early similarly to other invalid inputs.\n* NotificationAccessSettings (from Special App Access) -\u003e No changes, but use the canonical constant now.\n* ApprovalPreferenceController (used in NotificationAccessDetails) -\u003e Disable the toggle, unless the NLS was previously approved (in which case it can still be removed).\n\nFixes: 260570119\nFixes: 286043036\nTest: atest + manually\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b88fbf932a1631792a422f8ac34e83e1d6ae74d7)\nMerged-In: Ifc048311746c027e3683cdcf65f1079d04cf7c56\nChange-Id: Ifc048311746c027e3683cdcf65f1079d04cf7c56\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/3544f354f209b1cb9e19bffafb763556684f14e6"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/3544f354f209b1cb9e19bffafb763556684f14e6"}]},"branch":"refs/heads/lineage-20.0"},"7f56b3ca6c6edb8815c2d2859db1a43cd7dfa819":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-09-18 13:50:55.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/19/366319/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_Settings","ref":"refs/changes/19/366319/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/2 \u0026\u0026 git checkout -b change-366319 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_Settings refs/changes/19/366319/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d8355ac47e068ad20c6a7b1602e72f0585ec0085","subject":"Don\u0027t hide approved NLSes in Settings","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/d8355ac47e068ad20c6a7b1602e72f0585ec0085"}]}],"author":{"name":"Matías Hernández","email":"matiashe@google.com","date":"2023-06-15 16:37:52.000000000","tz":120},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2023-07-14 17:31:31.000000000","tz":0},"subject":"Settings: don\u0027t try to allow NLSes with too-long component names","message":"Settings: don\u0027t try to allow NLSes with too-long component names\n\n* NotificationAccessConfirmationActivity (triggered through CompanionDeviceManager) -\u003e Don\u0027t show the dialog, bail out early similarly to other invalid inputs.\n* NotificationAccessSettings (from Special App Access) -\u003e No changes, but use the canonical constant now.\n* ApprovalPreferenceController (used in NotificationAccessDetails) -\u003e Disable the toggle, unless the NLS was previously approved (in which case it can still be removed).\n\nFixes: 260570119\nFixes: 286043036\nTest: atest + manually\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b88fbf932a1631792a422f8ac34e83e1d6ae74d7)\nMerged-In: Ifc048311746c027e3683cdcf65f1079d04cf7c56\nChange-Id: Ifc048311746c027e3683cdcf65f1079d04cf7c56\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/7f56b3ca6c6edb8815c2d2859db1a43cd7dfa819"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Settings/commit/7f56b3ca6c6edb8815c2d2859db1a43cd7dfa819"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}