)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aab530ed134267cc7d00f70c27dd81ec4616a222","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     bharathraju2298 \u003cbharathraju049@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-08 19:59:50 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dialer: Add autorecord feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"forwarport to P"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"89da262a_5a6f7dab","line":7,"updated":"2019-08-13 00:10:50.000000000","message":"Please provide a bit more detail in the commit message body.","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e7870c4f498a365b069a03b9fd898fc5274e3a1d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     bharathraju2298 \u003cbharathraju049@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-08 19:59:50 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dialer: Add autorecord feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"forwarport to P"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5101a02e_01f2982a","line":7,"in_reply_to":"89da262a_5a6f7dab","updated":"2019-08-21 13:56:55.000000000","message":"Done","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"}],"java/com/android/dialer/app/res/values/cm_strings.xml":[{"author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aab530ed134267cc7d00f70c27dd81ec4616a222","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    \u003cstring name\u003d\"call_recording_format\"\u003eAudio format\u003c/string\u003e"},{"line_number":39,"context_line":"    \u003cstring name\u003d\"wb_amr_format\" translatable\u003d\"false\"\u003eAMR-WB\u003c/string\u003e"},{"line_number":40,"context_line":"    \u003cstring name\u003d\"aac_format\" translatable\u003d\"false\"\u003eAAC\u003c/string\u003e"},{"line_number":41,"context_line":"    \u003cstring name\u003d\"auto_call_recording_title\"\u003eAuto call recording\u003c/string\u003e"},{"line_number":42,"context_line":"    \u003cstring name\u003d\"auto_call_recording_key\" translatable\u003d\"false\"\u003eauto_call_recording\u003c/string\u003e"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \u003cstring name\u003d\"call_via\"\u003eCall via\u003c/string\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"643f4efd_f965b86c","line":41,"updated":"2019-08-13 00:10:50.000000000","message":"I\u0027m not sure the wording is as clear as it could be.  How about simply: \"Record all calls\"","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e7870c4f498a365b069a03b9fd898fc5274e3a1d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u003cstring name\u003d\"call_recording_format\"\u003eAudio format\u003c/string\u003e"},{"line_number":39,"context_line":"    \u003cstring name\u003d\"wb_amr_format\" translatable\u003d\"false\"\u003eAMR-WB\u003c/string\u003e"},{"line_number":40,"context_line":"    \u003cstring name\u003d\"aac_format\" translatable\u003d\"false\"\u003eAAC\u003c/string\u003e"},{"line_number":41,"context_line":"    \u003cstring name\u003d\"auto_call_recording_title\"\u003eAuto call recording\u003c/string\u003e"},{"line_number":42,"context_line":"    \u003cstring name\u003d\"auto_call_recording_key\" translatable\u003d\"false\"\u003eauto_call_recording\u003c/string\u003e"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \u003cstring name\u003d\"call_via\"\u003eCall via\u003c/string\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"e3ab3983_78a55ff7","line":41,"in_reply_to":"643f4efd_f965b86c","updated":"2019-08-21 13:56:55.000000000","message":"Done","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"59b94d338e7ae1b8a0c534eef3770a53e1aee10c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    \u003cstring name\u003d\"wb_amr_format\" translatable\u003d\"false\"\u003eAMR-WB\u003c/string\u003e"},{"line_number":40,"context_line":"    \u003cstring name\u003d\"aac_format\" translatable\u003d\"false\"\u003eAAC\u003c/string\u003e"},{"line_number":41,"context_line":"    \u003cstring name\u003d\"auto_call_recording_title\"\u003eAuto call recording\u003c/string\u003e"},{"line_number":42,"context_line":"    \u003cstring name\u003d\"auto_call_recording_key\" translatable\u003d\"false\"\u003eauto_call_recording\u003c/string\u003e"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \u003cstring name\u003d\"call_via\"\u003eCall via\u003c/string\u003e"},{"line_number":45,"context_line":"    \u003cstring name\u003d\"call_via_dialog_title\"\u003eCall via\\u2026\u003c/string\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"db1b58de_9342e60b","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":92},"updated":"2019-08-12 22:08:06.000000000","message":"make the key a constant in CallButtonPresenter.java after \"KEY_RECORDING_WARNING_PRESENTED\"","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"}],"java/com/android/incallui/CallButtonPresenter.java":[{"author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aab530ed134267cc7d00f70c27dd81ec4616a222","unresolved":true,"context_lines":[{"line_number":22,"context_line":"import android.content.pm.PackageManager;"},{"line_number":23,"context_line":"import android.os.Bundle;"},{"line_number":24,"context_line":"import android.os.Trace;"},{"line_number":25,"context_line":"import android.os.Handler;"},{"line_number":26,"context_line":"import android.preference.PreferenceManager;"},{"line_number":27,"context_line":"import android.support.v4.app.Fragment;"},{"line_number":28,"context_line":"import android.support.v4.os.UserManagerCompat;"}],"source_content_type":"text/x-java","patch_set":1,"id":"f8051319_0c9bce90","line":25,"updated":"2019-08-13 00:10:50.000000000","message":"Should be between Bundle and Trace","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e7870c4f498a365b069a03b9fd898fc5274e3a1d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import android.content.pm.PackageManager;"},{"line_number":23,"context_line":"import android.os.Bundle;"},{"line_number":24,"context_line":"import android.os.Trace;"},{"line_number":25,"context_line":"import android.os.Handler;"},{"line_number":26,"context_line":"import android.preference.PreferenceManager;"},{"line_number":27,"context_line":"import android.support.v4.app.Fragment;"},{"line_number":28,"context_line":"import android.support.v4.os.UserManagerCompat;"}],"source_content_type":"text/x-java","patch_set":1,"id":"c7fc49ac_d8b1cb7a","line":25,"in_reply_to":"f8051319_0c9bce90","updated":"2019-08-21 13:56:55.000000000","message":"Done","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aab530ed134267cc7d00f70c27dd81ec4616a222","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    CallRecorder recorder \u003d CallRecorder.getInstance();"},{"line_number":120,"context_line":"    recorder.addRecordingProgressListener(recordingProgressListener);"},{"line_number":121,"context_line":"    if(recorder.isRecording()){"},{"line_number":122,"context_line":"      inCallButtonUi.setCallRecordingState(true);"},{"line_number":123,"context_line":"    } else {"},{"line_number":124,"context_line":"      inCallButtonUi.setCallRecordingState(false);"}],"source_content_type":"text/x-java","patch_set":1,"id":"d56ab541_0691b50c","line":121,"updated":"2019-08-13 00:10:50.000000000","message":"Looks like this block could be rewritten as:\n\ninCallButtonUi.setCallRecordingState(recorder.isRecording());","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"59b94d338e7ae1b8a0c534eef3770a53e1aee10c","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    CallRecorder recorder \u003d CallRecorder.getInstance();"},{"line_number":120,"context_line":"    recorder.addRecordingProgressListener(recordingProgressListener);"},{"line_number":121,"context_line":"    if(recorder.isRecording()){"},{"line_number":122,"context_line":"      inCallButtonUi.setCallRecordingState(true);"},{"line_number":123,"context_line":"    } else {"},{"line_number":124,"context_line":"      inCallButtonUi.setCallRecordingState(false);"}],"source_content_type":"text/x-java","patch_set":1,"id":"5f01998e_65538f0f","line":121,"range":{"start_line":121,"start_character":4,"end_line":121,"end_character":31},"updated":"2019-08-12 22:08:06.000000000","message":"if[space](...)[space]{","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e7870c4f498a365b069a03b9fd898fc5274e3a1d","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    CallRecorder recorder \u003d CallRecorder.getInstance();"},{"line_number":120,"context_line":"    recorder.addRecordingProgressListener(recordingProgressListener);"},{"line_number":121,"context_line":"    if(recorder.isRecording()){"},{"line_number":122,"context_line":"      inCallButtonUi.setCallRecordingState(true);"},{"line_number":123,"context_line":"    } else {"},{"line_number":124,"context_line":"      inCallButtonUi.setCallRecordingState(false);"}],"source_content_type":"text/x-java","patch_set":1,"id":"f1c5a66d_8359a5f8","line":121,"range":{"start_line":121,"start_character":4,"end_line":121,"end_character":31},"in_reply_to":"5f01998e_65538f0f","updated":"2019-08-21 13:56:55.000000000","message":"Done","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e7870c4f498a365b069a03b9fd898fc5274e3a1d","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    CallRecorder recorder \u003d CallRecorder.getInstance();"},{"line_number":120,"context_line":"    recorder.addRecordingProgressListener(recordingProgressListener);"},{"line_number":121,"context_line":"    if(recorder.isRecording()){"},{"line_number":122,"context_line":"      inCallButtonUi.setCallRecordingState(true);"},{"line_number":123,"context_line":"    } else {"},{"line_number":124,"context_line":"      inCallButtonUi.setCallRecordingState(false);"}],"source_content_type":"text/x-java","patch_set":1,"id":"8d8d822d_96590148","line":121,"in_reply_to":"d56ab541_0691b50c","updated":"2019-08-21 13:56:55.000000000","message":"Done","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"59b94d338e7ae1b8a0c534eef3770a53e1aee10c","unresolved":true,"context_lines":[{"line_number":151,"context_line":"    Trace.beginSection(\"CallButtonPresenter.onStateChange\");"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    CallRecorder recorder \u003d CallRecorder.getInstance();"},{"line_number":154,"context_line":"    boolean isEnabled \u003d PreferenceManager.getDefaultSharedPreferences(context).getBoolean(context.getString(R.string.auto_call_recording_key), false);"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    if (newState \u003d\u003d InCallState.OUTGOING) {"},{"line_number":157,"context_line":"      call \u003d callList.getOutgoingCall();"}],"source_content_type":"text/x-java","patch_set":1,"id":"e8937571_191718e7","line":154,"range":{"start_line":154,"start_character":79,"end_line":154,"end_character":150},"updated":"2019-08-12 22:08:06.000000000","message":"line length","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e7870c4f498a365b069a03b9fd898fc5274e3a1d","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    Trace.beginSection(\"CallButtonPresenter.onStateChange\");"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    CallRecorder recorder \u003d CallRecorder.getInstance();"},{"line_number":154,"context_line":"    boolean isEnabled \u003d PreferenceManager.getDefaultSharedPreferences(context).getBoolean(context.getString(R.string.auto_call_recording_key), false);"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    if (newState \u003d\u003d InCallState.OUTGOING) {"},{"line_number":157,"context_line":"      call \u003d callList.getOutgoingCall();"}],"source_content_type":"text/x-java","patch_set":1,"id":"6d79cf9c_ac833252","line":154,"range":{"start_line":154,"start_character":79,"end_line":154,"end_character":150},"in_reply_to":"e8937571_191718e7","updated":"2019-08-21 13:56:55.000000000","message":"Done","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aab530ed134267cc7d00f70c27dd81ec4616a222","unresolved":true,"context_lines":[{"line_number":158,"context_line":"    } else if (newState \u003d\u003d InCallState.INCALL) {"},{"line_number":159,"context_line":"      call \u003d callList.getActiveOrBackgroundCall();"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    if (!isRecording \u0026\u0026 isEnabled \u0026\u0026 call !\u003d null) {"},{"line_number":162,"context_line":"        isRecording \u003d true;"},{"line_number":163,"context_line":"            new Handler().postDelayed(new Runnable() {"},{"line_number":164,"context_line":"                @Override"}],"source_content_type":"text/x-java","patch_set":1,"id":"f66453bc_bfef545c","line":161,"updated":"2019-08-13 00:10:50.000000000","message":"I take it recorder.isRecording() cannot be used here instead ? (and bool isRecording removed altogether)\n\nAlso, the whole block needs one more indent (should be aligned with \"call \u003d\" just above).","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"4fbbf30e4cc0a655e7f965479799f7114408f2b4","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    } else if (newState \u003d\u003d InCallState.INCALL) {"},{"line_number":159,"context_line":"      call \u003d callList.getActiveOrBackgroundCall();"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    if (!isRecording \u0026\u0026 isEnabled \u0026\u0026 call !\u003d null) {"},{"line_number":162,"context_line":"        isRecording \u003d true;"},{"line_number":163,"context_line":"            new Handler().postDelayed(new Runnable() {"},{"line_number":164,"context_line":"                @Override"}],"source_content_type":"text/x-java","patch_set":1,"id":"3255a975_9f13aa6e","line":161,"in_reply_to":"23e65134_8b379bca","updated":"2019-08-22 17:19:15.000000000","message":"The bool isRecording is needed:\nhttps://review.lineageos.org/c/LineageOS/android_packages_apps_Dialer/+/251235/3/java/com/android/incallui/CallButtonPresenter.java#158","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e7870c4f498a365b069a03b9fd898fc5274e3a1d","unresolved":true,"context_lines":[{"line_number":158,"context_line":"    } else if (newState \u003d\u003d InCallState.INCALL) {"},{"line_number":159,"context_line":"      call \u003d callList.getActiveOrBackgroundCall();"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    if (!isRecording \u0026\u0026 isEnabled \u0026\u0026 call !\u003d null) {"},{"line_number":162,"context_line":"        isRecording \u003d true;"},{"line_number":163,"context_line":"            new Handler().postDelayed(new Runnable() {"},{"line_number":164,"context_line":"                @Override"}],"source_content_type":"text/x-java","patch_set":1,"id":"23e65134_8b379bca","line":161,"in_reply_to":"f66453bc_bfef545c","updated":"2019-08-21 13:56:55.000000000","message":"Indention corrected.","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"59b94d338e7ae1b8a0c534eef3770a53e1aee10c","unresolved":true,"context_lines":[{"line_number":362,"context_line":"              prefs.edit()"},{"line_number":363,"context_line":"                  .putBoolean(KEY_RECORDING_WARNING_PRESENTED, true)"},{"line_number":364,"context_line":"                  .apply();"},{"line_number":365,"context_line":"            if(!recorder.isRecording()) {"},{"line_number":366,"context_line":"              startCallRecordingOrAskForPermission();"},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"            })"},{"line_number":369,"context_line":"            .setNegativeButton(android.R.string.cancel, null)"},{"line_number":370,"context_line":"            .show();"}],"source_content_type":"text/x-java","patch_set":1,"id":"b22cc100_385d5f4b","line":367,"range":{"start_line":365,"start_character":12,"end_line":367,"end_character":13},"updated":"2019-08-12 22:08:06.000000000","message":"needs one more indentation level\nAlso, needs a space between \"if\" and the opening \"(\"","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e7870c4f498a365b069a03b9fd898fc5274e3a1d","unresolved":false,"context_lines":[{"line_number":362,"context_line":"              prefs.edit()"},{"line_number":363,"context_line":"                  .putBoolean(KEY_RECORDING_WARNING_PRESENTED, true)"},{"line_number":364,"context_line":"                  .apply();"},{"line_number":365,"context_line":"            if(!recorder.isRecording()) {"},{"line_number":366,"context_line":"              startCallRecordingOrAskForPermission();"},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"            })"},{"line_number":369,"context_line":"            .setNegativeButton(android.R.string.cancel, null)"},{"line_number":370,"context_line":"            .show();"}],"source_content_type":"text/x-java","patch_set":1,"id":"8c7ceacc_68f3a439","line":367,"range":{"start_line":365,"start_character":12,"end_line":367,"end_character":13},"in_reply_to":"b22cc100_385d5f4b","updated":"2019-08-21 13:56:55.000000000","message":"Done","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"59b94d338e7ae1b8a0c534eef3770a53e1aee10c","unresolved":true,"context_lines":[{"line_number":369,"context_line":"            .setNegativeButton(android.R.string.cancel, null)"},{"line_number":370,"context_line":"            .show();"},{"line_number":371,"context_line":"      } else {"},{"line_number":372,"context_line":"        if(!recorder.isRecording()) {"},{"line_number":373,"context_line":"            startCallRecordingOrAskForPermission();"},{"line_number":374,"context_line":"        }"},{"line_number":375,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":1,"id":"14a9e929_594d47bd","line":372,"range":{"start_line":372,"start_character":8,"end_line":372,"end_character":37},"updated":"2019-08-12 22:08:06.000000000","message":"\"if[space](\"","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e7870c4f498a365b069a03b9fd898fc5274e3a1d","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            .setNegativeButton(android.R.string.cancel, null)"},{"line_number":370,"context_line":"            .show();"},{"line_number":371,"context_line":"      } else {"},{"line_number":372,"context_line":"        if(!recorder.isRecording()) {"},{"line_number":373,"context_line":"            startCallRecordingOrAskForPermission();"},{"line_number":374,"context_line":"        }"},{"line_number":375,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":1,"id":"ca755987_13c0d066","line":372,"range":{"start_line":372,"start_character":8,"end_line":372,"end_character":37},"in_reply_to":"14a9e929_594d47bd","updated":"2019-08-21 13:56:55.000000000","message":"Done","commit_id":"5f85941fdce36847a576670158851f1db43fd35d"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b1d3c5daf3b579f8e87771f26b9261522364cc5b","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    } else if (newState \u003d\u003d InCallState.INCALL) {"},{"line_number":156,"context_line":"      call \u003d callList.getActiveOrBackgroundCall();"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      if (!isRecording \u0026\u0026 isEnabled \u0026\u0026 call !\u003d null) {"},{"line_number":159,"context_line":"          isRecording \u003d true;"},{"line_number":160,"context_line":"          new Handler().postDelayed(new Runnable() {"},{"line_number":161,"context_line":"              @Override"}],"source_content_type":"text/x-java","patch_set":3,"id":"4a4a4dac_dfa6e9f3","line":158,"range":{"start_line":158,"start_character":10,"end_line":158,"end_character":22},"updated":"2019-08-21 17:22:46.000000000","message":"Are you sure this isRecording boolean is needed at all?","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b1d3c5daf3b579f8e87771f26b9261522364cc5b","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    } else if (newState \u003d\u003d InCallState.INCALL) {"},{"line_number":156,"context_line":"      call \u003d callList.getActiveOrBackgroundCall();"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      if (!isRecording \u0026\u0026 isEnabled \u0026\u0026 call !\u003d null) {"},{"line_number":159,"context_line":"          isRecording \u003d true;"},{"line_number":160,"context_line":"          new Handler().postDelayed(new Runnable() {"},{"line_number":161,"context_line":"              @Override"}],"source_content_type":"text/x-java","patch_set":3,"id":"a84effc4_b6e01ea8","line":158,"range":{"start_line":158,"start_character":39,"end_line":158,"end_character":51},"updated":"2019-08-21 17:22:46.000000000","message":"pretty sure at this point call can\u0027t be null","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"ac3e0ade765b5e41478d840c4e34aa34513356a5","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    } else if (newState \u003d\u003d InCallState.INCALL) {"},{"line_number":156,"context_line":"      call \u003d callList.getActiveOrBackgroundCall();"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      if (!isRecording \u0026\u0026 isEnabled \u0026\u0026 call !\u003d null) {"},{"line_number":159,"context_line":"          isRecording \u003d true;"},{"line_number":160,"context_line":"          new Handler().postDelayed(new Runnable() {"},{"line_number":161,"context_line":"              @Override"}],"source_content_type":"text/x-java","patch_set":3,"id":"e8bc6406_e9110fe6","line":158,"range":{"start_line":158,"start_character":10,"end_line":158,"end_character":22},"in_reply_to":"4a4a4dac_dfa6e9f3","updated":"2019-08-21 18:05:00.000000000","message":"No, I\u0027m not 100% sure. But it makes sense to me to skip that block, if the recording is already running.","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"ac3e0ade765b5e41478d840c4e34aa34513356a5","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    } else if (newState \u003d\u003d InCallState.INCALL) {"},{"line_number":156,"context_line":"      call \u003d callList.getActiveOrBackgroundCall();"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      if (!isRecording \u0026\u0026 isEnabled \u0026\u0026 call !\u003d null) {"},{"line_number":159,"context_line":"          isRecording \u003d true;"},{"line_number":160,"context_line":"          new Handler().postDelayed(new Runnable() {"},{"line_number":161,"context_line":"              @Override"}],"source_content_type":"text/x-java","patch_set":3,"id":"e4d88e6f_f2a94611","line":158,"range":{"start_line":158,"start_character":39,"end_line":158,"end_character":51},"in_reply_to":"a84effc4_b6e01ea8","updated":"2019-08-21 18:05:00.000000000","message":"I belive you. Will be removed in the next patchset.","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"a6611c8612ef9f560c8b9514cf8df91772e78934","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    } else if (newState \u003d\u003d InCallState.INCALL) {"},{"line_number":156,"context_line":"      call \u003d callList.getActiveOrBackgroundCall();"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      if (!isRecording \u0026\u0026 isEnabled \u0026\u0026 call !\u003d null) {"},{"line_number":159,"context_line":"          isRecording \u003d true;"},{"line_number":160,"context_line":"          new Handler().postDelayed(new Runnable() {"},{"line_number":161,"context_line":"              @Override"}],"source_content_type":"text/x-java","patch_set":3,"id":"65a5c672_f3d2d732","line":158,"range":{"start_line":158,"start_character":39,"end_line":158,"end_character":51},"in_reply_to":"aeb66b58_edb6318b","updated":"2019-10-26 17:02:36.000000000","message":"It\u0027s null, if an outgoing call is hung up before the remote has picked up the call.","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"4fbbf30e4cc0a655e7f965479799f7114408f2b4","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    } else if (newState \u003d\u003d InCallState.INCALL) {"},{"line_number":156,"context_line":"      call \u003d callList.getActiveOrBackgroundCall();"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      if (!isRecording \u0026\u0026 isEnabled \u0026\u0026 call !\u003d null) {"},{"line_number":159,"context_line":"          isRecording \u003d true;"},{"line_number":160,"context_line":"          new Handler().postDelayed(new Runnable() {"},{"line_number":161,"context_line":"              @Override"}],"source_content_type":"text/x-java","patch_set":3,"id":"aeb66b58_edb6318b","line":158,"range":{"start_line":158,"start_character":39,"end_line":158,"end_character":51},"in_reply_to":"e4d88e6f_f2a94611","updated":"2019-08-22 17:19:15.000000000","message":"Done","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"4fbbf30e4cc0a655e7f965479799f7114408f2b4","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    } else if (newState \u003d\u003d InCallState.INCALL) {"},{"line_number":156,"context_line":"      call \u003d callList.getActiveOrBackgroundCall();"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      if (!isRecording \u0026\u0026 isEnabled \u0026\u0026 call !\u003d null) {"},{"line_number":159,"context_line":"          isRecording \u003d true;"},{"line_number":160,"context_line":"          new Handler().postDelayed(new Runnable() {"},{"line_number":161,"context_line":"              @Override"}],"source_content_type":"text/x-java","patch_set":3,"id":"499c7353_0a45ebc9","line":158,"range":{"start_line":158,"start_character":10,"end_line":158,"end_character":22},"in_reply_to":"e8bc6406_e9110fe6","updated":"2019-08-22 17:19:15.000000000","message":"If the bool isRecording is removed, Dialer crashes always after auto recorded call is ending:\nlogcat: \n\n--------- beginning of crash\n08-22 17:55:07.000  9074  9074 E AndroidRuntime: FATAL EXCEPTION: main\n08-22 17:55:07.000  9074  9074 E AndroidRuntime: Process: com.android.dialer, PID: 9074\n08-22 17:55:07.000  9074  9074 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method \u0027java.lang.\nString com.android.incallui.call.DialerCall.getNumber()\u0027 on a null object reference\n08-22 17:55:07.000  9074  9074 E AndroidRuntime:        at com.android.incallui.CallButtonPresenter.startCallRecordingOrAskFo\nrPermission(CallButtonPresenter.java:381)\n08-22 17:55:07.000  9074  9074 E AndroidRuntime:        at com.android.incallui.CallButtonPresenter.callRecordClicked(CallBut\ntonPresenter.java:368)\n08-22 17:55:07.000  9074  9074 E AndroidRuntime:        at com.android.incallui.CallButtonPresenter$2.run(CallButtonPresenter\n.java:161)\n08-22 17:55:07.000  9074  9074 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:873)\n08-22 17:55:07.000  9074  9074 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:99)\n08-22 17:55:07.000  9074  9074 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:193)\n08-22 17:55:07.000  9074  9074 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:6718)\n08-22 17:55:07.000  9074  9074 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)\n08-22 17:55:07.000  9074  9074 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(Runtim\neInit.java:493)\n08-22 17:55:07.000  9074  9074 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)\n08-22 17:55:07.004  2346  9600 W ActivityManager:   Force finishing activity com.android.dialer/.DialtactsActivity\n\nSurprisingly this doesn\u0027t happen if just !isRecording is removed from the if clause, but the bool and \"isRecording \u003d true;\" are kept. Hopefully this makes some sense to you...","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b1d3c5daf3b579f8e87771f26b9261522364cc5b","unresolved":true,"context_lines":[{"line_number":163,"context_line":"                  callRecordClicked(true);"},{"line_number":164,"context_line":"              }"},{"line_number":165,"context_line":"          }, 500);"},{"line_number":166,"context_line":"    }"},{"line_number":167,"context_line":"      // When connected to voice mail, automatically shows the dialpad."},{"line_number":168,"context_line":"      // (On previous releases we showed it when in-call shows up, before waiting for"},{"line_number":169,"context_line":"      // OUTGOING.  We may want to do that once we start showing \"Voice mail\" label on"}],"source_content_type":"text/x-java","patch_set":3,"id":"64ef8e4b_7ed198a0","line":166,"updated":"2019-08-21 17:22:46.000000000","message":"Wrong identation","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"4fbbf30e4cc0a655e7f965479799f7114408f2b4","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                  callRecordClicked(true);"},{"line_number":164,"context_line":"              }"},{"line_number":165,"context_line":"          }, 500);"},{"line_number":166,"context_line":"    }"},{"line_number":167,"context_line":"      // When connected to voice mail, automatically shows the dialpad."},{"line_number":168,"context_line":"      // (On previous releases we showed it when in-call shows up, before waiting for"},{"line_number":169,"context_line":"      // OUTGOING.  We may want to do that once we start showing \"Voice mail\" label on"}],"source_content_type":"text/x-java","patch_set":3,"id":"8638456b_d9baa726","line":166,"in_reply_to":"0e210c7f_97297c1a","updated":"2019-08-22 17:19:15.000000000","message":"Done","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"ac3e0ade765b5e41478d840c4e34aa34513356a5","unresolved":true,"context_lines":[{"line_number":163,"context_line":"                  callRecordClicked(true);"},{"line_number":164,"context_line":"              }"},{"line_number":165,"context_line":"          }, 500);"},{"line_number":166,"context_line":"    }"},{"line_number":167,"context_line":"      // When connected to voice mail, automatically shows the dialpad."},{"line_number":168,"context_line":"      // (On previous releases we showed it when in-call shows up, before waiting for"},{"line_number":169,"context_line":"      // OUTGOING.  We may want to do that once we start showing \"Voice mail\" label on"}],"source_content_type":"text/x-java","patch_set":3,"id":"0e210c7f_97297c1a","line":166,"in_reply_to":"64ef8e4b_7ed198a0","updated":"2019-08-21 18:05:00.000000000","message":"Ack. 2 spaces indent.Will be fixed in next patchset.","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b1d3c5daf3b579f8e87771f26b9261522364cc5b","unresolved":true,"context_lines":[{"line_number":360,"context_line":"                  .putBoolean(KEY_RECORDING_WARNING_PRESENTED, true)"},{"line_number":361,"context_line":"                  .apply();"},{"line_number":362,"context_line":"                if (!recorder.isRecording()) {"},{"line_number":363,"context_line":"                    startCallRecordingOrAskForPermission();"},{"line_number":364,"context_line":"                }"},{"line_number":365,"context_line":"            })"},{"line_number":366,"context_line":"            .setNegativeButton(android.R.string.cancel, null)"}],"source_content_type":"text/x-java","patch_set":3,"id":"c8591665_4506baf4","line":363,"updated":"2019-08-21 17:22:46.000000000","message":"This should be moved when switching the toggle to make sure we have all the perms\nSwitch toggle -\u003e checks warningPresented -\u003e Present dialog","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"},{"author":{"_account_id":12847,"name":"nvertigo67","username":"nvertigo67","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"ac3e0ade765b5e41478d840c4e34aa34513356a5","unresolved":true,"context_lines":[{"line_number":360,"context_line":"                  .putBoolean(KEY_RECORDING_WARNING_PRESENTED, true)"},{"line_number":361,"context_line":"                  .apply();"},{"line_number":362,"context_line":"                if (!recorder.isRecording()) {"},{"line_number":363,"context_line":"                    startCallRecordingOrAskForPermission();"},{"line_number":364,"context_line":"                }"},{"line_number":365,"context_line":"            })"},{"line_number":366,"context_line":"            .setNegativeButton(android.R.string.cancel, null)"}],"source_content_type":"text/x-java","patch_set":3,"id":"29f1337c_49df8f86","line":363,"in_reply_to":"c8591665_4506baf4","updated":"2019-08-21 18:05:00.000000000","message":"Brainlocked. Can you point me to \"Switch toggle\", please?","commit_id":"373e6e4e9bd1fc536d11d866b0fad3dbf36c0f03"}]}