)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"05be940100a11cff6605bca75d1f5f47c83e4e3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3984d96b_a01872a4","updated":"2025-12-16 08:34:48.000000000","message":"can you take it all the way and just update gradle, gradlew, agp to the latest versions so that it builds on java 25 without some cryptic error messages?","commit_id":"988c7dfbd787139aba87a6b2fd7b31000ac11415"},{"author":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6f969f5f00d19e9fb299ccada95d7792558167c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a20afc9e_ced9193b","in_reply_to":"28f03e29_34bf8565","updated":"2025-12-17 09:13:33.000000000","message":"no idea what your issue is at this point? with updated gradle(w) + AGP, both ./gradlew assembleDebug and Android Studio\u0027s Assemble Module \u0027DeskClock\u0027 works here.\n\ntested /w Android Studio Otter 2 Feature Drop | 2025.2.2 RC 2 btw.","commit_id":"988c7dfbd787139aba87a6b2fd7b31000ac11415"},{"author":{"_account_id":25889,"name":"Greg Ross","email":"greg@toolstack.com","username":"GregRoss","avatars":[{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"40e023acf502f03bbc9ffe466f1fd9c9e710d32b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1cafd1b6_077e71a1","in_reply_to":"303c6e64_e4036aa7","updated":"2025-12-18 21:13:27.000000000","message":"I reverted back to AGP 8.3 just to take a look and it seems that on the UnitTest assembly it considered them \"up to date\" and doesn\u0027t re-recompile them (even if you do a project clean), where as 8.4 does do the compile, so probably a bug fix in 8.4 🤷","commit_id":"988c7dfbd787139aba87a6b2fd7b31000ac11415"},{"author":{"_account_id":25889,"name":"Greg Ross","email":"greg@toolstack.com","username":"GregRoss","avatars":[{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5dba7589e74fe843a261f4e6cc2aadee567be150","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d5bca8ae_e4830a34","in_reply_to":"3984d96b_a01872a4","updated":"2025-12-16 13:54:25.000000000","message":"I was going to look into that when I had some time, but thought getting something that worked until then was a good idea.","commit_id":"988c7dfbd787139aba87a6b2fd7b31000ac11415"},{"author":{"_account_id":25889,"name":"Greg Ross","email":"greg@toolstack.com","username":"GregRoss","avatars":[{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"041836b5c98a447c834d0fc84bd99fe44da6961f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5b1a3f70_00d60436","in_reply_to":"3be689e3_113f6557","updated":"2025-12-18 03:43:26.000000000","message":"Yes, if you specify the DeskClock module it will build fine (it only runs the assembleDebug command), but if you use the normal build command (aka ctrl-f9) it fails as that builds assembleDebug, assembleDebugAndroidTest, and assembleDebugUnitTest (for me at least) and of course the test cases are broken so the compile fails.\n\nI don\u0027t think it\u0027s a big deal now that I understand what\u0027s going on and there is an easy workaround until the unit tests get updated.","commit_id":"988c7dfbd787139aba87a6b2fd7b31000ac11415"},{"author":{"_account_id":25889,"name":"Greg Ross","email":"greg@toolstack.com","username":"GregRoss","avatars":[{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9c53bf4361bc38aaa87cfb8c7d2ffeb2394668d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"28f03e29_34bf8565","in_reply_to":"44138e8f_c064cb19","updated":"2025-12-17 00:47:51.000000000","message":"Unfortunately that doesn\u0027t solve the issues, I did some more digging and it looks like it\u0027s the test cases that are broken.\n\nFrom what I can tell AGP 8.4 and above actually pay attention to the broken test cases, so they throw an error and fail if you run them, which Android Studio does by default of course.\n\nSome of the classes that the test cases use were removed with this commit: \n\n13fec09161a1ad11a1b31e33b9e7830961172aae\n\nBack in 2023 with a refactoring of the timer code.\n\nSimply by deleting the tests folder I can upgrade to AGP 8.13.1 without issue (not saying that\u0027s a solution obviously though 😉).\n\nI think the problem with the test cases is that they\u0027re looking for the old timer UI elements that were replaced in the above commit, so it shouldn\u0027t be too hard to adapt them to the new UI... maybe 😉\n\nI\u0027ll do some more work on it over the next couple of days.","commit_id":"988c7dfbd787139aba87a6b2fd7b31000ac11415"},{"author":{"_account_id":25889,"name":"Greg Ross","email":"greg@toolstack.com","username":"GregRoss","avatars":[{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/988a51e74ca793db1ad6d484c12c630e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ca602ea784732bc95208ff9f3530a2893418ac18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c26293d5_1dc65f32","in_reply_to":"5b1a3f70_00d60436","updated":"2025-12-18 03:44:48.000000000","message":"I also noticed that your patchset 4 seems to replace the gradlew script with an older one?  Not sure if that was intentional.","commit_id":"988c7dfbd787139aba87a6b2fd7b31000ac11415"},{"author":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b487d7c8522181252832dc0a104a36463749a154","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3be689e3_113f6557","in_reply_to":"a20afc9e_ced9193b","updated":"2025-12-17 09:14:08.000000000","message":"tests compilation is broken btw, but that\u0027s out of scope of this change.","commit_id":"988c7dfbd787139aba87a6b2fd7b31000ac11415"},{"author":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cd085564ccc506222cf3432e68b52b9b0e310d8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"303c6e64_e4036aa7","in_reply_to":"c26293d5_1dc65f32","updated":"2025-12-18 07:46:37.000000000","message":"\u003eYes, if you specify the DeskClock module it will build fine (it only runs the assembleDebug command), but if you use the normal build command (aka ctrl-f9) it fails as that builds assembleDebug, assembleDebugAndroidTest, and assembleDebugUnitTest (for me at least) and of course the test cases are broken so the compile fails.\n\nthen no idea how supposedly upgrading AGP alone to a specific version would make them compile, it makes no sense.\n\n\u003eI also noticed that your patchset 4 seems to replace the gradlew script with an older one? Not sure if that was intentional.\n\nit\u0027s a newer one, that\u0027s the one you get after running ./gradlew wrapper.","commit_id":"988c7dfbd787139aba87a6b2fd7b31000ac11415"},{"author":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"440b33fc4283e204680a7aebae410708304a2df6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"44138e8f_c064cb19","in_reply_to":"d5bca8ae_e4830a34","updated":"2025-12-16 13:57:29.000000000","message":"yeah, but bumping version numbers and running `./gradlew wrapper` would probably have taken less time to do than writing a commit msg for this change.","commit_id":"988c7dfbd787139aba87a6b2fd7b31000ac11415"}]}