)]}'
{"id":"LineageOS%2Fandroid_packages_apps_DeskClock~267288","triplet_id":"LineageOS%2Fandroid_packages_apps_DeskClock~lineage-17.1~If39d4b5e33b7652c9928f4086b152a2c10cfc356","project":"LineageOS/android_packages_apps_DeskClock","branch":"lineage-17.1","full_branch":"refs/heads/lineage-17.1","hashtags":[],"change_id":"If39d4b5e33b7652c9928f4086b152a2c10cfc356","subject":"DeskClock: Fix crash when getting ringtone names","status":"ABANDONED","created":"2020-01-17 19:00:55.000000000","updated":"2020-01-24 17:50:04.000000000","total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"cca790fc73d56da20811f85b1190f2c9548c3f58","_number":267288,"virtual_id_number":267288,"owner":{"_account_id":2681,"name":"Scott Warner","email":"tortel1210@gmail.com","username":"Tortel","avatars":[{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-17 19:30:36.000000000","updated_by":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"real_updated_by":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"CC"}],"messages":[{"id":"2ab7bd9a7fb0c66176234c9689ebf44bb63ffaef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":2681,"name":"Scott Warner","email":"tortel1210@gmail.com","username":"Tortel","avatars":[{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-01-17 19:00:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aba44ed39309672f9833de40529babb13ac1a428","author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-01-17 19:30:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"72e4ce2bc01f3139a5493a7ee2a153f2bffb284d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":2681,"name":"Scott Warner","email":"tortel1210@gmail.com","username":"Tortel","avatars":[{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-01-17 19:54:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cca790fc73d56da20811f85b1190f2c9548c3f58","tag":"autogenerated:gerrit:abandon","author":{"_account_id":2681,"name":"Scott Warner","email":"tortel1210@gmail.com","username":"Tortel","avatars":[{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-01-24 17:50:04.000000000","message":"Abandoned\n\nThe exception is caused by this change: https://review.lineageos.org/c/LineageOS/android_frameworks_base/+/265508","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"141940f96fa6ab70a9a644b510d6a68f5b3e7fd1","revisions":{"303d2ec070beb388b29767d613ef4e3922cea56d":{"kind":"REWORK","_number":1,"created":"2020-01-17 19:00:55.000000000","uploader":{"_account_id":2681,"name":"Scott Warner","email":"tortel1210@gmail.com","username":"Tortel","avatars":[{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/88/267288/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_DeskClock","ref":"refs/changes/88/267288/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/1 \u0026\u0026 git checkout -b change-267288 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b5bda1061187aa3798c972e3eb9bd0ce59da5bc0","subject":"Provide upgrade path for cm-14.1 -\u003e lineage-17.0","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_DeskClock/commit/b5bda1061187aa3798c972e3eb9bd0ce59da5bc0"}]}],"author":{"name":"Scott Warner","email":"Tortel1210@gmail.com","date":"2020-01-17 18:50:54.000000000","tz":-300},"committer":{"name":"Scott Warner","email":"Tortel1210@gmail.com","date":"2020-01-17 18:50:54.000000000","tz":-300},"subject":"DeskClock: Fix crash when getting ringtone names","message":"DeskClock: Fix crash when getting ringtone names\n\nDue to restrictions introduced with Android 10 on device identifiers, it is no longer possible to read the default ringtone information without\nprivileged permissions.\nWhen loading ringtone names, if we hit a SecurityException, assume its the default ringtone.\n\nCrash stacktrace:\n\njava.lang.SecurityException: getDefaultOutgoingPhoneAccount: Neither user 10135 nor current process has android.permission.READ_PRIVILEGED_PHONE_STATE.\n   at android.os.Parcel.createException(Parcel.java:2071)\n   at android.os.Parcel.readException(Parcel.java:2039)\n   at android.os.Parcel.readException(Parcel.java:1987)\n   at com.android.internal.telecom.ITelecomService$Stub$Proxy.getUserSelectedOutgoingPhoneAccount(ITelecomService.java:1468)\n   at android.telecom.TelecomManager.getUserSelectedOutgoingPhoneAccount(TelecomManager.java:825)\n   at android.media.RingtoneManager.getDefaultPhoneAccountHandle(RingtoneManager.java:891)\n   at android.media.RingtoneManager.getActualDefaultRingtoneUri(RingtoneManager.java:785)\n   at android.media.Ringtone.getTitle(Ringtone.java:242)\n   at android.media.Ringtone.getTitle(Ringtone.java:225)\n   at com.android.deskclock.data.RingtoneModel.getRingtoneTitle(RingtoneModel.java:187)\n\nChange-Id: If39d4b5e33b7652c9928f4086b152a2c10cfc356\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_DeskClock/commit/303d2ec070beb388b29767d613ef4e3922cea56d"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_DeskClock/commit/303d2ec070beb388b29767d613ef4e3922cea56d"}]},"branch":"refs/heads/lineage-17.1"},"141940f96fa6ab70a9a644b510d6a68f5b3e7fd1":{"kind":"REWORK","_number":2,"created":"2020-01-17 19:54:02.000000000","uploader":{"_account_id":2681,"name":"Scott Warner","email":"tortel1210@gmail.com","username":"Tortel","avatars":[{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4c6a6df56bef868bf960ba6584e048e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/88/267288/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_DeskClock","ref":"refs/changes/88/267288/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/2 \u0026\u0026 git checkout -b change-267288 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_DeskClock refs/changes/88/267288/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b5bda1061187aa3798c972e3eb9bd0ce59da5bc0","subject":"Provide upgrade path for cm-14.1 -\u003e lineage-17.0","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_DeskClock/commit/b5bda1061187aa3798c972e3eb9bd0ce59da5bc0"}]}],"author":{"name":"Scott Warner","email":"Tortel1210@gmail.com","date":"2020-01-17 18:50:54.000000000","tz":-300},"committer":{"name":"Scott Warner","email":"Tortel1210@gmail.com","date":"2020-01-17 19:53:50.000000000","tz":-300},"subject":"DeskClock: Fix crash when getting ringtone names","message":"DeskClock: Fix crash when getting ringtone names\n\nDue to restrictions introduced with Android 10 on device identifiers, it is no longer possible to read the default ringtone information without\nprivileged permissions.\nWhen loading ringtone names, if we hit a SecurityException, assume its the default ringtone.\n\nCrash stacktrace:\n\njava.lang.SecurityException: getDefaultOutgoingPhoneAccount: Neither user 10135 nor current process has android.permission.READ_PRIVILEGED_PHONE_STATE.\n   at android.os.Parcel.createException(Parcel.java:2071)\n   at android.os.Parcel.readException(Parcel.java:2039)\n   at android.os.Parcel.readException(Parcel.java:1987)\n   at com.android.internal.telecom.ITelecomService$Stub$Proxy.getUserSelectedOutgoingPhoneAccount(ITelecomService.java:1468)\n   at android.telecom.TelecomManager.getUserSelectedOutgoingPhoneAccount(TelecomManager.java:825)\n   at android.media.RingtoneManager.getDefaultPhoneAccountHandle(RingtoneManager.java:891)\n   at android.media.RingtoneManager.getActualDefaultRingtoneUri(RingtoneManager.java:785)\n   at android.media.Ringtone.getTitle(Ringtone.java:242)\n   at android.media.Ringtone.getTitle(Ringtone.java:225)\n   at com.android.deskclock.data.RingtoneModel.getRingtoneTitle(RingtoneModel.java:187)\n\nChange-Id: If39d4b5e33b7652c9928f4086b152a2c10cfc356\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_DeskClock/commit/141940f96fa6ab70a9a644b510d6a68f5b3e7fd1"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_DeskClock/commit/141940f96fa6ab70a9a644b510d6a68f5b3e7fd1"}]},"branch":"refs/heads/lineage-17.1"}},"requirements":[],"submit_records":[]}