)]}'
{"id":"LineageOS%2Fandroid_packages_apps_Contacts~288839","triplet_id":"LineageOS%2Fandroid_packages_apps_Contacts~lineage-15.1~I1f62fdc077401fea2c48a31527464464f08a6b64","project":"LineageOS/android_packages_apps_Contacts","branch":"lineage-15.1","topic":"O_asb_2020-10","hashtags":[],"change_id":"I1f62fdc077401fea2c48a31527464464f08a6b64","subject":"Correct vulnerability when setting pending intents on import/export notifications by setting FLAG_IMMUTABLE","status":"MERGED","created":"2020-10-06 19:29:56.000000000","updated":"2020-10-11 11:57:39.000000000","submitted":"2020-10-11 11:57:39.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"288839-O_asb_2020-10","meta_rev_id":"3026c105c1bfc201c2cbe8b31df64080fa8a7a5b","_number":288839,"virtual_id_number":288839,"owner":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"d972112e6a0ab5ef5a2568d2ae1fe5967f75d155","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 19:29:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3026c105c1bfc201c2cbe8b31df64080fa8a7a5b","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-11 11:57:39.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f196a40c868f7393791916334911b7e97f658f5d","revisions":{"26adc6c0e38a30dc1ff398109967c16dd946d7ea":{"kind":"REWORK","_number":1,"created":"2020-10-06 19:29:56.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/39/288839/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_Contacts","ref":"refs/changes/39/288839/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/1 \u0026\u0026 git checkout -b change-288839 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/1","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aca6e26f12069e6eb9dcc0232c03ce5f4fc8a48f","subject":"Automatic translation import","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Contacts/commit/aca6e26f12069e6eb9dcc0232c03ce5f4fc8a48f"}]}],"author":{"name":"John Shao","email":"johnshao@google.com","date":"2020-07-29 22:17:01.000000000","tz":0},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2020-10-06 19:25:11.000000000","tz":-360},"subject":"Correct vulnerability when setting pending intents on import/export notifications by setting FLAG_IMMUTABLE","message":"Correct vulnerability when setting pending intents on import/export notifications by setting FLAG_IMMUTABLE\n\nFor cases where we were setting an empty content intent, setContentIntent has not been required since Gingerbread\n\nBug: 161718556\nTest: build\nChange-Id: I1f62fdc077401fea2c48a31527464464f08a6b64\n(cherry picked from commit 1d595f80e9c5157f8ca0285b572c9f1463e05c58)\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Contacts/commit/26adc6c0e38a30dc1ff398109967c16dd946d7ea"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Contacts/commit/26adc6c0e38a30dc1ff398109967c16dd946d7ea"}]},"branch":"refs/heads/lineage-15.1"},"f196a40c868f7393791916334911b7e97f658f5d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-10-11 11:57:39.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/39/288839/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_packages_apps_Contacts","ref":"refs/changes/39/288839/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/2 \u0026\u0026 git checkout -b change-288839 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/2","Reset To":"git fetch https://github.com/LineageOS/android_packages_apps_Contacts refs/changes/39/288839/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3193aa52b64b942c0eadcb8f512f76b35ac4c571","subject":"Patch URI vulnerability in contact photo editing","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Contacts/commit/3193aa52b64b942c0eadcb8f512f76b35ac4c571"}]}],"author":{"name":"John Shao","email":"johnshao@google.com","date":"2020-07-29 22:17:01.000000000","tz":0},"committer":{"name":"Anis Assi","email":"anisassi@google.com","date":"2020-08-07 00:12:09.000000000","tz":-420},"subject":"Correct vulnerability when setting pending intents on import/export notifications by setting FLAG_IMMUTABLE","message":"Correct vulnerability when setting pending intents on import/export notifications by setting FLAG_IMMUTABLE\n\nFor cases where we were setting an empty content intent, setContentIntent has not been required since Gingerbread\n\nBug: 161718556\nTest: build\nChange-Id: I1f62fdc077401fea2c48a31527464464f08a6b64\n(cherry picked from commit 1d595f80e9c5157f8ca0285b572c9f1463e05c58)\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Contacts/commit/f196a40c868f7393791916334911b7e97f658f5d"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_packages_apps_Contacts/commit/f196a40c868f7393791916334911b7e97f658f5d"}]},"branch":"refs/heads/lineage-15.1"}},"requirements":[],"submit_records":[],"submit_requirements":[]}