)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34879,"name":"Manuel Sierich","display_name":"Trogel","email":"trogel@clink.de","username":"Trogel","avatars":[{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2055759c416d0816ee1791130ea747e164315ab9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69e3a0cb_1c494b72","updated":"2025-03-23 15:27:38.000000000","message":"Change https://review.lineageos.org/c/LineageOS/android_packages_apps_LineageParts/+/424287 now removes def_battery_light_full_charge_disabled and hardcodes \u0027true\u0027 in LineageParts, as suggested. If that change is merged, the present one should be rejected.","commit_id":"bbaa0be775821d0d649cf6dafa3c3ec6bc36ed7d"},{"author":{"_account_id":34879,"name":"Manuel Sierich","display_name":"Trogel","email":"trogel@clink.de","username":"Trogel","avatars":[{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4b7c6d3ba3023f1c0df2b5d0e95b84e0b7d932a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf360fd3_424d5738","updated":"2025-03-10 21:26:05.000000000","message":"This does not yet hit the mark. I\u0027ll look into it.","commit_id":"bbaa0be775821d0d649cf6dafa3c3ec6bc36ed7d"},{"author":{"_account_id":34879,"name":"Manuel Sierich","display_name":"Trogel","email":"trogel@clink.de","username":"Trogel","avatars":[{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5ce11fae559d0933a149abb9eaabaa5f8464db9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09a336b5_4177829c","updated":"2025-03-10 22:08:54.000000000","message":"Um, it actually does hit the mark. I was just looking at the wrong A/B slot.","commit_id":"bbaa0be775821d0d649cf6dafa3c3ec6bc36ed7d"},{"author":{"_account_id":34879,"name":"Manuel Sierich","display_name":"Trogel","email":"trogel@clink.de","username":"Trogel","avatars":[{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f95052d17d87ea458265061c8fe793c1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a7deb69ad636739e6db32a2770f75273363291ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b1f8eff_ec1a9e59","updated":"2025-03-11 16:13:47.000000000","message":"Whatever the preferred way is, I\u0027d love to give it a try in the next days, if that could be a help. Let\u0027s see if I got the idea.\n\nWe would hardcode the default in LineageParts, expose it in some getter function, that is then used also from LineageBatteryLights as a default in the call to getIntForUser. This way we avoid duplication of the default value. That would likely also apply to the two other def_ bools in BatteryLightSettings.\n\nI might be wrong, but it seems that in contrast to the bools the default light colors are fetched from com.android.internal.R.integer.config_notificationsBattery...ARGB both in BatteryLightSettings and in LineageBatteryLights – so no duplication. The default brightness is hardcoded twice: in BatteryBrightnessPreference and in LineageBatteryLights.\n\nWould it make sense to align the handling of the various defaults?","commit_id":"bbaa0be775821d0d649cf6dafa3c3ec6bc36ed7d"},{"author":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f35452a9b446b76198e3e088e7b36af3b8982543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f577d095_a0b99c12","updated":"2025-03-10 22:46:38.000000000","message":"def_battery_light_full_charge_disabled should be removed instead and \u0027true\u0027 hardcoded in LineageParts.","commit_id":"bbaa0be775821d0d649cf6dafa3c3ec6bc36ed7d"}]}