)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"bf8ecb0c78a4d54d5520b6b1fa3f14ad45983326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d4b6781c_e6007738","updated":"2025-04-21 17:47:33.000000000","message":"Please +v, but this looks good, we were indeed leaking the callbacks","commit_id":"9586b2f79c83c1736e362b228558a99ba2324b12"}],"sdk/src/java/org/lineageos/internal/statusbar/NetworkTraffic.java":[{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8f11b3f01a790754c164748bc3c169ba7bf5b734","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        };"},{"line_number":302,"context_line":"        mObserver \u003d new SettingsObserver(mTrafficHandler);"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        manageNetworkCallbacks();"},{"line_number":305,"context_line":"    }"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    private void manageNetworkCallbacks() {"}],"source_content_type":"text/x-java","patch_set":3,"id":"aad5947f_7f02d0c2","line":304,"range":{"start_line":304,"start_character":0,"end_line":304,"end_character":33},"updated":"2025-04-21 09:21:23.000000000","message":"The settings observer should be called automatically as soon as registered, this might not be needed, can you check (along setting mMode earlier)?","commit_id":"d019f0cc27d5014cd08483e7978ec054f792947f"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"658d09b9d9fa76569ab8328a49a0d9cb1c9609dc","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        };"},{"line_number":302,"context_line":"        mObserver \u003d new SettingsObserver(mTrafficHandler);"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        manageNetworkCallbacks();"},{"line_number":305,"context_line":"    }"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    private void manageNetworkCallbacks() {"}],"source_content_type":"text/x-java","patch_set":3,"id":"eb0885f7_3e4d1ec6","line":304,"range":{"start_line":304,"start_character":0,"end_line":304,"end_character":33},"in_reply_to":"aad5947f_7f02d0c2","updated":"2025-04-21 09:24:28.000000000","message":"Actually Setting URIs aren\u0027t sticky, maybe you can call updateSettings manually? That should be equivalent","commit_id":"d019f0cc27d5014cd08483e7978ec054f792947f"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"857e342981291cde2606315ed215341f1f54920e","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        };"},{"line_number":302,"context_line":"        mObserver \u003d new SettingsObserver(mTrafficHandler);"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        manageNetworkCallbacks();"},{"line_number":305,"context_line":"    }"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    private void manageNetworkCallbacks() {"}],"source_content_type":"text/x-java","patch_set":3,"id":"36f18cbf_d4697680","line":304,"range":{"start_line":304,"start_character":0,"end_line":304,"end_character":33},"in_reply_to":"eb0885f7_3e4d1ec6","updated":"2025-04-21 17:44:05.000000000","message":"Done","commit_id":"d019f0cc27d5014cd08483e7978ec054f792947f"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"857e342981291cde2606315ed215341f1f54920e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * SPDX-FileCopyrightText: 2017-2023 The LineageOS project"},{"line_number":3,"context_line":" * SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":" */"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"12821ce1_8e5024d7","line":2,"range":{"start_line":2,"start_character":32,"end_line":2,"end_character":36},"updated":"2025-04-21 17:44:05.000000000","message":"2025","commit_id":"31ec7d2bf0c03526b06a40e76ad3ce9956c3349a"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"bf8ecb0c78a4d54d5520b6b1fa3f14ad45983326","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * SPDX-FileCopyrightText: 2017-2023 The LineageOS project"},{"line_number":3,"context_line":" * SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":" */"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"67c62dff_6d880dd9","line":2,"range":{"start_line":2,"start_character":32,"end_line":2,"end_character":36},"in_reply_to":"12821ce1_8e5024d7","updated":"2025-04-21 17:47:33.000000000","message":"Done","commit_id":"31ec7d2bf0c03526b06a40e76ad3ce9956c3349a"},{"author":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"862baecf99363dffddebf1be33f6094775a54c25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * SPDX-FileCopyrightText: 2017-2023 The LineageOS project"},{"line_number":3,"context_line":" * SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":" */"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"46d5799e_1b06c1bf","line":2,"range":{"start_line":2,"start_character":32,"end_line":2,"end_character":36},"in_reply_to":"67c62dff_6d880dd9","updated":"2025-04-22 05:04:13.000000000","message":"Made a few more changes, reflected the code style in the class.","commit_id":"31ec7d2bf0c03526b06a40e76ad3ce9956c3349a"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e41da76022bf5938bac985b32eafcdb9b225f179","unresolved":true,"context_lines":[{"line_number":302,"context_line":"    }"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    private void unregisterNetworkCallbacks() {"},{"line_number":305,"context_line":"        if (mConnectivityManager \u003d\u003d null) return;"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        if (mNetworkCallback !\u003d null) {"},{"line_number":308,"context_line":"            mConnectivityManager.unregisterNetworkCallback(mNetworkCallback);"}],"source_content_type":"text/x-java","patch_set":7,"id":"89bb6df9_133ad76a","line":305,"updated":"2025-04-22 07:24:54.000000000","message":"Don\u0027t think it makes sense to have it, the service is set in the constructor, maybe you could make it\nmanager \u003d requireNotNull(...)?","commit_id":"81e3fb7cf13b443da03e6101e07e2265847388b3"},{"author":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"735ed976f58af40d49f80e03823e995f840d5636","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    }"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    private void unregisterNetworkCallbacks() {"},{"line_number":305,"context_line":"        if (mConnectivityManager \u003d\u003d null) return;"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        if (mNetworkCallback !\u003d null) {"},{"line_number":308,"context_line":"            mConnectivityManager.unregisterNetworkCallback(mNetworkCallback);"}],"source_content_type":"text/x-java","patch_set":7,"id":"14773d4c_307e7701","line":305,"in_reply_to":"89bb6df9_133ad76a","updated":"2025-04-22 07:42:25.000000000","message":"Removed, i don\u0027t think its needed","commit_id":"81e3fb7cf13b443da03e6101e07e2265847388b3"}]}
