)]}'
{"id":"LineageOS%2Fandroid_libcore~405362","triplet_id":"LineageOS%2Fandroid_libcore~lineage-20.0~I545cdd49ec3cc138331145f4716c8148662a478b","project":"LineageOS/android_libcore","branch":"lineage-20.0","topic":"T_asb_2024-10","hashtags":[],"change_id":"I545cdd49ec3cc138331145f4716c8148662a478b","subject":"Do not accept zip files with invalid headers.","status":"MERGED","created":"2024-10-11 01:08:01.000000000","updated":"2024-10-20 14:01:40.000000000","submitted":"2024-10-20 14:01:40.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"405362-T_asb_2024-10","meta_rev_id":"74b2de11f46f7d0b49b771b1f47b7b5e6fba188f","_number":405362,"virtual_id_number":405362,"owner":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"80ef1db84298509b98bccd85309b00114e423aaf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2024-10-11 01:08:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"74b2de11f46f7d0b49b771b1f47b7b5e6fba188f","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2024-10-20 14:01:40.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"dc4486b48940105f3897590c9bc057a438659352","revisions":{"780976501083f36ee80d26d04a84e51c99bca341":{"kind":"REWORK","_number":1,"created":"2024-10-11 01:08:01.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/62/405362/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_libcore","ref":"refs/changes/62/405362/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_libcore refs/changes/62/405362/1 \u0026\u0026 git checkout -b change-405362 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_libcore refs/changes/62/405362/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_libcore refs/changes/62/405362/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_libcore refs/changes/62/405362/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_libcore refs/changes/62/405362/1","Reset To":"git fetch https://github.com/LineageOS/android_libcore refs/changes/62/405362/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a7d66adbcde1862f9295ae0a13f1751b193e4d7","subject":"Merge tag \u0027android-13.0.0_r35\u0027 into staging/lineage-20.0_merge-android-13.0.0_r35","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_libcore/commit/2a7d66adbcde1862f9295ae0a13f1751b193e4d7"}]}],"author":{"name":"Almaz Mingaleev","email":"mingaleev@google.com","date":"2024-07-10 12:38:35.000000000","tz":60},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2024-10-11 00:57:07.000000000","tz":-360},"subject":"Do not accept zip files with invalid headers.","message":"Do not accept zip files with invalid headers.\n\nAccording to Section 4.3.6 in [1] non-empty zip file starts with\nlocal file header. 4.3.1 allows empty files, and in such case\nfile starts with \"end of central directory record\".\n\nThis aligns ZipFile with libziparchive modulo empty zip files -\nlibziparchive rejects them.\n\nTests are skipped because sc-dev branch uses ART module\nprebuilts, but builds tests from sources which leads to presubmit\nfailures.\n\nIgnore-AOSP-First: b/309938635#comment1\n\n[1] https://pkwaredownloads.blob.core.windows.net/pem/APPNOTE.txt\n\nBug: 309938635\nTest: CtsLibcoreTestCases\nTest: CtsLibcoreOjTestCases\n(cherry picked from commit 288a44a1817707110cdf5a3a6ef8377c6e10cce2)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5a6809400627ab1c8dbb76f92dfb89daae6b2f65)\nMerged-In: I545cdd49ec3cc138331145f4716c8148662a478b\nChange-Id: I545cdd49ec3cc138331145f4716c8148662a478b\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_libcore/commit/780976501083f36ee80d26d04a84e51c99bca341"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_libcore/commit/780976501083f36ee80d26d04a84e51c99bca341"}]},"branch":"refs/heads/lineage-20.0"},"dc4486b48940105f3897590c9bc057a438659352":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-10-20 14:01:40.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/62/405362/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_libcore","ref":"refs/changes/62/405362/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_libcore refs/changes/62/405362/2 \u0026\u0026 git checkout -b change-405362 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_libcore refs/changes/62/405362/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_libcore refs/changes/62/405362/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_libcore refs/changes/62/405362/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_libcore refs/changes/62/405362/2","Reset To":"git fetch https://github.com/LineageOS/android_libcore refs/changes/62/405362/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7267082c39a25fb5afbc4eeb5752c1b276d29344","subject":"Snap for 8665969 from 13b87a9d1fa088ec191594f29e3c42f44de3ff40 to tm-release","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_libcore/commit/7267082c39a25fb5afbc4eeb5752c1b276d29344"}]}],"author":{"name":"Almaz Mingaleev","email":"mingaleev@google.com","date":"2024-07-10 12:38:35.000000000","tz":60},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2024-08-07 23:08:15.000000000","tz":0},"subject":"Do not accept zip files with invalid headers.","message":"Do not accept zip files with invalid headers.\n\nAccording to Section 4.3.6 in [1] non-empty zip file starts with\nlocal file header. 4.3.1 allows empty files, and in such case\nfile starts with \"end of central directory record\".\n\nThis aligns ZipFile with libziparchive modulo empty zip files -\nlibziparchive rejects them.\n\nTests are skipped because sc-dev branch uses ART module\nprebuilts, but builds tests from sources which leads to presubmit\nfailures.\n\nIgnore-AOSP-First: b/309938635#comment1\n\n[1] https://pkwaredownloads.blob.core.windows.net/pem/APPNOTE.txt\n\nBug: 309938635\nTest: CtsLibcoreTestCases\nTest: CtsLibcoreOjTestCases\n(cherry picked from commit 288a44a1817707110cdf5a3a6ef8377c6e10cce2)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5a6809400627ab1c8dbb76f92dfb89daae6b2f65)\nMerged-In: I545cdd49ec3cc138331145f4716c8148662a478b\nChange-Id: I545cdd49ec3cc138331145f4716c8148662a478b\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_libcore/commit/dc4486b48940105f3897590c9bc057a438659352"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_libcore/commit/dc4486b48940105f3897590c9bc057a438659352"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}