)]}'
{"id":"LineageOS%2Fandroid_kernel_sony_msm8994~183571","triplet_id":"LineageOS%2Fandroid_kernel_sony_msm8994~cm-14.1~Ic323d081da2fbed2795f40ec820e14626c5ce5b8","project":"LineageOS/android_kernel_sony_msm8994","branch":"cm-14.1","topic":"f2fs_v1","hashtags":[],"change_id":"Ic323d081da2fbed2795f40ec820e14626c5ce5b8","subject":"f2fs: enhance foreground GC","status":"ABANDONED","created":"2017-08-09 11:59:22.000000000","updated":"2017-10-27 17:28:50.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f2abf5680a163f83496e449f72048c36bcfef28e","_number":183571,"virtual_id_number":183571,"owner":{"_account_id":14098,"name":"Rohit Goswami","email":"driger633@gmail.com","username":"HaoZeke1","avatars":[{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9392,"name":"Olivier Karasangabo","email":"olivier@lineageos.org","username":"olivier","avatars":[{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"date":"2017-10-27 17:28:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9392,"name":"Olivier Karasangabo","email":"olivier@lineageos.org","username":"olivier","avatars":[{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"_account_id":9392,"name":"Olivier Karasangabo","email":"olivier@lineageos.org","username":"olivier","avatars":[{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9392,"name":"Olivier Karasangabo","email":"olivier@lineageos.org","username":"olivier","avatars":[{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-10-27 17:28:50.000000000","updated_by":{"_account_id":9392,"name":"Olivier Karasangabo","email":"olivier@lineageos.org","username":"olivier","avatars":[{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":9392,"name":"Olivier Karasangabo","email":"olivier@lineageos.org","username":"olivier","avatars":[{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"bf97f5069644767eb1b7f4e95707650490b8455d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14098,"name":"Rohit Goswami","email":"driger633@gmail.com","username":"HaoZeke1","avatars":[{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2017-08-09 11:59:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5463108c9d85dd6e685d5fcba08bcaedbab98ae6","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9392,"name":"Olivier Karasangabo","email":"olivier@lineageos.org","username":"olivier","avatars":[{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c5b0566befc01e4ca8e029b678d5d6c8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2017-10-27 17:28:50.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1a3be4a38d39ffd90b946d7cc68d1376584d312c","revisions":{"1a3be4a38d39ffd90b946d7cc68d1376584d312c":{"kind":"REWORK","_number":1,"created":"2017-08-09 11:59:22.000000000","uploader":{"_account_id":14098,"name":"Rohit Goswami","email":"driger633@gmail.com","username":"HaoZeke1","avatars":[{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/09061b7dfbeb6367a8333b1d2a8a4bf5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/71/183571/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_kernel_sony_msm8994","ref":"refs/changes/71/183571/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_kernel_sony_msm8994 refs/changes/71/183571/1 \u0026\u0026 git checkout -b change-183571 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_kernel_sony_msm8994 refs/changes/71/183571/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_kernel_sony_msm8994 refs/changes/71/183571/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_kernel_sony_msm8994 refs/changes/71/183571/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_kernel_sony_msm8994 refs/changes/71/183571/1","Reset To":"git fetch https://github.com/LineageOS/android_kernel_sony_msm8994 refs/changes/71/183571/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7faf335fe269ecc3e7a91ae8a3cf535c3f8e0ed9","subject":"f2fs: don\u0027t need to call set_page_dirty for io error","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_sony_msm8994/commit/7faf335fe269ecc3e7a91ae8a3cf535c3f8e0ed9"}]}],"author":{"name":"Chao Yu","email":"chao2.yu@samsung.com","date":"2016-01-23 08:23:55.000000000","tz":480},"committer":{"name":"HaoZeke","email":"driger633@gmail.com","date":"2017-08-09 13:42:27.000000000","tz":330},"subject":"f2fs: enhance foreground GC","message":"f2fs: enhance foreground GC\n\nIf we configure section consist of multiple segments, foreground GC will\ndo the garbage collection with following approach:\n\n\tfor each segment in victim section\n\t\tblk_start_plug\n\t\tfor each valid block in segment\n\t\t\twrite out by OPU method\n\t\tsubmit bio cache   \u003c---\n\t\tblk_finish_plug   \u003c---\n\nThere are two issue:\n1) for most of the time, \u0027submit bio cache\u0027 will break the merging in\ncurrent bio buffer from writes of next segments, making a smaller bio\nsubmitting.\n2) block plug only cover IO submitting in one segment, which reduce\nopportunity of merging IOs in plug with multiple segments.\n\nSo refactor the code as below structure to strive for biggest\nopportunity of merging IOs:\n\n\tblk_start_plug\n\tfor each segment in victim section\n\t\tfor each valid block in segment\n\t\t\twrite out by OPU method\n\tsubmit bio cache\n\tblk_finish_plug\n\nTest method:\n1. mkfs.f2fs -s 8 /dev/sdX\n2. touch 32 files\n3. write 2M data into each file\n4. punch 1.5M data from offset 0 for each file\n5. trigger foreground gc through ioctl\n\nBefore patch, there are totoally 40 bios submitted.\nf2fs_submit_write_bio: dev \u003d (8,32), WRITE_SYNC, DATA, sector \u003d 65536, size \u003d 122880\nf2fs_submit_write_bio: dev \u003d (8,32), WRITE_SYNC, DATA, sector \u003d 65776, size \u003d 122880\nf2fs_submit_write_bio: dev \u003d (8,32), WRITE_SYNC, DATA, sector \u003d 66016, size \u003d 122880\nf2fs_submit_write_bio: dev \u003d (8,32), WRITE_SYNC, DATA, sector \u003d 66256, size \u003d 122880\nf2fs_submit_write_bio: dev \u003d (8,32), WRITE_SYNC, DATA, sector \u003d 66496, size \u003d 32768\n----repeat for 8 times\n\nAfter patch, there are totally 35 bios submitted.\nf2fs_submit_write_bio: dev \u003d (8,32), WRITE_SYNC, DATA, sector \u003d 65536, size \u003d 122880\n----repeat 34 times\nf2fs_submit_write_bio: dev \u003d (8,32), WRITE_SYNC, DATA, sector \u003d 73696, size \u003d 16384\n\nChange-Id: Ic323d081da2fbed2795f40ec820e14626c5ce5b8\nSigned-off-by: Chao Yu \u003cchao2.yu@samsung.com\u003e\nSigned-off-by: Jaegeuk Kim \u003cjaegeuk@kernel.org\u003e\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_sony_msm8994/commit/1a3be4a38d39ffd90b946d7cc68d1376584d312c"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_sony_msm8994/commit/1a3be4a38d39ffd90b946d7cc68d1376584d312c"}]},"parents_data":[{"branch_name":"refs/heads/cm-14.1","commit_id":"7faf335fe269ecc3e7a91ae8a3cf535c3f8e0ed9","is_merged_in_target_branch":false,"change_id":"Iba5aaf21ecda0998b48225fd7f829bd7ccf0ccf0","change_number":183570,"patch_set_number":1,"change_status":"ABANDONED"}],"branch":"refs/heads/cm-14.1"}},"requirements":[],"submit_records":[],"submit_requirements":[]}