)]}'
{"id":"LineageOS%2Fandroid_kernel_samsung_jf~308662","triplet_id":"LineageOS%2Fandroid_kernel_samsung_jf~lineage-18.1~Ie7ac22065dac69f5d90b377b43a85157e1a205d9","project":"LineageOS/android_kernel_samsung_jf","branch":"lineage-18.1","hashtags":[],"change_id":"Ie7ac22065dac69f5d90b377b43a85157e1a205d9","subject":"firmware: use \u0027kernel_read()\u0027 to read firmware into kernel buffer","status":"MERGED","created":"2021-04-23 22:53:23.000000000","updated":"2021-04-25 22:34:26.000000000","submitted":"2021-04-25 22:34:26.000000000","submitter":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"308639","meta_rev_id":"7aea17d95b9ce6750db96e24db3ef2376fa19051","_number":308662,"virtual_id_number":308662,"owner":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"e3863aebcfaad9577102d92a07008e2f95ed3e0d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-04-23 22:53:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7aea17d95b9ce6750db96e24db3ef2376fa19051","tag":"autogenerated:gerrit:merged","author":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-04-25 22:34:26.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d144c63592864ca67ead73a1ac6faf3f0a490730","revisions":{"d144c63592864ca67ead73a1ac6faf3f0a490730":{"kind":"REWORK","_number":1,"created":"2021-04-23 22:53:23.000000000","uploader":{"_account_id":444,"name":"Arne Coucheron","email":"arco68@gmail.com","username":"arco","avatars":[{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a3b6bab703e0efa27dfe39ceb7f783fb.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/62/308662/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_kernel_samsung_jf","ref":"refs/changes/62/308662/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_kernel_samsung_jf refs/changes/62/308662/1 \u0026\u0026 git checkout -b change-308662 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_kernel_samsung_jf refs/changes/62/308662/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_kernel_samsung_jf refs/changes/62/308662/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_kernel_samsung_jf refs/changes/62/308662/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_kernel_samsung_jf refs/changes/62/308662/1","Reset To":"git fetch https://github.com/LineageOS/android_kernel_samsung_jf refs/changes/62/308662/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"06499980100e813e533fa00ed6b82c20c6989612","subject":"firmware: teach the kernel to load firmware files directly from the filesystem","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_samsung_jf/commit/06499980100e813e533fa00ed6b82c20c6989612"}]}],"author":{"name":"Linus Torvalds","email":"torvalds@linux-foundation.org","date":"2012-10-04 16:19:02.000000000","tz":-420},"committer":{"name":"Arne Coucheron","email":"arco68@gmail.com","date":"2021-04-23 22:29:43.000000000","tz":120},"subject":"firmware: use \u0027kernel_read()\u0027 to read firmware into kernel buffer","message":"firmware: use \u0027kernel_read()\u0027 to read firmware into kernel buffer\n\nFengguang correctly points out that the firmware reading should not use\nvfs_read(), since the buffer is in kernel space.\n\nThe vfs_read() just happened to work for kernel threads, but sparse\nwarns about the incorrect address spaces, and it\u0027s definitely incorrect\nand could fail for other users of the firmware loading.\n\nReported-by: Fengguang Wu \u003cfengguang.wu@intel.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\nChange-Id: Ie7ac22065dac69f5d90b377b43a85157e1a205d9\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_samsung_jf/commit/d144c63592864ca67ead73a1ac6faf3f0a490730"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_samsung_jf/commit/d144c63592864ca67ead73a1ac6faf3f0a490730"}]},"parents_data":[{"branch_name":"refs/heads/lineage-18.1","commit_id":"06499980100e813e533fa00ed6b82c20c6989612","is_merged_in_target_branch":true,"change_id":"Ie6a67f2ebf0370d5d82f84a43ca73224e572648e","change_number":308661,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/lineage-18.1"}},"requirements":[],"submit_records":[],"submit_requirements":[]}