)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25732,"name":"Sebastiano Barezzi","email":"seba@sebaubuntu.dev","username":"SebaUbuntu","avatars":[{"url":"https://www.gravatar.com/avatar/69c46a8345ae75b24d8966f7cea1a88f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/69c46a8345ae75b24d8966f7cea1a88f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/69c46a8345ae75b24d8966f7cea1a88f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/69c46a8345ae75b24d8966f7cea1a88f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"🌐, 🎤, 📷, 🖼️, 🎵, 👑"},"change_message_id":"230150e6674b252f55798479a4dc6b9d9b84cbf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f16e2a67_1d39aa34","updated":"2025-02-18 00:27:20.000000000","message":"Can you apply these directly to kona and lito defconfigs?","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"},{"author":{"_account_id":22176,"name":"Mohammad Mba","email":"mmba313@gmail.com","username":"Khalvat","avatars":[{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"Khalvat-M"},"change_message_id":"b6993aa660d9e03e9de8a7b51c8d39acc35e0442","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"86bc180e_29c0cd79","updated":"2025-02-17 21:57:55.000000000","message":"The following HALs in device manifest are not declared in FCM \u003c\u003d level 6: \n  android.hardware.biometrics.fingerprint.IFingerprint/default (@4)\n  android.hardware.bluetooth.audio.IBluetoothAudioProviderFactory/default (@4)\n  android.hardware.drm.IDrmFactory/clearkey (@1)\n  android.hardware.health.IHealth/default (@3)\n  android.hardware.ir.IConsumerIr/default (@1)\n  android.hardware.light.ILights/default (@2)\n  android.hardware.nfc.INfc/default (@1)\n  android.hardware.power.IPower/default (@5)\n  android.hardware.thermal.IThermal/default (@1)\n  android.hardware.usb.IUsb/default (@1)\n  android.hardware.usb.gadget.IUsbGadget/default (@1)\n  android.hardware.wifi.IWifi/default (@2)\n  android.hardware.wifi.hostapd.IHostapd/default (@2)\n  android.hardware.wifi.supplicant.ISupplicant/default (@3)\nERROR: files are incompatible: Runtime info and framework compatibility matrix are incompatible: No compatible kernel requiremen\nt found (kernel FCM version \u003d 6).\nFor kernel requirements at matrix level 6, Kernel config errors:\n    Missing config CONFIG_CRYPTO_CHACHA20POLY1305\n    Missing config CONFIG_TRACE_GPU_MEM\n    Missing config CONFIG_XFRM_MIGRATE\n\nandroid.hardware.radio@1.5::IRadio/slot1 is deprecated; requires at least 1.6\n    because it matches android.hardware.radio@1.4::IRadio/slot1 from /system/etc/vintf/compatibility_matrix.5.xml\nandroid.hardware.radio@1.5::IRadio/slot2 is deprecated; requires at least 1.6\n    because it matches android.hardware.radio@1.4::IRadio/slot2 from /system/etc/vintf/compatibility_matrix.5.xml\nandroid.hardware.radio@1.5::IRadio/slot1 is deprecated; requires at least 1.6\n    because it matches android.hardware.radio@1.5::IRadio/slot1 from /system/etc/vintf/compatibility_matrix.5.xml\nandroid.hardware.radio@1.5::IRadio/slot2 is deprecated; requires at least 1.6\n    because it matches android.hardware.radio@1.5::IRadio/slot2 from /system/etc/vintf/compatibility_matrix.5.xml: Success\nINCOMPATIBLE","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"},{"author":{"_account_id":22176,"name":"Mohammad Mba","email":"mmba313@gmail.com","username":"Khalvat","avatars":[{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"Khalvat-M"},"change_message_id":"f2d8090db8cca0d9517415154b3846658bac17a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"91a85f20_5666e598","updated":"2025-02-17 22:02:08.000000000","message":"have you tested without 418963","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"},{"author":{"_account_id":22176,"name":"Mohammad Mba","email":"mmba313@gmail.com","username":"Khalvat","avatars":[{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"Khalvat-M"},"change_message_id":"f8dad7b4385b1a1512b291159b216a2347f3168e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ffb809af_651cf450","updated":"2025-02-18 06:37:10.000000000","message":"it\u0027s fine now","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"},{"author":{"_account_id":32245,"name":"0xCAFEBABE","email":"me.cafebabe@gmail.com","username":"me-cafebabe","avatars":[{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"nya~"},"change_message_id":"b1e4f56e90a0ed883090d4dc34d8e8834a19098f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed20132b_615cb41a","in_reply_to":"11dadbbe_baa2d5ca","updated":"2025-02-18 06:56:59.000000000","message":"this config is based on comparison result of `android-base-conditional.xml` in between `r/android-4.19` and `s/android-4.19`. so, it\u0027s reliable when applying to different defconfigs.\n\nalso, `CONFIG_GKI_HIDDEN_GPU_CONFIGS` is dependency of `CONFIG_TRACE_GPU_MEM`","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"},{"author":{"_account_id":25732,"name":"Sebastiano Barezzi","email":"seba@sebaubuntu.dev","username":"SebaUbuntu","avatars":[{"url":"https://www.gravatar.com/avatar/69c46a8345ae75b24d8966f7cea1a88f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/69c46a8345ae75b24d8966f7cea1a88f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/69c46a8345ae75b24d8966f7cea1a88f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/69c46a8345ae75b24d8966f7cea1a88f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"🌐, 🎤, 📷, 🖼️, 🎵, 👑"},"change_message_id":"47d2684fb9d75dd98935ead0ed34cc25c378fa90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e5d9262_e785106d","in_reply_to":"6632623f_e3608cf9","updated":"2025-02-18 16:56:46.000000000","message":"Point still stands, it\u0027s way better to just apply it directly to original defconfigs, all devices could benefit from this","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"},{"author":{"_account_id":32245,"name":"0xCAFEBABE","email":"me.cafebabe@gmail.com","username":"me-cafebabe","avatars":[{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"nya~"},"change_message_id":"453f32d94b338fc26a7f6ec1375d89dd90d42bae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c48f05ba_e36f9948","in_reply_to":"91a85f20_5666e598","updated":"2025-02-18 00:21:20.000000000","message":"sure I did.\n\n1. you have to either include the kernel config fragment or pick the one I uploaded to xiaomi_sm8250 repo instead\n2. for radio, did you pick 395938","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"},{"author":{"_account_id":22176,"name":"Mohammad Mba","email":"mmba313@gmail.com","username":"Khalvat","avatars":[{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"Khalvat-M"},"change_message_id":"6ca421e6ab47c6a31f3671898dd3a1d1263c725b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6632623f_e3608cf9","in_reply_to":"afc2042c_90736951","updated":"2025-02-18 15:46:02.000000000","message":"will not break without include it\n\nhttps://review.lineageos.org/c/LineageOS/android_device_xiaomi_sm8250-common/+/419354","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"},{"author":{"_account_id":22176,"name":"Mohammad Mba","email":"mmba313@gmail.com","username":"Khalvat","avatars":[{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b5012c528cad9c180111aa0c7b59a427.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"Khalvat-M"},"change_message_id":"9b78796e75ccf56c57599b588dc1f1cedb67f59b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"11dadbbe_baa2d5ca","in_reply_to":"c48f05ba_e36f9948","updated":"2025-02-18 06:44:41.000000000","message":"it seems that we only need 3 config of it?\n\nCONFIG_CRYPTO_CHACHA20POLY1305\u003dy\nCONFIG_TRACE_GPU_MEM\u003dy\nCONFIG_XFRM_MIGRATE\u003dy","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"},{"author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"194dea56878e4dfe7601d03d99bb574ecac4f1c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"afc2042c_90736951","in_reply_to":"e59ccaba_669453c2","updated":"2025-02-18 15:29:07.000000000","message":"Does it really break FCM 5 devices? I\u0027d prefer having the changes in kona/lito/bengal perf defconfigs directly","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"},{"author":{"_account_id":32245,"name":"0xCAFEBABE","email":"me.cafebabe@gmail.com","username":"me-cafebabe","avatars":[{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"nya~"},"change_message_id":"9d54524b8d26b065953664047c8d747d9717715a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d9db504c_df6ecdda","in_reply_to":"ed20132b_615cb41a","updated":"2025-02-18 07:06:25.000000000","message":"ah, not `android-base-conditional.xml` but the else, I\u0027ve done this for so long and I wasn\u0027t remembering much","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"},{"author":{"_account_id":32245,"name":"0xCAFEBABE","email":"me.cafebabe@gmail.com","username":"me-cafebabe","avatars":[{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/579a599284aa0f2454acf08453b0f261.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"nya~"},"change_message_id":"a09ea6926768bd7faa7618625d9891ce12b840e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e59ccaba_669453c2","in_reply_to":"f16e2a67_1d39aa34","updated":"2025-02-18 00:31:57.000000000","message":"yeah it\u0027s doable, but I preferred this because it\u0027ll affect devices that still uses target-level 5, and maybe some devices uses their own defconfig instead. How do you think?","commit_id":"962c9817130c79200fd444cc7925a20b239f8b6a"}]}
