)]}'
{"id":"LineageOS%2Fandroid_kernel_qcom_sm8250~389580","triplet_id":"LineageOS%2Fandroid_kernel_qcom_sm8250~lineage-20~I52ed4f1253e82ba3e8f40f3aa1aff62580163f25","project":"LineageOS/android_kernel_qcom_sm8250","branch":"lineage-20","topic":"qcom-sm8250-erofs","hashtags":[],"change_id":"I52ed4f1253e82ba3e8f40f3aa1aff62580163f25","subject":"sched: Provide sched_set_fifo()","status":"MERGED","created":"2024-04-16 13:54:43.000000000","updated":"2024-04-18 15:34:11.000000000","submitted":"2024-04-18 15:34:11.000000000","submitter":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"389563-qcom-sm8250-erofs","meta_rev_id":"c0e0ee7865fdee06cb35c273cdb9735e18df2511","_number":389580,"virtual_id_number":389580,"owner":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"a01f9429b2cc81d4c3a3c40c5eefa26bee3b72f9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2024-04-16 13:54:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"338a2008116665b5525c22b91c41ad40a2c8f087","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2024-04-16 16:42:39.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"c0e0ee7865fdee06cb35c273cdb9735e18df2511","tag":"autogenerated:gerrit:merged","author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2024-04-18 15:34:11.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"260d03bf36763b7b15df8099534255ab500fb2a8","revisions":{"db2e2348001a452e2f929d08e5d5fa2f3502b5b0":{"kind":"REWORK","_number":1,"created":"2024-04-16 13:54:43.000000000","uploader":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/80/389580/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_kernel_qcom_sm8250","ref":"refs/changes/80/389580/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/1 \u0026\u0026 git checkout -b change-389580 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/1","Reset To":"git fetch https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ed12268ce2f6aa49afb02385a6693277202b3ed9","subject":"ANDROID: GKI: enable CONFIG_EROFS_FS\u003dy","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_qcom_sm8250/commit/ed12268ce2f6aa49afb02385a6693277202b3ed9"}]}],"author":{"name":"Peter Zijlstra","email":"peterz@infradead.org","date":"2020-04-21 10:09:13.000000000","tz":120},"committer":{"name":"Michael Bestas","email":"mkbestas@lineageos.org","date":"2024-04-16 00:26:54.000000000","tz":180},"subject":"sched: Provide sched_set_fifo()","message":"sched: Provide sched_set_fifo()\n\nSCHED_FIFO (or any static priority scheduler) is a broken scheduler\nmodel; it is fundamentally incapable of resource management, the one\nthing an OS is actually supposed to do.\n\nIt is impossible to compose static priority workloads. One cannot take\ntwo well designed and functional static priority workloads and mash\nthem together and still expect them to work.\n\nTherefore it doesn\u0027t make sense to expose the priority field; the\nkernel is fundamentally incapable of setting a sensible value, it\nneeds systems knowledge that it doesn\u0027t have.\n\nTake away sched_setschedule() / sched_setattr() from modules and\nreplace them with:\n\n  - sched_set_fifo(p); create a FIFO task (at prio 50)\n  - sched_set_fifo_low(p); create a task higher than NORMAL,\n\twhich ends up being a FIFO task at prio 1.\n  - sched_set_normal(p, nice); (re)set the task to normal\n\nThis stops the proliferation of randomly chosen, and irrelevant, FIFO\npriorities that dont\u0027t really mean anything anyway.\n\nThe system administrator/integrator, whoever has insight into the\nactual system design and requirements (userspace) can set-up\nappropriate priorities if and when needed.\n\nCc: airlied@redhat.com\nCc: alexander.deucher@amd.com\nCc: awalls@md.metrocast.net\nCc: axboe@kernel.dk\nCc: broonie@kernel.org\nCc: daniel.lezcano@linaro.org\nCc: gregkh@linuxfoundation.org\nCc: hannes@cmpxchg.org\nCc: herbert@gondor.apana.org.au\nCc: hverkuil@xs4all.nl\nCc: john.stultz@linaro.org\nCc: nico@fluxnic.net\nCc: paulmck@kernel.org\nCc: rafael.j.wysocki@intel.com\nCc: rmk+kernel@arm.linux.org.uk\nCc: sudeep.holla@arm.com\nCc: tglx@linutronix.de\nCc: ulf.hansson@linaro.org\nCc: wim@linux-watchdog.org\nChange-Id: I52ed4f1253e82ba3e8f40f3aa1aff62580163f25\nSigned-off-by: Peter Zijlstra (Intel) \u003cpeterz@infradead.org\u003e\nReviewed-by: Ingo Molnar \u003cmingo@kernel.org\u003e\nTested-by: Paul E. McKenney \u003cpaulmck@kernel.org\u003e\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_qcom_sm8250/commit/db2e2348001a452e2f929d08e5d5fa2f3502b5b0"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_qcom_sm8250/commit/db2e2348001a452e2f929d08e5d5fa2f3502b5b0"}]},"branch":"refs/heads/lineage-20"},"260d03bf36763b7b15df8099534255ab500fb2a8":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-04-16 16:42:39.000000000","uploader":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/80/389580/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_kernel_qcom_sm8250","ref":"refs/changes/80/389580/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/2 \u0026\u0026 git checkout -b change-389580 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/2","Reset To":"git fetch https://github.com/LineageOS/android_kernel_qcom_sm8250 refs/changes/80/389580/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a5af5361108e42bbdda5dc33d95922585f3790de","subject":"ANDROID: GKI: enable CONFIG_EROFS_FS\u003dy","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_qcom_sm8250/commit/a5af5361108e42bbdda5dc33d95922585f3790de"}]}],"author":{"name":"Peter Zijlstra","email":"peterz@infradead.org","date":"2020-04-21 10:09:13.000000000","tz":120},"committer":{"name":"Michael Bestas","email":"mkbestas@lineageos.org","date":"2024-04-16 16:42:18.000000000","tz":180},"subject":"sched: Provide sched_set_fifo()","message":"sched: Provide sched_set_fifo()\n\nSCHED_FIFO (or any static priority scheduler) is a broken scheduler\nmodel; it is fundamentally incapable of resource management, the one\nthing an OS is actually supposed to do.\n\nIt is impossible to compose static priority workloads. One cannot take\ntwo well designed and functional static priority workloads and mash\nthem together and still expect them to work.\n\nTherefore it doesn\u0027t make sense to expose the priority field; the\nkernel is fundamentally incapable of setting a sensible value, it\nneeds systems knowledge that it doesn\u0027t have.\n\nTake away sched_setschedule() / sched_setattr() from modules and\nreplace them with:\n\n  - sched_set_fifo(p); create a FIFO task (at prio 50)\n  - sched_set_fifo_low(p); create a task higher than NORMAL,\n\twhich ends up being a FIFO task at prio 1.\n  - sched_set_normal(p, nice); (re)set the task to normal\n\nThis stops the proliferation of randomly chosen, and irrelevant, FIFO\npriorities that dont\u0027t really mean anything anyway.\n\nThe system administrator/integrator, whoever has insight into the\nactual system design and requirements (userspace) can set-up\nappropriate priorities if and when needed.\n\nCc: airlied@redhat.com\nCc: alexander.deucher@amd.com\nCc: awalls@md.metrocast.net\nCc: axboe@kernel.dk\nCc: broonie@kernel.org\nCc: daniel.lezcano@linaro.org\nCc: gregkh@linuxfoundation.org\nCc: hannes@cmpxchg.org\nCc: herbert@gondor.apana.org.au\nCc: hverkuil@xs4all.nl\nCc: john.stultz@linaro.org\nCc: nico@fluxnic.net\nCc: paulmck@kernel.org\nCc: rafael.j.wysocki@intel.com\nCc: rmk+kernel@arm.linux.org.uk\nCc: sudeep.holla@arm.com\nCc: tglx@linutronix.de\nCc: ulf.hansson@linaro.org\nCc: wim@linux-watchdog.org\nChange-Id: I52ed4f1253e82ba3e8f40f3aa1aff62580163f25\nSigned-off-by: Peter Zijlstra (Intel) \u003cpeterz@infradead.org\u003e\nReviewed-by: Ingo Molnar \u003cmingo@kernel.org\u003e\nTested-by: Paul E. McKenney \u003cpaulmck@kernel.org\u003e\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_qcom_sm8250/commit/260d03bf36763b7b15df8099534255ab500fb2a8"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_qcom_sm8250/commit/260d03bf36763b7b15df8099534255ab500fb2a8"}]},"branch":"refs/heads/lineage-20"}},"requirements":[],"submit_records":[],"submit_requirements":[]}