)]}'
{"id":"LineageOS%2Fandroid_kernel_oneplus_msm8994~227513","triplet_id":"LineageOS%2Fandroid_kernel_oneplus_msm8994~lineage-16.0~I6e953c0a1188d2099f9202e2f8ba8145fa3531b5","project":"LineageOS/android_kernel_oneplus_msm8994","branch":"lineage-16.0","hashtags":[],"change_id":"I6e953c0a1188d2099f9202e2f8ba8145fa3531b5","subject":"ext3: fix a BUG when opening a file with O_TMPFILE flag","status":"MERGED","created":"2018-09-07 08:20:33.000000000","updated":"2018-09-16 09:10:44.000000000","submitted":"2018-09-16 09:10:44.000000000","submitter":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"227514-1537089044712-d34bf6b3","meta_rev_id":"cbb7f1b94e817fe69bb8ab6d2c5fdecb11aa4cbf","_number":227513,"virtual_id_number":227513,"owner":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2018-09-16 09:10:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2018-09-16 09:10:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"24f8d3330c02eebe712be8d29c2449aa4a491477","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-09-07 08:20:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9dd098c23dfc3466d640229c2b067e1388121feb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-09-15 14:14:02.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"005c3b624b9d1584d3258c8d23dd54c1b5472a9d","author":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-09-16 09:10:37.000000000","message":"Patch Set 2: Verified+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"cbb7f1b94e817fe69bb8ab6d2c5fdecb11aa4cbf","tag":"autogenerated:gerrit:merged","author":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2018-09-16 09:10:44.000000000","message":"Change has been successfully rebased and submitted as 84a41d59679001ec2ace2b70d9c1b193178c276c by Oskar Kratochvil","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"84a41d59679001ec2ace2b70d9c1b193178c276c","revisions":{"fe156c7fdda1bf7fe8f2732123518a0ef3b08173":{"kind":"REWORK","_number":1,"created":"2018-09-07 08:20:33.000000000","uploader":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/13/227513/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994","ref":"refs/changes/13/227513/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/1 \u0026\u0026 git checkout -b change-227513 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/1","Reset To":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1d126bbe1c791e09e7b3b356ffbb55559169ef9c","subject":"ext4: fix a BUG when opening a file with O_TMPFILE flag","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994/commit/1d126bbe1c791e09e7b3b356ffbb55559169ef9c"}]}],"author":{"name":"Zheng Liu","email":"wenqing.lz@taobao.com","date":"2013-07-21 02:03:20.000000000","tz":-240},"committer":{"name":"OzzysCmAcc","email":"oskarkratochvil86@yahoo.com","date":"2018-09-07 08:16:03.000000000","tz":120},"subject":"ext3: fix a BUG when opening a file with O_TMPFILE flag","message":"ext3: fix a BUG when opening a file with O_TMPFILE flag\n\nWhen we try to open a file with O_TMPFILE flag, we will trigger a bug.\nThe root cause is that in ext4_orphan_add() we check -\u003ei_nlink \u003d\u003d 0 and\nthis check always fails because we set -\u003ei_nlink \u003d 1 in\ninode_init_always().  We can use the following program to trigger it:\n\nint main(int argc, char *argv[])\n{\n\tint fd;\n\n\tfd \u003d open(argv[1], O_TMPFILE, 0666);\n\tif (fd \u003c 0) {\n\t\tperror(\"open \");\n\t\treturn -1;\n\t}\n\tclose(fd);\n\treturn 0;\n}\n\nThe oops message looks like this:\n\nkernel: kernel BUG at fs/ext3/namei.c:1992!\nkernel: invalid opcode: 0000 [#1] SMP\nkernel: Modules linked in: ext4 jbd2 crc16 cpufreq_ondemand ipv6 dm_mirror dm_region_hash dm_log dm_mod parport_pc parport serio_raw sg dcdbas pcspkr i2c_i801 ehci_pci ehci_hcd button acpi_cpufreq mperf e1000e ptp pps_core ttm drm_kms_helper drm hwmon i2c_algo_bit i2c_core ext3 jbd sd_mod ahci libahci libata scsi_mod uhci_hcd\nkernel: CPU: 0 PID: 2882 Comm: tst_tmpfile Not tainted 3.11.0-rc1+ #4\nkernel: Hardware name: Dell Inc. OptiPlex 780 /0V4W66, BIOS A05 08/11/2010\nkernel: task: ffff880112d30050 ti: ffff8801124d4000 task.ti: ffff8801124d4000\nkernel: RIP: 0010:[\u003cffffffffa00db5ae\u003e] [\u003cffffffffa00db5ae\u003e] ext3_orphan_add+0x6a/0x1eb [ext3]\nkernel: RSP: 0018:ffff8801124d5cc8  EFLAGS: 00010202\nkernel: RAX: 0000000000000000 RBX: ffff880111510128 RCX: ffff8801114683a0\nkernel: RDX: 0000000000000000 RSI: ffff880111510128 RDI: ffff88010fcf65a8\nkernel: RBP: ffff8801124d5d18 R08: 0080000000000000 R09: ffffffffa00d3b7f\nkernel: R10: ffff8801114683a0 R11: ffff8801032a2558 R12: 0000000000000000\nkernel: R13: ffff88010fcf6800 R14: ffff8801032a2558 R15: ffff8801115100d8\nkernel: FS:  00007f5d172b5700(0000) GS:ffff880117c00000(0000) knlGS:0000000000000000\nkernel: CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b\nkernel: CR2: 00007f5d16df15d0 CR3: 0000000110b1d000 CR4: 00000000000407f0\nkernel: Stack:\nkernel: 000000000000000c ffff8801048a7dc8 ffff8801114685a8 ffffffffa00b80d7\nkernel: ffff8801124d5e38 ffff8801032a2558 ffff88010ce24d68 0000000000000000\nkernel: ffff88011146b300 ffff8801124d5d44 ffff8801124d5d78 ffffffffa00db7e1\nkernel: Call Trace:\nkernel: [\u003cffffffffa00b80d7\u003e] ? journal_start+0x8c/0xbd [jbd]\nkernel: [\u003cffffffffa00db7e1\u003e] ext3_tmpfile+0xb2/0x13b [ext3]\nkernel: [\u003cffffffff821076f8\u003e] path_openat+0x11f/0x5e7\nkernel: [\u003cffffffff821c86b4\u003e] ? list_del+0x11/0x30\nkernel: [\u003cffffffff82065fa2\u003e] ?  __dequeue_entity+0x33/0x38\nkernel: [\u003cffffffff82107cd5\u003e] do_filp_open+0x3f/0x8d\nkernel: [\u003cffffffff82112532\u003e] ? __alloc_fd+0x50/0x102\nkernel: [\u003cffffffff820f9296\u003e] do_sys_open+0x13b/0x1cd\nkernel: [\u003cffffffff820f935c\u003e] SyS_open+0x1e/0x20\nkernel: [\u003cffffffff82398c02\u003e] system_call_fastpath+0x16/0x1b\nkernel: Code: 39 c7 0f 85 67 01 00 00 0f b7 03 25 00 f0 00 00 3d 00 40 00 00 74 18 3d 00 80 00 00 74 11 3d 00 a0 00 00 74 0a 83 7b 48 00 74 04 \u003c0f\u003e 0b eb fe 49 8b 85 50 03 00 00 4c 89 f6 48 c7 c7 c0 99 0e a0\nkernel: RIP  [\u003cffffffffa00db5ae\u003e] ext3_orphan_add+0x6a/0x1eb [ext3]\nkernel: RSP \u003cffff8801124d5cc8\u003e\n\nHere we couldn\u0027t call clear_nlink() directly because in d_tmpfile() we\nwill call inode_dec_link_count() to decrease -\u003ei_nlink.  So this commit\ntries to call d_tmpfile() before ext4_orphan_add() to fix this problem.\n\nChange-Id: I6e953c0a1188d2099f9202e2f8ba8145fa3531b5\nSigned-off-by: Zheng Liu \u003cwenqing.lz@taobao.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nCc: Jan Kara \u003cjack@suse.cz\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994/commit/fe156c7fdda1bf7fe8f2732123518a0ef3b08173"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994/commit/fe156c7fdda1bf7fe8f2732123518a0ef3b08173"}]},"branch":"refs/heads/lineage-16.0"},"31778475545e1460657dd6d45e73438cd4336341":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2018-09-15 14:14:02.000000000","uploader":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/13/227513/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994","ref":"refs/changes/13/227513/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/2 \u0026\u0026 git checkout -b change-227513 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/2","Reset To":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9a60949f2e2be4ab4b3e452622bf4e2cd2610b4f","subject":"ext4: fix a BUG when opening a file with O_TMPFILE flag","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994/commit/9a60949f2e2be4ab4b3e452622bf4e2cd2610b4f"}]}],"author":{"name":"Zheng Liu","email":"wenqing.lz@taobao.com","date":"2013-07-21 02:03:20.000000000","tz":-240},"committer":{"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","date":"2018-09-15 14:14:02.000000000","tz":120},"subject":"ext3: fix a BUG when opening a file with O_TMPFILE flag","message":"ext3: fix a BUG when opening a file with O_TMPFILE flag\n\nWhen we try to open a file with O_TMPFILE flag, we will trigger a bug.\nThe root cause is that in ext4_orphan_add() we check -\u003ei_nlink \u003d\u003d 0 and\nthis check always fails because we set -\u003ei_nlink \u003d 1 in\ninode_init_always().  We can use the following program to trigger it:\n\nint main(int argc, char *argv[])\n{\n\tint fd;\n\n\tfd \u003d open(argv[1], O_TMPFILE, 0666);\n\tif (fd \u003c 0) {\n\t\tperror(\"open \");\n\t\treturn -1;\n\t}\n\tclose(fd);\n\treturn 0;\n}\n\nThe oops message looks like this:\n\nkernel: kernel BUG at fs/ext3/namei.c:1992!\nkernel: invalid opcode: 0000 [#1] SMP\nkernel: Modules linked in: ext4 jbd2 crc16 cpufreq_ondemand ipv6 dm_mirror dm_region_hash dm_log dm_mod parport_pc parport serio_raw sg dcdbas pcspkr i2c_i801 ehci_pci ehci_hcd button acpi_cpufreq mperf e1000e ptp pps_core ttm drm_kms_helper drm hwmon i2c_algo_bit i2c_core ext3 jbd sd_mod ahci libahci libata scsi_mod uhci_hcd\nkernel: CPU: 0 PID: 2882 Comm: tst_tmpfile Not tainted 3.11.0-rc1+ #4\nkernel: Hardware name: Dell Inc. OptiPlex 780 /0V4W66, BIOS A05 08/11/2010\nkernel: task: ffff880112d30050 ti: ffff8801124d4000 task.ti: ffff8801124d4000\nkernel: RIP: 0010:[\u003cffffffffa00db5ae\u003e] [\u003cffffffffa00db5ae\u003e] ext3_orphan_add+0x6a/0x1eb [ext3]\nkernel: RSP: 0018:ffff8801124d5cc8  EFLAGS: 00010202\nkernel: RAX: 0000000000000000 RBX: ffff880111510128 RCX: ffff8801114683a0\nkernel: RDX: 0000000000000000 RSI: ffff880111510128 RDI: ffff88010fcf65a8\nkernel: RBP: ffff8801124d5d18 R08: 0080000000000000 R09: ffffffffa00d3b7f\nkernel: R10: ffff8801114683a0 R11: ffff8801032a2558 R12: 0000000000000000\nkernel: R13: ffff88010fcf6800 R14: ffff8801032a2558 R15: ffff8801115100d8\nkernel: FS:  00007f5d172b5700(0000) GS:ffff880117c00000(0000) knlGS:0000000000000000\nkernel: CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b\nkernel: CR2: 00007f5d16df15d0 CR3: 0000000110b1d000 CR4: 00000000000407f0\nkernel: Stack:\nkernel: 000000000000000c ffff8801048a7dc8 ffff8801114685a8 ffffffffa00b80d7\nkernel: ffff8801124d5e38 ffff8801032a2558 ffff88010ce24d68 0000000000000000\nkernel: ffff88011146b300 ffff8801124d5d44 ffff8801124d5d78 ffffffffa00db7e1\nkernel: Call Trace:\nkernel: [\u003cffffffffa00b80d7\u003e] ? journal_start+0x8c/0xbd [jbd]\nkernel: [\u003cffffffffa00db7e1\u003e] ext3_tmpfile+0xb2/0x13b [ext3]\nkernel: [\u003cffffffff821076f8\u003e] path_openat+0x11f/0x5e7\nkernel: [\u003cffffffff821c86b4\u003e] ? list_del+0x11/0x30\nkernel: [\u003cffffffff82065fa2\u003e] ?  __dequeue_entity+0x33/0x38\nkernel: [\u003cffffffff82107cd5\u003e] do_filp_open+0x3f/0x8d\nkernel: [\u003cffffffff82112532\u003e] ? __alloc_fd+0x50/0x102\nkernel: [\u003cffffffff820f9296\u003e] do_sys_open+0x13b/0x1cd\nkernel: [\u003cffffffff820f935c\u003e] SyS_open+0x1e/0x20\nkernel: [\u003cffffffff82398c02\u003e] system_call_fastpath+0x16/0x1b\nkernel: Code: 39 c7 0f 85 67 01 00 00 0f b7 03 25 00 f0 00 00 3d 00 40 00 00 74 18 3d 00 80 00 00 74 11 3d 00 a0 00 00 74 0a 83 7b 48 00 74 04 \u003c0f\u003e 0b eb fe 49 8b 85 50 03 00 00 4c 89 f6 48 c7 c7 c0 99 0e a0\nkernel: RIP  [\u003cffffffffa00db5ae\u003e] ext3_orphan_add+0x6a/0x1eb [ext3]\nkernel: RSP \u003cffff8801124d5cc8\u003e\n\nHere we couldn\u0027t call clear_nlink() directly because in d_tmpfile() we\nwill call inode_dec_link_count() to decrease -\u003ei_nlink.  So this commit\ntries to call d_tmpfile() before ext4_orphan_add() to fix this problem.\n\nChange-Id: I6e953c0a1188d2099f9202e2f8ba8145fa3531b5\nSigned-off-by: Zheng Liu \u003cwenqing.lz@taobao.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nCc: Jan Kara \u003cjack@suse.cz\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994/commit/31778475545e1460657dd6d45e73438cd4336341"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994/commit/31778475545e1460657dd6d45e73438cd4336341"}]},"branch":"refs/heads/lineage-16.0","description":"Rebase"},"84a41d59679001ec2ace2b70d9c1b193178c276c":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2018-09-16 09:10:44.000000000","uploader":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/13/227513/3","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994","ref":"refs/changes/13/227513/3","commands":{"Branch":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/3 \u0026\u0026 git checkout -b change-227513 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/3","Reset To":"git fetch https://github.com/LineageOS/android_kernel_oneplus_msm8994 refs/changes/13/227513/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bbec51e79bc0a70c33992d760f5d16ab8bc5f45f","subject":"ext4: fix a BUG when opening a file with O_TMPFILE flag","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994/commit/bbec51e79bc0a70c33992d760f5d16ab8bc5f45f"}]}],"author":{"name":"Zheng Liu","email":"wenqing.lz@taobao.com","date":"2013-07-21 02:03:20.000000000","tz":-240},"committer":{"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","date":"2018-09-16 09:10:44.000000000","tz":120},"subject":"ext3: fix a BUG when opening a file with O_TMPFILE flag","message":"ext3: fix a BUG when opening a file with O_TMPFILE flag\n\nWhen we try to open a file with O_TMPFILE flag, we will trigger a bug.\nThe root cause is that in ext4_orphan_add() we check -\u003ei_nlink \u003d\u003d 0 and\nthis check always fails because we set -\u003ei_nlink \u003d 1 in\ninode_init_always().  We can use the following program to trigger it:\n\nint main(int argc, char *argv[])\n{\n\tint fd;\n\n\tfd \u003d open(argv[1], O_TMPFILE, 0666);\n\tif (fd \u003c 0) {\n\t\tperror(\"open \");\n\t\treturn -1;\n\t}\n\tclose(fd);\n\treturn 0;\n}\n\nThe oops message looks like this:\n\nkernel: kernel BUG at fs/ext3/namei.c:1992!\nkernel: invalid opcode: 0000 [#1] SMP\nkernel: Modules linked in: ext4 jbd2 crc16 cpufreq_ondemand ipv6 dm_mirror dm_region_hash dm_log dm_mod parport_pc parport serio_raw sg dcdbas pcspkr i2c_i801 ehci_pci ehci_hcd button acpi_cpufreq mperf e1000e ptp pps_core ttm drm_kms_helper drm hwmon i2c_algo_bit i2c_core ext3 jbd sd_mod ahci libahci libata scsi_mod uhci_hcd\nkernel: CPU: 0 PID: 2882 Comm: tst_tmpfile Not tainted 3.11.0-rc1+ #4\nkernel: Hardware name: Dell Inc. OptiPlex 780 /0V4W66, BIOS A05 08/11/2010\nkernel: task: ffff880112d30050 ti: ffff8801124d4000 task.ti: ffff8801124d4000\nkernel: RIP: 0010:[\u003cffffffffa00db5ae\u003e] [\u003cffffffffa00db5ae\u003e] ext3_orphan_add+0x6a/0x1eb [ext3]\nkernel: RSP: 0018:ffff8801124d5cc8  EFLAGS: 00010202\nkernel: RAX: 0000000000000000 RBX: ffff880111510128 RCX: ffff8801114683a0\nkernel: RDX: 0000000000000000 RSI: ffff880111510128 RDI: ffff88010fcf65a8\nkernel: RBP: ffff8801124d5d18 R08: 0080000000000000 R09: ffffffffa00d3b7f\nkernel: R10: ffff8801114683a0 R11: ffff8801032a2558 R12: 0000000000000000\nkernel: R13: ffff88010fcf6800 R14: ffff8801032a2558 R15: ffff8801115100d8\nkernel: FS:  00007f5d172b5700(0000) GS:ffff880117c00000(0000) knlGS:0000000000000000\nkernel: CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b\nkernel: CR2: 00007f5d16df15d0 CR3: 0000000110b1d000 CR4: 00000000000407f0\nkernel: Stack:\nkernel: 000000000000000c ffff8801048a7dc8 ffff8801114685a8 ffffffffa00b80d7\nkernel: ffff8801124d5e38 ffff8801032a2558 ffff88010ce24d68 0000000000000000\nkernel: ffff88011146b300 ffff8801124d5d44 ffff8801124d5d78 ffffffffa00db7e1\nkernel: Call Trace:\nkernel: [\u003cffffffffa00b80d7\u003e] ? journal_start+0x8c/0xbd [jbd]\nkernel: [\u003cffffffffa00db7e1\u003e] ext3_tmpfile+0xb2/0x13b [ext3]\nkernel: [\u003cffffffff821076f8\u003e] path_openat+0x11f/0x5e7\nkernel: [\u003cffffffff821c86b4\u003e] ? list_del+0x11/0x30\nkernel: [\u003cffffffff82065fa2\u003e] ?  __dequeue_entity+0x33/0x38\nkernel: [\u003cffffffff82107cd5\u003e] do_filp_open+0x3f/0x8d\nkernel: [\u003cffffffff82112532\u003e] ? __alloc_fd+0x50/0x102\nkernel: [\u003cffffffff820f9296\u003e] do_sys_open+0x13b/0x1cd\nkernel: [\u003cffffffff820f935c\u003e] SyS_open+0x1e/0x20\nkernel: [\u003cffffffff82398c02\u003e] system_call_fastpath+0x16/0x1b\nkernel: Code: 39 c7 0f 85 67 01 00 00 0f b7 03 25 00 f0 00 00 3d 00 40 00 00 74 18 3d 00 80 00 00 74 11 3d 00 a0 00 00 74 0a 83 7b 48 00 74 04 \u003c0f\u003e 0b eb fe 49 8b 85 50 03 00 00 4c 89 f6 48 c7 c7 c0 99 0e a0\nkernel: RIP  [\u003cffffffffa00db5ae\u003e] ext3_orphan_add+0x6a/0x1eb [ext3]\nkernel: RSP \u003cffff8801124d5cc8\u003e\n\nHere we couldn\u0027t call clear_nlink() directly because in d_tmpfile() we\nwill call inode_dec_link_count() to decrease -\u003ei_nlink.  So this commit\ntries to call d_tmpfile() before ext4_orphan_add() to fix this problem.\n\nChange-Id: I6e953c0a1188d2099f9202e2f8ba8145fa3531b5\nSigned-off-by: Zheng Liu \u003cwenqing.lz@taobao.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nCc: Jan Kara \u003cjack@suse.cz\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994/commit/84a41d59679001ec2ace2b70d9c1b193178c276c"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_kernel_oneplus_msm8994/commit/84a41d59679001ec2ace2b70d9c1b193178c276c"}]},"branch":"refs/heads/lineage-16.0","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":14088,"name":"Oskar Kratochvil","email":"oskarkratochvil86@yahoo.com","username":"OzzysCmAcc","avatars":[{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4cf6346d37c491fe1b8a3c205445b866.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}