)]}'
{"drivers/input/keyboard/qx1000.c":[{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":468,"context_line":"\t\tdev_err(\u0026data-\u003eclient-\u003edev,\"set_direction for pdata-\u003egpio_rst failed\\n\");"},{"line_number":469,"context_line":"\t\treturn -EINVAL;"},{"line_number":470,"context_line":"\t}"},{"line_number":471,"context_line":"\tudelay(50); "},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"\treturn 0;"},{"line_number":474,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"4a2533fe_a390ea2b","side":"PARENT","line":471,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra space from the end of the line","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"static u8 aw9523b_chip_id(void)"},{"line_number":478,"context_line":"{ "},{"line_number":479,"context_line":"\tu8 chip_id;"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"\taw9523b_read_reg(REG_IC_ID, \u0026chip_id);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"6fe3f17e_5bf9ea7a","side":"PARENT","line":478,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra space from the end of the line","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":484,"context_line":"}"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"static void aw9523b_config_P1_output(void)"},{"line_number":487,"context_line":"{    "},{"line_number":488,"context_line":"\taw9523b_write_reg(REG_CONFIG_PORT1, 0x00);"},{"line_number":489,"context_line":"}"},{"line_number":490,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"74a25f1d_851c5f2d","side":"PARENT","line":487,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra spaces from the end of the line","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":521,"context_line":"}"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"static u8 aw9523b_get_P1_value(void) "},{"line_number":525,"context_line":"{    "},{"line_number":526,"context_line":"\tu8 value \u003d 0;"},{"line_number":527,"context_line":"\taw9523b_read_reg(REG_INPUT_PORT1, \u0026value);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"131c32c0_2d11b94c","side":"PARENT","line":524,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra space from the end of the line","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":522,"context_line":""},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"static u8 aw9523b_get_P1_value(void) "},{"line_number":525,"context_line":"{    "},{"line_number":526,"context_line":"\tu8 value \u003d 0;"},{"line_number":527,"context_line":"\taw9523b_read_reg(REG_INPUT_PORT1, \u0026value);"},{"line_number":528,"context_line":"\treturn value;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"64e88b13_db11eed0","side":"PARENT","line":525,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra spaces from the end of the line","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":557,"context_line":"\tspin_unlock_irqrestore(\u0026data-\u003eirq_lock, irqflags);"},{"line_number":558,"context_line":"}"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"  "},{"line_number":561,"context_line":"static void aw9523b_read_keyboard_state(u8* keyboard_state)"},{"line_number":562,"context_line":"{"},{"line_number":563,"context_line":"\tint port;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"634a9b1c_303c22c2","side":"PARENT","line":560,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra spaces","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":1151,"context_line":"\t\terr \u003d -ENOMEM;"},{"line_number":1152,"context_line":"\t\tgoto exit;"},{"line_number":1153,"context_line":"\t}"},{"line_number":1154,"context_line":"    "},{"line_number":1155,"context_line":"\tif (client-\u003edev.of_node) {"},{"line_number":1156,"context_line":"\t\terr \u003d aw9523b_parse_dt(\u0026client-\u003edev, pdata);"},{"line_number":1157,"context_line":"\t\tif (err) {"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"1e0ae761_6f7392cd","side":"PARENT","line":1154,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra spaces","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":1161,"context_line":"\t\t}"},{"line_number":1162,"context_line":"\t}"},{"line_number":1163,"context_line":""},{"line_number":1164,"context_line":"\tspin_lock_init(\u0026pdata-\u003eirq_lock);   "},{"line_number":1165,"context_line":"\tg_client \u003d client;"},{"line_number":1166,"context_line":"\ti2c_set_clientdata(client, pdata);"},{"line_number":1167,"context_line":"\tpdata-\u003eclient \u003d client;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"64f24314_32be2b4d","side":"PARENT","line":1164,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra spaces from the end of the line","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":1200,"context_line":"\t\terr \u003d -EINVAL;"},{"line_number":1201,"context_line":"\t\tgoto deinit_power_exit;"},{"line_number":1202,"context_line":"\t}"},{"line_number":1203,"context_line":"\t"},{"line_number":1204,"context_line":"\terr \u003d register_aw9523b_input_dev(\u0026client-\u003edev);"},{"line_number":1205,"context_line":"\tif (err) {"},{"line_number":1206,"context_line":"\t\tdev_err(\u0026client-\u003edev, \"Failed to register aw9523b input device\\n\");"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"c96f9cff_f0cb58fb","side":"PARENT","line":1203,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra tab","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":1251,"context_line":"\tif (pdata \u0026\u0026 (client-\u003edev.of_node))"},{"line_number":1252,"context_line":"\t\tdevm_kfree(\u0026client-\u003edev, pdata);"},{"line_number":1253,"context_line":"free_i2c_clientdata_exit:"},{"line_number":1254,"context_line":"\ti2c_set_clientdata(client, NULL);    "},{"line_number":1255,"context_line":"\tkfree(pdata);"},{"line_number":1256,"context_line":"exit:"},{"line_number":1257,"context_line":"\treturn err;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"ec3fb34f_3fac9f76","side":"PARENT","line":1254,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra spaces from the end of the line","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":1261,"context_line":"static int aw9523b_remove(struct i2c_client *client)"},{"line_number":1262,"context_line":"{"},{"line_number":1263,"context_line":"\tstruct aw9523b_data *data \u003d i2c_get_clientdata(client);"},{"line_number":1264,"context_line":"    "},{"line_number":1265,"context_line":"\tcancel_delayed_work_sync(\u0026data-\u003epoll_work);"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"\taw9523b_power_deinit(data);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"0c85e678_a0e5ca21","side":"PARENT","line":1264,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra spaces","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a0827ba3f36aec5d5f65a25426dcf06d68129f28","unresolved":true,"context_lines":[{"line_number":1350,"context_line":"\tstruct gpio_button_data *bdata \u003d dev_id;"},{"line_number":1351,"context_line":""},{"line_number":1352,"context_line":"\tBUG_ON(irq !\u003d bdata-\u003eirq);"},{"line_number":1353,"context_line":" "},{"line_number":1354,"context_line":"\tif (bdata-\u003ebutton-\u003ewakeup)"},{"line_number":1355,"context_line":"\t\tpm_stay_awake(bdata-\u003einput-\u003edev.parent);"},{"line_number":1356,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"d9de2f48_7faa351b","side":"PARENT","line":1353,"updated":"2021-08-30 20:31:07.000000000","message":"Remove the extra space","commit_id":"0e73adec8c390d896afff00bc10265cce5a6ab02"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":1278,"context_line":"\tstruct input_dev *input \u003d bdata-\u003einput;"},{"line_number":1279,"context_line":"\tint state;"},{"line_number":1280,"context_line":"\tu16 mask \u003d 0;"},{"line_number":1281,"context_line":"\tu16 keycode \u003d button-\u003ecode;"},{"line_number":1282,"context_line":"\tbool report \u003d true;"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":"\tstate \u003d (__gpio_get_value(button-\u003egpio) ? 1 : 0) ^ button-\u003eactive_low;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"1cec8bd5_90e5fa76","side":"PARENT","line":1281,"updated":"2021-09-12 06:11:21.000000000","message":"Keep the variable declaration here, even if the default value is never used","commit_id":"b20211eec8b8463e24ede7206d60af6604c19df8"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42842f1f051f3daaeb6d89e8fdc8853d1abaf88c","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"\tstruct input_dev *input \u003d bdata-\u003einput;"},{"line_number":1279,"context_line":"\tint state;"},{"line_number":1280,"context_line":"\tu16 mask \u003d 0;"},{"line_number":1281,"context_line":"\tu16 keycode \u003d button-\u003ecode;"},{"line_number":1282,"context_line":"\tbool report \u003d true;"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":"\tstate \u003d (__gpio_get_value(button-\u003egpio) ? 1 : 0) ^ button-\u003eactive_low;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"11b8d78e_a3606de3","side":"PARENT","line":1281,"in_reply_to":"1cec8bd5_90e5fa76","updated":"2021-09-12 16:37:20.000000000","message":"Ack","commit_id":"b20211eec8b8463e24ede7206d60af6604c19df8"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"static const u16 qwerty_keys[AW9523_NR_KEYS] \u003d {"},{"line_number":261,"context_line":"\t/* 0..7 */"},{"line_number":262,"context_line":"\tKEY_LEFTMETA/*GPIO - F(x)tec*/,\tKEY_H,\t\tKEY_B,\t\tKEY_7,"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"45c1be99_738e4d4b","line":259,"updated":"2021-09-12 06:11:21.000000000","message":"Remove these extra blank lines","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"static const u16 qwerty_keys[AW9523_NR_KEYS] \u003d {"},{"line_number":261,"context_line":"\t/* 0..7 */"},{"line_number":262,"context_line":"\tKEY_LEFTMETA/*GPIO - F(x)tec*/,\tKEY_H,\t\tKEY_B,\t\tKEY_7,"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"709d430a_f52a4a38","line":259,"in_reply_to":"45c1be99_738e4d4b","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":281,"context_line":"\tKEY_U,\t\tKEY_8,\t\tKEY_R,\t\tKEY_5,"},{"line_number":282,"context_line":"\t/* 56..63 */"},{"line_number":283,"context_line":"\tKEY_ESC,\tKEY_1,\t\tKEY_LEFTALT/*GPIO*/,\tKEY_RESERVED/*GPIO - Silent Fn*/,"},{"line_number":284,"context_line":"\tKEY_2,\t\tKEY_4,\t\tKEY_TAB,\tKEY_RIGHTALT/*GPIO - Right Fn as AltGr */,"},{"line_number":285,"context_line":"};"},{"line_number":286,"context_line":"static const u16 qwerty_fn_keys[AW9523_NR_KEYS] \u003d {"},{"line_number":287,"context_line":"\t/* 0..7 */"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"27e7e31b_316ba105","line":284,"updated":"2021-09-12 06:11:21.000000000","message":"Changing the default keymap so that it doesn\u0027t match the printed keycaps is a bad idea. I realize F(x)tec made some poor choices here, but the default behavior should match the printing to avoid confusing the users.","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":true,"context_lines":[{"line_number":281,"context_line":"\tKEY_U,\t\tKEY_8,\t\tKEY_R,\t\tKEY_5,"},{"line_number":282,"context_line":"\t/* 56..63 */"},{"line_number":283,"context_line":"\tKEY_ESC,\tKEY_1,\t\tKEY_LEFTALT/*GPIO*/,\tKEY_RESERVED/*GPIO - Silent Fn*/,"},{"line_number":284,"context_line":"\tKEY_2,\t\tKEY_4,\t\tKEY_TAB,\tKEY_RIGHTALT/*GPIO - Right Fn as AltGr */,"},{"line_number":285,"context_line":"};"},{"line_number":286,"context_line":"static const u16 qwerty_fn_keys[AW9523_NR_KEYS] \u003d {"},{"line_number":287,"context_line":"\t/* 0..7 */"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"a44e605f_a321054a","line":284,"in_reply_to":"27e7e31b_316ba105","updated":"2021-09-12 16:46:49.000000000","message":"I\u0027m with you. It\u0027s just convenient for me to do that while developing. That should be an advanced settings option really.","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"41b55ba210e1d8d0a51bdfc104a858baa73d2b02","unresolved":true,"context_lines":[{"line_number":602,"context_line":" * Tells if the specified KF_XXXX modifier need to be forced."},{"line_number":603,"context_line":" * Return true if specified modifier needs to be forced."},{"line_number":604,"context_line":" */"},{"line_number":605,"context_line":"static inline bool need_forced_modifier(u16 aModifier, u16 aBitField) {"},{"line_number":606,"context_line":"\t// We need to force aModifier if it is specified in aBitField but not in our logical modifier bit field already"},{"line_number":607,"context_line":"\treturn (aBitField \u0026 aModifier) \u0026\u0026 !(g_logical_modifiers \u0026 aModifier);"},{"line_number":608,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"94d43bbe_c1e97124","line":605,"updated":"2021-09-12 17:19:01.000000000","message":"This might be simpler if implemented as a preprocessor macro instead of a static inline function","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":603,"context_line":" * Return true if specified modifier needs to be forced."},{"line_number":604,"context_line":" */"},{"line_number":605,"context_line":"static inline bool need_forced_modifier(u16 aModifier, u16 aBitField) {"},{"line_number":606,"context_line":"\t// We need to force aModifier if it is specified in aBitField but not in our logical modifier bit field already"},{"line_number":607,"context_line":"\treturn (aBitField \u0026 aModifier) \u0026\u0026 !(g_logical_modifiers \u0026 aModifier);"},{"line_number":608,"context_line":"}"},{"line_number":609,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"5ebb215f_4ad1ffc7","line":606,"updated":"2021-09-12 06:11:21.000000000","message":"\u0027//\u0027 is C++, not C. Comments should use /* */","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":603,"context_line":" * Return true if specified modifier needs to be forced."},{"line_number":604,"context_line":" */"},{"line_number":605,"context_line":"static inline bool need_forced_modifier(u16 aModifier, u16 aBitField) {"},{"line_number":606,"context_line":"\t// We need to force aModifier if it is specified in aBitField but not in our logical modifier bit field already"},{"line_number":607,"context_line":"\treturn (aBitField \u0026 aModifier) \u0026\u0026 !(g_logical_modifiers \u0026 aModifier);"},{"line_number":608,"context_line":"}"},{"line_number":609,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"b0bfa6e4_2007db5a","line":606,"in_reply_to":"5ebb215f_4ad1ffc7","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"41b55ba210e1d8d0a51bdfc104a858baa73d2b02","unresolved":true,"context_lines":[{"line_number":611,"context_line":" * Tells if the specified KF_XXX modifier was forced."},{"line_number":612,"context_line":" * Return true if specified modifier was forced."},{"line_number":613,"context_line":" */"},{"line_number":614,"context_line":"static inline bool modifier_forced(u16 aFlag) {"},{"line_number":615,"context_line":"\t// We know a modifier was forced if it is set in the logical bit field but not in the physical bit field."},{"line_number":616,"context_line":"\treturn (g_logical_modifiers \u0026 aFlag) \u0026\u0026 !(g_physical_modifiers \u0026 aFlag);"},{"line_number":617,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"316d9fa0_65934ef8","line":614,"updated":"2021-09-12 17:19:01.000000000","message":"This might be simpler if implemented as a preprocessor macro instead of a static inline function","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":612,"context_line":" * Return true if specified modifier was forced."},{"line_number":613,"context_line":" */"},{"line_number":614,"context_line":"static inline bool modifier_forced(u16 aFlag) {"},{"line_number":615,"context_line":"\t// We know a modifier was forced if it is set in the logical bit field but not in the physical bit field."},{"line_number":616,"context_line":"\treturn (g_logical_modifiers \u0026 aFlag) \u0026\u0026 !(g_physical_modifiers \u0026 aFlag);"},{"line_number":617,"context_line":"}"},{"line_number":618,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"bf1bc306_1ced3db8","line":615,"updated":"2021-09-12 06:11:21.000000000","message":"Use /* */","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":612,"context_line":" * Return true if specified modifier was forced."},{"line_number":613,"context_line":" */"},{"line_number":614,"context_line":"static inline bool modifier_forced(u16 aFlag) {"},{"line_number":615,"context_line":"\t// We know a modifier was forced if it is set in the logical bit field but not in the physical bit field."},{"line_number":616,"context_line":"\treturn (g_logical_modifiers \u0026 aFlag) \u0026\u0026 !(g_physical_modifiers \u0026 aFlag);"},{"line_number":617,"context_line":"}"},{"line_number":618,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"680c7646_f648c655","line":615,"in_reply_to":"bf1bc306_1ced3db8","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":619,"context_line":"/**"},{"line_number":620,"context_line":" * Tells whether we should use our driver level function keymap"},{"line_number":621,"context_line":" */"},{"line_number":622,"context_line":"static inline bool use_driver_fn() {"},{"line_number":623,"context_line":"\t// This is the case if our logical modifiers do not contain Fn and if our physical modifiers do contain it"},{"line_number":624,"context_line":"\treturn !(g_logical_modifiers \u0026 KF_FN) \u0026\u0026 (g_physical_modifiers \u0026 KF_FN);"},{"line_number":625,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"105a4024_af6d1c49","line":622,"updated":"2021-09-12 06:11:21.000000000","message":"I think you can eliminate this predicate if you don\u0027t use KF_FN to trigger the internal keymap shift. Just use a new global variable instead.","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":619,"context_line":"/**"},{"line_number":620,"context_line":" * Tells whether we should use our driver level function keymap"},{"line_number":621,"context_line":" */"},{"line_number":622,"context_line":"static inline bool use_driver_fn() {"},{"line_number":623,"context_line":"\t// This is the case if our logical modifiers do not contain Fn and if our physical modifiers do contain it"},{"line_number":624,"context_line":"\treturn !(g_logical_modifiers \u0026 KF_FN) \u0026\u0026 (g_physical_modifiers \u0026 KF_FN);"},{"line_number":625,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"213985a8_84849471","line":622,"in_reply_to":"105a4024_af6d1c49","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":620,"context_line":" * Tells whether we should use our driver level function keymap"},{"line_number":621,"context_line":" */"},{"line_number":622,"context_line":"static inline bool use_driver_fn() {"},{"line_number":623,"context_line":"\t// This is the case if our logical modifiers do not contain Fn and if our physical modifiers do contain it"},{"line_number":624,"context_line":"\treturn !(g_logical_modifiers \u0026 KF_FN) \u0026\u0026 (g_physical_modifiers \u0026 KF_FN);"},{"line_number":625,"context_line":"}"},{"line_number":626,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"bc7bd9e2_924a9dbe","line":623,"updated":"2021-09-12 06:11:21.000000000","message":"Use /* */","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":620,"context_line":" * Tells whether we should use our driver level function keymap"},{"line_number":621,"context_line":" */"},{"line_number":622,"context_line":"static inline bool use_driver_fn() {"},{"line_number":623,"context_line":"\t// This is the case if our logical modifiers do not contain Fn and if our physical modifiers do contain it"},{"line_number":624,"context_line":"\treturn !(g_logical_modifiers \u0026 KF_FN) \u0026\u0026 (g_physical_modifiers \u0026 KF_FN);"},{"line_number":625,"context_line":"}"},{"line_number":626,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"02cb6c54_1ebf79f7","line":623,"in_reply_to":"bc7bd9e2_924a9dbe","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":625,"context_line":"}"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":""},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"static void aw9523b_check_keys(struct aw9523b_data *pdata, u8* keyboard_state)"},{"line_number":630,"context_line":"{"},{"line_number":631,"context_line":"\tstatic u8 capslock_led_enable \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"2be1ae5c_ee0c6720","line":628,"updated":"2021-09-12 06:11:21.000000000","message":"Remove the extra blank lines","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":625,"context_line":"}"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":""},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"static void aw9523b_check_keys(struct aw9523b_data *pdata, u8* keyboard_state)"},{"line_number":630,"context_line":"{"},{"line_number":631,"context_line":"\tstatic u8 capslock_led_enable \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"0c000aad_2a4e6eba","line":628,"in_reply_to":"2be1ae5c_ee0c6720","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":643,"context_line":""},{"line_number":644,"context_line":"\tfor (key_nr \u003d 0; key_nr \u003c AW9523_NR_KEYS; ++key_nr) {"},{"line_number":645,"context_line":"\t\tbool key_state \u003d aw9523b_key_state(keyboard_state, key_nr);"},{"line_number":646,"context_line":"\t\t// If that key was pressed"},{"line_number":647,"context_line":"\t\tif (key_state \u0026\u0026 !pressed[key_nr]) {"},{"line_number":648,"context_line":"\t\t\tu16 force_flags;"},{"line_number":649,"context_line":"\t\t\tif (pdata-\u003efb_blanked) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"93d8d341_3cc73696","line":646,"updated":"2021-09-12 06:11:21.000000000","message":"Use /* */","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":643,"context_line":""},{"line_number":644,"context_line":"\tfor (key_nr \u003d 0; key_nr \u003c AW9523_NR_KEYS; ++key_nr) {"},{"line_number":645,"context_line":"\t\tbool key_state \u003d aw9523b_key_state(keyboard_state, key_nr);"},{"line_number":646,"context_line":"\t\t// If that key was pressed"},{"line_number":647,"context_line":"\t\tif (key_state \u0026\u0026 !pressed[key_nr]) {"},{"line_number":648,"context_line":"\t\t\tu16 force_flags;"},{"line_number":649,"context_line":"\t\t\tif (pdata-\u003efb_blanked) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"73605d60_396c5dd4","line":646,"in_reply_to":"93d8d341_3cc73696","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":689,"context_line":"\t\t\t\tinput_report_key(aw9523b_input_dev, KEY_RIGHTALT, 1);"},{"line_number":690,"context_line":"\t\t\t\tinput_sync(aw9523b_input_dev);"},{"line_number":691,"context_line":"\t\t\t\tg_logical_modifiers |\u003d KF_ALTGR;"},{"line_number":692,"context_line":"\t\t\t}"},{"line_number":693,"context_line":"\t\t\tinput_report_key(aw9523b_input_dev, keycode, 1);"},{"line_number":694,"context_line":"\t\t\tinput_sync(aw9523b_input_dev);"},{"line_number":695,"context_line":"\t\t\tif (keycode \u003d\u003d KEY_CAPSLOCK) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"cfa3a78d_d7a7b377","line":692,"updated":"2021-09-12 06:11:21.000000000","message":"Do you need a new case to handle KF_SYM here? What about allowing KF_FN in force_flags?","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":true,"context_lines":[{"line_number":689,"context_line":"\t\t\t\tinput_report_key(aw9523b_input_dev, KEY_RIGHTALT, 1);"},{"line_number":690,"context_line":"\t\t\t\tinput_sync(aw9523b_input_dev);"},{"line_number":691,"context_line":"\t\t\t\tg_logical_modifiers |\u003d KF_ALTGR;"},{"line_number":692,"context_line":"\t\t\t}"},{"line_number":693,"context_line":"\t\t\tinput_report_key(aw9523b_input_dev, keycode, 1);"},{"line_number":694,"context_line":"\t\t\tinput_sync(aw9523b_input_dev);"},{"line_number":695,"context_line":"\t\t\tif (keycode \u003d\u003d KEY_CAPSLOCK) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"e30c9358_c0895d66","line":692,"in_reply_to":"cfa3a78d_d7a7b377","updated":"2021-09-12 16:46:49.000000000","message":"Good points!","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":699,"context_line":"\t\t\t\t++capslock_led_enable;"},{"line_number":700,"context_line":"\t\t\t}"},{"line_number":701,"context_line":"\t\t}"},{"line_number":702,"context_line":"\t\t// If that key was released"},{"line_number":703,"context_line":"\t\telse if (!key_state \u0026\u0026 pressed[key_nr]) {"},{"line_number":704,"context_line":"\t\t\tkeycode \u003d pressed[key_nr];"},{"line_number":705,"context_line":"\t\t\tprintk(KERN_DEBUG \"aw9523b: key release: key_nr\u003d%d keycode\u003d%04hx gpm\u003d%04hx glm\u003d%04hx\\n\","}],"source_content_type":"text/x-csrc","patch_set":9,"id":"513a2a66_e95e65d4","line":702,"updated":"2021-09-12 06:11:21.000000000","message":"Use /* */","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":699,"context_line":"\t\t\t\t++capslock_led_enable;"},{"line_number":700,"context_line":"\t\t\t}"},{"line_number":701,"context_line":"\t\t}"},{"line_number":702,"context_line":"\t\t// If that key was released"},{"line_number":703,"context_line":"\t\telse if (!key_state \u0026\u0026 pressed[key_nr]) {"},{"line_number":704,"context_line":"\t\t\tkeycode \u003d pressed[key_nr];"},{"line_number":705,"context_line":"\t\t\tprintk(KERN_DEBUG \"aw9523b: key release: key_nr\u003d%d keycode\u003d%04hx gpm\u003d%04hx glm\u003d%04hx\\n\","}],"source_content_type":"text/x-csrc","patch_set":9,"id":"242dbe40_1a827138","line":702,"in_reply_to":"513a2a66_e95e65d4","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":709,"context_line":"\t\t\t\tcontinue;"},{"line_number":710,"context_line":"\t\t\t}"},{"line_number":711,"context_line":"\t\t\tpressed[key_nr] \u003d 0;"},{"line_number":712,"context_line":"\t\t\t// Report our key release"},{"line_number":713,"context_line":"\t\t\tinput_report_key(aw9523b_input_dev, keycode, 0);"},{"line_number":714,"context_line":"\t\t\tinput_sync(aw9523b_input_dev);"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"ff138354_da251a6f","line":712,"updated":"2021-09-12 06:11:21.000000000","message":"Use /* */","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":709,"context_line":"\t\t\t\tcontinue;"},{"line_number":710,"context_line":"\t\t\t}"},{"line_number":711,"context_line":"\t\t\tpressed[key_nr] \u003d 0;"},{"line_number":712,"context_line":"\t\t\t// Report our key release"},{"line_number":713,"context_line":"\t\t\tinput_report_key(aw9523b_input_dev, keycode, 0);"},{"line_number":714,"context_line":"\t\t\tinput_sync(aw9523b_input_dev);"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"dec7fc61_a8850270","line":712,"in_reply_to":"ff138354_da251a6f","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":713,"context_line":"\t\t\tinput_report_key(aw9523b_input_dev, keycode, 0);"},{"line_number":714,"context_line":"\t\t\tinput_sync(aw9523b_input_dev);"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"\t\t\t// Start removing our forced modifiers"},{"line_number":717,"context_line":"\t\t\tif (modifier_forced(KF_ALTGR)) {"},{"line_number":718,"context_line":"\t\t\t\tprintk(KERN_INFO \"aw9523b: release logical altgr\\n\");"},{"line_number":719,"context_line":"\t\t\t\tinput_report_key(aw9523b_input_dev, KEY_RIGHTALT, 0);"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"a20bdc20_80461e6b","line":716,"updated":"2021-09-12 06:11:21.000000000","message":"Use /* */","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":713,"context_line":"\t\t\tinput_report_key(aw9523b_input_dev, keycode, 0);"},{"line_number":714,"context_line":"\t\t\tinput_sync(aw9523b_input_dev);"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"\t\t\t// Start removing our forced modifiers"},{"line_number":717,"context_line":"\t\t\tif (modifier_forced(KF_ALTGR)) {"},{"line_number":718,"context_line":"\t\t\t\tprintk(KERN_INFO \"aw9523b: release logical altgr\\n\");"},{"line_number":719,"context_line":"\t\t\t\tinput_report_key(aw9523b_input_dev, KEY_RIGHTALT, 0);"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"8fbe2307_74a5e832","line":716,"in_reply_to":"a20bdc20_80461e6b","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":737,"context_line":"\t\t\t\tinput_report_key(aw9523b_input_dev, KEY_LEFTSHIFT, 0);"},{"line_number":738,"context_line":"\t\t\t\tinput_sync(aw9523b_input_dev);"},{"line_number":739,"context_line":"\t\t\t\tg_logical_modifiers \u0026\u003d ~KF_SHIFT;"},{"line_number":740,"context_line":"\t\t\t}"},{"line_number":741,"context_line":"\t\t\tif (keycode \u003d\u003d KEY_CAPSLOCK) {"},{"line_number":742,"context_line":"\t\t\t\tif (capslock_led_enable \u003e\u003d 2) {"},{"line_number":743,"context_line":"\t\t\t\t\tgpio_direction_output(pdata-\u003egpio_caps_led, 0);"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"d567d2ed_dfdeb8ca","line":740,"updated":"2021-09-12 06:11:21.000000000","message":"KF_SYM will need a new case here too? What about KF_FN?","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":737,"context_line":"\t\t\t\tinput_report_key(aw9523b_input_dev, KEY_LEFTSHIFT, 0);"},{"line_number":738,"context_line":"\t\t\t\tinput_sync(aw9523b_input_dev);"},{"line_number":739,"context_line":"\t\t\t\tg_logical_modifiers \u0026\u003d ~KF_SHIFT;"},{"line_number":740,"context_line":"\t\t\t}"},{"line_number":741,"context_line":"\t\t\tif (keycode \u003d\u003d KEY_CAPSLOCK) {"},{"line_number":742,"context_line":"\t\t\t\tif (capslock_led_enable \u003e\u003d 2) {"},{"line_number":743,"context_line":"\t\t\t\t\tgpio_direction_output(pdata-\u003egpio_caps_led, 0);"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"8eb4536b_e8410370","line":740,"in_reply_to":"d567d2ed_dfdeb8ca","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":748,"context_line":"\t}"},{"line_number":749,"context_line":"}"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"static void aw9523b_irq_work(struct work_struct *work)"},{"line_number":753,"context_line":"{"},{"line_number":754,"context_line":"\tstruct aw9523b_data *pdata \u003d container_of(work, struct aw9523b_data, irq_work);"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"779d9ce2_24cb9f44","line":751,"updated":"2021-09-12 06:11:21.000000000","message":"Do you really want this extra blank line?","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce0129749485d46de367867c3336ba8e45614b17","unresolved":false,"context_lines":[{"line_number":748,"context_line":"\t}"},{"line_number":749,"context_line":"}"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"static void aw9523b_irq_work(struct work_struct *work)"},{"line_number":753,"context_line":"{"},{"line_number":754,"context_line":"\tstruct aw9523b_data *pdata \u003d container_of(work, struct aw9523b_data, irq_work);"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"af629719_df239bcc","line":751,"in_reply_to":"779d9ce2_24cb9f44","updated":"2021-09-12 16:46:49.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":1325,"context_line":"\tconst struct gpio_keys_button *button \u003d bdata-\u003ebutton;"},{"line_number":1326,"context_line":"\tstruct input_dev *input \u003d bdata-\u003einput;"},{"line_number":1327,"context_line":"\tint state;"},{"line_number":1328,"context_line":"\tu16 mask \u003d 0;\t"},{"line_number":1329,"context_line":"\tbool report \u003d true;"},{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"\tstate \u003d (__gpio_get_value(button-\u003egpio) ? 1 : 0) ^ button-\u003eactive_low;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"c3ce5e9a_15fc43f3","line":1328,"updated":"2021-09-12 06:11:21.000000000","message":"Remove the stray tab at the end of the line","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42842f1f051f3daaeb6d89e8fdc8853d1abaf88c","unresolved":false,"context_lines":[{"line_number":1325,"context_line":"\tconst struct gpio_keys_button *button \u003d bdata-\u003ebutton;"},{"line_number":1326,"context_line":"\tstruct input_dev *input \u003d bdata-\u003einput;"},{"line_number":1327,"context_line":"\tint state;"},{"line_number":1328,"context_line":"\tu16 mask \u003d 0;\t"},{"line_number":1329,"context_line":"\tbool report \u003d true;"},{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"\tstate \u003d (__gpio_get_value(button-\u003egpio) ? 1 : 0) ^ button-\u003eactive_low;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"f6efee4e_360af286","line":1328,"in_reply_to":"c3ce5e9a_15fc43f3","updated":"2021-09-12 16:37:20.000000000","message":"Done","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":1340,"context_line":"\t\treturn;"},{"line_number":1341,"context_line":"\t}"},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":"\t// We expect our button code to be within range of our keys array as defined in DTSI file"},{"line_number":1344,"context_line":"\tif (button-\u003ecode\u003c0 || button-\u003ecode\u003e\u003dAW9523_NR_KEYS) {"},{"line_number":1345,"context_line":"\t\tdev_err(input-\u003edev.parent, \"button code out of range\\n\");"},{"line_number":1346,"context_line":"\t\treturn;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"cfc137b0_9fceee25","line":1343,"updated":"2021-09-12 06:11:21.000000000","message":"Use /* */","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42842f1f051f3daaeb6d89e8fdc8853d1abaf88c","unresolved":true,"context_lines":[{"line_number":1340,"context_line":"\t\treturn;"},{"line_number":1341,"context_line":"\t}"},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":"\t// We expect our button code to be within range of our keys array as defined in DTSI file"},{"line_number":1344,"context_line":"\tif (button-\u003ecode\u003c0 || button-\u003ecode\u003e\u003dAW9523_NR_KEYS) {"},{"line_number":1345,"context_line":"\t\tdev_err(input-\u003edev.parent, \"button code out of range\\n\");"},{"line_number":1346,"context_line":"\t\treturn;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"3f955f87_e4a7ba41","line":1343,"in_reply_to":"cfc137b0_9fceee25","updated":"2021-09-12 16:37:20.000000000","message":"C++ style comments are used in several other places in that file. Moreover even though it\u0027s been a while since I last bothered writing some strict C it seems to me that enums and structs in here are using C++ styles rather than C style. Then again as stated I\u0027m no expert and I\u0027m not very interested in those discussions either. If ever people are happy with us committing those changes then I would be happy to align to the coding guidelines whatever they are. As it stands this is a bit premature :)","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":1341,"context_line":"\t}"},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":"\t// We expect our button code to be within range of our keys array as defined in DTSI file"},{"line_number":1344,"context_line":"\tif (button-\u003ecode\u003c0 || button-\u003ecode\u003e\u003dAW9523_NR_KEYS) {"},{"line_number":1345,"context_line":"\t\tdev_err(input-\u003edev.parent, \"button code out of range\\n\");"},{"line_number":1346,"context_line":"\t\treturn;"},{"line_number":1347,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"4561d688_db7ecdd4","line":1344,"updated":"2021-09-12 06:11:21.000000000","message":"button-\u003ecode is unsigned, so can\u0027t be \u003c 0","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42842f1f051f3daaeb6d89e8fdc8853d1abaf88c","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"\t}"},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":"\t// We expect our button code to be within range of our keys array as defined in DTSI file"},{"line_number":1344,"context_line":"\tif (button-\u003ecode\u003c0 || button-\u003ecode\u003e\u003dAW9523_NR_KEYS) {"},{"line_number":1345,"context_line":"\t\tdev_err(input-\u003edev.parent, \"button code out of range\\n\");"},{"line_number":1346,"context_line":"\t\treturn;"},{"line_number":1347,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"71225897_e1a80367","line":1344,"in_reply_to":"4561d688_db7ecdd4","updated":"2021-09-12 16:37:20.000000000","message":"Done","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":1347,"context_line":"\t}"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"\t//"},{"line_number":1351,"context_line":"\tu16 keycode \u003d (use_driver_fn()  ? key_fn_array[button-\u003ecode] : key_array[button-\u003ecode]);"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"\t// Silent Hardware/Driver Fn modifier"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"b483b004_7609555b","line":1350,"updated":"2021-09-12 06:11:21.000000000","message":"Remove the blank comment line","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42842f1f051f3daaeb6d89e8fdc8853d1abaf88c","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"\t}"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"\t//"},{"line_number":1351,"context_line":"\tu16 keycode \u003d (use_driver_fn()  ? key_fn_array[button-\u003ecode] : key_array[button-\u003ecode]);"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"\t// Silent Hardware/Driver Fn modifier"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"82888d9a_6b22ab76","line":1350,"in_reply_to":"b483b004_7609555b","updated":"2021-09-12 16:37:20.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"\t//"},{"line_number":1351,"context_line":"\tu16 keycode \u003d (use_driver_fn()  ? key_fn_array[button-\u003ecode] : key_array[button-\u003ecode]);"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"\t// Silent Hardware/Driver Fn modifier"},{"line_number":1354,"context_line":"\tif (keycode \u003d\u003d KEY_RESERVED) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"21d5d4bf_2755c45d","line":1351,"updated":"2021-09-12 06:11:21.000000000","message":"Adding new variable declarations in the middle of the function is legal syntax, but doesn\u0027t match the coding style","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42842f1f051f3daaeb6d89e8fdc8853d1abaf88c","unresolved":false,"context_lines":[{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"\t//"},{"line_number":1351,"context_line":"\tu16 keycode \u003d (use_driver_fn()  ? key_fn_array[button-\u003ecode] : key_array[button-\u003ecode]);"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"\t// Silent Hardware/Driver Fn modifier"},{"line_number":1354,"context_line":"\tif (keycode \u003d\u003d KEY_RESERVED) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"6af0b4f8_f4969e74","line":1351,"in_reply_to":"21d5d4bf_2755c45d","updated":"2021-09-12 16:37:20.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":1350,"context_line":"\t//"},{"line_number":1351,"context_line":"\tu16 keycode \u003d (use_driver_fn()  ? key_fn_array[button-\u003ecode] : key_array[button-\u003ecode]);"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"\t// Silent Hardware/Driver Fn modifier"},{"line_number":1354,"context_line":"\tif (keycode \u003d\u003d KEY_RESERVED) {"},{"line_number":1355,"context_line":"\t\tmask \u003d KF_FN;"},{"line_number":1356,"context_line":"\t\treport \u003d false;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"961ce470_2df5342a","line":1353,"updated":"2021-09-12 06:11:21.000000000","message":"Use /* */","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42842f1f051f3daaeb6d89e8fdc8853d1abaf88c","unresolved":false,"context_lines":[{"line_number":1350,"context_line":"\t//"},{"line_number":1351,"context_line":"\tu16 keycode \u003d (use_driver_fn()  ? key_fn_array[button-\u003ecode] : key_array[button-\u003ecode]);"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"\t// Silent Hardware/Driver Fn modifier"},{"line_number":1354,"context_line":"\tif (keycode \u003d\u003d KEY_RESERVED) {"},{"line_number":1355,"context_line":"\t\tmask \u003d KF_FN;"},{"line_number":1356,"context_line":"\t\treport \u003d false;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"8682df72_963357c8","line":1353,"in_reply_to":"961ce470_2df5342a","updated":"2021-09-12 16:37:20.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"\t// Silent Hardware/Driver Fn modifier"},{"line_number":1354,"context_line":"\tif (keycode \u003d\u003d KEY_RESERVED) {"},{"line_number":1355,"context_line":"\t\tmask \u003d KF_FN;"},{"line_number":1356,"context_line":"\t\treport \u003d false;"},{"line_number":1357,"context_line":"\t}"},{"line_number":1358,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"ea4e4710_4d1df980","line":1355,"updated":"2021-09-12 06:11:21.000000000","message":"Don\u0027t set KF_FN here, use a new global variable instead to trigger the internal keymap shift","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42842f1f051f3daaeb6d89e8fdc8853d1abaf88c","unresolved":true,"context_lines":[{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"\t// Silent Hardware/Driver Fn modifier"},{"line_number":1354,"context_line":"\tif (keycode \u003d\u003d KEY_RESERVED) {"},{"line_number":1355,"context_line":"\t\tmask \u003d KF_FN;"},{"line_number":1356,"context_line":"\t\treport \u003d false;"},{"line_number":1357,"context_line":"\t}"},{"line_number":1358,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":9,"id":"66a4dac9_5976e040","line":1355,"in_reply_to":"ea4e4710_4d1df980","updated":"2021-09-12 16:37:20.000000000","message":"That was indeed an option though for now I decided against adding another state management variable. That may yet change.","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":1356,"context_line":"\t\treport \u003d false;"},{"line_number":1357,"context_line":"\t}"},{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"\t//"},{"line_number":1360,"context_line":"\tif (keycode \u003d\u003d KEY_FN) {"},{"line_number":1361,"context_line":"\t\tmask \u003d KF_FN;"},{"line_number":1362,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"3329b4fd_bb61ce50","line":1359,"updated":"2021-09-12 06:11:21.000000000","message":"Remove the blank comment line","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42842f1f051f3daaeb6d89e8fdc8853d1abaf88c","unresolved":false,"context_lines":[{"line_number":1356,"context_line":"\t\treport \u003d false;"},{"line_number":1357,"context_line":"\t}"},{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"\t//"},{"line_number":1360,"context_line":"\tif (keycode \u003d\u003d KEY_FN) {"},{"line_number":1361,"context_line":"\t\tmask \u003d KF_FN;"},{"line_number":1362,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"a4ea0d56_3d6459e3","line":1359,"in_reply_to":"3329b4fd_bb61ce50","updated":"2021-09-12 16:37:20.000000000","message":"Ack","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"41b55ba210e1d8d0a51bdfc104a858baa73d2b02","unresolved":true,"context_lines":[{"line_number":1373,"context_line":"\t\tmask \u003d KF_CTRL;"},{"line_number":1374,"context_line":"\t\tkeycode \u003d KEY_LEFTCTRL;"},{"line_number":1375,"context_line":"\t}"},{"line_number":1376,"context_line":"\t"},{"line_number":1377,"context_line":"\tif (keycode \u003d\u003d KEY_LEFTSHIFT || keycode \u003d\u003d KEY_RIGHTSHIFT) {"},{"line_number":1378,"context_line":"\t\tmask \u003d KF_SHIFT;"},{"line_number":1379,"context_line":"\t\tkeycode \u003d KEY_LEFTSHIFT;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"02e8709d_94a9e330","line":1376,"updated":"2021-09-12 17:19:01.000000000","message":"I missed this one. There is a tab on this blank line","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"480c7c1144d30d49cf0b6eadf83e5b33cac0bca7","unresolved":true,"context_lines":[{"line_number":1377,"context_line":"\tif (keycode \u003d\u003d KEY_LEFTSHIFT || keycode \u003d\u003d KEY_RIGHTSHIFT) {"},{"line_number":1378,"context_line":"\t\tmask \u003d KF_SHIFT;"},{"line_number":1379,"context_line":"\t\tkeycode \u003d KEY_LEFTSHIFT;"},{"line_number":1380,"context_line":"\t}"},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"\tif (mask) {"},{"line_number":1383,"context_line":"\t\tif (state) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"2134918b_03e3f11b","line":1380,"updated":"2021-09-12 06:11:21.000000000","message":"Do you need another case for KF_SYM?","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":28535,"name":"Stéphane Lenclud","display_name":"Slion","email":"stephane.lenclud@gmail.com","username":"Slion","avatars":[{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9daff69f1b0e9d786861936220d7578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42842f1f051f3daaeb6d89e8fdc8853d1abaf88c","unresolved":true,"context_lines":[{"line_number":1377,"context_line":"\tif (keycode \u003d\u003d KEY_LEFTSHIFT || keycode \u003d\u003d KEY_RIGHTSHIFT) {"},{"line_number":1378,"context_line":"\t\tmask \u003d KF_SHIFT;"},{"line_number":1379,"context_line":"\t\tkeycode \u003d KEY_LEFTSHIFT;"},{"line_number":1380,"context_line":"\t}"},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"\tif (mask) {"},{"line_number":1383,"context_line":"\t\tif (state) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"8c3f72ad_09794060","line":1380,"in_reply_to":"2134918b_03e3f11b","updated":"2021-09-12 16:37:20.000000000","message":"Yeah, I\u0027ll have to look into that. Sym as a KCM modifier is not working yet and will need device repository changes. It\u0027s still mapped to AltGr.","commit_id":"1822abb9071a088d0df3dbcf027a2981482796eb"},{"author":{"_account_id":16914,"name":"Sean McCreary","email":"mccreary@mcwest.org","username":"mccreary","avatars":[{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e9d6655476ef046675d290848ca25271.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5ef05c00640497dd0a8db2a5ebfdbabd35ba0f15","unresolved":true,"context_lines":[{"line_number":281,"context_line":"\tKEY_U,\t\tKEY_8,\t\tKEY_R,\t\tKEY_5,"},{"line_number":282,"context_line":"\t/* 56..63 */"},{"line_number":283,"context_line":"\tKEY_ESC,\tKEY_1,\t\tKEY_LEFTALT/*GPIO*/,\tKEY_RESERVED/*GPIO - Silent Fn*/,"},{"line_number":284,"context_line":"\tKEY_2,\t\tKEY_4,\t\tKEY_TAB,\tKEY_RIGHTALT/*GPIO - Right Fn as AltGr TODO: switch back to KEY_RESERVED */,"},{"line_number":285,"context_line":"};"},{"line_number":286,"context_line":"static const u16 qwerty_fn_keys[AW9523_NR_KEYS] \u003d {"},{"line_number":287,"context_line":"\t/* 0..7 */"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"35f73d88_ffd0df2f","line":284,"updated":"2021-09-13 00:23:33.000000000","message":"We often manage this kind of tweak in a second CR applied after this one, and marked [DNM] or [Do Not Merge] in the subject. See 293227 for an example. That lets the reviewers consider only the final code while you can pick the extra CR for testing,","commit_id":"e09a1f8f99e3ebb7c3e39102397642f1d688e718"}]}