)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2ac13c0a2444528a73c03b7085848444cc878fc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"hidl: Add standard timed_out vibrator service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is what works on most devices from S8 to S10 ..."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I48164e9adfa52cd223c5a2925fa3b48417a6e50c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"96fcb46f_d5c74384","line":9,"range":{"start_line":9,"start_character":50,"end_line":9,"end_character":3},"updated":"2020-05-25 15:57:57.000000000","message":"I\u0027d drop this","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"hidl: Add standard timed_out vibrator service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is what works on most devices from S8 to S10 ..."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I48164e9adfa52cd223c5a2925fa3b48417a6e50c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ebf405ae_fc5d5096","line":9,"range":{"start_line":9,"start_character":50,"end_line":9,"end_character":3},"in_reply_to":"96fcb46f_d5c74384","updated":"2020-05-25 16:06:46.000000000","message":"Done","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"}],"hidl/vibrator/Android.bp":[{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"56ba858800f2e74197c875a3b3c69402c54efdf4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"// Copyright (C) 2019-2020 The LineageOS Project"},{"line_number":2,"context_line":"// Copyright (C) 2020      Andreas Schneider \u003casn@cryptomilk.org\u003e"},{"line_number":3,"context_line":"//"},{"line_number":4,"context_line":"// Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ca4954bd_5b11ff32","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":26},"updated":"2020-05-25 15:50:13.000000000","message":"only 2020","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"// Copyright (C) 2019-2020 The LineageOS Project"},{"line_number":2,"context_line":"// Copyright (C) 2020      Andreas Schneider \u003casn@cryptomilk.org\u003e"},{"line_number":3,"context_line":"//"},{"line_number":4,"context_line":"// Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ff0cda4d_e7018213","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":26},"in_reply_to":"ca4954bd_5b11ff32","updated":"2020-05-25 16:06:46.000000000","message":"Done","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"56ba858800f2e74197c875a3b3c69402c54efdf4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"// Copyright (C) 2019-2020 The LineageOS Project"},{"line_number":2,"context_line":"// Copyright (C) 2020      Andreas Schneider \u003casn@cryptomilk.org\u003e"},{"line_number":3,"context_line":"//"},{"line_number":4,"context_line":"// Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"// you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"69c9e26e_df7e3d95","line":2,"updated":"2020-05-25 15:50:13.000000000","message":"is there a specific reason to add this line?","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2ac13c0a2444528a73c03b7085848444cc878fc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"// Copyright (C) 2019-2020 The LineageOS Project"},{"line_number":2,"context_line":"// Copyright (C) 2020      Andreas Schneider \u003casn@cryptomilk.org\u003e"},{"line_number":3,"context_line":"//"},{"line_number":4,"context_line":"// Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"// you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"be327ad9_a12b8d1d","line":2,"in_reply_to":"69c9e26e_df7e3d95","updated":"2020-05-25 15:57:57.000000000","message":"Usually we don\u0027t add individual copyrights.","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"// Copyright (C) 2019-2020 The LineageOS Project"},{"line_number":2,"context_line":"// Copyright (C) 2020      Andreas Schneider \u003casn@cryptomilk.org\u003e"},{"line_number":3,"context_line":"//"},{"line_number":4,"context_line":"// Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"// you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c6e2782a_bc809793","line":2,"in_reply_to":"be327ad9_a12b8d1d","updated":"2020-05-25 16:06:46.000000000","message":"Done","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"}],"hidl/vibrator/Vibrator.cpp":[{"author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2ac13c0a2444528a73c03b7085848444cc878fc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (C) 2019-2020 The LineageOS Project"},{"line_number":3,"context_line":" * Copyright (C) 2020      Andreas Schneider \u003casn@cryptomilk.org\u003e"},{"line_number":4,"context_line":" *"},{"line_number":5,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7bddc514_5cbb7190","line":2,"updated":"2020-05-25 15:57:57.000000000","message":"Same copyright comments as before","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2ac13c0a2444528a73c03b7085848444cc878fc","unresolved":true,"context_lines":[{"line_number":25,"context_line":"#include \u003chardware/vibrator.h\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#include \u003ccinttypes\u003e"},{"line_number":28,"context_line":"#include \u003ccmath\u003e"},{"line_number":29,"context_line":"#include \u003cfstream\u003e"},{"line_number":30,"context_line":"#include \u003ciostream\u003e"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"f426367e_059df85a","line":28,"updated":"2020-05-25 15:57:57.000000000","message":"usually c* headers are a bit of a red flag - what are we using from cmath?","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":true,"context_lines":[{"line_number":25,"context_line":"#include \u003chardware/vibrator.h\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#include \u003ccinttypes\u003e"},{"line_number":28,"context_line":"#include \u003ccmath\u003e"},{"line_number":29,"context_line":"#include \u003cfstream\u003e"},{"line_number":30,"context_line":"#include \u003ciostream\u003e"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"f3bb00a8_eb476bc2","line":28,"in_reply_to":"f426367e_059df85a","updated":"2020-05-25 16:06:46.000000000","message":"intensity \u003d std::lround((amplitude - 1) * 10000.0 / 254.0);","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2ac13c0a2444528a73c03b7085848444cc878fc","unresolved":true,"context_lines":[{"line_number":29,"context_line":"#include \u003cfstream\u003e"},{"line_number":30,"context_line":"#include \u003ciostream\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"#define INTENSITY_MIN 1000"},{"line_number":33,"context_line":"#define INTENSITY_MAX 10000"},{"line_number":34,"context_line":"#define INENSITY_DEFAULT INTENSITY_MAX"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"#define CLICK_TIMING_MS 20"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#define VIBRATOR_TIMEOUT_PATH \"/sys/class/timed_output/vibrator/enable\""},{"line_number":39,"context_line":"#define VIBRATOR_INTENSITY_PATH \"/sys/class/timed_output/vibrator/intensity\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"namespace android {"},{"line_number":42,"context_line":"namespace hardware {"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f6bb1e8_9f1827a3","line":39,"range":{"start_line":32,"start_character":0,"end_line":39,"end_character":76},"updated":"2020-05-25 15:57:57.000000000","message":"These could go in the header file I think","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#include \u003cfstream\u003e"},{"line_number":30,"context_line":"#include \u003ciostream\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"#define INTENSITY_MIN 1000"},{"line_number":33,"context_line":"#define INTENSITY_MAX 10000"},{"line_number":34,"context_line":"#define INENSITY_DEFAULT INTENSITY_MAX"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"#define CLICK_TIMING_MS 20"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#define VIBRATOR_TIMEOUT_PATH \"/sys/class/timed_output/vibrator/enable\""},{"line_number":39,"context_line":"#define VIBRATOR_INTENSITY_PATH \"/sys/class/timed_output/vibrator/intensity\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"namespace android {"},{"line_number":42,"context_line":"namespace hardware {"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"a5b8475b_80932b9e","line":39,"range":{"start_line":32,"start_character":0,"end_line":39,"end_character":76},"in_reply_to":"1f6bb1e8_9f1827a3","updated":"2020-05-25 16:06:46.000000000","message":"Done","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"56ba858800f2e74197c875a3b3c69402c54efdf4","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    return Status::OK;"},{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"static bool doesNodeExist(const std::string\u0026 path) {"},{"line_number":70,"context_line":"    std::ifstream f(path.c_str());"},{"line_number":71,"context_line":"    return f.good();"},{"line_number":72,"context_line":"}"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"21e3adc1_29ef6d79","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":25},"updated":"2020-05-25 15:50:13.000000000","message":"i still dont like this name, maybe something like \"nodeExist\" makes more sense","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    return Status::OK;"},{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"static bool doesNodeExist(const std::string\u0026 path) {"},{"line_number":70,"context_line":"    std::ifstream f(path.c_str());"},{"line_number":71,"context_line":"    return f.good();"},{"line_number":72,"context_line":"}"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"daac73f0_0bb954e3","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":25},"in_reply_to":"21e3adc1_29ef6d79","updated":"2020-05-25 16:06:46.000000000","message":"Done","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"56ba858800f2e74197c875a3b3c69402c54efdf4","unresolved":true,"context_lines":[{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"static bool doesNodeExist(const std::string\u0026 path) {"},{"line_number":70,"context_line":"    std::ifstream f(path.c_str());"},{"line_number":71,"context_line":"    return f.good();"},{"line_number":72,"context_line":"}"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"d356a949_2a8bcfdf","line":70,"range":{"start_line":70,"start_character":9,"end_line":70,"end_character":18},"updated":"2020-05-25 15:50:13.000000000","message":"ofstream probably makes more sense here since you only write to it","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":false,"context_lines":[{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"static bool doesNodeExist(const std::string\u0026 path) {"},{"line_number":70,"context_line":"    std::ifstream f(path.c_str());"},{"line_number":71,"context_line":"    return f.good();"},{"line_number":72,"context_line":"}"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"e7cd0a71_ffa4400f","line":70,"range":{"start_line":70,"start_character":9,"end_line":70,"end_character":18},"in_reply_to":"d356a949_2a8bcfdf","updated":"2020-05-25 16:06:46.000000000","message":"Done","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2ac13c0a2444528a73c03b7085848444cc878fc","unresolved":true,"context_lines":[{"line_number":263,"context_line":"}"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"const std::string Vibrator::effectToName(Effect effect) {"},{"line_number":266,"context_line":"    return toString(effect);"},{"line_number":267,"context_line":"}"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"const std::string Vibrator::effectStrengthToName(EffectStrength strength) {"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"40584165_b4d72fe6","line":266,"updated":"2020-05-25 15:57:57.000000000","message":"Why do we have these?","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":false,"context_lines":[{"line_number":263,"context_line":"}"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"const std::string Vibrator::effectToName(Effect effect) {"},{"line_number":266,"context_line":"    return toString(effect);"},{"line_number":267,"context_line":"}"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"const std::string Vibrator::effectStrengthToName(EffectStrength strength) {"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"b9a42e38_6559f565","line":266,"in_reply_to":"40584165_b4d72fe6","updated":"2020-05-25 16:06:46.000000000","message":"That we can write LOG() messages.","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"05efefc5a1f3693855095253242d73831ed3874d","unresolved":true,"context_lines":[{"line_number":254,"context_line":"}"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"const std::string Vibrator::effectToName(Effect effect) {"},{"line_number":257,"context_line":"    return toString(effect);"},{"line_number":258,"context_line":"}"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"const std::string Vibrator::effectStrengthToName(EffectStrength strength) {"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"81b55fd5_a2343175","line":257,"updated":"2020-06-03 02:51:18.000000000","message":"cant you just use toString directly instead of wrapping it? i see no reason to add these functions tbh","commit_id":"ee2e2184b6058dbe73e15033dbc3b737f7ae72ff"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ec1b383a473076facc657b50f7074fbbcad91e3e","unresolved":false,"context_lines":[{"line_number":254,"context_line":"}"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"const std::string Vibrator::effectToName(Effect effect) {"},{"line_number":257,"context_line":"    return toString(effect);"},{"line_number":258,"context_line":"}"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"const std::string Vibrator::effectStrengthToName(EffectStrength strength) {"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9a2eb64d_8e6ff044","line":257,"in_reply_to":"81b55fd5_a2343175","updated":"2020-06-03 06:17:25.000000000","message":"No, I can\u0027t and also Google seems to be able as it is in their example. If you get it working feel free to replace it.","commit_id":"ee2e2184b6058dbe73e15033dbc3b737f7ae72ff"},{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a5ba22e5432914fcc420b23db09aa6bd299c3bb9","unresolved":true,"context_lines":[{"line_number":254,"context_line":"}"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"const std::string Vibrator::effectToName(Effect effect) {"},{"line_number":257,"context_line":"    return toString(effect);"},{"line_number":258,"context_line":"}"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"const std::string Vibrator::effectStrengthToName(EffectStrength strength) {"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"e7a719ba_7332f02c","line":257,"in_reply_to":"9a2eb64d_8e6ff044","updated":"2020-06-03 06:31:24.000000000","message":"now im curious /why/ you cant, i just changed it locally and it compiled just fine","commit_id":"ee2e2184b6058dbe73e15033dbc3b737f7ae72ff"},{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"05efefc5a1f3693855095253242d73831ed3874d","unresolved":true,"context_lines":[{"line_number":258,"context_line":"}"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"const std::string Vibrator::effectStrengthToName(EffectStrength strength) {"},{"line_number":261,"context_line":"    return toString(strength);"},{"line_number":262,"context_line":"}"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"}  // namespace implementation"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"c1c6dbd9_b850a485","line":261,"updated":"2020-06-03 02:51:18.000000000","message":"same here","commit_id":"ee2e2184b6058dbe73e15033dbc3b737f7ae72ff"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ec1b383a473076facc657b50f7074fbbcad91e3e","unresolved":false,"context_lines":[{"line_number":258,"context_line":"}"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"const std::string Vibrator::effectStrengthToName(EffectStrength strength) {"},{"line_number":261,"context_line":"    return toString(strength);"},{"line_number":262,"context_line":"}"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"}  // namespace implementation"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"b94017e1_de581936","line":261,"in_reply_to":"c1c6dbd9_b850a485","updated":"2020-06-03 06:17:25.000000000","message":"No, I can\u0027t and also Google seems to be able as it is in their example. If you get it working feel free to replace it.","commit_id":"ee2e2184b6058dbe73e15033dbc3b737f7ae72ff"}],"hidl/vibrator/Vibrator.h":[{"author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2ac13c0a2444528a73c03b7085848444cc878fc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (C) 2019-2020 The LineageOS Project"},{"line_number":3,"context_line":" * Copyright (C) 2020      Andreas Schneider \u003casn@cryptomilk.org\u003e"},{"line_number":4,"context_line":" *"},{"line_number":5,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cc157c75_dd12a71f","line":2,"updated":"2020-05-25 15:57:57.000000000","message":"2020","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (C) 2019-2020 The LineageOS Project"},{"line_number":3,"context_line":" * Copyright (C) 2020      Andreas Schneider \u003casn@cryptomilk.org\u003e"},{"line_number":4,"context_line":" *"},{"line_number":5,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2560f603_caccae83","line":2,"in_reply_to":"cc157c75_dd12a71f","updated":"2020-05-25 16:06:46.000000000","message":"Done","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2ac13c0a2444528a73c03b7085848444cc878fc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (C) 2019-2020 The LineageOS Project"},{"line_number":3,"context_line":" * Copyright (C) 2020      Andreas Schneider \u003casn@cryptomilk.org\u003e"},{"line_number":4,"context_line":" *"},{"line_number":5,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9bc28ab1_fb89d32d","line":3,"updated":"2020-05-25 15:57:57.000000000","message":"We usually don\u0027t do individual copyrights","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (C) 2019-2020 The LineageOS Project"},{"line_number":3,"context_line":" * Copyright (C) 2020      Andreas Schneider \u003casn@cryptomilk.org\u003e"},{"line_number":4,"context_line":" *"},{"line_number":5,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d6498d2e_58228763","line":3,"in_reply_to":"9bc28ab1_fb89d32d","updated":"2020-05-25 16:06:46.000000000","message":"Done","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"56ba858800f2e74197c875a3b3c69402c54efdf4","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    static const std::string effectToName(Effect effect);"},{"line_number":71,"context_line":"    static const std::string effectStrengthToName(EffectStrength effect);"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  private:"},{"line_number":74,"context_line":"    bool mEnabled{false};"},{"line_number":75,"context_line":"    uint8_t mAmplitude{UINT8_MAX};"},{"line_number":76,"context_line":"    bool mExternalControl{false};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"830947a5_694ef873","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":10},"updated":"2020-05-25 15:50:13.000000000","message":"remove","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    static const std::string effectToName(Effect effect);"},{"line_number":71,"context_line":"    static const std::string effectStrengthToName(EffectStrength effect);"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  private:"},{"line_number":74,"context_line":"    bool mEnabled{false};"},{"line_number":75,"context_line":"    uint8_t mAmplitude{UINT8_MAX};"},{"line_number":76,"context_line":"    bool mExternalControl{false};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6cf93f8d_60a923bb","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":10},"in_reply_to":"830947a5_694ef873","updated":"2020-05-25 16:06:46.000000000","message":"Done","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"}],"hidl/vibrator/service.cpp":[{"author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2ac13c0a2444528a73c03b7085848444cc878fc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (C) 2019 The LineageOS Project"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5764ed03_1d773d0a","line":2,"updated":"2020-05-25 15:57:57.000000000","message":"2020","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ccb1173a0db4c46f8d2fc1b8b9e8a0dbef95ca12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (C) 2019 The LineageOS Project"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"284bb501_4108feb3","line":2,"in_reply_to":"5764ed03_1d773d0a","updated":"2020-05-25 16:06:46.000000000","message":"Done","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"56ba858800f2e74197c875a3b3c69402c54efdf4","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    vibrator \u003d new Vibrator();"},{"line_number":44,"context_line":"    if (vibrator \u003d\u003d nullptr) {"},{"line_number":45,"context_line":"        LOG(ERROR) \u003c\u003c \"Can not create an instance of ExynosVibrator HAL IVibrator, \""},{"line_number":46,"context_line":"                      \"exiting.\";"},{"line_number":47,"context_line":"        goto shutdown;"},{"line_number":48,"context_line":"    }"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"d53c31ff_c38f1089","line":45,"range":{"start_line":45,"start_character":53,"end_line":45,"end_character":67},"updated":"2020-05-25 15:50:13.000000000","message":"s/ExynosVibrator/Vibrator/","commit_id":"f2fafea9553ff9ddd601a5f8f0e88dda96507ea0"},{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"05efefc5a1f3693855095253242d73831ed3874d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (C) 2019 The LineageOS Project"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"39a758ec_45327db1","line":2,"range":{"start_line":2,"start_character":17,"end_line":2,"end_character":21},"updated":"2020-06-03 02:51:18.000000000","message":"2020","commit_id":"ee2e2184b6058dbe73e15033dbc3b737f7ae72ff"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ec1b383a473076facc657b50f7074fbbcad91e3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (C) 2019 The LineageOS Project"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"418d2119_1be3bfa2","line":2,"range":{"start_line":2,"start_character":17,"end_line":2,"end_character":21},"in_reply_to":"39a758ec_45327db1","updated":"2020-06-03 06:17:25.000000000","message":"Done","commit_id":"ee2e2184b6058dbe73e15033dbc3b737f7ae72ff"},{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"05efefc5a1f3693855095253242d73831ed3874d","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    status \u003d vibrator-\u003eregisterAsService();"},{"line_number":53,"context_line":"    if (status !\u003d OK) {"},{"line_number":54,"context_line":"        LOG(ERROR) \u003c\u003c \"Could not register service for ExynosVibrator HAL\";"},{"line_number":55,"context_line":"        goto shutdown;"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"15dd177d_b010cbf3","line":54,"range":{"start_line":54,"start_character":54,"end_line":54,"end_character":69},"updated":"2020-06-03 02:51:18.000000000","message":"s/ExynosVibrator/Vibrator/","commit_id":"ee2e2184b6058dbe73e15033dbc3b737f7ae72ff"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ec1b383a473076facc657b50f7074fbbcad91e3e","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    status \u003d vibrator-\u003eregisterAsService();"},{"line_number":53,"context_line":"    if (status !\u003d OK) {"},{"line_number":54,"context_line":"        LOG(ERROR) \u003c\u003c \"Could not register service for ExynosVibrator HAL\";"},{"line_number":55,"context_line":"        goto shutdown;"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"b79af826_729f29b2","line":54,"range":{"start_line":54,"start_character":54,"end_line":54,"end_character":69},"in_reply_to":"15dd177d_b010cbf3","updated":"2020-06-03 06:17:25.000000000","message":"Done","commit_id":"ee2e2184b6058dbe73e15033dbc3b737f7ae72ff"},{"author":{"_account_id":17401,"name":"Jan Altensen","email":"info@stricted.net","username":"Stricted","avatars":[{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c6a78acf6b91723dfca8e18b4b0b7b08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"05efefc5a1f3693855095253242d73831ed3874d","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        goto shutdown;"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    LOG(INFO) \u003c\u003c \"ExynosVibrator HAL service is Ready.\";"},{"line_number":59,"context_line":"    joinRpcThreadpool();"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"shutdown:"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"2903e6e3_c01ae0d5","line":58,"range":{"start_line":58,"start_character":18,"end_line":58,"end_character":32},"updated":"2020-06-03 02:51:18.000000000","message":"s/ExynosVibrator/Vibrator/","commit_id":"ee2e2184b6058dbe73e15033dbc3b737f7ae72ff"},{"author":{"_account_id":2320,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"modpunk","avatars":[{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ff2f1e3c638391229f288e9449c387f3.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ec1b383a473076facc657b50f7074fbbcad91e3e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        goto shutdown;"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    LOG(INFO) \u003c\u003c \"ExynosVibrator HAL service is Ready.\";"},{"line_number":59,"context_line":"    joinRpcThreadpool();"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"shutdown:"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"f8fb08a9_7cc73bb9","line":58,"range":{"start_line":58,"start_character":18,"end_line":58,"end_character":32},"in_reply_to":"2903e6e3_c01ae0d5","updated":"2020-06-03 06:17:25.000000000","message":"Done","commit_id":"ee2e2184b6058dbe73e15033dbc3b737f7ae72ff"}]}