)]}'
{"id":"LineageOS%2Fandroid_hardware_lineage_interfaces~258520","triplet_id":"LineageOS%2Fandroid_hardware_lineage_interfaces~lineage-16.0~I1370680fb45ee5fe5905536193e85636dc65372c","project":"LineageOS/android_hardware_lineage_interfaces","branch":"lineage-16.0","full_branch":"refs/heads/lineage-16.0","hashtags":[],"change_id":"I1370680fb45ee5fe5905536193e85636dc65372c","subject":"IFingerprintInscreen: Add support ambient light for onPress()","status":"ABANDONED","created":"2019-09-18 14:09:19.000000000","updated":"2020-04-21 18:41:45.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6a67e937b1ba59b960e208661f180120d6de31eb","_number":258520,"virtual_id_number":258520,"owner":{"_account_id":13559,"name":"Abhishek Aggarwal","email":"warabhishek@gmail.com","username":"Abhishek","avatars":[{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23283,"name":"Peter Cai","email":"peter@cxy.moe","username":"realPeterCxy","avatars":[{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23283,"name":"Peter Cai","email":"peter@cxy.moe","username":"realPeterCxy","avatars":[{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"_account_id":23283,"name":"Peter Cai","email":"peter@cxy.moe","username":"realPeterCxy","avatars":[{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":23283,"name":"Peter Cai","email":"peter@cxy.moe","username":"realPeterCxy","avatars":[{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-23 07:30:42.000000000","updated_by":{"_account_id":23283,"name":"Peter Cai","email":"peter@cxy.moe","username":"realPeterCxy","avatars":[{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"real_updated_by":{"_account_id":23283,"name":"Peter Cai","email":"peter@cxy.moe","username":"realPeterCxy","avatars":[{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":23283,"name":"Peter Cai","email":"peter@cxy.moe","username":"realPeterCxy","avatars":[{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"86c788c91cb04b19cc8ea8f826c18624202a077c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":13559,"name":"Abhishek Aggarwal","email":"warabhishek@gmail.com","username":"Abhishek","avatars":[{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-18 14:09:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3ba71d716efc72a5e97e5c80ca2d3376321876c6","tag":"autogenerated:gerrit:unsetPrivate","author":{"_account_id":13559,"name":"Abhishek Aggarwal","email":"warabhishek@gmail.com","username":"Abhishek","avatars":[{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-20 12:10:40.000000000","message":"Unset private","accounts_in_message":[],"_revision_number":1},{"id":"ffa6f7c85e87705f96612958296b80a767bc60b9","author":{"_account_id":23283,"name":"Peter Cai","email":"peter@cxy.moe","username":"realPeterCxy","avatars":[{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7789b26409931ee52f89e48985924dc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-23 07:30:42.000000000","message":"Patch Set 1:\n\n1. Why would you need this?\n2. I personally do not like extending an already-existing HIDL interface and breaking all device code. If you absolutely need this, I\u0027d suggest incrementing the interface version code.\n3. I think it is perfectly possible to access the sensor service from your FOD HIDL implementaion. If we extend the interface every time a new sort of data is needed by some device\u0027s FOD HIDL, we wil soon be in the lineage of Chrome and Firefox that has a version code of 100 or something","accounts_in_message":[],"_revision_number":1},{"id":"6a67e937b1ba59b960e208661f180120d6de31eb","tag":"autogenerated:gerrit:abandon","author":{"_account_id":13559,"name":"Abhishek Aggarwal","email":"warabhishek@gmail.com","username":"Abhishek","avatars":[{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-04-21 18:41:45.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8e66068c388a72cd4526c735e765216ea0140dde","revisions":{"8e66068c388a72cd4526c735e765216ea0140dde":{"kind":"REWORK","_number":1,"created":"2019-09-18 14:09:19.000000000","uploader":{"_account_id":13559,"name":"Abhishek Aggarwal","email":"warabhishek@gmail.com","username":"Abhishek","avatars":[{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d34106366ca5d664cb98e05ac5bbc9ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/20/258520/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_hardware_lineage_interfaces","ref":"refs/changes/20/258520/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_hardware_lineage_interfaces refs/changes/20/258520/1 \u0026\u0026 git checkout -b change-258520 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_hardware_lineage_interfaces refs/changes/20/258520/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_hardware_lineage_interfaces refs/changes/20/258520/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_hardware_lineage_interfaces refs/changes/20/258520/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_hardware_lineage_interfaces refs/changes/20/258520/1","Reset To":"git fetch https://github.com/LineageOS/android_hardware_lineage_interfaces refs/changes/20/258520/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c0a938c741e4fdaaf0f7ea3571b3cbad45d9de93","subject":"IFingerprintInscreen: Allow HALs to control position and size","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_hardware_lineage_interfaces/commit/c0a938c741e4fdaaf0f7ea3571b3cbad45d9de93"}]}],"author":{"name":"TheScarastic","email":"warabhishek@gmail.com","date":"2019-09-18 14:04:46.000000000","tz":330},"committer":{"name":"TheScarastic","email":"warabhishek@gmail.com","date":"2019-09-18 14:06:30.000000000","tz":330},"subject":"IFingerprintInscreen: Add support ambient light for onPress()","message":"IFingerprintInscreen: Add support ambient light for onPress()\n\nChange-Id: I1370680fb45ee5fe5905536193e85636dc65372c\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_hardware_lineage_interfaces/commit/8e66068c388a72cd4526c735e765216ea0140dde"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_hardware_lineage_interfaces/commit/8e66068c388a72cd4526c735e765216ea0140dde"}]},"branch":"refs/heads/lineage-16.0"}},"requirements":[],"submit_records":[]}