)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"99c725be244f67fc0727e48acd870d84469f628c","unresolved":true,"context_lines":[{"line_number":11,"context_line":"calling convention and should pass \u0027this ptr\u0027 as the first argument [1]"},{"line_number":12,"context_line":"as well as its return value, at least according ARM ABI [2]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Additionally android::SurfaceComposerClient::Transaction::apply(bool)"},{"line_number":15,"context_line":"shim has void return value instead of status_t so the caller retrieves"},{"line_number":16,"context_line":"random value."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://review.lineageos.org/c/LineageOS/android_device_xiaomi_sdm710-common/+/360011/comments/eb6600df_3e2fb434"},{"line_number":19,"context_line":"[2] https://github.com/ARM-software/abi-aa/blob/617079d8a0d45bec83d351974849483cf0cc66d5/cppabi32/cppabi32.rst?plain\u003d1#L576"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"10c1dccd_f7aedb89","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":13},"updated":"2023-06-28 09:41:32.000000000","message":"Don\u0027t you prefer moving this to a separate change?","commit_id":"d67ae54f8e89f01373dfd59592a0532462f45d20"},{"author":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"01ca44b32043c0b600d5d704a92c4f2c46aaeb45","unresolved":true,"context_lines":[{"line_number":11,"context_line":"calling convention and should pass \u0027this ptr\u0027 as the first argument [1]"},{"line_number":12,"context_line":"as well as its return value, at least according ARM ABI [2]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Additionally android::SurfaceComposerClient::Transaction::apply(bool)"},{"line_number":15,"context_line":"shim has void return value instead of status_t so the caller retrieves"},{"line_number":16,"context_line":"random value."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://review.lineageos.org/c/LineageOS/android_device_xiaomi_sdm710-common/+/360011/comments/eb6600df_3e2fb434"},{"line_number":19,"context_line":"[2] https://github.com/ARM-software/abi-aa/blob/617079d8a0d45bec83d351974849483cf0cc66d5/cppabi32/cppabi32.rst?plain\u003d1#L576"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0bfba89a_593ef5a2","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":13},"in_reply_to":"10c1dccd_f7aedb89","updated":"2023-06-28 09:43:42.000000000","message":"no, this is still ABI issue.","commit_id":"d67ae54f8e89f01373dfd59592a0532462f45d20"}]}