)]}'
{"id":"LineageOS%2Fandroid_hardware_interfaces~399431","triplet_id":"LineageOS%2Fandroid_hardware_interfaces~lineage-20.0~Iee4783217cc88134af6de0fe66128684ca984dba","project":"LineageOS/android_hardware_interfaces","branch":"lineage-20.0","topic":"T_asb_2024-08","hashtags":[],"change_id":"Iee4783217cc88134af6de0fe66128684ca984dba","subject":"Use onUnlinked in health HAL","status":"MERGED","created":"2024-08-09 16:48:28.000000000","updated":"2024-08-12 11:56:58.000000000","submitted":"2024-08-12 11:56:58.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"399431-T_asb_2024-08","meta_rev_id":"095c3f84a13f42f7f34ebbf0aaf4c7a9541eeee6","_number":399431,"virtual_id_number":399431,"owner":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"b144420b9f8da2dfe48621f58645998f2170a3d4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2024-08-09 16:48:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"095c3f84a13f42f7f34ebbf0aaf4c7a9541eeee6","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2024-08-12 11:56:58.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d69eb6560e8ee96f3e16a3612021b8200fe2a6c1","revisions":{"da2fb10ad4ef807ca0f972a4916fe71d8ffddfc2":{"kind":"REWORK","_number":1,"created":"2024-08-09 16:48:28.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/31/399431/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_hardware_interfaces","ref":"refs/changes/31/399431/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/1 \u0026\u0026 git checkout -b change-399431 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/1","Reset To":"git fetch https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f31f7a105851f892c16e25b550ee02c3e071a4d0","subject":"bluetooth: do not fatally error on unknown packet types","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_hardware_interfaces/commit/f31f7a105851f892c16e25b550ee02c3e071a4d0"}]}],"author":{"name":"Devin Moore","email":"devinmoore@google.com","date":"2024-01-19 22:22:01.000000000","tz":0},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2024-08-09 16:24:25.000000000","tz":-360},"subject":"Use onUnlinked in health HAL","message":"Use onUnlinked in health HAL\n\nIt\u0027s possible to get an onBinderDied callback after a call to\nAIBinder_unlinkToDeath() so we can\u0027t delete the objects in callbacks_\nuntil we are done using the void* cookie.\nHandling the cleanup in onBinderUnlinked will handle the case where we\nmanually unlink it as well as the case where it\u0027s unlinked due to death.\n\nTest: atest VtsHalHealthTargetTest\nBug: 319210610\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e5e95bf5759a736f3debc6eb583fb1c82b38d847)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1e1627a5da86782960a157a059aec816be5c82b1)\nMerged-In: Iee4783217cc88134af6de0fe66128684ca984dba\nChange-Id: Iee4783217cc88134af6de0fe66128684ca984dba\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_hardware_interfaces/commit/da2fb10ad4ef807ca0f972a4916fe71d8ffddfc2"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_hardware_interfaces/commit/da2fb10ad4ef807ca0f972a4916fe71d8ffddfc2"}]},"branch":"refs/heads/lineage-20.0"},"d69eb6560e8ee96f3e16a3612021b8200fe2a6c1":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-08-12 11:56:58.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/31/399431/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_hardware_interfaces","ref":"refs/changes/31/399431/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/2 \u0026\u0026 git checkout -b change-399431 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/2","Reset To":"git fetch https://github.com/LineageOS/android_hardware_interfaces refs/changes/31/399431/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ff477f9bcca57cb81a175953b2647f896fd47b8c","subject":"Merge cherrypicks of [\u0027ag/20605249\u0027] into security-aosp-tm-release.","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_hardware_interfaces/commit/ff477f9bcca57cb81a175953b2647f896fd47b8c"}]}],"author":{"name":"Devin Moore","email":"devinmoore@google.com","date":"2024-01-19 22:22:01.000000000","tz":0},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2024-06-06 00:20:12.000000000","tz":0},"subject":"Use onUnlinked in health HAL","message":"Use onUnlinked in health HAL\n\nIt\u0027s possible to get an onBinderDied callback after a call to\nAIBinder_unlinkToDeath() so we can\u0027t delete the objects in callbacks_\nuntil we are done using the void* cookie.\nHandling the cleanup in onBinderUnlinked will handle the case where we\nmanually unlink it as well as the case where it\u0027s unlinked due to death.\n\nTest: atest VtsHalHealthTargetTest\nBug: 319210610\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e5e95bf5759a736f3debc6eb583fb1c82b38d847)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1e1627a5da86782960a157a059aec816be5c82b1)\nMerged-In: Iee4783217cc88134af6de0fe66128684ca984dba\nChange-Id: Iee4783217cc88134af6de0fe66128684ca984dba\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_hardware_interfaces/commit/d69eb6560e8ee96f3e16a3612021b8200fe2a6c1"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_hardware_interfaces/commit/d69eb6560e8ee96f3e16a3612021b8200fe2a6c1"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}