)]}'
{"src/hardware.c":[{"author":{"_account_id":21793,"name":"Aleksandar Petkov","email":"sashko506@gmail.com","username":"sashko9807","avatars":[{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c018801ec297537eb86ca3262d8530439ba57a90","unresolved":true,"context_lines":[{"line_number":1030,"context_line":"#if (SCO_CFG_INCLUDED \u003d\u003d TRUE \u0026\u0026 BTHW_FW_EXTENDED_CONFIGURATION \u003d\u003d TRUE)"},{"line_number":1031,"context_line":"                hw_sco_config_set_params();"},{"line_number":1032,"context_line":"                hw_set_SCO_codec(BTHW_FW_EXTENDED_CONFIGURATION_SCO_CODEC);"},{"line_number":1033,"context_line":"#else"},{"line_number":1034,"context_line":"                bt_vendor_cbacks-\u003efwcfg_cb(BT_VND_OP_RESULT_SUCCESS);"},{"line_number":1035,"context_line":"#endif"},{"line_number":1036,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2ba85783_e9f80a9a","line":1033,"updated":"2019-06-21 22:21:07.000000000","message":"Maybe end the condition here and remove the rest of the fwcfg_cback from the i2s/pcm config related methods?","commit_id":"33e144939b63c7c5ade0f3b4719b24307533fabc"},{"author":{"_account_id":23573,"name":"Dmitry Gruzd","email":"z3dd3r@gmail.com","username":"z3DD3r","avatars":[{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c497aaf44f517b2bdf43a64fb530ca087ac96280","unresolved":true,"context_lines":[{"line_number":1030,"context_line":"#if (SCO_CFG_INCLUDED \u003d\u003d TRUE \u0026\u0026 BTHW_FW_EXTENDED_CONFIGURATION \u003d\u003d TRUE)"},{"line_number":1031,"context_line":"                hw_sco_config_set_params();"},{"line_number":1032,"context_line":"                hw_set_SCO_codec(BTHW_FW_EXTENDED_CONFIGURATION_SCO_CODEC);"},{"line_number":1033,"context_line":"#else"},{"line_number":1034,"context_line":"                bt_vendor_cbacks-\u003efwcfg_cb(BT_VND_OP_RESULT_SUCCESS);"},{"line_number":1035,"context_line":"#endif"},{"line_number":1036,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"688d0300_cb2bdb07","line":1033,"in_reply_to":"2ba85783_e9f80a9a","updated":"2019-06-21 23:44:43.000000000","message":"If we end the condition here then fwcfg_cb will be called before audio codec configuration finish. The entire fix is based on that audio codec configuration must be finished before fwcfg_cb called.","commit_id":"33e144939b63c7c5ade0f3b4719b24307533fabc"},{"author":{"_account_id":23573,"name":"Dmitry Gruzd","email":"z3dd3r@gmail.com","username":"z3DD3r","avatars":[{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4e09f19f545eaced97b30049b94d822d9d0dc095","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"#if (SCO_CFG_INCLUDED \u003d\u003d TRUE \u0026\u0026 BTHW_FW_EXTENDED_CONFIGURATION \u003d\u003d TRUE)"},{"line_number":1031,"context_line":"                hw_sco_config_set_params();"},{"line_number":1032,"context_line":"                hw_set_SCO_codec(BTHW_FW_EXTENDED_CONFIGURATION_SCO_CODEC);"},{"line_number":1033,"context_line":"#else"},{"line_number":1034,"context_line":"                bt_vendor_cbacks-\u003efwcfg_cb(BT_VND_OP_RESULT_SUCCESS);"},{"line_number":1035,"context_line":"#endif"},{"line_number":1036,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8083b20a_9cfcf8d3","line":1033,"in_reply_to":"688d0300_cb2bdb07","updated":"2019-06-22 10:22:15.000000000","message":"Done","commit_id":"33e144939b63c7c5ade0f3b4719b24307533fabc"},{"author":{"_account_id":21793,"name":"Aleksandar Petkov","email":"sashko506@gmail.com","username":"sashko9807","avatars":[{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c018801ec297537eb86ca3262d8530439ba57a90","unresolved":true,"context_lines":[{"line_number":1255,"context_line":"    ALOGI(\"sco I2S/PCM config result %d [0-Success, 1-Fail]\", status);"},{"line_number":1256,"context_line":"    if (bt_vendor_cbacks)"},{"line_number":1257,"context_line":"    {"},{"line_number":1258,"context_line":"#if (SCO_CFG_INCLUDED \u003d\u003d TRUE \u0026\u0026 BTHW_FW_EXTENDED_CONFIGURATION \u003d\u003d TRUE)"},{"line_number":1259,"context_line":"        bt_vendor_cbacks-\u003efwcfg_cb(BT_VND_OP_RESULT_SUCCESS);"},{"line_number":1260,"context_line":"        bt_vendor_cbacks-\u003escocfg_cb(BT_VND_OP_RESULT_SUCCESS);"},{"line_number":1261,"context_line":"#endif"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"08619253_6ba8b81c","line":1258,"updated":"2019-06-21 22:21:07.000000000","message":"No need to check for SCO_CFG_INCLUDED here. The same goes for every other method which already falls into SCO_CFG_INCLUDE\u003d\u003dTRUE condition.","commit_id":"33e144939b63c7c5ade0f3b4719b24307533fabc"},{"author":{"_account_id":23573,"name":"Dmitry Gruzd","email":"z3dd3r@gmail.com","username":"z3DD3r","avatars":[{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c497aaf44f517b2bdf43a64fb530ca087ac96280","unresolved":true,"context_lines":[{"line_number":1255,"context_line":"    ALOGI(\"sco I2S/PCM config result %d [0-Success, 1-Fail]\", status);"},{"line_number":1256,"context_line":"    if (bt_vendor_cbacks)"},{"line_number":1257,"context_line":"    {"},{"line_number":1258,"context_line":"#if (SCO_CFG_INCLUDED \u003d\u003d TRUE \u0026\u0026 BTHW_FW_EXTENDED_CONFIGURATION \u003d\u003d TRUE)"},{"line_number":1259,"context_line":"        bt_vendor_cbacks-\u003efwcfg_cb(BT_VND_OP_RESULT_SUCCESS);"},{"line_number":1260,"context_line":"        bt_vendor_cbacks-\u003escocfg_cb(BT_VND_OP_RESULT_SUCCESS);"},{"line_number":1261,"context_line":"#endif"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"dcc18375_f3d0a02b","line":1258,"in_reply_to":"08619253_6ba8b81c","updated":"2019-06-21 23:44:43.000000000","message":"Nice catch! We can remove it. In fact, this does not change anything, but without this check code will look a bit cleaner.","commit_id":"33e144939b63c7c5ade0f3b4719b24307533fabc"},{"author":{"_account_id":23573,"name":"Dmitry Gruzd","email":"z3dd3r@gmail.com","username":"z3DD3r","avatars":[{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4e09f19f545eaced97b30049b94d822d9d0dc095","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"    ALOGI(\"sco I2S/PCM config result %d [0-Success, 1-Fail]\", status);"},{"line_number":1256,"context_line":"    if (bt_vendor_cbacks)"},{"line_number":1257,"context_line":"    {"},{"line_number":1258,"context_line":"#if (SCO_CFG_INCLUDED \u003d\u003d TRUE \u0026\u0026 BTHW_FW_EXTENDED_CONFIGURATION \u003d\u003d TRUE)"},{"line_number":1259,"context_line":"        bt_vendor_cbacks-\u003efwcfg_cb(BT_VND_OP_RESULT_SUCCESS);"},{"line_number":1260,"context_line":"        bt_vendor_cbacks-\u003escocfg_cb(BT_VND_OP_RESULT_SUCCESS);"},{"line_number":1261,"context_line":"#endif"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"16fd3eff_8ecc222c","line":1258,"in_reply_to":"dcc18375_f3d0a02b","updated":"2019-06-22 10:22:15.000000000","message":"Done","commit_id":"33e144939b63c7c5ade0f3b4719b24307533fabc"},{"author":{"_account_id":21793,"name":"Aleksandar Petkov","email":"sashko506@gmail.com","username":"sashko9807","avatars":[{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c018801ec297537eb86ca3262d8530439ba57a90","unresolved":true,"context_lines":[{"line_number":1503,"context_line":"** Returns          None"},{"line_number":1504,"context_line":"**"},{"line_number":1505,"context_line":"*******************************************************************************/"},{"line_number":1506,"context_line":"void hw_sco_config(void)"},{"line_number":1507,"context_line":"{"},{"line_number":1508,"context_line":"    hw_sco_config_set_params();"},{"line_number":1509,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"fb673915_56edc657","line":1506,"updated":"2019-06-21 22:21:07.000000000","message":"Why is it needed to split the hw_sco_config() into two separate functions?","commit_id":"33e144939b63c7c5ade0f3b4719b24307533fabc"},{"author":{"_account_id":23573,"name":"Dmitry Gruzd","email":"z3dd3r@gmail.com","username":"z3DD3r","avatars":[{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5a1a09afdd21cca5c60c7cdd5986400ac3e7a2ae","unresolved":true,"context_lines":[{"line_number":1503,"context_line":"** Returns          None"},{"line_number":1504,"context_line":"**"},{"line_number":1505,"context_line":"*******************************************************************************/"},{"line_number":1506,"context_line":"void hw_sco_config(void)"},{"line_number":1507,"context_line":"{"},{"line_number":1508,"context_line":"    hw_sco_config_set_params();"},{"line_number":1509,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ec9e53f5_7615d7c4","line":1506,"in_reply_to":"72120b7e_c798c702","updated":"2019-06-22 03:20:36.000000000","message":"Seems i understood your proposal. Here is what we can do:\n1. Remove hw_sco_config_set_params() function\n2. Call hw_set_SCO_codec() inside of hw_sco_config()\n3. Replace calls of the hw_set_SCO_codec() with hw_sco_config()\n\nIn such case we don\u0027t need to split hw_sco_config(). We also can remove changes inside of hw_set_SCO_codec().","commit_id":"33e144939b63c7c5ade0f3b4719b24307533fabc"},{"author":{"_account_id":21793,"name":"Aleksandar Petkov","email":"sashko506@gmail.com","username":"sashko9807","avatars":[{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"959d1a638954e05b5f9bac0f9a77e6d114a27a50","unresolved":true,"context_lines":[{"line_number":1503,"context_line":"** Returns          None"},{"line_number":1504,"context_line":"**"},{"line_number":1505,"context_line":"*******************************************************************************/"},{"line_number":1506,"context_line":"void hw_sco_config(void)"},{"line_number":1507,"context_line":"{"},{"line_number":1508,"context_line":"    hw_sco_config_set_params();"},{"line_number":1509,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"72120b7e_c798c702","line":1506,"in_reply_to":"e5113668_d0d40b17","updated":"2019-06-22 01:13:04.000000000","message":"I don\u0027t think it is needed to set the i2s/pcm parameters in a seperate function. If there is an issue with something inside the hw_sco_config() method which prevents this to work, we could put it inside a condition, and continue the configuration.","commit_id":"33e144939b63c7c5ade0f3b4719b24307533fabc"},{"author":{"_account_id":23573,"name":"Dmitry Gruzd","email":"z3dd3r@gmail.com","username":"z3DD3r","avatars":[{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4e09f19f545eaced97b30049b94d822d9d0dc095","unresolved":false,"context_lines":[{"line_number":1503,"context_line":"** Returns          None"},{"line_number":1504,"context_line":"**"},{"line_number":1505,"context_line":"*******************************************************************************/"},{"line_number":1506,"context_line":"void hw_sco_config(void)"},{"line_number":1507,"context_line":"{"},{"line_number":1508,"context_line":"    hw_sco_config_set_params();"},{"line_number":1509,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"341a4378_50cad7d1","line":1506,"in_reply_to":"ec9e53f5_7615d7c4","updated":"2019-06-22 10:22:15.000000000","message":"Done","commit_id":"33e144939b63c7c5ade0f3b4719b24307533fabc"},{"author":{"_account_id":23573,"name":"Dmitry Gruzd","email":"z3dd3r@gmail.com","username":"z3DD3r","avatars":[{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c497aaf44f517b2bdf43a64fb530ca087ac96280","unresolved":true,"context_lines":[{"line_number":1503,"context_line":"** Returns          None"},{"line_number":1504,"context_line":"**"},{"line_number":1505,"context_line":"*******************************************************************************/"},{"line_number":1506,"context_line":"void hw_sco_config(void)"},{"line_number":1507,"context_line":"{"},{"line_number":1508,"context_line":"    hw_sco_config_set_params();"},{"line_number":1509,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e5113668_d0d40b17","line":1506,"in_reply_to":"fb673915_56edc657","updated":"2019-06-21 23:44:43.000000000","message":"We must configure SCO related parameters (bt_sco_i2spcm_param , sco_bus_clock_rate , sco_bus_wbs_clock_rate) because hw_set_SCO_codec() will call the hw_sco_i2spcm_config() in the end of the whole chain and hw_sco_i2spcm_config() uses these parameters. Please note that  hw_sco_config() is the only method who configures the SCO related parameters but it is not used when hw_set_SCO_codec() called. Thats why we need to split hw_sco_config() and call the hw_sco_config_set_params() right before the hw_set_SCO_codec(BTHW_FW_EXTENDED_CONFIGURATION_SCO_CODEC);","commit_id":"33e144939b63c7c5ade0f3b4719b24307533fabc"},{"author":{"_account_id":21793,"name":"Aleksandar Petkov","email":"sashko506@gmail.com","username":"sashko9807","avatars":[{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"deac5088993909ce4e1b5d67562ae91fe1fcf24e","unresolved":true,"context_lines":[{"line_number":288,"context_line":"/******************************************************************************"},{"line_number":289,"context_line":"**  SCO configuration related functions"},{"line_number":290,"context_line":"******************************************************************************/"},{"line_number":291,"context_line":"#if (SCO_CFG_INCLUDED \u003d\u003d TRUE)"},{"line_number":292,"context_line":"void hw_sco_config(void);"},{"line_number":293,"context_line":"static int hw_set_SCO_codec(uint16_t codec);"},{"line_number":294,"context_line":"#endif"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7b1eee7c_da9bef20","line":291,"updated":"2019-06-27 23:12:33.000000000","message":"SCO_CFG_INCLUDED is TRUE by default, would better to add BTHW_FW_EXTENDED_CONFIGURATION \u003d\u003d TRUE inside the condition aswell.","commit_id":"f12f24691f836315f6b5840f7373a6a5faec1470"},{"author":{"_account_id":23573,"name":"Dmitry Gruzd","email":"z3dd3r@gmail.com","username":"z3DD3r","avatars":[{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8a02b82e85992ca65e659b680bdc11e436a21877","unresolved":false,"context_lines":[{"line_number":288,"context_line":"/******************************************************************************"},{"line_number":289,"context_line":"**  SCO configuration related functions"},{"line_number":290,"context_line":"******************************************************************************/"},{"line_number":291,"context_line":"#if (SCO_CFG_INCLUDED \u003d\u003d TRUE)"},{"line_number":292,"context_line":"void hw_sco_config(void);"},{"line_number":293,"context_line":"static int hw_set_SCO_codec(uint16_t codec);"},{"line_number":294,"context_line":"#endif"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"087ffa2e_d508fdeb","line":291,"in_reply_to":"7b1eee7c_da9bef20","updated":"2019-06-28 15:24:59.000000000","message":"Default value of the SCO_CFG_INCLUDED doesn\u0027t matter. SCO_CFG_INCLUDED is used here only because implementation of these two methods is wrapped with #if (SCO_CFG_INCLUDED \u003d\u003d TRUE)\n\nAlso BTHW_FW_EXTENDED_CONFIGURATION should be omitted here because:\n* BTHW_FW_EXTENDED_CONFIGURATION doesn\u0027t related to declaration of hw_sco_config() and hw_set_SCO_codec(). We should be able to use these functions without BTHW_FW_EXTENDED_CONFIGURATION if necessary.\n* It is just a forward declaration which does not change anything in logic, performance or compilation time even if BTHW_FW_EXTENDED_CONFIGURATION is not set to TRUE.\n* Code looks cleaner without BTHW_FW_EXTENDED_CONFIGURATION","commit_id":"f12f24691f836315f6b5840f7373a6a5faec1470"},{"author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"46e92488972a7d91e9776d5684f4989f0037332a","unresolved":true,"context_lines":[{"line_number":1667,"context_line":"        else"},{"line_number":1668,"context_line":"        {"},{"line_number":1669,"context_line":"            /* Disable mSBC */"},{"line_number":1670,"context_line":"            *p++ \u003d SCO_CODEC_PARAM_SIZE; /* set the parameter size */"},{"line_number":1671,"context_line":"            UINT8_TO_STREAM(p,0); /* disable */"},{"line_number":1672,"context_line":"            UINT16_TO_STREAM(p, 0);"},{"line_number":1673,"context_line":""},{"line_number":1674,"context_line":"            /* set the totall size of this packet */"},{"line_number":1675,"context_line":"            p_buf-\u003elen \u003d HCI_CMD_PREAMBLE_SIZE + SCO_CODEC_PARAM_SIZE;"},{"line_number":1676,"context_line":""},{"line_number":1677,"context_line":"            p_set_SCO_codec_cback \u003d hw_set_CVSD_codec_cback;"},{"line_number":1678,"context_line":"            if ((codec !\u003d SCO_CODEC_CVSD) \u0026\u0026 (codec !\u003d SCO_CODEC_NONE))"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"38cde909_25530fbb","line":1675,"range":{"start_line":1670,"start_character":0,"end_line":1675,"end_character":70},"updated":"2019-07-19 03:05:10.000000000","message":"Is this part something that is technically correct independent of the rest of this change? If so, it should really be a separate change.","commit_id":"f12f24691f836315f6b5840f7373a6a5faec1470"},{"author":{"_account_id":21793,"name":"Aleksandar Petkov","email":"sashko506@gmail.com","username":"sashko9807","avatars":[{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/67c40235e7f8530ccb2f373306a73c3f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f79360c05c7ebcfbc5655fca82397deb3aaaf670","unresolved":true,"context_lines":[{"line_number":1667,"context_line":"        else"},{"line_number":1668,"context_line":"        {"},{"line_number":1669,"context_line":"            /* Disable mSBC */"},{"line_number":1670,"context_line":"            *p++ \u003d SCO_CODEC_PARAM_SIZE; /* set the parameter size */"},{"line_number":1671,"context_line":"            UINT8_TO_STREAM(p,0); /* disable */"},{"line_number":1672,"context_line":"            UINT16_TO_STREAM(p, 0);"},{"line_number":1673,"context_line":""},{"line_number":1674,"context_line":"            /* set the totall size of this packet */"},{"line_number":1675,"context_line":"            p_buf-\u003elen \u003d HCI_CMD_PREAMBLE_SIZE + SCO_CODEC_PARAM_SIZE;"},{"line_number":1676,"context_line":""},{"line_number":1677,"context_line":"            p_set_SCO_codec_cback \u003d hw_set_CVSD_codec_cback;"},{"line_number":1678,"context_line":"            if ((codec !\u003d SCO_CODEC_CVSD) \u0026\u0026 (codec !\u003d SCO_CODEC_NONE))"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"70d4c64a_1567376a","line":1675,"range":{"start_line":1670,"start_character":0,"end_line":1675,"end_character":70},"in_reply_to":"38cde909_25530fbb","updated":"2019-08-02 13:55:30.000000000","message":"Not really related, to this hack\nhttps://android-review.googlesource.com/c/platform/hardware/broadcom/libbt/+/214636","commit_id":"f12f24691f836315f6b5840f7373a6a5faec1470"},{"author":{"_account_id":23573,"name":"Dmitry Gruzd","email":"z3dd3r@gmail.com","username":"z3DD3r","avatars":[{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/703416f7c2c7a43659660b68c5d17811.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7959cabc1ffb83f9493aa6bf99dbcaec4e5a4b89","unresolved":false,"context_lines":[{"line_number":1667,"context_line":"        else"},{"line_number":1668,"context_line":"        {"},{"line_number":1669,"context_line":"            /* Disable mSBC */"},{"line_number":1670,"context_line":"            *p++ \u003d SCO_CODEC_PARAM_SIZE; /* set the parameter size */"},{"line_number":1671,"context_line":"            UINT8_TO_STREAM(p,0); /* disable */"},{"line_number":1672,"context_line":"            UINT16_TO_STREAM(p, 0);"},{"line_number":1673,"context_line":""},{"line_number":1674,"context_line":"            /* set the totall size of this packet */"},{"line_number":1675,"context_line":"            p_buf-\u003elen \u003d HCI_CMD_PREAMBLE_SIZE + SCO_CODEC_PARAM_SIZE;"},{"line_number":1676,"context_line":""},{"line_number":1677,"context_line":"            p_set_SCO_codec_cback \u003d hw_set_CVSD_codec_cback;"},{"line_number":1678,"context_line":"            if ((codec !\u003d SCO_CODEC_CVSD) \u0026\u0026 (codec !\u003d SCO_CODEC_NONE))"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7d90b6c7_cb39cc93","line":1675,"range":{"start_line":1670,"start_character":0,"end_line":1675,"end_character":70},"in_reply_to":"70d4c64a_1567376a","updated":"2019-08-02 16:11:25.000000000","message":"Done","commit_id":"f12f24691f836315f6b5840f7373a6a5faec1470"}]}