)]}'
{"id":"LineageOS%2Fandroid_frameworks_opt_telephony~450864","triplet_id":"LineageOS%2Fandroid_frameworks_opt_telephony~lineage-20.0~I7252c692eb2a5ff4b4fcbddba77425cb423539f3","project":"LineageOS/android_frameworks_opt_telephony","branch":"lineage-20.0","topic":"T_asb_2025-09","attention_set":{},"removed_from_attention_set":{"17656":{"account":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"last_update":"2025-12-19 21:04:17.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7252c692eb2a5ff4b4fcbddba77425cb423539f3","subject":"Remove get/set of voicemail ringtone uri in shared preferences.","status":"MERGED","created":"2025-09-09 16:44:16.000000000","updated":"2025-12-19 21:04:17.000000000","submitted":"2025-12-19 21:04:17.000000000","submitter":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"450864-T_asb_2025-09","meta_rev_id":"ca02ca7699f94838c173a42fe811aaf95b424a86","_number":450864,"virtual_id_number":450864,"owner":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":1,"date":"2025-12-19 20:52:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":2,"date":"2025-12-19 20:52:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-19 20:52:13.000000000","updated_by":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"50bcf7567ab153ad5dbf7b5168d4939293156d41","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-09-09 16:44:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ffdaf07d4611484725f5c1c204f23d248586694a","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-09-09 16:44:29.000000000","message":"Topic set to T_asb_2025-09","accounts_in_message":[],"_revision_number":1},{"id":"11097928504b84a697069bced67237ebe397f875","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-12-17 20:16:53.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"2844473170787e7e6d27d00a488d36c1ca267437","author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-12-19 20:52:13.000000000","message":"Patch Set 2: Code-Review+2 Verified+1","accounts_in_message":[],"_revision_number":2},{"id":"ca02ca7699f94838c173a42fe811aaf95b424a86","tag":"autogenerated:gerrit:merged","author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-12-19 21:04:17.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4d52bf7257c7c40f2c7f5fdac9c7315abec75bc1","revisions":{"f85939e0615ce32f62d7f78a39cf6796b6fb7f98":{"kind":"REWORK","_number":1,"created":"2025-09-09 16:44:16.000000000","uploader":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/64/450864/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_frameworks_opt_telephony","ref":"refs/changes/64/450864/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/1 \u0026\u0026 git checkout -b change-450864 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/1","Reset To":"git fetch https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"84e045d8f5c843dc6ebf44416e6471dc2598f63d","subject":"Revert \"Clear up the obsoleted cascading signal strength polling logic\"","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_opt_telephony/commit/84e045d8f5c843dc6ebf44416e6471dc2598f63d"}]}],"author":{"name":"Tyler Gunn","email":"tgunn@google.com","date":"2025-04-22 22:01:54.000000000","tz":0},"committer":{"name":"mse1969","email":"mse1969@posteo.de","date":"2025-09-09 10:17:57.000000000","tz":120},"subject":"Remove get/set of voicemail ringtone uri in shared preferences.","message":"Remove get/set of voicemail ringtone uri in shared preferences.\n\nPrior to Android P, TelephonyManager#setVoicemailRingtoneUri was used\nby the dialer app to set the voicemail notification sound played when\nthe platform got a new voicemail notification.  Likewise,\ngetVoicemailRingtoneUri was used to retrieve the set value.\n\nPrior to P this was just saved in the shared prefs, but after P a\nmigration was done to move the shared preference to the\nNotificationChannel#getSound for the voicemail notification.  If, however,\nyou called `setVoicemailRingtoneUri` it was still possible to change the\nshared preference and have that migrated to be set on the notification\nchannel, causing a cross-profile exploit.\n\nIn the current world, the notifications for voicemail are NOT posted in\nTelephony any more, and are instead associated with the notification\nchannel for voicemail IN the dialer app.  On the off chance a dialer does\nnot show the voicemail notification, Telephony can post it as well, but\nat this point the related sound is expected to be associated with the\nnotification channel.\n\nTo mitigate this cross-profile vulnerability:\n1. Ensure TelephonyManager#setVoicemailRingtoneUri does not save to shared\npreferences any more.\n2. Ensure the TelephonyManager#getVoicemailRingtoneUrigetRingtoneUri ONLY\nqueries from the notification channel, and not from the shared\npreferences since that is not used.  This ensures we can never return a\nbad URI set via the setter.\n3. Remove the code in migrateVoicemailNotificationSettings which will take\nthe shared preference and migrate it over to the channel; this is not\nneeded as realistically ANY device from P would have updated LONG ago and\nhad its notification setting migrated to the channel anyways.\n\nTest: Change the default voicemail notification channel sound on\n\"phone services\"; verify that Dialer can still get this value.\nTest: Changed the voicemail notification channel in the dialer app so that\nit has a different value; verify that voicemail notifications use the\ncorrect sound.\nFlag: EXEMPT security patch.\nBug: 325030433\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8e47af093625b997ffb8ca0379a4a56c02ddeb20)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5057ee3badc307777a961daafe94471ffcaf577e)\nMerged-In: I7252c692eb2a5ff4b4fcbddba77425cb423539f3\nChange-Id: I7252c692eb2a5ff4b4fcbddba77425cb423539f3\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_opt_telephony/commit/f85939e0615ce32f62d7f78a39cf6796b6fb7f98"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_opt_telephony/commit/f85939e0615ce32f62d7f78a39cf6796b6fb7f98"}]},"branch":"refs/heads/lineage-20.0"},"4d52bf7257c7c40f2c7f5fdac9c7315abec75bc1":{"kind":"NO_CHANGE","_number":2,"created":"2025-12-17 20:16:53.000000000","uploader":{"_account_id":17656,"name":"Markus S","email":"mse1969@posteo.de","username":"mse1969","avatars":[{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/faf0a883d71780207ed87e774bfbaff0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/64/450864/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_frameworks_opt_telephony","ref":"refs/changes/64/450864/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/2 \u0026\u0026 git checkout -b change-450864 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/2","Reset To":"git fetch https://github.com/LineageOS/android_frameworks_opt_telephony refs/changes/64/450864/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"84e045d8f5c843dc6ebf44416e6471dc2598f63d","subject":"Revert \"Clear up the obsoleted cascading signal strength polling logic\"","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_opt_telephony/commit/84e045d8f5c843dc6ebf44416e6471dc2598f63d"}]}],"author":{"name":"Tyler Gunn","email":"tgunn@google.com","date":"2025-04-22 22:01:54.000000000","tz":0},"committer":{"name":"mse1969","email":"mse1969@posteo.de","date":"2025-12-13 16:30:57.000000000","tz":60},"subject":"Remove get/set of voicemail ringtone uri in shared preferences.","message":"Remove get/set of voicemail ringtone uri in shared preferences.\n\nPrior to Android P, TelephonyManager#setVoicemailRingtoneUri was used\nby the dialer app to set the voicemail notification sound played when\nthe platform got a new voicemail notification.  Likewise,\ngetVoicemailRingtoneUri was used to retrieve the set value.\n\nPrior to P this was just saved in the shared prefs, but after P a\nmigration was done to move the shared preference to the\nNotificationChannel#getSound for the voicemail notification.  If, however,\nyou called `setVoicemailRingtoneUri` it was still possible to change the\nshared preference and have that migrated to be set on the notification\nchannel, causing a cross-profile exploit.\n\nIn the current world, the notifications for voicemail are NOT posted in\nTelephony any more, and are instead associated with the notification\nchannel for voicemail IN the dialer app.  On the off chance a dialer does\nnot show the voicemail notification, Telephony can post it as well, but\nat this point the related sound is expected to be associated with the\nnotification channel.\n\nTo mitigate this cross-profile vulnerability:\n1. Ensure TelephonyManager#setVoicemailRingtoneUri does not save to shared\npreferences any more.\n2. Ensure the TelephonyManager#getVoicemailRingtoneUrigetRingtoneUri ONLY\nqueries from the notification channel, and not from the shared\npreferences since that is not used.  This ensures we can never return a\nbad URI set via the setter.\n3. Remove the code in migrateVoicemailNotificationSettings which will take\nthe shared preference and migrate it over to the channel; this is not\nneeded as realistically ANY device from P would have updated LONG ago and\nhad its notification setting migrated to the channel anyways.\n\nTest: Change the default voicemail notification channel sound on\n\"phone services\"; verify that Dialer can still get this value.\nTest: Changed the voicemail notification channel in the dialer app so that\nit has a different value; verify that voicemail notifications use the\ncorrect sound.\nFlag: EXEMPT security patch.\nBug: 325030433\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8e47af093625b997ffb8ca0379a4a56c02ddeb20)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5057ee3badc307777a961daafe94471ffcaf577e)\nMerged-In: I7252c692eb2a5ff4b4fcbddba77425cb423539f3\nChange-Id: I7252c692eb2a5ff4b4fcbddba77425cb423539f3\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_opt_telephony/commit/4d52bf7257c7c40f2c7f5fdac9c7315abec75bc1"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_opt_telephony/commit/4d52bf7257c7c40f2c7f5fdac9c7315abec75bc1"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[],"atom_explanations":{}}}]}