)]}'
{"id":"LineageOS%2Fandroid_frameworks_base~64925","triplet_id":"LineageOS%2Fandroid_frameworks_base~cm-14.1~I2f67d991cc4038e56b3b630705d93f3ae6458c48","project":"LineageOS/android_frameworks_base","branch":"cm-14.1","hashtags":[],"change_id":"I2f67d991cc4038e56b3b630705d93f3ae6458c48","subject":"Allow location providers also outside of /system","status":"ABANDONED","created":"2016-12-14 07:33:42.000000000","updated":"2017-01-29 08:45:59.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9bd50c7eeb9c5d3f645fc65cbe718f2883c5c0cd","_number":64925,"virtual_id_number":64925,"owner":{"_account_id":16293,"name":"Luca Benci","email":"benci.luca@gmail.com","username":"7lb","avatars":[{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"date":"2016-12-22 00:15:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16,"name":"Björn Lundén (blunden)","email":"blunden2@gmail.com","username":"blunden","avatars":[{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"date":"2016-12-16 07:24:02.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16293,"name":"Luca Benci","email":"benci.luca@gmail.com","username":"7lb","avatars":[{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"date":"2016-12-22 00:15:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":3671,"name":"Dan Pasanen","email":"dan.pasanen@gmail.com","username":"invisiblek","avatars":[{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"date":"2016-12-22 00:15:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6392,"name":"Tim Sinthofen","email":"t.sinthofen@gmx.de","username":"roxxor","avatars":[{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"date":"2016-12-22 00:15:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":3672,"name":"Abhisek Devkota","email":"abedev@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},{"value":0,"date":"2016-12-16 10:12:06.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7148,"name":"Kilian von Pflugk","email":"gerrit@jumoog.io","username":"jumoog","avatars":[{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"date":"2016-12-22 00:15:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6334,"name":"Brandon McAnsh","email":"brandon.mcansh@gmail.com","username":"bmc08gt","avatars":[{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"disliked":{"_account_id":6334,"name":"Brandon McAnsh","email":"brandon.mcansh@gmail.com","username":"bmc08gt","avatars":[{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":-1,"date":"2016-12-14 17:27:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16,"name":"Björn Lundén (blunden)","email":"blunden2@gmail.com","username":"blunden","avatars":[{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"date":"2016-12-22 00:15:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16293,"name":"Luca Benci","email":"benci.luca@gmail.com","username":"7lb","avatars":[{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":-1,"date":"2016-12-15 19:41:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":3671,"name":"Dan Pasanen","email":"dan.pasanen@gmail.com","username":"invisiblek","avatars":[{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":1,"date":"2016-12-15 19:05:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6392,"name":"Tim Sinthofen","email":"t.sinthofen@gmx.de","username":"roxxor","avatars":[{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"date":"2016-12-14 17:27:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":3672,"name":"Abhisek Devkota","email":"abedev@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},{"value":0,"date":"2016-12-22 00:15:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7148,"name":"Kilian von Pflugk","email":"gerrit@jumoog.io","username":"jumoog","avatars":[{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":-1,"date":"2016-12-15 19:06:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6334,"name":"Brandon McAnsh","email":"brandon.mcansh@gmail.com","username":"bmc08gt","avatars":[{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0},"CI":{"all":[{"_account_id":16,"name":"Björn Lundén (blunden)","email":"blunden2@gmail.com","username":"blunden","avatars":[{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":16293,"name":"Luca Benci","email":"benci.luca@gmail.com","username":"7lb","avatars":[{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":3671,"name":"Dan Pasanen","email":"dan.pasanen@gmail.com","username":"invisiblek","avatars":[{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":6392,"name":"Tim Sinthofen","email":"t.sinthofen@gmx.de","username":"roxxor","avatars":[{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":3672,"name":"Abhisek Devkota","email":"abedev@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},{"_account_id":7148,"name":"Kilian von Pflugk","email":"gerrit@jumoog.io","username":"jumoog","avatars":[{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":6334,"name":"Brandon McAnsh","email":"brandon.mcansh@gmail.com","username":"bmc08gt","avatars":[{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16,"name":"Björn Lundén (blunden)","email":"blunden2@gmail.com","username":"blunden","avatars":[{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":3671,"name":"Dan Pasanen","email":"dan.pasanen@gmail.com","username":"invisiblek","avatars":[{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":3672,"name":"Abhisek Devkota","email":"abedev@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},{"_account_id":6334,"name":"Brandon McAnsh","email":"brandon.mcansh@gmail.com","username":"bmc08gt","avatars":[{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":6392,"name":"Tim Sinthofen","email":"t.sinthofen@gmx.de","username":"roxxor","avatars":[{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":7148,"name":"Kilian von Pflugk","email":"gerrit@jumoog.io","username":"jumoog","avatars":[{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":16293,"name":"Luca Benci","email":"benci.luca@gmail.com","username":"7lb","avatars":[{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-16 10:12:06.000000000","updated_by":{"_account_id":7148,"name":"Kilian von Pflugk","email":"gerrit@jumoog.io","username":"jumoog","avatars":[{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":7148,"name":"Kilian von Pflugk","email":"gerrit@jumoog.io","username":"jumoog","avatars":[{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2016-12-22 00:15:46.000000000","updated_by":{"_account_id":16,"name":"Björn Lundén (blunden)","email":"blunden2@gmail.com","username":"blunden","avatars":[{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":16,"name":"Björn Lundén (blunden)","email":"blunden2@gmail.com","username":"blunden","avatars":[{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2016-12-22 00:15:46.000000000","updated_by":{"_account_id":3671,"name":"Dan Pasanen","email":"dan.pasanen@gmail.com","username":"invisiblek","avatars":[{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":3671,"name":"Dan Pasanen","email":"dan.pasanen@gmail.com","username":"invisiblek","avatars":[{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2016-12-22 00:15:46.000000000","updated_by":{"_account_id":3672,"name":"Abhisek Devkota","email":"abedev@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"reviewer":{"_account_id":3672,"name":"Abhisek Devkota","email":"abedev@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9783a1d90357ec42d6c19c18cfff6c0a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"state":"REVIEWER"},{"updated":"2016-12-22 00:15:46.000000000","updated_by":{"_account_id":6334,"name":"Brandon McAnsh","email":"brandon.mcansh@gmail.com","username":"bmc08gt","avatars":[{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":6334,"name":"Brandon McAnsh","email":"brandon.mcansh@gmail.com","username":"bmc08gt","avatars":[{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2016-12-22 00:15:46.000000000","updated_by":{"_account_id":6392,"name":"Tim Sinthofen","email":"t.sinthofen@gmx.de","username":"roxxor","avatars":[{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":6392,"name":"Tim Sinthofen","email":"t.sinthofen@gmx.de","username":"roxxor","avatars":[{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"db22989eabdc5f90d8fddb2f20556c04a1492e6d","author":{"_account_id":16293,"name":"Luca Benci","email":"benci.luca@gmail.com","username":"7lb","avatars":[{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-14 07:33:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"422cfbb9575359a84811d8bbf996456450d4760c","author":{"_account_id":16293,"name":"Luca Benci","email":"benci.luca@gmail.com","username":"7lb","avatars":[{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-14 09:33:31.000000000","message":"Patch Set 1:\n\nThis is needed for network location providers not installed as system apps (e.g. microg\u0027s UnifiedNlp) to be used by android.\n\nUp to android 6 this was the standard behaviour (see https://code.google.com/p/android/issues/detail?id\u003d226358)","accounts_in_message":[],"_revision_number":1},{"id":"92b34fa8feb94070b7904ce73d0d7ca7ff392e7d","author":{"_account_id":16,"name":"Björn Lundén (blunden)","email":"blunden2@gmail.com","username":"blunden","avatars":[{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99b3d0b30f6a3f2a61890354bc375df6.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-14 17:27:39.000000000","message":"Patch Set 1: Code-Review-1\n\nThe relevant part of the commit message that changed this is:\n\n\"Make ServiceWatcher stricter by requiring that the matching package be in the system image.\"\n\nThat sounds like a change potentially made for security reasons to me. I think we need to be careful when considering this change.","accounts_in_message":[],"_revision_number":1},{"id":"98f6206a4eecec0f88fc5782699afe20d0bc3ace","author":{"_account_id":16293,"name":"Luca Benci","email":"benci.luca@gmail.com","username":"7lb","avatars":[{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-15 07:22:58.000000000","message":"Patch Set 1:\n\nAgreed, but it\u0027s also a functionality regression. This way, users can no longer select a non-google location provider without rooting the device, since no nlp is provided by AOSP.\n\nIdeally, this should be reverted upstream, or a way for non-root users to select the network location provider to use by the system should be provided.","accounts_in_message":[],"_revision_number":1},{"id":"49062d1af3c9e67b90009b896c81ba3180a45824","author":{"_account_id":6392,"name":"Tim Sinthofen","email":"t.sinthofen@gmx.de","username":"roxxor","avatars":[{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7f8663472a7eb7ab49ae370564990ed0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-15 19:05:48.000000000","message":"Patch Set 1: Code-Review+1\n\nI support this patch, as this is essential to obtain network location for GAPPs free devices.\nAlternatively CM could also simply ship with UnifiedNLP ;)","accounts_in_message":[],"_revision_number":1},{"id":"a23dfce1420ad97bb0f58febf161f9f9b8416642","author":{"_account_id":6334,"name":"Brandon McAnsh","email":"brandon.mcansh@gmail.com","username":"bmc08gt","avatars":[{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6ed4af883db831af7002b231c3914998.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-15 19:06:51.000000000","message":"Patch Set 1: Code-Review-1\n\nfrom a security standpoint, i dislike this","accounts_in_message":[],"_revision_number":1},{"id":"a9696fa578fb3d0c05f96ee6960adddf17c26de8","author":{"_account_id":3671,"name":"Dan Pasanen","email":"dan.pasanen@gmail.com","username":"invisiblek","avatars":[{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-15 19:41:09.000000000","message":"Patch Set 1: Code-Review-1\n\nYea, agreed. Reverting AOSP security patches is generally a bad idea. GAPPS gets around this by being shipped on /system, UnifiedNlp could do the same.","accounts_in_message":[],"_revision_number":1},{"id":"5873335df6aede375158125a054d253c6c9f88f7","author":{"_account_id":16293,"name":"Luca Benci","email":"benci.luca@gmail.com","username":"7lb","avatars":[{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-16 07:24:02.000000000","message":"Patch Set 1:\n\nI suppose the cyanogenmod team would not be willing to include UnifiedNlp as default network location provider, would it?\n\nNot that I have asked the UnifiedNlp team if they would be willing to have it ship by default on CM, I\u0027m just asking.","accounts_in_message":[],"_revision_number":1},{"id":"483343fcc7ac61eabcccd5e83bc566c53ca15ffe","author":{"_account_id":7148,"name":"Kilian von Pflugk","email":"gerrit@jumoog.io","username":"jumoog","avatars":[{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fe051145a20439afc55b95305f3bfb16.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-16 10:12:06.000000000","message":"Patch Set 1:\n\neven the offical readme tells you to put it under system: https://github.com/microg/android_packages_apps_UnifiedNlp#android-44---60-kitkat--lollipop--marshmallow","accounts_in_message":[],"_revision_number":1},{"id":"6622127fd7c30a2a7ef1a670a762de152a241a34","author":{"_account_id":16301,"name":"importer-bot","username":"importer-bot","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-17 03:04:53.000000000","message":"Imported from https://review.cyanogenmod.org/177082","accounts_in_message":[],"_revision_number":1},{"id":"e0746fb49ce6028a06951d2d3d57cd6fd052ad0f","author":{"_account_id":16293,"name":"Luca Benci","email":"benci.luca@gmail.com","username":"7lb","avatars":[{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-20 07:38:41.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"6939895dcc0320e35bb485f83669f8f6b23382f3","author":{"_account_id":16301,"name":"importer-bot","username":"importer-bot","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2016-12-22 00:15:47.000000000","message":"Resumed import of https://review.cyanogenmod.org/177082","accounts_in_message":[],"_revision_number":1},{"id":"c65805528ff54020deb1a9ad30fec54fb9179c92","author":{"_account_id":13914,"name":"la|r|ma","email":"cm@larma.de","username":"la_r_ma","avatars":[{"url":"https://www.gravatar.com/avatar/c1f11386a16e5808e6d61dd21f7ff61d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c1f11386a16e5808e6d61dd21f7ff61d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c1f11386a16e5808e6d61dd21f7ff61d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c1f11386a16e5808e6d61dd21f7ff61d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2017-01-26 12:45:18.000000000","message":"Patch Set 1:\n\nPlease reconsider this patch. \n\nThe decision from Google was not because of security concerns of external location providers (external location providers are not granted any additional permissions, only the ability to set the current network-based location, hardly a security issue).\n\nIt was done in an attempt to make this part working properly with file-based encryption. You can see this easily by looking at the commit history on this file: A first commit added a flag MATCH_ENCRYPTION_AWARE_AND_UNAWARE [1] which apparently did not result in the desired effect (because in fact it did not work with file-based encryption because this code is not executed again after unlocking the file-based encryption). So they \"solved\" it by just removing support for network location providers on /data for all [2]. Apparently the devs thought that feature is not important enough to find a way to make it work with file-based encryption and there was a policy to have the same results with file-based encryption and without.\n\nThe fact they didn\u0027t backport this to Android 6 is also a strong indicator that it is not a security feature.\n\nI\u0027d like to point out that the info in the readme is purely informational: I don\u0027t like the requirement of modifying the system partition to add a provider that does not technically require a modification of the system.\n\n[1] https://android.googlesource.com/platform/frameworks/base/+/58482c55d0848f9675b551cf2fea4990336f0b31%5E!/#F0\n\n[2] https://android.googlesource.com/platform/frameworks/base/+/c7bacab20fa8a0e603726f4f8ebafd3a96babeb1%5E!/#F2","accounts_in_message":[],"_revision_number":1},{"id":"64aba21a01b8ae8a907927e9f6378457826521bb","author":{"_account_id":3671,"name":"Dan Pasanen","email":"dan.pasanen@gmail.com","username":"invisiblek","avatars":[{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/567258b0a81572b88aae22f443dbd832.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2017-01-26 12:55:10.000000000","message":"Patch Set 1:\n\n\u003e Please reconsider this patch.\n \u003e \n \u003e The decision from Google was not because of security concerns of\n \u003e external location providers (external location providers are not\n \u003e granted any additional permissions, only the ability to set the\n \u003e current network-based location, hardly a security issue).\n \u003e \n \u003e It was done in an attempt to make this part working properly with\n \u003e file-based encryption. You can see this easily by looking at the\n \u003e commit history on this file: A first commit added a flag\n \u003e MATCH_ENCRYPTION_AWARE_AND_UNAWARE [1] which apparently did not\n \u003e result in the desired effect (because in fact it did not work with\n \u003e file-based encryption because this code is not executed again after\n \u003e unlocking the file-based encryption). So they \"solved\" it by just\n \u003e removing support for network location providers on /data for all\n \u003e [2]. Apparently the devs thought that feature is not important\n \u003e enough to find a way to make it work with file-based encryption and\n \u003e there was a policy to have the same results with file-based\n \u003e encryption and without.\n \u003e \n \u003e The fact they didn\u0027t backport this to Android 6 is also a strong\n \u003e indicator that it is not a security feature.\n \u003e \n \u003e I\u0027d like to point out that the info in the readme is purely\n \u003e informational: I don\u0027t like the requirement of modifying the system\n \u003e partition to add a provider that does not technically require a\n \u003e modification of the system.\n \u003e \n \u003e [1] https://android.googlesource.com/platform/frameworks/base/+/58482c55d0848f9675b551cf2fea4990336f0b31%5E!/#F0\n \u003e \n \u003e [2] https://android.googlesource.com/platform/frameworks/base/+/c7bacab20fa8a0e603726f4f8ebafd3a96babeb1%5E!/#F2\n\nNo. You can fork the repo and make all the changes you want. Build your own rom and use that. We\u0027re not reverting AOSP security (whether or not they backported it to 6.0 is irrelevant)\n\nMicrog and anything that attempts to fake things (location providers, signature spoofing) will never be supported, nor embraced in this project.","accounts_in_message":[],"_revision_number":1},{"id":"9bd50c7eeb9c5d3f645fc65cbe718f2883c5c0cd","author":{"_account_id":13914,"name":"la|r|ma","email":"cm@larma.de","username":"la_r_ma","avatars":[{"url":"https://www.gravatar.com/avatar/c1f11386a16e5808e6d61dd21f7ff61d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c1f11386a16e5808e6d61dd21f7ff61d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c1f11386a16e5808e6d61dd21f7ff61d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c1f11386a16e5808e6d61dd21f7ff61d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2017-01-29 08:45:59.000000000","message":"Patch Set 1:\n\n\u003e We\u0027re not reverting AOSP security\n \u003e (whether or not they backported it to 6.0 is irrelevant)\n \u003e \n \u003e Microg and anything that attempts to fake things (location\n \u003e providers, signature spoofing) will never be supported, nor\n \u003e embraced in this project.\n\nI tried to explain why this is *not* related to security by referencing the relevant commits, but apparently you were not reading my last post.\n\nI understand that you don\u0027t want to integrate signature spoofing because it actually has influence on the security of the system (although my opinion is that the power it grants to users weights more than the possibility that inexperienced users accidentally grant a permission they did not want to grant, but that\u0027s only an opinion), but this has nothing to do with location providers. \n\nLocation providers always had the possibility to be installed by users in the past. You can even see that this is not about security by noticing the fact that it only requires the location provider to be on /system (\u003d /system/app is fine), not in /system/priv-app where apps that have more privileges then user apps reside. \n\nYou should accept the possibility that Google did that change because it was easier for them then solving the actual problem and they didn\u0027t care about other location providers in first place. Not every restriction in Android is for the sake of security, after all Android is still build to suite Google\u0027s interests (e.g. Android has a comprehensive firewall system that would be technically able to block apps from using the internet, but Google is not exposing this possibility - is this to protect the users, or maybe their own interests?)\n\nI also can\u0027t understand how you can argue you are doing anything for the security of your users by forcing them to use recovery or root to install a location provider.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a706275bef7d69fbb7b641d725f70857b6011cea","revisions":{"a706275bef7d69fbb7b641d725f70857b6011cea":{"kind":"REWORK","_number":1,"created":"2016-12-14 07:33:42.000000000","uploader":{"_account_id":16293,"name":"Luca Benci","email":"benci.luca@gmail.com","username":"7lb","avatars":[{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d65a22af110b58294f9d0f75630bc51.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/25/64925/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_frameworks_base","ref":"refs/changes/25/64925/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/25/64925/1 \u0026\u0026 git checkout -b change-64925 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/25/64925/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/25/64925/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/25/64925/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_frameworks_base refs/changes/25/64925/1","Reset To":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/25/64925/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"37a51213dc915bba20589a9feab0761de607bc15","subject":"Store Network Mode selected in subId Table.","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/37a51213dc915bba20589a9feab0761de607bc15"}]}],"author":{"name":"7lb","email":"benci.luca@gmail.com","date":"2016-12-13 16:42:05.000000000","tz":60},"committer":{"name":"Luca Benci","email":"benci.luca@gmail.com","date":"2016-12-14 08:33:14.000000000","tz":60},"subject":"Allow location providers also outside of /system","message":"Allow location providers also outside of /system\n\nFrom this patch:\nhttps://github.com/microg/android_packages_apps_UnifiedNlp/blob/master/patches/android_frameworks_base-N.patch\n\nChange-Id: I2f67d991cc4038e56b3b630705d93f3ae6458c48\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/a706275bef7d69fbb7b641d725f70857b6011cea"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/a706275bef7d69fbb7b641d725f70857b6011cea"}]},"branch":"refs/heads/cm-14.1"}},"requirements":[],"submit_records":[],"submit_requirements":[]}