)]}'
{"id":"LineageOS%2Fandroid_frameworks_base~430772","triplet_id":"LineageOS%2Fandroid_frameworks_base~lineage-20.0~I180e699bd8d3fb5ea6aa4807f435060999436416","project":"LineageOS/android_frameworks_base","branch":"lineage-20.0","topic":"T_asb_2025-05","hashtags":[],"change_id":"I180e699bd8d3fb5ea6aa4807f435060999436416","subject":"[vims] better handle assistant force stop","status":"MERGED","created":"2025-05-11 22:06:21.000000000","updated":"2025-06-07 13:45:46.000000000","submitted":"2025-06-07 13:45:46.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"430763-T_asb_2025-05","meta_rev_id":"db016f723203f0ccd17b090fe6b006de82b0ce82","_number":430772,"virtual_id_number":430772,"owner":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"fe8102eac10326dc9339ec9f7108cee6d73519de","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-05-11 22:06:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"db016f723203f0ccd17b090fe6b006de82b0ce82","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-06-07 13:45:46.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e2965a9cbd94d344ed1927cb41764a34afce3110","revisions":{"df96c264b058dfc94c616ccaa4fbcf9c8fc7b584":{"kind":"REWORK","_number":1,"created":"2025-05-11 22:06:21.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/72/430772/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_frameworks_base","ref":"refs/changes/72/430772/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/1 \u0026\u0026 git checkout -b change-430772 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/1","Reset To":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f70cdde8f6d7906b1701492161f9a72a1ec876c3","subject":"speech: No BIND_ALLOW_BACKGROUND_ACTIVITY_STARTS","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/f70cdde8f6d7906b1701492161f9a72a1ec876c3"}]}],"author":{"name":"Felix Oghina","email":"hackz@google.com","date":"2023-04-27 13:30:34.000000000","tz":0},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2025-05-11 17:21:01.000000000","tz":-360},"subject":"[vims] better handle assistant force stop","message":"[vims] better handle assistant force stop\n\nCurrently, force stopping a 3p assistant app resets it to the default a\nssistant. This is not a desirable user experience. This seems to be\naccidental, some history that I was able to dig up:\n\n* b/20882522 - \"clearing data in assistant causes it to die and not\n  respond to queries\" - this will happen today anyway, because the\n  in-app setting for it gets turned off\n* the fix for the above ended up resetting the assistant setting when\n  the assistant is force stopped (as a proxy for data cleared)\n* this caused b/121104681 - force stopping assistant resets the default\n  assistant setting\n* also b/124450140 - clearing assistant resets default to none\n* the fixes for these included clearing the assistant role profile,\n  which ends up setting it to the \"fallback\" app (set in roles.xml).\n\nThis fix removes any role and setting clearing / resetting when force\nstopping or clearing the active assistant app. It keeps the part that\nensures the service is restarted, i.e. the original bug is still fixed,\ni.e. assistant responds to queries after being force stopped (but not\ncleared, which has never worked anyway).\n\nFixes: 191743558\n\nTest: atest CtsVoiceInteractionTestCases\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ba9625e664c76943448ce5b7d97e3b381e71710d)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:402a71810da63067535e8f9b1f6d837e85bde514)\nMerged-In: I180e699bd8d3fb5ea6aa4807f435060999436416\nChange-Id: I180e699bd8d3fb5ea6aa4807f435060999436416\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/df96c264b058dfc94c616ccaa4fbcf9c8fc7b584"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/df96c264b058dfc94c616ccaa4fbcf9c8fc7b584"}]},"branch":"refs/heads/lineage-20.0"},"e2965a9cbd94d344ed1927cb41764a34afce3110":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-06-07 13:45:46.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/72/430772/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_frameworks_base","ref":"refs/changes/72/430772/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/2 \u0026\u0026 git checkout -b change-430772 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/2","Reset To":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/72/430772/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d5c8b51f03b66872cafbacfdb5ae52cb41c7132d","subject":"Merge cherrypicks of [\u0027googleplex-android-review.googlesource.com/31116451\u0027, \u0027googleplex-android-review.googlesource.com/30699509\u0027, \u0027googleplex-android-review.googlesource.com/31369309\u0027, \u0027googleplex-android-review.googlesource.com/31592330\u0027, \u0027googleplex-android-review.googlesource.com/32103416\u0027, \u0027googleplex-android-review.googlesource.com/31789942\u0027, \u0027googleplex-android-review.googlesource.com/32160026\u0027, \u0027googleplex-android-review.googlesource.com/31247038\u0027, \u0027googleplex-android-review.googlesource.com/32131154\u0027] into security-aosp-tm-release.","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/d5c8b51f03b66872cafbacfdb5ae52cb41c7132d"}]}],"author":{"name":"Felix Oghina","email":"hackz@google.com","date":"2023-04-27 13:30:34.000000000","tz":0},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2025-03-14 19:19:07.000000000","tz":-420},"subject":"[vims] better handle assistant force stop","message":"[vims] better handle assistant force stop\n\nCurrently, force stopping a 3p assistant app resets it to the default a\nssistant. This is not a desirable user experience. This seems to be\naccidental, some history that I was able to dig up:\n\n* b/20882522 - \"clearing data in assistant causes it to die and not\n  respond to queries\" - this will happen today anyway, because the\n  in-app setting for it gets turned off\n* the fix for the above ended up resetting the assistant setting when\n  the assistant is force stopped (as a proxy for data cleared)\n* this caused b/121104681 - force stopping assistant resets the default\n  assistant setting\n* also b/124450140 - clearing assistant resets default to none\n* the fixes for these included clearing the assistant role profile,\n  which ends up setting it to the \"fallback\" app (set in roles.xml).\n\nThis fix removes any role and setting clearing / resetting when force\nstopping or clearing the active assistant app. It keeps the part that\nensures the service is restarted, i.e. the original bug is still fixed,\ni.e. assistant responds to queries after being force stopped (but not\ncleared, which has never worked anyway).\n\nFixes: 191743558\n\nTest: atest CtsVoiceInteractionTestCases\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ba9625e664c76943448ce5b7d97e3b381e71710d)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:402a71810da63067535e8f9b1f6d837e85bde514)\nMerged-In: I180e699bd8d3fb5ea6aa4807f435060999436416\nChange-Id: I180e699bd8d3fb5ea6aa4807f435060999436416\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/e2965a9cbd94d344ed1927cb41764a34afce3110"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/e2965a9cbd94d344ed1927cb41764a34afce3110"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}