)]}'
{"id":"LineageOS%2Fandroid_frameworks_base~401145","triplet_id":"LineageOS%2Fandroid_frameworks_base~lineage-20.0~I5eb8e97f3ae1a18d5e7e7c2c7eca048ebff3440a","project":"LineageOS/android_frameworks_base","branch":"lineage-20.0","topic":"T_asb_2024-09","hashtags":[],"change_id":"I5eb8e97f3ae1a18d5e7e7c2c7eca048ebff3440a","subject":"RESTRICT AUTOMERGE Delete keystore keys from RecoveryService.rebootRecoveryWithCommand()","status":"MERGED","created":"2024-09-06 15:46:57.000000000","updated":"2024-09-13 15:11:40.000000000","submitted":"2024-09-13 15:11:40.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"401144-T_asb_2024-09","meta_rev_id":"109cfbf9a29a6c3cf8a6c691db77baa6bc332aeb","_number":401145,"virtual_id_number":401145,"owner":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"09918f56a9092bac6b52be9c010ba6e91297b5e0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2024-09-06 15:46:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"109cfbf9a29a6c3cf8a6c691db77baa6bc332aeb","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2024-09-13 15:11:40.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"17aa5aaa5f9c97a3de16b4af7dc758555e4687cf","revisions":{"b457ca08b5388bb66bf1c44ed33aa860267147fd":{"kind":"REWORK","_number":1,"created":"2024-09-06 15:46:57.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/45/401145/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_frameworks_base","ref":"refs/changes/45/401145/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/1 \u0026\u0026 git checkout -b change-401145 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/1","Reset To":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fea05c2596a97bf9ea331454d745d7f7706b472b","subject":"DO NOT MERGE Ignore - Sanitized uri scheme by removing scheme delimiter","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/fea05c2596a97bf9ea331454d745d7f7706b472b"}]}],"author":{"name":"Nikolay Elenkov","email":"nikolayelenkov@google.com","date":"2024-06-30 06:23:00.000000000","tz":0},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2024-09-06 13:35:28.000000000","tz":-360},"subject":"RESTRICT AUTOMERGE Delete keystore keys from RecoveryService.rebootRecoveryWithCommand()","message":"RESTRICT AUTOMERGE Delete keystore keys from RecoveryService.rebootRecoveryWithCommand()\n\nAdds deleteSecrets() to RecoverySystemService. This method is called\nfrom rebootRecoveryWithCommand () before the --wipe_data command is\npassed to recovery and the device is force-rebooted.\n\ndeleteSecerts() calls IKeystoreMaintenance.deleteAllKeys() in order to\nquickly destroy the keys protecting the synthetic password blobs\nused to derive FBE encryption keys.\n\nThe intent is to make FBE-encrypted data unrecoverable even if the full\ndata wipe in recovery is interrupted or skipped.\n\nBug: 324321147\nTest: Manual - System -\u003e Reset options -\u003e Erase all data.\nTest: Hold VolDown key to interrupt reboot and stop at bootloader\nscreen.\nTest: fastboot oem bcd wipe command \u0026\u0026 fastboot oem bcd wipe recovery\nTest: fastboot reboot\nTest: Device reboots into recovery and prompts to factory reset:\nTest: \u0027Cannot load Android system. Your data may be corrupt. ...\u0027\n(cherry picked from https://android-review.googlesource.com/q/commit:0d00031851e9f5d8ef93947205a7e8b5257f0d8d)\nIgnore-AOSP-First: Security fix backport\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dfbaa7295390de97ae2e8b154cc9be5512108ac4)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d020a38e4148a642e2f06363e27cce60097efa5d)\nMerged-In: I5eb8e97f3ae1a18d5e7e7c2c7eca048ebff3440a\nChange-Id: I5eb8e97f3ae1a18d5e7e7c2c7eca048ebff3440a\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/b457ca08b5388bb66bf1c44ed33aa860267147fd"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/b457ca08b5388bb66bf1c44ed33aa860267147fd"}]},"branch":"refs/heads/lineage-20.0"},"17aa5aaa5f9c97a3de16b4af7dc758555e4687cf":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-09-13 15:11:40.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/45/401145/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_frameworks_base","ref":"refs/changes/45/401145/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/2 \u0026\u0026 git checkout -b change-401145 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/2","Reset To":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/45/401145/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"32ba2ef377de9df91f37575ee9dab8c88cd0f9a4","subject":"DO NOT MERGE Ignore - Sanitized uri scheme by removing scheme delimiter","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/32ba2ef377de9df91f37575ee9dab8c88cd0f9a4"}]}],"author":{"name":"Nikolay Elenkov","email":"nikolayelenkov@google.com","date":"2024-06-30 06:23:00.000000000","tz":0},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2024-07-10 22:16:51.000000000","tz":0},"subject":"RESTRICT AUTOMERGE Delete keystore keys from RecoveryService.rebootRecoveryWithCommand()","message":"RESTRICT AUTOMERGE Delete keystore keys from RecoveryService.rebootRecoveryWithCommand()\n\nAdds deleteSecrets() to RecoverySystemService. This method is called\nfrom rebootRecoveryWithCommand () before the --wipe_data command is\npassed to recovery and the device is force-rebooted.\n\ndeleteSecerts() calls IKeystoreMaintenance.deleteAllKeys() in order to\nquickly destroy the keys protecting the synthetic password blobs\nused to derive FBE encryption keys.\n\nThe intent is to make FBE-encrypted data unrecoverable even if the full\ndata wipe in recovery is interrupted or skipped.\n\nBug: 324321147\nTest: Manual - System -\u003e Reset options -\u003e Erase all data.\nTest: Hold VolDown key to interrupt reboot and stop at bootloader\nscreen.\nTest: fastboot oem bcd wipe command \u0026\u0026 fastboot oem bcd wipe recovery\nTest: fastboot reboot\nTest: Device reboots into recovery and prompts to factory reset:\nTest: \u0027Cannot load Android system. Your data may be corrupt. ...\u0027\n(cherry picked from https://android-review.googlesource.com/q/commit:0d00031851e9f5d8ef93947205a7e8b5257f0d8d)\nIgnore-AOSP-First: Security fix backport\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dfbaa7295390de97ae2e8b154cc9be5512108ac4)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d020a38e4148a642e2f06363e27cce60097efa5d)\nMerged-In: I5eb8e97f3ae1a18d5e7e7c2c7eca048ebff3440a\nChange-Id: I5eb8e97f3ae1a18d5e7e7c2c7eca048ebff3440a\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/17aa5aaa5f9c97a3de16b4af7dc758555e4687cf"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/17aa5aaa5f9c97a3de16b4af7dc758555e4687cf"}]},"branch":"refs/heads/lineage-20.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}