)]}'
{"id":"LineageOS%2Fandroid_frameworks_base~318548","triplet_id":"LineageOS%2Fandroid_frameworks_base~lineage-18.1~I7a72c1d3abd1f83924865326797630ded2f2040f","project":"LineageOS/android_frameworks_base","branch":"lineage-18.1","full_branch":"refs/heads/lineage-18.1","topic":"R_asb_2021-11","hashtags":[],"change_id":"I7a72c1d3abd1f83924865326797630ded2f2040f","subject":"Changed INTERACT_ACROSS_PROFILES appop to be set per UID","status":"MERGED","created":"2021-11-03 14:15:50.000000000","updated":"2021-11-07 16:57:49.000000000","submitted":"2021-11-07 16:57:49.000000000","submitter":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"318541-R_asb_2021-11","meta_rev_id":"ef26dde569839029ced687958d6c1592f5374b47","_number":318548,"virtual_id_number":318548,"owner":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0},"CI":{"all":[{"value":0,"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"762b735bbfb230fc58b4e50ef0d84c06dbf7d475","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-11-03 14:15:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ef26dde569839029ced687958d6c1592f5374b47","tag":"autogenerated:gerrit:merged","author":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-11-07 16:57:49.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fb173a023100b0e671e2aa70c5cb77b6f9cc931d","revisions":{"b021356ac4072164766683557341f366fe733564":{"kind":"REWORK","_number":1,"created":"2021-11-03 14:15:50.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/318548/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_frameworks_base","ref":"refs/changes/48/318548/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/1 \u0026\u0026 git checkout -b change-318548 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/1","Reset To":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3712770a8160bbdf636b2e84ee39c4948e2491e5","subject":"TIF: fix issue of using caller-aware methods after clearCallingIdentity()","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/3712770a8160bbdf636b2e84ee39c4948e2491e5"}]}],"author":{"name":"kholoud mohamed","email":"kholoudm@google.com","date":"2021-05-04 15:33:54.000000000","tz":60},"committer":{"name":"Kevin F. Haggerty","email":"haggertk@lineageos.org","date":"2021-11-03 13:05:26.000000000","tz":-360},"subject":"Changed INTERACT_ACROSS_PROFILES appop to be set per UID","message":"Changed INTERACT_ACROSS_PROFILES appop to be set per UID\n\nIn some cases, enforceCrossUserOrProfilePermission fails for packages\nwhich have INTERACT_ACROSS_PROFILE appop granted if it shares the uid\nwith another package that doesn\u0027t hold the permission,\nthis is because getPackagesForUid is used to get the\ncallingPackage which could return either packages randomly.\nI\u0027ve changed setting the appop to be per uid instead of per package,\n\nTest: manual testing\nBug: 183188804\nBug: 183730243\nBug: 195630721\nChange-Id: I7a72c1d3abd1f83924865326797630ded2f2040f\nMerged-In: I7a72c1d3abd1f83924865326797630ded2f2040f\n(cherry picked from commit 4670d1d855a853852980148d99b190171db4ec79)\n(cherry picked from commit be1752c13f694de4d637870214e0124d43087302)\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/b021356ac4072164766683557341f366fe733564"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/b021356ac4072164766683557341f366fe733564"}]},"branch":"refs/heads/lineage-18.1"},"fb173a023100b0e671e2aa70c5cb77b6f9cc931d":{"kind":"REWORK","_number":2,"created":"2021-11-07 16:57:49.000000000","uploader":{"_account_id":15173,"name":"Kevin Haggerty","email":"haggertk@lineageos.org","username":"haggertk","avatars":[{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/258edfac858c1ce5f056ed4ca050a578.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/318548/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_frameworks_base","ref":"refs/changes/48/318548/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/2 \u0026\u0026 git checkout -b change-318548 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/2","Reset To":"git fetch https://github.com/LineageOS/android_frameworks_base refs/changes/48/318548/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ee583fd2e4487f1ff4653796ab778219797cfaaa","subject":"TIF: fix issue of using caller-aware methods after clearCallingIdentity()","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/ee583fd2e4487f1ff4653796ab778219797cfaaa"}]}],"author":{"name":"kholoud mohamed","email":"kholoudm@google.com","date":"2021-05-04 15:33:54.000000000","tz":60},"committer":{"name":"Anis Assi","email":"anisassi@google.com","date":"2021-10-01 20:01:01.000000000","tz":0},"subject":"Changed INTERACT_ACROSS_PROFILES appop to be set per UID","message":"Changed INTERACT_ACROSS_PROFILES appop to be set per UID\n\nIn some cases, enforceCrossUserOrProfilePermission fails for packages\nwhich have INTERACT_ACROSS_PROFILE appop granted if it shares the uid\nwith another package that doesn\u0027t hold the permission,\nthis is because getPackagesForUid is used to get the\ncallingPackage which could return either packages randomly.\nI\u0027ve changed setting the appop to be per uid instead of per package,\n\nTest: manual testing\nBug: 183188804\nBug: 183730243\nBug: 195630721\nChange-Id: I7a72c1d3abd1f83924865326797630ded2f2040f\nMerged-In: I7a72c1d3abd1f83924865326797630ded2f2040f\n(cherry picked from commit 4670d1d855a853852980148d99b190171db4ec79)\n(cherry picked from commit be1752c13f694de4d637870214e0124d43087302)\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/fb173a023100b0e671e2aa70c5cb77b6f9cc931d"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_frameworks_base/commit/fb173a023100b0e671e2aa70c5cb77b6f9cc931d"}]},"branch":"refs/heads/lineage-18.1"}},"requirements":[],"submit_records":[]}
