)]}'
{"packages/SettingsLib/src/com/android/settingslib/net/DataUsageController.java":[{"author":{"_account_id":15734,"name":"Tim Schumacher","email":"timschumi@gmx.de","username":"TimSchumi","avatars":[{"url":"https://www.gravatar.com/avatar/83acb78510931d206fa4f49c8377cc20.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/83acb78510931d206fa4f49c8377cc20.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/83acb78510931d206fa4f49c8377cc20.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/83acb78510931d206fa4f49c8377cc20.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ad40ae62de836e0121c3612f88263be520ddae17","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    public DataUsageInfo getDataUsageInfo() {"},{"line_number":118,"context_line":"        if (isMobileDataSupported() \u0026\u0026 isMobileDataEnabled()) {"},{"line_number":119,"context_line":"            return getCellularDataUsageInfo();"},{"line_number":120,"context_line":"        } else {"},{"line_number":121,"context_line":"            return getWifiDataUsageInfo();"}],"source_content_type":"text/x-java","patch_set":1,"id":"8a5bd2c8_4bda943d","line":118,"range":{"start_line":118,"start_character":39,"end_line":118,"end_character":60},"updated":"2018-10-28 23:53:40.000000000","message":"I\u0027m not sure if we want this here. Displaying the WiFi Data usage by default is a thing we should only do if Mobile Data isn\u0027t supported at all. Everything else will probably result in more heart attacks than necessary.","commit_id":"130dc6bbda23e8c89809ebf0de272434415244fe"},{"author":{"_account_id":12604,"name":"L R","email":"syphyr@gmail.com","username":"syphyr","avatars":[{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"78ea2869b5bbdbf0e8a6108b110c53d854b6116e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    public DataUsageInfo getDataUsageInfo() {"},{"line_number":118,"context_line":"        if (isMobileDataSupported() \u0026\u0026 isMobileDataEnabled()) {"},{"line_number":119,"context_line":"            return getCellularDataUsageInfo();"},{"line_number":120,"context_line":"        } else {"},{"line_number":121,"context_line":"            return getWifiDataUsageInfo();"}],"source_content_type":"text/x-java","patch_set":1,"id":"415c7f96_9ebf964a","line":118,"range":{"start_line":118,"start_character":39,"end_line":118,"end_character":60},"in_reply_to":"8a5bd2c8_4bda943d","updated":"2018-10-29 00:19:16.000000000","message":"We could add the data type at the end of this string, ie; SIM/WiFi to specify.","commit_id":"130dc6bbda23e8c89809ebf0de272434415244fe"},{"author":{"_account_id":15734,"name":"Tim Schumacher","email":"timschumi@gmx.de","username":"TimSchumi","avatars":[{"url":"https://www.gravatar.com/avatar/83acb78510931d206fa4f49c8377cc20.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/83acb78510931d206fa4f49c8377cc20.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/83acb78510931d206fa4f49c8377cc20.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/83acb78510931d206fa4f49c8377cc20.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ad40ae62de836e0121c3612f88263be520ddae17","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        }"},{"line_number":123,"context_line":"    }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    public DataUsageInfo getCellularDataUsageInfo() {"},{"line_number":126,"context_line":"        final String subscriberId \u003d getActiveSubscriberId(mContext);"},{"line_number":127,"context_line":"        if (subscriberId \u003d\u003d null) {"},{"line_number":128,"context_line":"            return warn(\"no subscriber id\");"}],"source_content_type":"text/x-java","patch_set":1,"id":"68c1b559_f7779af4","line":125,"range":{"start_line":125,"start_character":25,"end_line":125,"end_character":51},"updated":"2018-10-28 23:53:40.000000000","message":"Shouldn\u0027t this be in line with all the other variables/functions?\ni.e. getMobileDataUsageInfo()","commit_id":"130dc6bbda23e8c89809ebf0de272434415244fe"},{"author":{"_account_id":12604,"name":"L R","email":"syphyr@gmail.com","username":"syphyr","avatars":[{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"38d7b832e77ef4624786779b34090448c9cb3db9","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                usage.warningLevel \u003d getDefaultWarningLevel();"},{"line_number":210,"context_line":"            }"},{"line_number":211,"context_line":"            if (usage !\u003d null) {"},{"line_number":212,"context_line":"                if (mNetworkController !\u003d null) {"},{"line_number":213,"context_line":"                    // get carrier name if it is available"},{"line_number":214,"context_line":"                    usage.carrier \u003d mNetworkController.getMobileDataNetworkName();"},{"line_number":215,"context_line":"                } else if (isMobileDataSupported() \u0026\u0026 isMobileDataEnabled()) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"e4c2ec63_3ae0ae22","line":212,"range":{"start_line":212,"start_character":20,"end_line":212,"end_character":46},"updated":"2018-10-29 21:17:21.000000000","message":"my wifi only device is setting usage.carrier to null here. I think we also need to check for isMobileDataSupported() and isMobileDataEnabled() here too.","commit_id":"e07b99cd06dce2a894c07e975e550ec414b5f975"},{"author":{"_account_id":12604,"name":"L R","email":"syphyr@gmail.com","username":"syphyr","avatars":[{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ad0428f1ae3726e8e4bad9928cc082be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"850595006fce86bfa1e12382a063533ade7f05b7","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                usage.warningLevel \u003d getDefaultWarningLevel();"},{"line_number":210,"context_line":"            }"},{"line_number":211,"context_line":"            if (usage !\u003d null) {"},{"line_number":212,"context_line":"                if (mNetworkController !\u003d null) {"},{"line_number":213,"context_line":"                    // get carrier name if it is available"},{"line_number":214,"context_line":"                    usage.carrier \u003d mNetworkController.getMobileDataNetworkName();"},{"line_number":215,"context_line":"                } else if (isMobileDataSupported() \u0026\u0026 isMobileDataEnabled()) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"de7984b8_2c6eed6b","line":212,"range":{"start_line":212,"start_character":20,"end_line":212,"end_character":46},"in_reply_to":"e4c2ec63_3ae0ae22","updated":"2018-10-29 22:34:14.000000000","message":"Actually, my issue was with strings.xml, but we still might need to also check isMobileDataEnabled() here.","commit_id":"e07b99cd06dce2a894c07e975e550ec414b5f975"},{"author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"151a4b1ed65322ae1730b107a94fc010faa20406","unresolved":false,"context_lines":[{"line_number":45,"context_line":"import static android.text.format.DateUtils.FORMAT_SHOW_DATE;"},{"line_number":46,"context_line":"import static android.net.TrafficStats.MB_IN_BYTES;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"import static android.net.ConnectivityManager.TYPE_ETHERNET;"},{"line_number":49,"context_line":"import static android.net.ConnectivityManager.TYPE_WIFI;"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"public class DataUsageController {"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-java","patch_set":3,"id":"2ce10e65_89f9a489","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":56},"updated":"2018-11-04 11:21:29.000000000","message":"these belong above and below line 40","commit_id":"cdf552ae0fd28273fe2108185147658b4470de0a"},{"author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"151a4b1ed65322ae1730b107a94fc010faa20406","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                        // get carrier name if it is available"},{"line_number":215,"context_line":"                        usage.carrier \u003d mNetworkController.getMobileDataNetworkName();"},{"line_number":216,"context_line":"                    } else {"},{"line_number":217,"context_line":"                        // carrier name not available, but telephony is enabled"},{"line_number":218,"context_line":"                        usage.carrier \u003d \"SIM\";"},{"line_number":219,"context_line":"                    }"},{"line_number":220,"context_line":"                } else if (hasWifiRadio()) {"}],"source_content_type":"text/x-java","patch_set":3,"id":"12e48090_8d85302e","line":217,"updated":"2018-11-04 11:21:29.000000000","message":"+is","commit_id":"cdf552ae0fd28273fe2108185147658b4470de0a"},{"author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"151a4b1ed65322ae1730b107a94fc010faa20406","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                    }"},{"line_number":220,"context_line":"                } else if (hasWifiRadio()) {"},{"line_number":221,"context_line":"                    // telephony is not enabled or supported,"},{"line_number":222,"context_line":"                    // check if device WiFi-capable"},{"line_number":223,"context_line":"                    usage.carrier \u003d \"WiFi\";"},{"line_number":224,"context_line":"                } else if (hasEthernet()) {"},{"line_number":225,"context_line":"                    // check if Ethernet is supported"}],"source_content_type":"text/x-java","patch_set":3,"id":"52e82cd2_44a6f724","line":222,"range":{"start_line":222,"start_character":32,"end_line":222,"end_character":51},"updated":"2018-11-04 11:21:29.000000000","message":"device +is+ WiFi-capable","commit_id":"cdf552ae0fd28273fe2108185147658b4470de0a"},{"author":{"_account_id":13028,"name":"Michael W","email":"baddaemon87@gmail.com","username":"BadDaemon","avatars":[{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d7353d59293ecf50e0388d0c18b25977.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d000821a672af1e961cff31032b7228a661f377a","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                } else if (hasWifiRadio()) {"},{"line_number":221,"context_line":"                    // telephony is not enabled or supported,"},{"line_number":222,"context_line":"                    // check if device WiFi-capable"},{"line_number":223,"context_line":"                    usage.carrier \u003d \"WiFi\";"},{"line_number":224,"context_line":"                } else if (hasEthernet()) {"},{"line_number":225,"context_line":"                    // check if Ethernet is supported"},{"line_number":226,"context_line":"                    usage.carrier \u003d \"Ethernet\";"}],"source_content_type":"text/x-java","patch_set":3,"id":"64dc3a74_2b8da5bb","line":223,"range":{"start_line":223,"start_character":36,"end_line":223,"end_character":42},"updated":"2018-11-04 11:08:00.000000000","message":"I don\u0027t like the hardcoding of these strings here. Even if it\u0027s the same among the languages you checked, I am sure chinese or cyrillic users won\u0027t be happy with these","commit_id":"cdf552ae0fd28273fe2108185147658b4470de0a"}]}