)]}'
{"Android.mk":[{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":770,"context_line":""},{"line_number":771,"context_line":"# for FIMG2D acceleration"},{"line_number":772,"context_line":"ifeq ($(BOARD_USES_SKIA_FIMGAPI),true)"},{"line_number":773,"context_line":"        LOCAL_CFLAGS +\u003d -DFIMG2D_ENABLED"},{"line_number":774,"context_line":"        LOCAL_SRC_FILES +\u003d src/core/SkThread_trylock.cpp"},{"line_number":775,"context_line":"        LOCAL_C_INCLUDES +\u003d $(TOP)/hardware/samsung_slsi-cm/exynos/include"},{"line_number":776,"context_line":"        ifeq ($(BOARD_USES_FIMGAPI_V4L2),true)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5f681702_e3aa70d0","line":773,"updated":"2016-11-27 21:55:40.000000000","message":"nitpick, but it seems like the convention in this file is tabs, not spaces for indentation","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"},{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":772,"context_line":"ifeq ($(BOARD_USES_SKIA_FIMGAPI),true)"},{"line_number":773,"context_line":"        LOCAL_CFLAGS +\u003d -DFIMG2D_ENABLED"},{"line_number":774,"context_line":"        LOCAL_SRC_FILES +\u003d src/core/SkThread_trylock.cpp"},{"line_number":775,"context_line":"        LOCAL_C_INCLUDES +\u003d $(TOP)/hardware/samsung_slsi-cm/exynos/include"},{"line_number":776,"context_line":"        ifeq ($(BOARD_USES_FIMGAPI_V4L2),true)"},{"line_number":777,"context_line":"                LOCAL_CFLAGS +\u003d -DFIMG2D_V4L2_ENABLED"},{"line_number":778,"context_line":"                LOCAL_SRC_FILES +\u003d src/core/SkFimgV4L2.cpp"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5f681702_23bc6804","line":775,"range":{"start_line":775,"start_character":57,"end_line":775,"end_character":59},"updated":"2016-11-27 21:55:40.000000000","message":"TARGET_SLSI_VARIANT ? We only have cm right now, so this is probably fine anyway.","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"},{"author":{"_account_id":11604,"name":"Simon Shields","email":"simon@lineageos.org","username":"forkbomb","avatars":[{"url":"https://www.gravatar.com/avatar/d6e634dcec0db2884bae61721a87640b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d6e634dcec0db2884bae61721a87640b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d6e634dcec0db2884bae61721a87640b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d6e634dcec0db2884bae61721a87640b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"abc20d8e0afc7f1e19fcdc42b59fa4533664c4e4","unresolved":false,"context_lines":[{"line_number":772,"context_line":"ifeq ($(BOARD_USES_SKIA_FIMGAPI),true)"},{"line_number":773,"context_line":"        LOCAL_CFLAGS +\u003d -DFIMG2D_ENABLED"},{"line_number":774,"context_line":"        LOCAL_SRC_FILES +\u003d src/core/SkThread_trylock.cpp"},{"line_number":775,"context_line":"        LOCAL_C_INCLUDES +\u003d $(TOP)/hardware/samsung_slsi-cm/exynos/include"},{"line_number":776,"context_line":"        ifeq ($(BOARD_USES_FIMGAPI_V4L2),true)"},{"line_number":777,"context_line":"                LOCAL_CFLAGS +\u003d -DFIMG2D_V4L2_ENABLED"},{"line_number":778,"context_line":"                LOCAL_SRC_FILES +\u003d src/core/SkFimgV4L2.cpp"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5f681702_b708b228","line":775,"range":{"start_line":775,"start_character":57,"end_line":775,"end_character":59},"in_reply_to":"5f681702_23bc6804","updated":"2016-11-28 22:02:47.000000000","message":"exynos4 has headers in hardware/samsung/exynos4/hal/include (although it would be nice if we could use the common exynos hals, i think we need some newer kernel-side stuff to get there)","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"}],"include/core/SkFimgApi4x.h":[{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"bool FimgApiIsDstMode(Fimg *fimg);"},{"line_number":57,"context_line":"bool FimgApiCompromise(Fimg *fimg);"},{"line_number":58,"context_line":"int FimgApiStretch(Fimg *fimg, const char *func_name);"},{"line_number":59,"context_line":"int FimgARGB32_Rect(const uint32_t *device,  int x,  int y,  int width,  int height,"},{"line_number":60,"context_line":"                    size_t rowbyte,  uint32_t color);"},{"line_number":61,"context_line":"int FimgRGB16_Rect(const uint32_t *device,  int x,  int y,  int width,  int height,"},{"line_number":62,"context_line":"                    size_t rowbyte,  uint32_t color);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5f681702_43bfe4fa","line":59,"range":{"start_line":59,"start_character":43,"end_line":59,"end_character":45},"updated":"2016-11-27 21:55:40.000000000","message":"two space? o__0","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"}],"include/core/SkFimgV4L2.h":[{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    unsigned int    srcFH;"},{"line_number":77,"context_line":"    unsigned int    srcBPP;"},{"line_number":78,"context_line":"    int             srcColorFormat;"},{"line_number":79,"context_line":"    unsigned char  *srcAddr;"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    int             dstX;"},{"line_number":82,"context_line":"    int             dstY;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5f681702_a3d07852","line":79,"range":{"start_line":79,"start_character":4,"end_line":79,"end_character":17},"updated":"2016-11-27 21:55:40.000000000","message":"If it\u0027s possible to use things like uint8_t for pointer/address types, that would be better.","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"},{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    int             mskColorFormat;"},{"line_number":104,"context_line":"    unsigned char  *mskAddr;"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    unsigned long   fillcolor;"},{"line_number":107,"context_line":"    int             rotate;"},{"line_number":108,"context_line":"    unsigned int    alpha;"},{"line_number":109,"context_line":"    int             repeat;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5f681702_e3c1d082","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":17},"updated":"2016-11-27 21:55:40.000000000","message":"Can we make this a fixed width type also? What\u0027s the range here?","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"},{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    unsigned long   fillcolor;"},{"line_number":107,"context_line":"    int             rotate;"},{"line_number":108,"context_line":"    unsigned int    alpha;"},{"line_number":109,"context_line":"    int             repeat;"},{"line_number":110,"context_line":"    int             xfermode;"},{"line_number":111,"context_line":"    int             isDither;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5f681702_03c5ec8e","line":108,"range":{"start_line":108,"start_character":4,"end_line":108,"end_character":16},"updated":"2016-11-27 21:55:40.000000000","message":"uint32_t, or uint8_t if the expected range is 0-255?","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"}],"include/core/SkPixmap.h":[{"author":{"_account_id":7155,"name":"Christopher H.","email":"raymanfx@gmail.com","username":"RaymanFX","avatars":[{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8861db6f77b3bed61ebcf0e178c8af54234b4c2b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    SkAlphaType alphaType() const { return fInfo.alphaType(); }"},{"line_number":70,"context_line":"    bool isOpaque() const { return fInfo.isOpaque(); }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#if 1"},{"line_number":73,"context_line":"    /**"},{"line_number":74,"context_line":"     *  From SkBitmap.h"},{"line_number":75,"context_line":"     */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5f681702_e35ef143","line":72,"updated":"2016-11-27 21:00:48.000000000","message":"TODO:\n* Check if we can use other interfaces here.\n* Use the correct macro barrier","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"}],"src/core/SkBlitter_RGB16.cpp":[{"author":{"_account_id":7155,"name":"Christopher H.","email":"raymanfx@gmail.com","username":"RaymanFX","avatars":[{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8861db6f77b3bed61ebcf0e178c8af54234b4c2b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                               uint32_t srcExpanded, unsigned scale);"},{"line_number":49,"context_line":"#endif"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"#if defined(FIMG2D_ENABLED)"},{"line_number":52,"context_line":"/*"},{"line_number":53,"context_line":" * Legacy methods (removed in upstream)"},{"line_number":54,"context_line":" */"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f681702_2359095a","line":51,"updated":"2016-11-27 21:00:48.000000000","message":"TODO:\n* Check if there is an existing method for pmcolor_to_expand16_L\n* Check if there is an existing method for blend32_16_row_L","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"}],"src/core/SkDraw.cpp":[{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":924,"context_line":"                    shaderIsBitmap \u003d tempShader-\u003eisABitmap(\u0026srcBitmap, NULL, tempTileMode);"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"                    if (shaderIsBitmap \u0026\u0026 (srcBitmap.isNull() \u003d\u003d false) \u0026\u0026"},{"line_number":927,"context_line":"                        (tempTileMode[0] \u003d\u003d SkShader::kClamp_TileMode) \u0026\u0026 (tempTileMode[1] \u003d\u003d SkShader::kClamp_TileMode)) {"},{"line_number":928,"context_line":"                        SkRect r;"},{"line_number":929,"context_line":"                        SkIRect fimg_ir;"},{"line_number":930,"context_line":"                        Fimg fimg;"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f681702_63d66052","line":927,"updated":"2016-11-27 21:55:40.000000000","message":"line length","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"},{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":945,"context_line":"                        fimg.srcBPP \u003d srcBitmap.bytesPerPixel();"},{"line_number":946,"context_line":"                        fimg.srcColorFormat \u003d srcBitmap.colorType();"},{"line_number":947,"context_line":"                        srcBitmap.lockPixels();"},{"line_number":948,"context_line":"                        fimg.srcAddr \u003d (unsigned char *)srcBitmap.getAddr(0, 0);"},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"                        if ((r.fLeft \u003c 0) || (r.fTop \u003c 0))"},{"line_number":951,"context_line":"                            fimg.srcAddr \u003d NULL;"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f681702_c3cbf4a2","line":948,"range":{"start_line":948,"start_character":39,"end_line":948,"end_character":56},"updated":"2016-11-27 21:55:40.000000000","message":"unsigned char * cast? :/","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"},{"author":{"_account_id":7155,"name":"Christopher H.","email":"raymanfx@gmail.com","username":"RaymanFX","avatars":[{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8861db6f77b3bed61ebcf0e178c8af54234b4c2b","unresolved":false,"context_lines":[{"line_number":961,"context_line":"                        fimg.dstFH \u003d fDst.height();"},{"line_number":962,"context_line":"                        fimg.dstBPP \u003d fDst.bytesPerPixel();"},{"line_number":963,"context_line":"                        fimg.dstColorFormat \u003d fDst.colorType();"},{"line_number":964,"context_line":"                        // FIXME: Do we need to lock here?"},{"line_number":965,"context_line":"                        //fDst.lockPixels();"},{"line_number":966,"context_line":"                        fimg.dstAddr \u003d (unsigned char *)fDst.getAddr(0, 0);"},{"line_number":967,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f681702_03568d2a","line":964,"updated":"2016-11-27 21:00:48.000000000","message":"TODO:\n* Check if we need to lock the target SkPixmap ref","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"},{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":1449,"context_line":"        int iy \u003d SkScalarRoundToInt(matrix.getTranslateY());"},{"line_number":1450,"context_line":"        if (clipHandlesSprite(*fRC, ix, iy, pmap)) {"},{"line_number":1451,"context_line":"#if defined(FIMG2D_ENABLED)"},{"line_number":1452,"context_line":"            Fimg fimg;"},{"line_number":1453,"context_line":"#endif"},{"line_number":1454,"context_line":"            SkTBlitterAllocator allocator;"},{"line_number":1455,"context_line":"            // blitter will be owned by the allocator."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f681702_83e8dc16","line":1452,"updated":"2016-11-27 21:55:40.000000000","message":"Can\u0027t bring this into the FIMG2D_ENABLED block below?","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"}],"src/core/SkFimgApi4x.cpp":[{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    if (fimg-\u003esrcAddr !\u003d NULL) {"},{"line_number":286,"context_line":"        srcImage.addr.type \u003d ADDR_USER;"},{"line_number":287,"context_line":"        srcImage.addr.start \u003d (long unsigned)fimg-\u003esrcAddr;"},{"line_number":288,"context_line":"        srcImage.plane2.type \u003d ADDR_USER;"},{"line_number":289,"context_line":"        srcImage.plane2.start \u003d NULL;"},{"line_number":290,"context_line":"        srcImage.need_cacheopr \u003d true;"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f681702_c3f2d406","line":287,"range":{"start_line":287,"start_character":30,"end_line":287,"end_character":45},"updated":"2016-11-27 21:55:40.000000000","message":"Casting like this worries me when it comes to 64-bit, although fimg4 devices are all 32-bit anyway.","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"}],"src/core/SkFimgV4L2.cpp":[{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        return false;"},{"line_number":366,"context_line":"    }"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    result \u003d exynos_bl_set_dst_format(fimg_handle_t, rowbyte/32, y+height, x, y, width, height, ChangeColorForV4L2(kN32_SkColorType));"},{"line_number":369,"context_line":"    if (result \u003c 0) {"},{"line_number":370,"context_line":"        ALOGE(\"\u003cSkFimgV4L2\u003e exynos_bl_set_dst_format error : %d\", result);"},{"line_number":371,"context_line":"        exynos_bl_destroy(fimg_handle_t);"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f681702_a3f7d8f5","line":368,"updated":"2016-11-27 21:55:40.000000000","message":"line length","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"},{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        return false;"},{"line_number":435,"context_line":"    }"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    result \u003d exynos_bl_set_dst_format(fimg_handle_t, rowbyte/16, y+height, x, y, width, height, ChangeColorForV4L2(kRGB_565_SkColorType));"},{"line_number":438,"context_line":"    if (result \u003c 0) {"},{"line_number":439,"context_line":"        ALOGE(\"\u003cSkFimgV4L2\u003e exynos_bl_set_dst_format error : %d\", result);"},{"line_number":440,"context_line":"        exynos_bl_destroy(fimg_handle_t);"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f681702_e3d8b080","line":437,"updated":"2016-11-27 21:55:40.000000000","message":"line length","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"}],"src/core/SkPixmap.cpp":[{"author":{"_account_id":7155,"name":"Christopher H.","email":"raymanfx@gmail.com","username":"RaymanFX","avatars":[{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/59f6b56629607bdf2e288b99c9de2501.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8861db6f77b3bed61ebcf0e178c8af54234b4c2b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    return SkToU16(pixel);"},{"line_number":118,"context_line":"}"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"#if 1"},{"line_number":121,"context_line":"/**"},{"line_number":122,"context_line":" * From SkBitmap.cpp"},{"line_number":123,"context_line":" */"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f681702_c35bf551","line":120,"updated":"2016-11-27 21:00:48.000000000","message":"TODO:\n* Check if we can use other interfaces here.\n* Use the correct macro barrier","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"},{"author":{"_account_id":2936,"name":"Ethan Chen","email":"intervigil@gmail.com","username":"intervigil","avatars":[{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/382d80f420fb681ba1b88c29df904f29.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b6abe4822fb0fb41e7b8001772f9cc72e6b6f3a","unresolved":false,"context_lines":[{"line_number":122,"context_line":" * From SkBitmap.cpp"},{"line_number":123,"context_line":" */"},{"line_number":124,"context_line":"void* SkPixmap::getAddr(int x, int y) const {"},{"line_number":125,"context_line":"    SkASSERT((unsigned)x \u003c (unsigned)this-\u003ewidth());"},{"line_number":126,"context_line":"    SkASSERT((unsigned)y \u003c (unsigned)this-\u003eheight());"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    char* base \u003d (char*)this-\u003egetPixels();"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f681702_23e3c835","line":125,"updated":"2016-11-27 21:55:40.000000000","message":"Asserts in live codepaths are worrying.","commit_id":"adad09316f5f2250081f5a29fbdadc012cdc6d9b"}]}