)]}'
{"id":"LineageOS%2Fandroid_external_giflib~414856","triplet_id":"LineageOS%2Fandroid_external_giflib~lineage-21.0~Ieef04e789acf783eda2dff2cd9284ed204f1d117","project":"LineageOS/android_external_giflib","branch":"lineage-21.0","topic":"U_asb_2025-01","hashtags":[],"change_id":"Ieef04e789acf783eda2dff2cd9284ed204f1d117","subject":"Fix potential overflow when calculating ImageSize","status":"MERGED","created":"2025-01-10 00:32:06.000000000","updated":"2025-01-19 08:49:30.000000000","submitted":"2025-01-19 08:49:30.000000000","submitter":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"414856-U_asb_2025-01","meta_rev_id":"e5e31174dd19cc7c55fb766ac413f36c74b208eb","_number":414856,"virtual_id_number":414856,"owner":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"all":[{"value":0,"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"1b9198d3e57bcb12ed9cfdaac305c69ef2ce376a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-01-10 00:32:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e5e31174dd19cc7c55fb766ac413f36c74b208eb","tag":"autogenerated:gerrit:merged","author":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-01-19 08:49:30.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3281e14f6b9b85473145ee0ae33b8d4b8fbabffe","revisions":{"626cbc4cfa9da8d686e665656147051cbf24a2eb":{"kind":"REWORK","_number":1,"created":"2025-01-10 00:32:06.000000000","uploader":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/56/414856/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_external_giflib","ref":"refs/changes/56/414856/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/1 \u0026\u0026 git checkout -b change-414856 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/1","Reset To":"git fetch https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b771f86bcb3d0086ee5eda84da70634e7ab746dd","subject":"Merge \"Enable vendor variant of libgif static library\" am: 8697006065 am: 119800dda5 am: 35c48f1948","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_external_giflib/commit/b771f86bcb3d0086ee5eda84da70634e7ab746dd"}]}],"author":{"name":"Sadaf Ebrahimi","email":"sadafebrahimi@google.com","date":"2024-09-17 21:02:42.000000000","tz":0},"committer":{"name":"Michael Bestas","email":"mkbestas@lineageos.org","date":"2025-01-10 00:31:47.000000000","tz":120},"subject":"Fix potential overflow when calculating ImageSize","message":"Fix potential overflow when calculating ImageSize\n\nThe modified if statement doesn\u0027t check the size of ImageDesc.Width and\nImageDesc.Height. If ImageDesc.Width and ImageDesc.Height are larger\nthan SIZE_MAX, then ImageSize overflows.\n\nBug: 355461643\nTest: TreeHugger\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a6ede43ad88693f782f3a6c5b8b9b9c451151ac7)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:da6189e11ed4ea9199a82b4b0d2bd7bed04a7efb)\nMerged-In: Ieef04e789acf783eda2dff2cd9284ed204f1d117\nChange-Id: Ieef04e789acf783eda2dff2cd9284ed204f1d117\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_external_giflib/commit/626cbc4cfa9da8d686e665656147051cbf24a2eb"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_external_giflib/commit/626cbc4cfa9da8d686e665656147051cbf24a2eb"}]},"branch":"refs/heads/lineage-21.0"},"3281e14f6b9b85473145ee0ae33b8d4b8fbabffe":{"kind":"NO_CHANGE","_number":2,"created":"2025-01-19 08:49:30.000000000","uploader":{"_account_id":4550,"name":"Michael Bestas","email":"mkbestas@lineageos.org","username":"mikeioannina","avatars":[{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/344122da7b260a387a09ad1f04358f40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/56/414856/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_external_giflib","ref":"refs/changes/56/414856/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/2 \u0026\u0026 git checkout -b change-414856 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/2","Reset To":"git fetch https://github.com/LineageOS/android_external_giflib refs/changes/56/414856/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cc0f935f94a8f8e7b896b4482dcb1bb1f42c37a2","subject":"Snap for 9316940 from b771f86bcb3d0086ee5eda84da70634e7ab746dd to udc-release","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_external_giflib/commit/cc0f935f94a8f8e7b896b4482dcb1bb1f42c37a2"}]}],"author":{"name":"Sadaf Ebrahimi","email":"sadafebrahimi@google.com","date":"2024-09-17 21:02:42.000000000","tz":0},"committer":{"name":"Android Build Coastguard Worker","email":"android-build-coastguard-worker@google.com","date":"2024-11-06 23:34:50.000000000","tz":0},"subject":"Fix potential overflow when calculating ImageSize","message":"Fix potential overflow when calculating ImageSize\n\nThe modified if statement doesn\u0027t check the size of ImageDesc.Width and\nImageDesc.Height. If ImageDesc.Width and ImageDesc.Height are larger\nthan SIZE_MAX, then ImageSize overflows.\n\nBug: 355461643\nTest: TreeHugger\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a6ede43ad88693f782f3a6c5b8b9b9c451151ac7)\n(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:da6189e11ed4ea9199a82b4b0d2bd7bed04a7efb)\nMerged-In: Ieef04e789acf783eda2dff2cd9284ed204f1d117\nChange-Id: Ieef04e789acf783eda2dff2cd9284ed204f1d117\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_external_giflib/commit/3281e14f6b9b85473145ee0ae33b8d4b8fbabffe"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_external_giflib/commit/3281e14f6b9b85473145ee0ae33b8d4b8fbabffe"}]},"branch":"refs/heads/lineage-21.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}