)]}'
{"id":"LineageOS%2Fandroid_device_xiaomi_peridot~482252","triplet_id":"LineageOS%2Fandroid_device_xiaomi_peridot~lineage-23.2~Ib8a46aecc475d818cfc598fc3206f46b0c5063a7","project":"LineageOS/android_device_xiaomi_peridot","branch":"lineage-23.2","hashtags":[],"change_id":"Ib8a46aecc475d818cfc598fc3206f46b0c5063a7","subject":"peridot: modules: Simplify kernel modules list","status":"MERGED","created":"2026-05-02 14:57:04.000000000","updated":"2026-05-06 09:07:38.000000000","submitted":"2026-05-06 09:07:38.000000000","submitter":{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"482253","meta_rev_id":"668d55afe019ae9c9da432f069b73dd9e5e536d2","_number":482252,"virtual_id_number":482252,"owner":{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":1,"date":"2026-05-06 09:06:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":2,"date":"2026-05-06 09:06:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":21290,"name":"Arian","email":"arian.kulmer@web.de","username":"ArianK16a","avatars":[{"url":"https://www.gravatar.com/avatar/5fb921ba0d8167f4a9239e07f970970f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5fb921ba0d8167f4a9239e07f970970f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5fb921ba0d8167f4a9239e07f970970f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5fb921ba0d8167f4a9239e07f970970f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"REVIEWER":[{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-02 14:57:04.000000000","updated_by":{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":21290,"name":"Arian","email":"arian.kulmer@web.de","username":"ArianK16a","avatars":[{"url":"https://www.gravatar.com/avatar/5fb921ba0d8167f4a9239e07f970970f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5fb921ba0d8167f4a9239e07f970970f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5fb921ba0d8167f4a9239e07f970970f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5fb921ba0d8167f4a9239e07f970970f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"CC"}],"messages":[{"id":"ea7f8c9de896a0e868fdb4ab7c79d67fa60c037e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2026-05-02 14:57:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"13a68c9f2e9888587f828a965aca0050956840b4","author":{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2026-05-06 09:06:54.000000000","message":"Patch Set 1: Code-Review+2 Verified+1","accounts_in_message":[],"_revision_number":1},{"id":"668d55afe019ae9c9da432f069b73dd9e5e536d2","tag":"autogenerated:gerrit:merged","author":{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2026-05-06 09:07:38.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d21a5db7e6670e1d4e8ba32ecf4516fa7c8b28ff","revisions":{"d21a5db7e6670e1d4e8ba32ecf4516fa7c8b28ff":{"kind":"REWORK","_number":1,"created":"2026-05-02 14:57:04.000000000","uploader":{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/52/482252/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_device_xiaomi_peridot","ref":"refs/changes/52/482252/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_device_xiaomi_peridot refs/changes/52/482252/1 \u0026\u0026 git checkout -b change-482252 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_device_xiaomi_peridot refs/changes/52/482252/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_device_xiaomi_peridot refs/changes/52/482252/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_device_xiaomi_peridot refs/changes/52/482252/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_device_xiaomi_peridot refs/changes/52/482252/1","Reset To":"git fetch https://github.com/LineageOS/android_device_xiaomi_peridot refs/changes/52/482252/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"135029bee7717ec912014916d895bdc4b625f4ca","subject":"peridot: Remove virtual framebuffer","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_device_xiaomi_peridot/commit/135029bee7717ec912014916d895bdc4b625f4ca"}]}],"author":{"name":"Arian","email":"arian.kulmer@web.de","date":"2026-05-02 14:14:03.000000000","tz":330},"committer":{"name":"AdarshGrewal","email":"adarshgrewal@gmail.com","date":"2026-05-02 14:56:58.000000000","tz":330},"subject":"peridot: modules: Simplify kernel modules list","message":"peridot: modules: Simplify kernel modules list\n\nInclude the module blocklists from kernel.\nDifferentiante between four categories of modules:\n* first-stage modules:\n    originally built in-tree, explicitly defined in modules.list.msm.pineapple and\n    built into vendor_boot, so used on android boot and recovery boot.\n* second-stage modules:\n    used by recovery and android (vendor_dlkm and recovery)\n* vendor modules:\n    used by android only (vendor_dlkm)\n* system modules:\n    used by android only (system_dlkm)\n\nThe new module list files were created like this from the stock lists:\nmodules.list.first_stage: grep -v -x -f vendor_boot/lib/modules/modules.load kernel/xiaomi/sm8635/modules.list.msm.pineapple\nmodules.list.second_stage: grep -v -x -f vendor_boot/lib/modules/modules.load vendor_boot/lib/modules/modules.load.recovery\nmodules.list.vendor_dlkm: grep -v -x -f vendor_boot/lib/modules/modules.load.recovery vendor_dlkm/lib/modules/modules.load\nmodules.list.system_dlkm: cat kernel/xiaomi/sm8635/modules.bzl | grep .ko\n\nChange-Id: Ib8a46aecc475d818cfc598fc3206f46b0c5063a7\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_device_xiaomi_peridot/commit/d21a5db7e6670e1d4e8ba32ecf4516fa7c8b28ff"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_device_xiaomi_peridot/commit/d21a5db7e6670e1d4e8ba32ecf4516fa7c8b28ff"}]},"branch":"refs/heads/lineage-23.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":30766,"name":"Adarsh Grewal","email":"adarshgrewal@gmail.com","username":"adarshgrewal","avatars":[{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d8e3254ae8ed63649454dc48e4bfbcca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"CI","status":"MAY"}]}],"submit_requirements":[{"name":"CI","description":"Prevent submit if CI failed.","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:CI\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:CI\u003dMIN"],"atom_explanations":{"label:CI\u003dMIN":""}}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[],"atom_explanations":{}}}]}