)]}'
{"id":"LineageOS%2Fandroid_device_oneplus_msm8998-common~246761","triplet_id":"LineageOS%2Fandroid_device_oneplus_msm8998-common~lineage-16.0~I178e9588e1dde96400dcb2178a027597d05949bd","project":"LineageOS/android_device_oneplus_msm8998-common","branch":"lineage-16.0","hashtags":[],"change_id":"I178e9588e1dde96400dcb2178a027597d05949bd","subject":"msm8998-common: Enable OEM unlock and bootable image signing","status":"MERGED","created":"2019-04-22 05:44:39.000000000","updated":"2019-04-22 06:36:18.000000000","submitted":"2019-04-22 06:36:18.000000000","submitter":{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"46761-1555914978287-248b21c","meta_rev_id":"6690112e829713ad8469f841698a62bd6e274504","_number":246761,"virtual_id_number":246761,"owner":{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":1,"date":"2019-04-22 06:36:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":2,"date":"2019-04-22 06:36:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":10258,"name":"dianlujitao","email":"dianlujitao@lineageos.org","username":"dianlujitao","avatars":[{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"reviewers":{"REVIEWER":[{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":10258,"name":"dianlujitao","email":"dianlujitao@lineageos.org","username":"dianlujitao","avatars":[{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-22 05:44:39.000000000","updated_by":{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":10258,"name":"dianlujitao","email":"dianlujitao@lineageos.org","username":"dianlujitao","avatars":[{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f63be36ff090f17abde0116fc7033f52.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"cc5f39b6c01adf69e7c01648885721ba23c48d9b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-04-22 05:44:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6e2f0f49dbbdb521826132f0293bb92c30d9ad4b","author":{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-04-22 06:36:14.000000000","message":"Patch Set 1: Verified+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6690112e829713ad8469f841698a62bd6e274504","tag":"autogenerated:gerrit:merged","author":{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-04-22 06:36:18.000000000","message":"Change has been successfully merged by Daniel Hillenbrand","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a8f9d219614378bd1c3f1981a931c21d1ba7c1d3","revisions":{"a8f9d219614378bd1c3f1981a931c21d1ba7c1d3":{"kind":"REWORK","_number":1,"created":"2019-04-22 05:44:39.000000000","uploader":{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/61/246761/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_device_oneplus_msm8998-common","ref":"refs/changes/61/246761/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_device_oneplus_msm8998-common refs/changes/61/246761/1 \u0026\u0026 git checkout -b change-246761 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_device_oneplus_msm8998-common refs/changes/61/246761/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_device_oneplus_msm8998-common refs/changes/61/246761/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_device_oneplus_msm8998-common refs/changes/61/246761/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_device_oneplus_msm8998-common refs/changes/61/246761/1","Reset To":"git fetch https://github.com/LineageOS/android_device_oneplus_msm8998-common refs/changes/61/246761/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"370f0b81e2c934252653a55eb722b78795d116f8","subject":"msm8998-common: enable Wi-Fi STA/AP concurrency","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_device_oneplus_msm8998-common/commit/370f0b81e2c934252653a55eb722b78795d116f8"}]}],"author":{"name":"dianlujitao","email":"dianlujitao@lineageos.org","date":"2019-03-28 06:33:56.000000000","tz":480},"committer":{"name":"codeworkx","email":"daniel.hillenbrand@codeworkx.de","date":"2019-04-22 05:44:25.000000000","tz":120},"subject":"msm8998-common: Enable OEM unlock and bootable image signing","message":"msm8998-common: Enable OEM unlock and bootable image signing\n\n * Given the fact that the bootloader allows bootable images with\n   arbitrary signatures to boot, one can relock the bootloader after\n   installing a signed custom recovery. After that, custom ROMs can be\n   installed from recovery as usual, as long as the boot.img\u0027s are\n   signed.\n * This is NOT a security vulnerability because unlocked bootloader is\n   still prerequisite to access fastboot boot/flash, in contrast it\u0027s a\n   feature suggested by Google.\n * To make it feasible with Lineage, sign the img with AOSP verity key\n   which is publicly available.\n * OnePlus happens to use the same key to sign their own images and\n   bootloader, so as a bonus there\u0027s even no 5s warning indicating a\n   custom boot.img is in use on boot.\n * This doesn\u0027t mean using custom ROMs with locked bootloader is\n   suggested.\n\nChange-Id: I178e9588e1dde96400dcb2178a027597d05949bd\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_device_oneplus_msm8998-common/commit/a8f9d219614378bd1c3f1981a931c21d1ba7c1d3"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_device_oneplus_msm8998-common/commit/a8f9d219614378bd1c3f1981a931c21d1ba7c1d3"}]},"branch":"refs/heads/lineage-16.0"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":523,"name":"Daniel Hillenbrand","email":"daniel.hillenbrand@codeworkx.de","username":"codeworkx","avatars":[{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d2d7bc2b214b1441300845e14e121c40.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}