)]}'
{"id":"LineageOS%2Fandroid_device_oneplus_giulia~474457","triplet_id":"LineageOS%2Fandroid_device_oneplus_giulia~lineage-23.2~Id85857ceebf4c168aec9db3209d5bb448b40866c","project":"LineageOS/android_device_oneplus_giulia","branch":"lineage-23.2","topic":"waffle-fifo-primitive-effects","hashtags":[],"change_id":"Id85857ceebf4c168aec9db3209d5bb448b40866c","subject":"giulia: vibrator: effect: Fix -Wreorder-init-list","status":"MERGED","created":"2026-02-16 06:14:13.000000000","updated":"2026-02-16 13:25:32.000000000","submitted":"2026-02-16 13:25:32.000000000","submitter":{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"474459-waffle-fifo-primitive-effects","meta_rev_id":"6fbb41d20fce31ff14c5807f0f961f7b86a5fd1b","_number":474457,"virtual_id_number":474457,"owner":{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":1,"date":"2026-02-16 12:49:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":2,"date":"2026-02-16 12:49:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"CC":[{"_account_id":17257,"name":"Cosmin Tanislav","email":"demonsingur@gmail.com","username":"Demon000","avatars":[{"url":"https://www.gravatar.com/avatar/a4a1c70fcdfa00ccdfc7fc2d39028a98.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a4a1c70fcdfa00ccdfc7fc2d39028a98.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a4a1c70fcdfa00ccdfc7fc2d39028a98.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a4a1c70fcdfa00ccdfc7fc2d39028a98.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-16 06:14:13.000000000","updated_by":{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":17257,"name":"Cosmin Tanislav","email":"demonsingur@gmail.com","username":"Demon000","avatars":[{"url":"https://www.gravatar.com/avatar/a4a1c70fcdfa00ccdfc7fc2d39028a98.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a4a1c70fcdfa00ccdfc7fc2d39028a98.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a4a1c70fcdfa00ccdfc7fc2d39028a98.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a4a1c70fcdfa00ccdfc7fc2d39028a98.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"CC"}],"messages":[{"id":"30e3d23f73eb71fbb5082e11368b3e40460cfb76","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2026-02-16 06:14:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3262132361515b716b3e0b8cc9b6a3453b6d38f0","author":{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2026-02-16 12:49:24.000000000","message":"Patch Set 1: Code-Review+2 Verified+1","accounts_in_message":[],"_revision_number":1},{"id":"6fbb41d20fce31ff14c5807f0f961f7b86a5fd1b","tag":"autogenerated:gerrit:merged","author":{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2026-02-16 13:25:32.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4cdb018743052ee38de0ddbf19e780694ca92594","revisions":{"4cdb018743052ee38de0ddbf19e780694ca92594":{"kind":"REWORK","_number":1,"created":"2026-02-16 06:14:13.000000000","uploader":{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/57/474457/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_device_oneplus_giulia","ref":"refs/changes/57/474457/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_device_oneplus_giulia refs/changes/57/474457/1 \u0026\u0026 git checkout -b change-474457 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_device_oneplus_giulia refs/changes/57/474457/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_device_oneplus_giulia refs/changes/57/474457/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_device_oneplus_giulia refs/changes/57/474457/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_device_oneplus_giulia refs/changes/57/474457/1","Reset To":"git fetch https://github.com/LineageOS/android_device_oneplus_giulia refs/changes/57/474457/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9ff3cc9735796958716bacd4bd0531e7becf1eeb","subject":"giulia: vibrator: effect: Use header library","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_device_oneplus_giulia/commit/9ff3cc9735796958716bacd4bd0531e7becf1eeb"}]}],"author":{"name":"Cosmin Tanislav","email":"demonsingur@gmail.com","date":"2025-03-02 17:33:07.000000000","tz":120},"committer":{"name":"chandu078","email":"chandudyavanapelli03@gmail.com","date":"2026-02-16 06:11:22.000000000","tz":0},"subject":"giulia: vibrator: effect: Fix -Wreorder-init-list","message":"giulia: vibrator: effect: Fix -Wreorder-init-list\n\neffect/effect.cpp:79:19: warning: ISO C++ requires field designators to be specified in declaration order; field \u0027data\u0027 will be initialized after field \u0027length\u0027 [-Wreorder-init-list]\n   79 |         .length \u003d ARRAY_SIZE(effect_0),\n      |         ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~\neffect/effect.cpp:36:23: note: expanded from macro \u0027ARRAY_SIZE\u0027\n   36 | #define ARRAY_SIZE(a) (sizeof(a) / sizeof(*(a)))\n      |                       ^\neffect/effect.cpp:78:17: note: previous initialization for field \u0027data\u0027 is here\n   78 |         .data \u003d effect_0,\n\nChange-Id: Id85857ceebf4c168aec9db3209d5bb448b40866c\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_device_oneplus_giulia/commit/4cdb018743052ee38de0ddbf19e780694ca92594"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_device_oneplus_giulia/commit/4cdb018743052ee38de0ddbf19e780694ca92594"}]},"branch":"refs/heads/lineage-23.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":30975,"name":"Chandu Dyavanapelli","display_name":"chandu","email":"chandudyavanapelli03@gmail.com","username":"chandu078","avatars":[{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f9c386b484cd992a45c37de4c8aa9aee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"CI","status":"MAY"}]}],"submit_requirements":[{"name":"CI","description":"Prevent submit if CI failed.","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:CI\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:CI\u003dMIN"],"atom_explanations":{"label:CI\u003dMIN":""}}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[],"atom_explanations":{}}}]}