)]}'
{"id":"LineageOS%2Fandroid_build_soong~255821","triplet_id":"LineageOS%2Fandroid_build_soong~lineage-17.0~Icc18de5dfaa83fc0a1eda6f3704f3a92e1de0764","project":"LineageOS/android_build_soong","branch":"lineage-17.0","topic":"ten-sdk-bringup","hashtags":[],"change_id":"Icc18de5dfaa83fc0a1eda6f3704f3a92e1de0764","subject":"soong: Squash of lineage-sdk bringup commits","status":"MERGED","created":"2019-09-05 21:29:15.000000000","updated":"2019-09-10 23:39:31.000000000","submitted":"2019-09-10 23:39:31.000000000","submitter":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"55821-1568158771046-094d2c0","meta_rev_id":"c79cde4985045861395a2180096bcba21962a9f8","_number":255821,"virtual_id_number":255821,"owner":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3962,"name":"Rashed Abdel-Tawab","email":"rashedabdeltawab@gmail.com","username":"Rashed","avatars":[{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2019-09-10 23:17:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":1,"date":"2019-09-10 23:34:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":3962,"name":"Rashed Abdel-Tawab","email":"rashedabdeltawab@gmail.com","username":"Rashed","avatars":[{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":3962,"name":"Rashed Abdel-Tawab","email":"rashedabdeltawab@gmail.com","username":"Rashed","avatars":[{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2019-09-10 23:17:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":2,"date":"2019-09-10 23:34:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":3962,"name":"Rashed Abdel-Tawab","email":"rashedabdeltawab@gmail.com","username":"Rashed","avatars":[{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":3962,"name":"Rashed Abdel-Tawab","email":"rashedabdeltawab@gmail.com","username":"Rashed","avatars":[{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"reviewers":{"REVIEWER":[{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":3962,"name":"Rashed Abdel-Tawab","email":"rashedabdeltawab@gmail.com","username":"Rashed","avatars":[{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-05 21:29:15.000000000","updated_by":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":3962,"name":"Rashed Abdel-Tawab","email":"rashedabdeltawab@gmail.com","username":"Rashed","avatars":[{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-09-07 08:20:49.000000000","updated_by":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2019-09-07 08:20:49.000000000","updated_by":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2019-09-07 08:20:49.000000000","updated_by":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":10067,"name":"Łukasz Patron","email":"priv.luk@gmail.com","username":"luk1337","avatars":[{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/63c52ed7e79934b002d63a86e9b9d78a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"e2e147dfc6d8f96c09d7ffee6d6454b22cea63d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-05 21:29:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7c346699114989344b9334beabff293ab090a4fe","author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-07 08:20:49.000000000","message":"Patch Set 1:\n\nI wonder if we should have this in the stack this time too:\nsoong: Allow framework to access lineage-sdk resources\nhttps://review.lineageos.org/c/LineageOS/android_build_soong/+/227276\n\nAllows non-services framework code to access lineage resources.","accounts_in_message":[],"_revision_number":1},{"id":"cae4b4492aaf0e03ad84a0e89174a992061fbeaf","author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-07 09:50:37.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n \u003e \n \u003e I wonder if we should have this in the stack this time too:\n \u003e soong: Allow framework to access lineage-sdk resources\n \u003e https://review.lineageos.org/c/LineageOS/android_build_soong/+/227276\n \u003e \n \u003e Allows non-services framework code to access lineage resources.\nFine for me, better to add it here then loosing it","accounts_in_message":[],"_revision_number":1},{"id":"3dc7d73f26257290332892eebfb7d6cf98410122","author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-07 21:52:52.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e  \u003e \n\u003e  \u003e I wonder if we should have this in the stack this time too:\n\u003e  \u003e soong: Allow framework to access lineage-sdk resources\n\u003e  \u003e https://review.lineageos.org/c/LineageOS/android_build_soong/+/227276\n\u003e  \u003e \n\u003e  \u003e Allows non-services framework code to access lineage resources.\n\u003e Fine for me, better to add it here then loosing it\n\n?","accounts_in_message":[],"_revision_number":1},{"id":"0b6e4b93b766bad532f0b4c4c96cd2c315c2fb3b","author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-07 22:57:39.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 1:\n\u003e \u003e  \u003e \n\u003e \u003e  \u003e I wonder if we should have this in the stack this time too:\n\u003e \u003e  \u003e soong: Allow framework to access lineage-sdk resources\n\u003e \u003e  \u003e https://review.lineageos.org/c/LineageOS/android_build_soong/+/227276\n\u003e \u003e  \u003e \n\u003e \u003e  \u003e Allows non-services framework code to access lineage resources.\n\u003e \u003e Fine for me, better to add it here then loosing it\n\u003e \n\u003e ?\n\nWe never ended up using this change, but by itself it could be useful","accounts_in_message":[],"_revision_number":1},{"id":"cd8cb64e8b98a4a76a9f9e4e2f66c385127b5257","author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-09 06:01:35.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 1:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 1:\n\u003e \u003e \u003e  \u003e \n\u003e \u003e \u003e  \u003e I wonder if we should have this in the stack this time too:\n\u003e \u003e \u003e  \u003e soong: Allow framework to access lineage-sdk resources\n\u003e \u003e \u003e  \u003e https://review.lineageos.org/c/LineageOS/android_build_soong/+/227276\n\u003e \u003e \u003e  \u003e \n\u003e \u003e \u003e  \u003e Allows non-services framework code to access lineage resources.\n\u003e \u003e \u003e Fine for me, better to add it here then loosing it\n\u003e \u003e \n\u003e \u003e ?\n\u003e \n\u003e We never ended up using this change, but by itself it could be useful\n\nYeah I will add it in after verifying that it still works.","accounts_in_message":[],"_revision_number":1},{"id":"05f1d0d285fa560678e751813c6851b3c717dca7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-09 19:43:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"00c3a91175dab034a36835f0cfcf2acc626d2c9a","author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-09 19:44:24.000000000","message":"Patch Set 2:\n\n\u003e \u003e \u003e \u003e  \u003e I wonder if we should have this in the stack this time too:\n\u003e \u003e \u003e \u003e  \u003e soong: Allow framework to access lineage-sdk resources\n\u003e \u003e \u003e \u003e  \u003e https://review.lineageos.org/c/LineageOS/android_build_soong/+/227276\n\u003e \u003e \u003e \u003e  \u003e \n\u003e \u003e \u003e \u003e  \u003e Allows non-services framework code to access lineage resources.\n\u003e \u003e \u003e \u003e Fine for me, better to add it here then loosing it\n\u003e \u003e \u003e \n\u003e \u003e \u003e ?\n\u003e \u003e \n\u003e \u003e We never ended up using this change, but by itself it could be useful\n\u003e \n\u003e Yeah I will add it in after verifying that it still works.\n\nYep - still works fine (did build and runtime verification).  Have added to this squash.","accounts_in_message":[],"_revision_number":2},{"id":"7e988df16dfdd0cf7abd4f1118e87af594a07ab8","author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-09 19:52:50.000000000","message":"Patch Set 2:\n\nSince it might help highlight the benefit of the patch, here\u0027s my simple test - in fw core print a string (any) from lineage resources during boot:\n\n--- a/core/java/android/app/WallpaperManager.java\n+++ b/core/java/android/app/WallpaperManager.java\n@@ -511,6 +511,8 @@ public class WallpaperManager {\n     /*package*/ WallpaperManager(IWallpaperManager service, Context context, Handler handler) {\n         mContext \u003d context;\n         initGlobals(service, context.getMainLooper());\n+        Log.d(TAG, \"samm: \" + context.getResources().getString(\n+                org.lineageos.platform.internal.R.string.config_externalSystemServer));\n     }\n \n     /**\n\nWith PS1 build failed saying resource not found.  With PS2 frameworks now depends on lineage resources so build succeeds.","accounts_in_message":[],"_revision_number":2},{"id":"8ba6c5d698498a54f4ef8519ec368215e7ba4c42","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-09 23:37:16.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"cfbca616b64a89408a60136906068a2fec97e9f9","author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-10 23:17:49.000000000","message":"Patch Set 3: Verified+1 Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"0610340a284f605f471d3754eac6bc079d0bb540","author":{"_account_id":3962,"name":"Rashed Abdel-Tawab","email":"rashedabdeltawab@gmail.com","username":"Rashed","avatars":[{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2019-09-10 23:34:33.000000000","message":"Patch Set 3: Verified+1 Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c79cde4985045861395a2180096bcba21962a9f8","tag":"autogenerated:gerrit:merged","author":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2019-09-10 23:39:31.000000000","message":"Change has been successfully merged by Sam Mortimer","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ca54a78f8bf2962cf8c316384df18342b2103c41","revisions":{"bdf1f0581b006ff4a16ba0b9ece94c08fd678426":{"kind":"REWORK","_number":1,"created":"2019-09-05 21:29:15.000000000","uploader":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/21/255821/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_build_soong","ref":"refs/changes/21/255821/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/1 \u0026\u0026 git checkout -b change-255821 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_build_soong refs/changes/21/255821/1","Reset To":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"39d8079b08c261bf07ae6c0cc2151f98342ef215","subject":"Give Blueprint modules access to all namespaces","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_build_soong/commit/39d8079b08c261bf07ae6c0cc2151f98342ef215"}]}],"author":{"name":"Rashed Abdel-Tawab","email":"rashed@linux.com","date":"2018-08-09 21:08:53.000000000","tz":-420},"committer":{"name":"Sam Mortimer","email":"sam@mortimer.me.uk","date":"2019-09-05 21:21:13.000000000","tz":-420},"subject":"soong: Squash of lineage-sdk bringup commits","message":"soong: Squash of lineage-sdk bringup commits\n\nSquash of:\n\nAuthor: Rashed Abdel-Tawab \u003crashed@linux.com\u003e\nDate:   Thu Aug 9 14:08:53 2018 -0700\n    soong: Special case Lineage SDK\n     * org.lineageos.platform-res.apk needs to be installed to /system/framework\n     * org.lineageos.platform-res needs to be a dependency for\n       org.lineageos.platform and org.lineageos.platform.internal\n     * Add other special exceptions for org.lineageos.platform-res\n    Change-Id: Ic617c07c086916005ea4b88f26d31c61691a45f8\n\nAuthor: Sam Mortimer \u003csam@mortimer.me.uk\u003e\nDate:   Thu Aug 30 15:33:16 2018 -0700\n    soong: make org.lineage.platform-res depend on framework-res\n    *) Allows us to build org.lineage.platform-res with no_framework_libs\n       true (as is done for framework-res).\n    *) Whilst we\u0027re here, undo a dependency loop prevention in aar.go\n       that we added during sdk bringup to allow our platform res to build\n       with no_framework_libs false.\n    Change-Id: Ib452a2e45112baf5d61b70b4be1ce0c01dfd84e5\n\nAuthor: Luca Stefani \u003cluca.stefani.ge1@gmail.com\u003e\nDate:   Mon Feb 4 18:56:52 2019 +0100\n    Always link org.lineageos.platform-res for org.lineageos.platform.sdk\n    Test: m clean \u0026\u0026 m org.lineageos.platform.sdk\n    Change-Id: I58956855bd4d1157e2582103c4861e7b384b4f73\n\nChange-Id: Icc18de5dfaa83fc0a1eda6f3704f3a92e1de0764\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_build_soong/commit/bdf1f0581b006ff4a16ba0b9ece94c08fd678426"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_build_soong/commit/bdf1f0581b006ff4a16ba0b9ece94c08fd678426"}]},"branch":"refs/heads/lineage-17.0"},"904f51f2c126a2f8bf12c362c4e221ba2a2d5b28":{"kind":"REWORK","_number":2,"created":"2019-09-09 19:43:16.000000000","uploader":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/21/255821/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_build_soong","ref":"refs/changes/21/255821/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/2 \u0026\u0026 git checkout -b change-255821 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_build_soong refs/changes/21/255821/2","Reset To":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"39d8079b08c261bf07ae6c0cc2151f98342ef215","subject":"Give Blueprint modules access to all namespaces","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_build_soong/commit/39d8079b08c261bf07ae6c0cc2151f98342ef215"}]}],"author":{"name":"Rashed Abdel-Tawab","email":"rashed@linux.com","date":"2018-08-09 21:08:53.000000000","tz":-420},"committer":{"name":"Sam Mortimer","email":"sam@mortimer.me.uk","date":"2019-09-09 19:42:53.000000000","tz":-420},"subject":"soong: Squash of lineage-sdk bringup commits","message":"soong: Squash of lineage-sdk bringup commits\n\nSquash of:\n\nAuthor: Rashed Abdel-Tawab \u003crashed@linux.com\u003e\nDate:   Thu Aug 9 14:08:53 2018 -0700\n    soong: Special case Lineage SDK\n     * org.lineageos.platform-res.apk needs to be installed to /system/framework\n     * org.lineageos.platform-res needs to be a dependency for\n       org.lineageos.platform and org.lineageos.platform.internal\n     * Add other special exceptions for org.lineageos.platform-res\n    Change-Id: Ic617c07c086916005ea4b88f26d31c61691a45f8\n\nAuthor: Sam Mortimer \u003csam@mortimer.me.uk\u003e\nDate:   Thu Aug 30 15:33:16 2018 -0700\n    soong: make org.lineage.platform-res depend on framework-res\n    *) Allows us to build org.lineage.platform-res with no_framework_libs\n       true (as is done for framework-res).\n    *) Whilst we\u0027re here, undo a dependency loop prevention in aar.go\n       that we added during sdk bringup to allow our platform res to build\n       with no_framework_libs false.\n    Change-Id: Ib452a2e45112baf5d61b70b4be1ce0c01dfd84e5\n\nAuthor: Luca Stefani \u003cluca.stefani.ge1@gmail.com\u003e\nDate:   Mon Feb 4 18:56:52 2019 +0100\n    Always link org.lineageos.platform-res for org.lineageos.platform.sdk\n    Test: m clean \u0026\u0026 m org.lineageos.platform.sdk\n    Change-Id: I58956855bd4d1157e2582103c4861e7b384b4f73\n\nAuthor: Sam Mortimer \u003csam@mortimer.me.uk\u003e\nDate:   Fri Aug 31 10:52:29 2018 -0700\n    soong: Allow framework to access lineage-sdk resources\n    *) Make framework depend on lineage-sdk resource package\n    *) Allows framework module to access lineage-sdk resources\n       via usual org.lineageos.platform.internal.R paths.\n    Change-Id: Ifd19d43d9308ac370ad40a499de16bf8ce204beb\n\nChange-Id: Icc18de5dfaa83fc0a1eda6f3704f3a92e1de0764\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_build_soong/commit/904f51f2c126a2f8bf12c362c4e221ba2a2d5b28"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_build_soong/commit/904f51f2c126a2f8bf12c362c4e221ba2a2d5b28"}]},"branch":"refs/heads/lineage-17.0"},"ca54a78f8bf2962cf8c316384df18342b2103c41":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2019-09-09 23:37:16.000000000","uploader":{"_account_id":3075,"name":"Sam Mortimer","email":"sam@mortimer.me.uk","username":"samm","avatars":[{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98e4e3feb67a8a476fe62b2887e41480.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/21/255821/3","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_build_soong","ref":"refs/changes/21/255821/3","commands":{"Branch":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/3 \u0026\u0026 git checkout -b change-255821 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_build_soong refs/changes/21/255821/3","Reset To":"git fetch https://github.com/LineageOS/android_build_soong refs/changes/21/255821/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"33f95299622a2c6c332cd428a4f324771f5b9575","subject":"soong: Whitelist nproc","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_build_soong/commit/33f95299622a2c6c332cd428a4f324771f5b9575"}]}],"author":{"name":"Rashed Abdel-Tawab","email":"rashed@linux.com","date":"2018-08-09 21:08:53.000000000","tz":-420},"committer":{"name":"Sam Mortimer","email":"sam@mortimer.me.uk","date":"2019-09-09 23:37:16.000000000","tz":120},"subject":"soong: Squash of lineage-sdk bringup commits","message":"soong: Squash of lineage-sdk bringup commits\n\nSquash of:\n\nAuthor: Rashed Abdel-Tawab \u003crashed@linux.com\u003e\nDate:   Thu Aug 9 14:08:53 2018 -0700\n    soong: Special case Lineage SDK\n     * org.lineageos.platform-res.apk needs to be installed to /system/framework\n     * org.lineageos.platform-res needs to be a dependency for\n       org.lineageos.platform and org.lineageos.platform.internal\n     * Add other special exceptions for org.lineageos.platform-res\n    Change-Id: Ic617c07c086916005ea4b88f26d31c61691a45f8\n\nAuthor: Sam Mortimer \u003csam@mortimer.me.uk\u003e\nDate:   Thu Aug 30 15:33:16 2018 -0700\n    soong: make org.lineage.platform-res depend on framework-res\n    *) Allows us to build org.lineage.platform-res with no_framework_libs\n       true (as is done for framework-res).\n    *) Whilst we\u0027re here, undo a dependency loop prevention in aar.go\n       that we added during sdk bringup to allow our platform res to build\n       with no_framework_libs false.\n    Change-Id: Ib452a2e45112baf5d61b70b4be1ce0c01dfd84e5\n\nAuthor: Luca Stefani \u003cluca.stefani.ge1@gmail.com\u003e\nDate:   Mon Feb 4 18:56:52 2019 +0100\n    Always link org.lineageos.platform-res for org.lineageos.platform.sdk\n    Test: m clean \u0026\u0026 m org.lineageos.platform.sdk\n    Change-Id: I58956855bd4d1157e2582103c4861e7b384b4f73\n\nAuthor: Sam Mortimer \u003csam@mortimer.me.uk\u003e\nDate:   Fri Aug 31 10:52:29 2018 -0700\n    soong: Allow framework to access lineage-sdk resources\n    *) Make framework depend on lineage-sdk resource package\n    *) Allows framework module to access lineage-sdk resources\n       via usual org.lineageos.platform.internal.R paths.\n    Change-Id: Ifd19d43d9308ac370ad40a499de16bf8ce204beb\n\nChange-Id: Icc18de5dfaa83fc0a1eda6f3704f3a92e1de0764\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_build_soong/commit/ca54a78f8bf2962cf8c316384df18342b2103c41"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_build_soong/commit/ca54a78f8bf2962cf8c316384df18342b2103c41"}]},"branch":"refs/heads/lineage-17.0","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":3962,"name":"Rashed Abdel-Tawab","email":"rashedabdeltawab@gmail.com","username":"Rashed","avatars":[{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":3962,"name":"Rashed Abdel-Tawab","email":"rashedabdeltawab@gmail.com","username":"Rashed","avatars":[{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/6e28c56bf2b55e191b60a61ca5852f1f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}