)]}'
{"ui.cpp":[{"author":{"_account_id":5503,"name":"Tom Marshall","email":"tdm.code@gmail.com","username":"tdm","avatars":[{"url":"https://www.gravatar.com/avatar/59e37fea5951b84c0450be42ed5e0e19.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/59e37fea5951b84c0450be42ed5e0e19.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/59e37fea5951b84c0450be42ed5e0e19.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/59e37fea5951b84c0450be42ed5e0e19.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3df2423f60afe6e95006021c970f5af33ceb1d34","unresolved":true,"context_lines":[{"line_number":338,"context_line":"  //"},{"line_number":339,"context_line":"  // Touch input events will only be available if touch_screen_allowed_ is set."},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"  CalibrateTouch(fd);"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"  if (ev.type \u003d\u003d EV_SYN) {"},{"line_number":344,"context_line":"    if (touch_screen_allowed_ \u0026\u0026 ev.code \u003d\u003d SYN_REPORT) {"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"faf656ac_1b93960b","line":341,"updated":"2019-08-06 16:59:11.000000000","message":"Won\u0027t this run on every touch?  That would not be good.","commit_id":"297398a003577546731616efd119ef58580d7eaa"},{"author":{"_account_id":18205,"name":"Alessandro Astone","email":"ales.astone@gmail.com","username":"YoDevil","avatars":[{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"88d13868a4ead03492208d5d6c828bfd9742d367","unresolved":true,"context_lines":[{"line_number":338,"context_line":"  //"},{"line_number":339,"context_line":"  // Touch input events will only be available if touch_screen_allowed_ is set."},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"  CalibrateTouch(fd);"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"  if (ev.type \u003d\u003d EV_SYN) {"},{"line_number":344,"context_line":"    if (touch_screen_allowed_ \u0026\u0026 ev.code \u003d\u003d SYN_REPORT) {"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"18ac3ac8_0d2471c4","line":341,"in_reply_to":"ba8d4ed2_a7046257","updated":"2019-08-06 17:53:50.000000000","message":"Eh actually, when scrolling especially this is unnecessarily expensive.","commit_id":"297398a003577546731616efd119ef58580d7eaa"},{"author":{"_account_id":18205,"name":"Alessandro Astone","email":"ales.astone@gmail.com","username":"YoDevil","avatars":[{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c1b4e99cbdb7a843eb705c241d2cd95654ea7568","unresolved":true,"context_lines":[{"line_number":338,"context_line":"  //"},{"line_number":339,"context_line":"  // Touch input events will only be available if touch_screen_allowed_ is set."},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"  CalibrateTouch(fd);"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"  if (ev.type \u003d\u003d EV_SYN) {"},{"line_number":344,"context_line":"    if (touch_screen_allowed_ \u0026\u0026 ev.code \u003d\u003d SYN_REPORT) {"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ba8d4ed2_a7046257","line":341,"in_reply_to":"faf656ac_1b93960b","updated":"2019-08-06 17:44:58.000000000","message":"Yeah it does, i don\u0027t think it would be necessarely bad.\nAs i hinted in slack, placing it in OnTouchDeviceDetected() would make it detect the wrong max values (not sure why).\nDo you wanna wrap it in a boolean, or do you see better alternatives?","commit_id":"297398a003577546731616efd119ef58580d7eaa"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42e2e15fc6b405ba8b8da9a3979de5367402b70b","unresolved":true,"context_lines":[{"line_number":76,"context_line":"      has_up_key(false),"},{"line_number":77,"context_line":"      has_down_key(false),"},{"line_number":78,"context_line":"      has_touch_screen(false),"},{"line_number":79,"context_line":"      needs_touch_calibration_(true),"},{"line_number":80,"context_line":"      touch_slot_(0),"},{"line_number":81,"context_line":"      touch_finger_down_(false),"},{"line_number":82,"context_line":"      touch_saw_x_(false),"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5edaa1cb_6bcae64d","line":79,"updated":"2019-08-06 18:08:49.000000000","message":"could be removed","commit_id":"bb126edffaf0447176d6f673f1bc58ab2c809b34"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42e2e15fc6b405ba8b8da9a3979de5367402b70b","unresolved":true,"context_lines":[{"line_number":240,"context_line":"}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"void RecoveryUI::CalibrateTouch(int fd) {"},{"line_number":243,"context_line":"    struct input_absinfo info;"},{"line_number":244,"context_line":"    memset(\u0026info, 0, sizeof(info));"},{"line_number":245,"context_line":"    if (ioctl(fd, EVIOCGABS(ABS_MT_POSITION_X), \u0026info) \u003d\u003d 0) {"},{"line_number":246,"context_line":"        touch_min_.x(info.minimum);"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"ef200a5e_75082e17","line":243,"updated":"2019-08-06 18:08:49.000000000","message":"maybe use a static bool here","commit_id":"bb126edffaf0447176d6f673f1bc58ab2c809b34"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42e2e15fc6b405ba8b8da9a3979de5367402b70b","unresolved":true,"context_lines":[{"line_number":338,"context_line":"  // ABS_MT_TRACKING_ID being -1."},{"line_number":339,"context_line":"  //"},{"line_number":340,"context_line":"  // Touch input events will only be available if touch_screen_allowed_ is set."},{"line_number":341,"context_line":"  if (needs_touch_calibration_) {"},{"line_number":342,"context_line":"    CalibrateTouch(fd);"},{"line_number":343,"context_line":"    needs_touch_calibration_ \u003d false;"},{"line_number":344,"context_line":"  }"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"df2967cb_01057418","line":341,"updated":"2019-08-06 18:08:49.000000000","message":"only the call to the function needed","commit_id":"bb126edffaf0447176d6f673f1bc58ab2c809b34"},{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4305835d64be5b1f933e1e11850aea6f97b0f58a","unresolved":true,"context_lines":[{"line_number":241,"context_line":"void RecoveryUI::CalibrateTouch(int fd) {"},{"line_number":242,"context_line":"  struct input_absinfo info;"},{"line_number":243,"context_line":"  static bool calibrated \u003d false;"},{"line_number":244,"context_line":"  if (!calibrated) {"},{"line_number":245,"context_line":"    LOG(ERROR) \u003c\u003c \"CALIBRATING\";"},{"line_number":246,"context_line":"    memset(\u0026info, 0, sizeof(info));"},{"line_number":247,"context_line":"    if (ioctl(fd, EVIOCGABS(ABS_MT_POSITION_X), \u0026info) \u003d\u003d 0) {"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"694492aa_7e650e06","line":244,"updated":"2019-08-06 18:22:26.000000000","message":"if (calibrated) return\navoid nesting if possible","commit_id":"0dcf5764cd9013d30a077c6437f5fd75bb7e9001"},{"author":{"_account_id":18205,"name":"Alessandro Astone","email":"ales.astone@gmail.com","username":"YoDevil","avatars":[{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"369ab3809f863c94b99723996a6f76407bb38015","unresolved":false,"context_lines":[{"line_number":241,"context_line":"void RecoveryUI::CalibrateTouch(int fd) {"},{"line_number":242,"context_line":"  struct input_absinfo info;"},{"line_number":243,"context_line":"  static bool calibrated \u003d false;"},{"line_number":244,"context_line":"  if (!calibrated) {"},{"line_number":245,"context_line":"    LOG(ERROR) \u003c\u003c \"CALIBRATING\";"},{"line_number":246,"context_line":"    memset(\u0026info, 0, sizeof(info));"},{"line_number":247,"context_line":"    if (ioctl(fd, EVIOCGABS(ABS_MT_POSITION_X), \u0026info) \u003d\u003d 0) {"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"0f5dc3a5_298830ad","line":244,"in_reply_to":"694492aa_7e650e06","updated":"2019-08-06 19:06:02.000000000","message":"While I agree, I\u0027m not sure everyone would.\nDone.","commit_id":"0dcf5764cd9013d30a077c6437f5fd75bb7e9001"},{"author":{"_account_id":13648,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm","avatars":[{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3d939ee28d51d14e76de3a4510b309ce.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9c587fa185679012b2ec1faea2994f87426da5ab","unresolved":true,"context_lines":[{"line_number":242,"context_line":"  struct input_absinfo info;"},{"line_number":243,"context_line":"  static bool calibrated \u003d false;"},{"line_number":244,"context_line":"  if (!calibrated) {"},{"line_number":245,"context_line":"    LOG(ERROR) \u003c\u003c \"CALIBRATING\";"},{"line_number":246,"context_line":"    memset(\u0026info, 0, sizeof(info));"},{"line_number":247,"context_line":"    if (ioctl(fd, EVIOCGABS(ABS_MT_POSITION_X), \u0026info) \u003d\u003d 0) {"},{"line_number":248,"context_line":"      touch_min_.x(info.minimum);"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"513006a6_87b0c889","line":245,"updated":"2019-08-06 18:21:38.000000000","message":"Why ERROR and why all caps message?","commit_id":"0dcf5764cd9013d30a077c6437f5fd75bb7e9001"},{"author":{"_account_id":18205,"name":"Alessandro Astone","email":"ales.astone@gmail.com","username":"YoDevil","avatars":[{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61b8bcab7b164d13b5e9461718f72b62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"369ab3809f863c94b99723996a6f76407bb38015","unresolved":false,"context_lines":[{"line_number":242,"context_line":"  struct input_absinfo info;"},{"line_number":243,"context_line":"  static bool calibrated \u003d false;"},{"line_number":244,"context_line":"  if (!calibrated) {"},{"line_number":245,"context_line":"    LOG(ERROR) \u003c\u003c \"CALIBRATING\";"},{"line_number":246,"context_line":"    memset(\u0026info, 0, sizeof(info));"},{"line_number":247,"context_line":"    if (ioctl(fd, EVIOCGABS(ABS_MT_POSITION_X), \u0026info) \u003d\u003d 0) {"},{"line_number":248,"context_line":"      touch_min_.x(info.minimum);"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"4ff3c828_85a4dbf0","line":245,"in_reply_to":"513006a6_87b0c889","updated":"2019-08-06 19:06:02.000000000","message":"Leftover obviously","commit_id":"0dcf5764cd9013d30a077c6437f5fd75bb7e9001"}],"ui.h":[{"author":{"_account_id":11883,"name":"Luca Stefani","email":"luca.stefani.ge1@gmail.com","username":"luca020400","avatars":[{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e0d7fe321be897bf85cf3d240cbd3be9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42e2e15fc6b405ba8b8da9a3979de5367402b70b","unresolved":true,"context_lines":[{"line_number":350,"context_line":"  };"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"  // Touch event related variables. See the comments in RecoveryUI::OnInputEvent()."},{"line_number":353,"context_line":"  bool needs_touch_calibration_;"},{"line_number":354,"context_line":"  int touch_slot_;"},{"line_number":355,"context_line":"  bool touch_finger_down_;"},{"line_number":356,"context_line":"  bool touch_saw_x_;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"31f24dde_1069601a","line":353,"updated":"2019-08-06 18:08:49.000000000","message":"not needed","commit_id":"bb126edffaf0447176d6f673f1bc58ab2c809b34"}]}