)]}'
{"id":"LineageOS%2Fandroid_bionic~317618","triplet_id":"LineageOS%2Fandroid_bionic~lineage-19.0~Ic3ad7095ddae7ea1039cb6a18603d5cde8a16152","project":"LineageOS/android_bionic","branch":"lineage-19.0","attention_set":{},"removed_from_attention_set":{"14048":{"account":{"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"last_update":"2021-12-03 03:50:34.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic3ad7095ddae7ea1039cb6a18603d5cde8a16152","subject":"linker: Add support for dynamic SHIM libraries","status":"MERGED","created":"2021-10-09 19:15:00.000000000","updated":"2021-12-03 03:50:34.000000000","submitted":"2021-12-03 03:50:34.000000000","submitter":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"317618","meta_rev_id":"335954bc9bba384122a7e9283b804e8e25591ad4","_number":317618,"virtual_id_number":317618,"owner":{"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-03 03:50:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-03 03:50:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-03 03:50:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-12-03 03:50:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-03 03:50:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"CI":{"all":[{"value":0,"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fail"," 0":"No score","+1":"Pass"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":16208,"name":"Wang Han","email":"416810799@qq.com","username":"aviraxp","avatars":[{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"reviewers":{"REVIEWER":[{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":16208,"name":"Wang Han","email":"416810799@qq.com","username":"aviraxp","avatars":[{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-09 19:15:00.000000000","updated_by":{"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":16208,"name":"Wang Han","email":"416810799@qq.com","username":"aviraxp","avatars":[{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/afce8dbb3c6c755dcb7fb83ddfd99e7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-12-02 21:00:22.000000000","updated_by":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-12-03 03:49:52.000000000","updated_by":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-12-03 03:50:34.000000000","updated_by":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"e3bf77735f6be99e616f0a6be77b1e13848b3eec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-09 19:15:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c7cb4f8bb602649f9f2c46f8881f45d27a2d3a46","author":{"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-09 23:01:43.000000000","message":"Patch Set 1: Verified+1 Code-Review+1\n\nVerified on tegra, shimming nvaudio hal","accounts_in_message":[],"_revision_number":1},{"id":"622dae83cfdc021cb2040fd422aacea1f24ba292","author":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-12-02 21:00:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1745abad63a676506ed1c36f5579727cbc531d87","author":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-12-03 03:49:52.000000000","message":"Patch Set 1: Verified+1 Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"335954bc9bba384122a7e9283b804e8e25591ad4","tag":"autogenerated:gerrit:merged","author":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-12-03 03:50:34.000000000","message":"Change has been successfully rebased and submitted as a2d8272fa8fe2098a9ad96d7e1e2aa03d160529a","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a2d8272fa8fe2098a9ad96d7e1e2aa03d160529a","revisions":{"fe09ea94723b93216bae7dbf4f9d3ad3abb7c65f":{"kind":"REWORK","_number":1,"created":"2021-10-09 19:15:00.000000000","uploader":{"_account_id":14048,"name":"Aaron Kling","email":"webgeek1234@gmail.com","username":"webgeek1234","avatars":[{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7da03dd304852ff0dcea1f9f064f83ee.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/18/317618/1","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_bionic","ref":"refs/changes/18/317618/1","commands":{"Branch":"git fetch https://github.com/LineageOS/android_bionic refs/changes/18/317618/1 \u0026\u0026 git checkout -b change-317618 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_bionic refs/changes/18/317618/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_bionic refs/changes/18/317618/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_bionic refs/changes/18/317618/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_bionic refs/changes/18/317618/1","Reset To":"git fetch https://github.com/LineageOS/android_bionic refs/changes/18/317618/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e1c42ccac8c56db870a352e234250445bdf7c6c5","subject":"Snap for 7579381 from c75fbc7b8a7a04feacab54cffc1c3129e0e4d769 to sc-release","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_bionic/commit/e1c42ccac8c56db870a352e234250445bdf7c6c5"}]}],"author":{"name":"Christopher R. Palmer","email":"crpalmer@gmail.com","date":"2017-04-08 20:40:01.000000000","tz":120},"committer":{"name":"Aaron Kling","email":"webgeek1234@gmail.com","date":"2021-10-09 19:14:03.000000000","tz":-300},"subject":"linker: Add support for dynamic SHIM libraries","message":"linker: Add support for dynamic SHIM libraries\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Tue Nov 3 16:44:44 2015 -0500\n\n    linker: Add support for dynamic \"shim\" libs\n\n    Add a new environment variable\n\n    LD_SHIM_LIBS\n\n    that is a colon (\":\") separated list of vertical bar (\"|\") separated pairs.\n    The pairs are the name for a soinfo reference (executable or shared library)\n    followed by the name of the shim library to load.  For example:\n\n    LD_SHIM_LIBS\u003drmt_storage|libshim_ioprio.so:/system/lib/libicuuv.so|libshim_icu53.so\n\n    will instruct the linker to load the dynamic library libshim_ioprio.so\n    whenver rmt_storage is executed [*] and will load libshim_icu53.so whenever\n    any executable or other shared library links against /system/lib/libicuuv.so.\n\n    There are no restrictions against circular references.  In this example,\n    libshim_icu53.so can link against libicuuv.so which provides a simple and\n    convenient means of adding compatibility symbols.\n\n    [*] Note that the absolute path is not available to the linker and therefore\n    using the name of executables does depend on the invocation and therefore\n    should only be used if absolutely necessary.  That is, running\n    /system/bin/rmt_storage would not load any shim libs in this example because\n    it does not match the name of the invocation of the command.\n\n    If you have trouble determining the sonames being loaded, you can also set\n    the environment variable LD_DEBUG\u003d1 which will cause additional information\n    to be logged to help trace the detection of the shim libs.\n\n    Change-Id: I0ef80fa466167f7bcb7dac90842bef1c3cf879b6\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Sun Nov 15 14:26:32 2015 -0500\n\n    linker: Fix the fact that shim libs do not properly call constructors\n\n    Change-Id: I34333e13443a154e675b853fa41442351bc4243a\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Tue Dec 1 07:10:36 2015 -0500\n\n    linker: Don\u0027t try to walk the g_active_shim_libs when doing dlsym\n\n    This is a bug in the original shim_lib implementation which was\n    doing the shim lib resolution both when loading the libraries\n    and when doing the dynamic symbol resolution.\n\n    Change-Id: Ib2df0498cf551b3bbd37d7c351410b9908eb1795\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Sun Nov 29 08:28:10 2015 -0500\n\n    linker: Reset the active shim libs each time we do a dlopen\n\n    We use the active libs to avoid recursively trying to load the\n    same library:\n\n    A -\u003e shimlibs add B -\u003e depends on A -\u003e shimlibs add B -\u003e ...\n\n    However, when we repeatedly dlopen the same library we need\n    to reset the active shim libs to avoid failing to add B the\n    second time we dlopen A.\n\n    Change-Id: I27580e3d6a53858e8bca025d6c85f981cffbea06\n\nAuthor: Danny Baumann \u003cdannybaumann@web.de\u003e\nDate:   Fri Dec 11 10:29:16 2015 +0100\n\n    Make shim lib load failure non-fatal.\n\n    Instead, print an appropriate warning message. Aborting symbol\n    resolution on shim lib load failure leads to weird symbol lookup\n    failures, because symbols in libraries referenced after the one loading\n    the shim won\u0027t be loaded anymore without a log message stating why that\n    happened.\n\n    Change-Id: Ic3ad7095ddae7ea1039cb6a18603d5cde8a16143\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Sat Dec 12 06:10:09 2015 -0500\n\n    bionic: Do not allow LD_SHIM_LIBS for setuid executables\n\n    That\u0027s really not safe...\n\n    Change-Id: If79af951830966fc21812cd0f60a8998a752a941\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Sun Feb 14 11:38:44 2016 -0500\n\n    bionic: linker: Load shim libs *before* the self-linked libs\n\n    By loading them earlier, this allows us to override a symbol in\n    a library that is being directly linked.\n\n    I believe this explains why some people have had problems shimming\n    one lib but when the changet he shim to be against a different\n    lib it magically works.\n\n    It also makes it possible to override some symbols that were\n    nearly impossible to override before this change.  For example, it is\n    pretty much impossible to override a symbol in libutils without\n    this change because it\u0027s loaded almost everywhere so no matter\n    where you try to place the shimming, it will be too late and\n    the other symbol will have priority.\n\n    In particularly, this is necessary to be able to correctly\n    shim the VectorImpl symbols for dlx.\n\n    Change-Id: I461ca416bc288e28035352da00fde5f34f8d9ffa\n\nAuthor: Chirayu Desai \u003cchirayudesai1@gmail.com\u003e\nDate:   Thu Aug 25 19:02:41 2016 +0530\n\n    linker: Update find_library call for shimlibs\n\n    commits 0cdef7e7f3c6837b56a969120d9098463d1df8d8\n    \"Respect caller DT_RUNPATH in dlopen().\"\n    and 42d5fcb9f494eb45de3b6bf759f4a18076e84728\n    \"Introducing linker namespaces\"\n    added new arguments to find_library, add them here.\n\n    Change-Id: I8f35a45b00d14f8b2ce01a0a96d2dc7759be04a6\n\nAuthor: Chippa-a \u003cvusal1372@gmail.com\u003e\nDate:   Sat Aug 27 14:56:30 2016 +0200\n\n    linker: Update LD_SHIM_LIBS parser function\n\n     * Upgrade the code using the same changes as\n        42d5fcb9f494eb45de3b6bf759f4a18076e84728\n        bda20e78f0f314dbbf0f0bbcf0740cf2d6a4b85e\n\n    Change-Id: Ic8be0871945bd9feccd0f94a6770f3cc78a70a0f\n\nAuthor: Danny Baumann \u003cdannybaumann@web.de\u003e\nDate:   Wed Sep 7 16:54:06 2016 +0200\n\n    Inject shim libs as if they were DT_NEEDED.\n\n    The previous separate approach had one flaw: If the shim lib requires\n    another lib that\u0027s already loaded, find_library_internal() would return\n    the previously loaded copy, but the later load action would fail as the\n    ELF reader map of the initial loading round was already discarded and\n    thus a new ElfReader instance for the soinfo instance was created, which\n    didn\u0027t know about the previous reading/loading state.\n\n    Change-Id: Ib224dbd35d114197097e3dee14a077cc9130fedb\n\nAuthor: jrior001 \u003cjriordan001@gmail.com\u003e\nDate:   Fri Oct 7 19:36:51 2016 -0400\n\n    linker: load shims prior to DT_NEEDED check\n\n    This allows shims to override existing symbols, not just\n    inject new symbols.\n\n    Change-Id: Ib9216bcc651d8d38999c593babb94d76dc1dbc95\n\nAuthor: Adrian DC \u003cradian.dc@gmail.com\u003e\nDate: Sat, 8 Apr 2017 22:40:01 +0200\n\n     * Adapt to latest AOSP Oreo bionic linker changes\n     * Additional header to avoid unused function\n\n    Change-Id: Ib9216bcc651d8d38999c593babb94d76dc1dbc95\n\nAuthor: Paul Keith \u003cjavelinanddart@gmail.com\u003e\nDate:   Thu Feb 15 21:57:33 2018 +0100\n\n    linker: Move shims to TARGET_LD_SHIM_LIBS\n\n    * To reduce security exposure, let\u0027s set this at compile time,\n      and block off all the code unless the board flag is set\n\n    Change-Id: Ieec5f5d9e0f39a798fd48eae037ecffe9502474c\n\nAuthor: Nich \u003cnctrenco@gmail.com\u003e\nDate:   Fri Jun 8 09:48:17 2018 +0800\n\n    linker: Provide soinfo path of the shimmed binary\n\n    This is a forward port of part of the original change that was missed out\n    since the initial port of the shim logic to O.\n\n    Change-Id: I1f7ff98472cfef5cb2d2bcb303082784898cd0c6\n\nAuthor: Nich \u003cnctrenco@gmail.com\u003e\nDate:   Tue Jun 5 13:36:43 2018 +0800\n\n    linker: Remove unused find_libraries declaration\n\n    commit \"Inject shim libs as if they were DT_NEEDED.\" removed references\n    to the forward declaration.\n\n    Change-Id: I5f1aaa3a96f2af3edef07d4ea4e204b586424631\n\nAuthor: Nich \u003cnctrenco@gmail.com\u003e\nDate:   Sun Jun 10 00:45:51 2018 +0800\n\n    linker: Make shim reference path absolute\n\n    This way, we can filter out non-existent binaries, and ensure we get\n    its absolute path before matching with get_realpath(). This for one\n    allows the use of symlinks in TARGET_LD_SHIM_LIBS.\n\n    Change-Id: I823815271b3257965534b6b87d8ea36ffb68bc08\n\nAuthor: Nich \u003cnctrenco@gmail.com\u003e\nDate:   Fri Jun 15 03:59:05 2018 +0800\n\n    linker: Ensure active matching pairs\n\n    Change-Id: I54c666b4560dbfb40839b0bf9132a7fd8d3ed2dd\n\nAuthor: Nich \u003cnctrenco@gmail.com\u003e\nDate:   Thu Jun 21 01:58:10 2018 +0800\n\n    linker: Don\u0027t involve shim in for_each_dt_needed\n\n    for_each_dt_needed may have other usages that shouldn\u0027t involve the\n    shim, for example, in the unloading of soinfos.\n\n    Change-Id: Id38de183d90c3f707767bdca032a5ea2bc82fde8\n\nAuthor: Jiyong Park \u003cjiyong@google.com\u003e\nDate:   Fri Jan 25 18:18:01 2019 +0900\n\n    Call realpath(3) only when the path is accessible for read\n\n    Suppress the SELinux denial log spam by not calling realpath(3) when the\n    path does not exist or is not accessible for read, and then not auditing\n    access(2) failure.\n\n    Change-Id: I729ecb8ea0bb581069eb849bae7cd28e6ab636cc\n\nChange-Id: Ic3ad7095ddae7ea1039cb6a18603d5cde8a16152\nSigned-off-by: Wang Han \u003c416810799@qq.com\u003e\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_bionic/commit/fe09ea94723b93216bae7dbf4f9d3ad3abb7c65f"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_bionic/commit/fe09ea94723b93216bae7dbf4f9d3ad3abb7c65f"}]},"branch":"refs/heads/lineage-19.0"},"a2d8272fa8fe2098a9ad96d7e1e2aa03d160529a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-12-03 03:50:34.000000000","uploader":{"_account_id":11801,"name":"Joseph Annareddy","email":"javelinanddart@gmail.com","username":"javelinanddart","avatars":[{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0df5381571b66bb61674368f2bfc3e60.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/18/317618/2","fetch":{"anonymous http":{"url":"https://github.com/LineageOS/android_bionic","ref":"refs/changes/18/317618/2","commands":{"Branch":"git fetch https://github.com/LineageOS/android_bionic refs/changes/18/317618/2 \u0026\u0026 git checkout -b change-317618 FETCH_HEAD","Checkout":"git fetch https://github.com/LineageOS/android_bionic refs/changes/18/317618/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://github.com/LineageOS/android_bionic refs/changes/18/317618/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://github.com/LineageOS/android_bionic refs/changes/18/317618/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://github.com/LineageOS/android_bionic refs/changes/18/317618/2","Reset To":"git fetch https://github.com/LineageOS/android_bionic refs/changes/18/317618/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"23a5e7d99f534b2992d4fa5e977e7c1607e2dcea","subject":"Add inaddr.h header file","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_bionic/commit/23a5e7d99f534b2992d4fa5e977e7c1607e2dcea"}]}],"author":{"name":"Christopher R. Palmer","email":"crpalmer@gmail.com","date":"2017-04-08 20:40:01.000000000","tz":120},"committer":{"name":"Paul Keith","email":"javelinanddart@gmail.com","date":"2021-12-03 03:50:34.000000000","tz":60},"subject":"linker: Add support for dynamic SHIM libraries","message":"linker: Add support for dynamic SHIM libraries\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Tue Nov 3 16:44:44 2015 -0500\n\n    linker: Add support for dynamic \"shim\" libs\n\n    Add a new environment variable\n\n    LD_SHIM_LIBS\n\n    that is a colon (\":\") separated list of vertical bar (\"|\") separated pairs.\n    The pairs are the name for a soinfo reference (executable or shared library)\n    followed by the name of the shim library to load.  For example:\n\n    LD_SHIM_LIBS\u003drmt_storage|libshim_ioprio.so:/system/lib/libicuuv.so|libshim_icu53.so\n\n    will instruct the linker to load the dynamic library libshim_ioprio.so\n    whenver rmt_storage is executed [*] and will load libshim_icu53.so whenever\n    any executable or other shared library links against /system/lib/libicuuv.so.\n\n    There are no restrictions against circular references.  In this example,\n    libshim_icu53.so can link against libicuuv.so which provides a simple and\n    convenient means of adding compatibility symbols.\n\n    [*] Note that the absolute path is not available to the linker and therefore\n    using the name of executables does depend on the invocation and therefore\n    should only be used if absolutely necessary.  That is, running\n    /system/bin/rmt_storage would not load any shim libs in this example because\n    it does not match the name of the invocation of the command.\n\n    If you have trouble determining the sonames being loaded, you can also set\n    the environment variable LD_DEBUG\u003d1 which will cause additional information\n    to be logged to help trace the detection of the shim libs.\n\n    Change-Id: I0ef80fa466167f7bcb7dac90842bef1c3cf879b6\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Sun Nov 15 14:26:32 2015 -0500\n\n    linker: Fix the fact that shim libs do not properly call constructors\n\n    Change-Id: I34333e13443a154e675b853fa41442351bc4243a\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Tue Dec 1 07:10:36 2015 -0500\n\n    linker: Don\u0027t try to walk the g_active_shim_libs when doing dlsym\n\n    This is a bug in the original shim_lib implementation which was\n    doing the shim lib resolution both when loading the libraries\n    and when doing the dynamic symbol resolution.\n\n    Change-Id: Ib2df0498cf551b3bbd37d7c351410b9908eb1795\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Sun Nov 29 08:28:10 2015 -0500\n\n    linker: Reset the active shim libs each time we do a dlopen\n\n    We use the active libs to avoid recursively trying to load the\n    same library:\n\n    A -\u003e shimlibs add B -\u003e depends on A -\u003e shimlibs add B -\u003e ...\n\n    However, when we repeatedly dlopen the same library we need\n    to reset the active shim libs to avoid failing to add B the\n    second time we dlopen A.\n\n    Change-Id: I27580e3d6a53858e8bca025d6c85f981cffbea06\n\nAuthor: Danny Baumann \u003cdannybaumann@web.de\u003e\nDate:   Fri Dec 11 10:29:16 2015 +0100\n\n    Make shim lib load failure non-fatal.\n\n    Instead, print an appropriate warning message. Aborting symbol\n    resolution on shim lib load failure leads to weird symbol lookup\n    failures, because symbols in libraries referenced after the one loading\n    the shim won\u0027t be loaded anymore without a log message stating why that\n    happened.\n\n    Change-Id: Ic3ad7095ddae7ea1039cb6a18603d5cde8a16143\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Sat Dec 12 06:10:09 2015 -0500\n\n    bionic: Do not allow LD_SHIM_LIBS for setuid executables\n\n    That\u0027s really not safe...\n\n    Change-Id: If79af951830966fc21812cd0f60a8998a752a941\n\nAuthor: Christopher R. Palmer \u003ccrpalmer@gmail.com\u003e\nDate:   Sun Feb 14 11:38:44 2016 -0500\n\n    bionic: linker: Load shim libs *before* the self-linked libs\n\n    By loading them earlier, this allows us to override a symbol in\n    a library that is being directly linked.\n\n    I believe this explains why some people have had problems shimming\n    one lib but when the changet he shim to be against a different\n    lib it magically works.\n\n    It also makes it possible to override some symbols that were\n    nearly impossible to override before this change.  For example, it is\n    pretty much impossible to override a symbol in libutils without\n    this change because it\u0027s loaded almost everywhere so no matter\n    where you try to place the shimming, it will be too late and\n    the other symbol will have priority.\n\n    In particularly, this is necessary to be able to correctly\n    shim the VectorImpl symbols for dlx.\n\n    Change-Id: I461ca416bc288e28035352da00fde5f34f8d9ffa\n\nAuthor: Chirayu Desai \u003cchirayudesai1@gmail.com\u003e\nDate:   Thu Aug 25 19:02:41 2016 +0530\n\n    linker: Update find_library call for shimlibs\n\n    commits 0cdef7e7f3c6837b56a969120d9098463d1df8d8\n    \"Respect caller DT_RUNPATH in dlopen().\"\n    and 42d5fcb9f494eb45de3b6bf759f4a18076e84728\n    \"Introducing linker namespaces\"\n    added new arguments to find_library, add them here.\n\n    Change-Id: I8f35a45b00d14f8b2ce01a0a96d2dc7759be04a6\n\nAuthor: Chippa-a \u003cvusal1372@gmail.com\u003e\nDate:   Sat Aug 27 14:56:30 2016 +0200\n\n    linker: Update LD_SHIM_LIBS parser function\n\n     * Upgrade the code using the same changes as\n        42d5fcb9f494eb45de3b6bf759f4a18076e84728\n        bda20e78f0f314dbbf0f0bbcf0740cf2d6a4b85e\n\n    Change-Id: Ic8be0871945bd9feccd0f94a6770f3cc78a70a0f\n\nAuthor: Danny Baumann \u003cdannybaumann@web.de\u003e\nDate:   Wed Sep 7 16:54:06 2016 +0200\n\n    Inject shim libs as if they were DT_NEEDED.\n\n    The previous separate approach had one flaw: If the shim lib requires\n    another lib that\u0027s already loaded, find_library_internal() would return\n    the previously loaded copy, but the later load action would fail as the\n    ELF reader map of the initial loading round was already discarded and\n    thus a new ElfReader instance for the soinfo instance was created, which\n    didn\u0027t know about the previous reading/loading state.\n\n    Change-Id: Ib224dbd35d114197097e3dee14a077cc9130fedb\n\nAuthor: jrior001 \u003cjriordan001@gmail.com\u003e\nDate:   Fri Oct 7 19:36:51 2016 -0400\n\n    linker: load shims prior to DT_NEEDED check\n\n    This allows shims to override existing symbols, not just\n    inject new symbols.\n\n    Change-Id: Ib9216bcc651d8d38999c593babb94d76dc1dbc95\n\nAuthor: Adrian DC \u003cradian.dc@gmail.com\u003e\nDate: Sat, 8 Apr 2017 22:40:01 +0200\n\n     * Adapt to latest AOSP Oreo bionic linker changes\n     * Additional header to avoid unused function\n\n    Change-Id: Ib9216bcc651d8d38999c593babb94d76dc1dbc95\n\nAuthor: Paul Keith \u003cjavelinanddart@gmail.com\u003e\nDate:   Thu Feb 15 21:57:33 2018 +0100\n\n    linker: Move shims to TARGET_LD_SHIM_LIBS\n\n    * To reduce security exposure, let\u0027s set this at compile time,\n      and block off all the code unless the board flag is set\n\n    Change-Id: Ieec5f5d9e0f39a798fd48eae037ecffe9502474c\n\nAuthor: Nich \u003cnctrenco@gmail.com\u003e\nDate:   Fri Jun 8 09:48:17 2018 +0800\n\n    linker: Provide soinfo path of the shimmed binary\n\n    This is a forward port of part of the original change that was missed out\n    since the initial port of the shim logic to O.\n\n    Change-Id: I1f7ff98472cfef5cb2d2bcb303082784898cd0c6\n\nAuthor: Nich \u003cnctrenco@gmail.com\u003e\nDate:   Tue Jun 5 13:36:43 2018 +0800\n\n    linker: Remove unused find_libraries declaration\n\n    commit \"Inject shim libs as if they were DT_NEEDED.\" removed references\n    to the forward declaration.\n\n    Change-Id: I5f1aaa3a96f2af3edef07d4ea4e204b586424631\n\nAuthor: Nich \u003cnctrenco@gmail.com\u003e\nDate:   Sun Jun 10 00:45:51 2018 +0800\n\n    linker: Make shim reference path absolute\n\n    This way, we can filter out non-existent binaries, and ensure we get\n    its absolute path before matching with get_realpath(). This for one\n    allows the use of symlinks in TARGET_LD_SHIM_LIBS.\n\n    Change-Id: I823815271b3257965534b6b87d8ea36ffb68bc08\n\nAuthor: Nich \u003cnctrenco@gmail.com\u003e\nDate:   Fri Jun 15 03:59:05 2018 +0800\n\n    linker: Ensure active matching pairs\n\n    Change-Id: I54c666b4560dbfb40839b0bf9132a7fd8d3ed2dd\n\nAuthor: Nich \u003cnctrenco@gmail.com\u003e\nDate:   Thu Jun 21 01:58:10 2018 +0800\n\n    linker: Don\u0027t involve shim in for_each_dt_needed\n\n    for_each_dt_needed may have other usages that shouldn\u0027t involve the\n    shim, for example, in the unloading of soinfos.\n\n    Change-Id: Id38de183d90c3f707767bdca032a5ea2bc82fde8\n\nAuthor: Jiyong Park \u003cjiyong@google.com\u003e\nDate:   Fri Jan 25 18:18:01 2019 +0900\n\n    Call realpath(3) only when the path is accessible for read\n\n    Suppress the SELinux denial log spam by not calling realpath(3) when the\n    path does not exist or is not accessible for read, and then not auditing\n    access(2) failure.\n\n    Change-Id: I729ecb8ea0bb581069eb849bae7cd28e6ab636cc\n\nChange-Id: Ic3ad7095ddae7ea1039cb6a18603d5cde8a16152\nSigned-off-by: Wang Han \u003c416810799@qq.com\u003e\n","web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_bionic/commit/a2d8272fa8fe2098a9ad96d7e1e2aa03d160529a"}],"resolve_conflicts_web_links":[{"name":"GitHub","tooltip":"Open in GitWeb","url":"https://github.com/LineageOS/android_bionic/commit/a2d8272fa8fe2098a9ad96d7e1e2aa03d160529a"}]},"branch":"refs/heads/lineage-19.0","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":18796,"name":"Mohammed Althaf T","display_name":"Althaf","email":"althafvly@gmail.com","username":"althafvly","avatars":[{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/615e97a1ca0592d6148f01637a82498e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":16185,"name":"Nolen Johnson","email":"johnsonnolen@gmail.com","username":"njohnson","avatars":[{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35fbec921061bf203f1189ddc1cb9697.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}